From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a0fc45fd99-68486944-be79-4713-834e-dce297922f7a-000000@eu-central-1.amazonses.com> Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021114.outbound.protection.outlook.com [52.101.70.114]) by lore.virtuozzo.com (Postfix) with ESMTPS id 63A8C8017D for ; Fri, 2 Oct 2026 11:00:44 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZVaNYP/tNs0NBKRr9dJejpO9oXxvy0eCxe6lXhu6CcWTgbE3iC/J5630MVPk5KzwVScG2bdv3Z/dmzdBnT3Af3GdXMeNPVMc8UY+DVPUojn/ds/g4QXkXA3LirSKrBETuFaW09lP1aqSAPrg4+y8FoWaYIXUyizp4KfSWo+96dWkzHKe2cwFlu2FRQK/sLz/kfWNAFd/YJbw16536bAbUipyC56SmSsCLUp4kabuvZcxzN+x0GO3iH3i7L+IpiKPouZ+TxHFg8MUho2ko4ZGxCvXe4kOWCTRObXT7UrdrUNMX40G3/5JsMPgBVirJGF5gIQNLVA2vM6+qz2M0tCX2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NjIVtjyCndg2pJhK+bUz+wc7vNpzCZKoGxHGnOEVoBs=; b=HPJEpzqGKB6Jt4g3VOHDvYxvc/Le5FU9WwiTEb28PsKb/ZFxtKm4vtsTjnb2C5+I7cbPJr9LY2iS3x/b9blkTUNa5uFTMSK9VEFsZbzd6GNSHjPcbcz1g3Nv0tiM505Y75UraLWUD5G3YPTOvyMGjoBOohECEStzk195zjjyZ9eh0L+CJoVTYQ5mQaaQiYw/8ZODl2BGB1E4XlRCAVi50id3BIZmTX9MeCdSJOvm8b35FPRdoOJPavrqZzzvx7oEYEAJk4U28MrAMPAMUjD9n8/K38C28McD1YMEL/QtVJ/buWNVZeaUeWA3/bwzgr33eu8QYr2cf3/e9540oN5hAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NjIVtjyCndg2pJhK+bUz+wc7vNpzCZKoGxHGnOEVoBs=; b=Apah9DBixSJ7BI/BWzO+AzBcLar9q7aJcQhkgexeGlQsVxSU+hoU4Pas7hQ8AxywvFEFoTzu+fnHORtbWjU1V9m1Jb+zydIrej/dFc+GB/KMK+EBJaWElK53jKuHRFL2E+P8bxQomk3Tgapjzh6R3Ihaj6j+M69xDqZ5rNgo/mw= Received: from PR1P264CA0114.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cd::6) by MI3PR08MB612574.eurprd08.prod.outlook.com (2603:10a6:290:9d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.27; Fri, 2 Oct 2026 11:00:41 +0000 Received: from ZR1PEPF0000E6B7.eurprd07.prod.outlook.com (2603:10a6:102:2cd:cafe::5a) by PR1P264CA0114.outlook.office365.com (2603:10a6:102:2cd::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.19 via Frontend Transport; Fri, 2 Oct 2026 11:00:41 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by ZR1PEPF0000E6B7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.14 via Frontend Transport; Fri, 2 Oct 2026 11:00:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1790938840; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Message-ID; bh=NjIVtjyCndg2pJhK+bUz+wc7vNpzCZKoGxHGnOEVoBs=; b=lJcrzpQjmoSYEtQttnvL75Ia+t9ClN42BbEfCbtB+cJ0J5yyEOq35tmSOppHTiZL eZOvqSZAawmKKJAlUp9rIi6V2fXH7m5XdhzaAQD7yqvJgcrARXIbPn0LOCUiMgLiWeQ QqWghwEth+LNnTtNL5RaHVHEsgUDCDjs6wxOXzQ7ppBQEmgOeoPVdT3pmMd4U156c/6 32fO9ieSy1bIV6t+cxtItrMu4iyGiV/I/U+DtnGg7CnuwtVtizk0JjF0i77XoEHOIVU BWZU62u0BU/OgINmpM2Wbk6Rm6e+XZMP5BG999wVpcfOw43H3hhLGANtLq9gbbyPtEd qCDt6nrpUg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=sokbgaaqhfgd6qjht2wmdajpuuanpimv; d=amazonses.com; t=1790938840; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Message-ID:Feedback-ID; bh=NjIVtjyCndg2pJhK+bUz+wc7vNpzCZKoGxHGnOEVoBs=; b=QQL7nRqusnzNz041XX5Ci6cMfwIyhxMNQrEi4UcOqWpxX0eKdc7Fk2koOqdX7B+K IYQooN9YNY/uc5S5v4FKE5Uk2HrquZtgnOIQ/0rs6kwMY2uLzhrKhXaWHIGuZVvXo56 hCPqL6Nr+ROAqAo9qgKGaBx7cE/XPFKTD38idDlA= From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-8.0 1/1] hw/scsi: avoid deadlock upon TMF request cancelling with VirtIO #VSTOR-148264 To: "Denis V. Lunev" , svt-core@virtuozzo.com Cc: den@virtuozzo.com, andrey.drobyshev@virtuozzo.com In-Reply-To: <20261002105811.1830637-1-den@openvz.org> References: <20261002105811.1830637-1-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 2 Oct 2026 11:00:40 +0000 Message-ID: <010701a0fc45fd99-68486944-be79-4713-834e-dce297922f7a-000000@eu-central-1.amazonses.com> Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.02-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E6B7:EE_|MI3PR08MB612574:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c54bcbfc-9fd5-496c-f2cd-08df20746614 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|9140799003|32142699015|376014|48200799018|10067099003|56012099006|5063699009|55112099003|16102099003|18002099003|22082099003|4113699003|5113699003; X-Microsoft-Antispam-Message-Info: lbVN1OL3Z4enaVQ9lgdBl8pt1G1/t844TtynwjqT9/1gzMb/j5626kaAFGp864x7Rb3eHFhZsPI7IRwGrqHq7eL+Kai19yS08XDQQ2SA6rJzHlbSZUlAZ2TgJTxoiqFtXAuJmxz3t68h9Z+3RVUz9l/hpSVQ8Qokezj8ObSN8jWCi2F/snVqlXfU96/XaSnIhKgkieG7BTzGoFskhzqLrwFhrpNOC+uIsR/S8+9Qm1e/PcxGBrBaWXjeE5Fgmn5GzVm84sLU40dbtH4k4by18enoa6Px9PDPcysRDDbtkHe7EujoKbkfjFqiXlXOvWgfQpkF2XgIklD59S4mQlD7ugxEG5Vw0/JmvGxy1Nn8/M0MA8DiqTBQaSxAAaHIRJKzH8gvbSotCEd9xrb/HCGOjl6tNk7j0013lRoVEUywJ4JVo4Py0iXTGrUVsxXJA6FqmpeDxhlptV4jBQTFUtTbsdIphanpa+m+5K5SnI0+RGcLZvxEyWbayakgiwWlioCzkwjJNM2DfYcnWbRIw1Q5vLdHe/oNS2mYJvrEv7p6MUhlKoXJo54YTpH+3R28Vq9gEgy3oEJxhKKs1/JR6DtSKef3AUyEC9GmKI8EjIpx1xm62O9PvADvSYirIs17DNuXhafYKSqt5/Z9ozfNsIRn60iXt9PNL1BWeBDn8SB8BWvqJNwynHdrs7i5xWtFLSKFb8NY36BtvZG2Y1i7umQkBGjOLp6fqU6LPD0K90HziREATaHs13kt+aIWDbjOtm6B6TL59WJ4IG70Q9LB88oB6xNk2yZcWI5zbMXaxb4DDWjGyow0Vj4ScYY8oxKLIjbjze/vk40qpB2FZjDGWQRzGw== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(9140799003)(32142699015)(376014)(48200799018)(10067099003)(56012099006)(5063699009)(55112099003)(16102099003)(18002099003)(22082099003)(4113699003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ypnetwjOe/sQPhIQIqFiirv7rrArJ5R7EesXEVgB3wKnb0wrXBHzZK8+ZfxBdxd9P1wNhtSFBU10TpDjrfPVA8GbY3SsKvYWlBAj0HOnrf1H6bWv+LUu7y87HMijn3giFTmMUIJOs8fPJGPP0Wc3inCgU4EFvIGau3FSwxoaCiQXzHxH/Dm2FWXOK/nMC1z4aG34TWXAH+ibqQe68dWHj8QTYIUn2EWp6SLZqQCTA4kLZL0Hu3dX96r+MLYqyMfgo0UMn30YbkTQMfLwTP9kJ1ApUXChH5ekF4KcGBr+9G9uVld9ZzBOJii3OK0JlwQw6p+oROLNuKUT3J6O25TAUCURH+m3IyeKqfP+JkdrFz8s3/v+BR6WRfMKp9xUipf+zcB1AVDAQNbn3lqwdW5hPB457pVQfnS271KbVyylg+KG3W0GGJvews5YWKf/L9XM X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2026 11:00:41.0191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c54bcbfc-9fd5-496c-f2cd-08df20746614 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E6B7.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI3PR08MB612574 > From: Fiona Ebner >=20 > When scsi_req_dequeue() is reached via > scsi_req_cancel_async() > virtio_scsi_tmf_cancel_req() > virtio_scsi_do_tmf_aio_context(), > there is a deadlock when trying to acquire the SCSI device's requests > lock, because it was already acquired in > virtio_scsi_do_tmf_aio_context(). >=20 > In particular, the issue happens with a FreeBSD guest (13, 14, 15, > maybe more), when it cancels SCSI requests, because of timeout. >=20 > This is a regression caused by commit da6eebb33b ("virtio-scsi: > perform TMFs in appropriate AioContexts") and the introduction of the > [ ... ] > list each time. > --Stefan] > Signed-off-by: Stefan Hajnoczi > (cherry picked from commit 6910f04aa646f63a0257f77201ad8ea15992b816) > Signed-off-by: Michael Tokarev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026100210581= 1.1830637-1-den@openvz.org?part=3D1