From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1213661fd-968a767d-74c0-4264-969d-437be6f4c84f-000000@eu-central-1.amazonses.com> Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022092.outbound.protection.outlook.com [52.101.66.92]) by lore.virtuozzo.com (Postfix) with ESMTPS id DB2CE8017D for ; Fri, 9 Oct 2026 15:09:39 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PL8JxqKwV9iaKlU3aj3n9KRAm0MqfMR411FNh1wCjL2Ow9eFd6fLWYkub23XMcn7VucJlaDu1aSR59RGOqWpzGOsHK2W0GyU6dxtVmqhpsrsDw+/pgqS9i4kO+iYzMvqB97+KoJ5fh4AHeHZcuSfQ6rZWlu4zFCW6+5TxGE0IgTL7HlHrojfKROVp1qLCTtiFaYZ7RgzgPQZAzWR54l2gCRSPm+dtRBeSriXsR2J3zwmzpa0j5Wj6GruMZTcqx0iBMjY16q8Ld8Uej3Uvihn5oiUZNqkNVfKd3n1soRqFKKcpVZ6St4+A6RU4YTwbngavd3h+zOWZwznMO+MD9UYyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHQ5o/5vdBWpXWuByj1FPILxBdllLLXp/ECcLkncQxQ=; b=biCR2e04+uFAFgrhRRoC0PqLSDSbepQoWTfQZkXOB8zJ4rMpW/trOsUe/nw/G1/pAOrXMrdXkwb0a82WvsPv8d5WXjAGs0LGnF9blq0deMeSC076naXqXhIOc0hZdSlf3KGJ+QqBaw+aVZsQAF4I0k1ccZmFw2BLkIGZmY+Xynq2dm+6/e5kd5/3wOOJCOfEfMi1nLbwfGsHSd1AOqV2DxIzVMwYygW6kP3rcBOswvK023jVmqkA22HmEApGWxvZ+2WIAqG0OMXwBumjJrx1e9flnJlsZBnvYqSo9uceY8d/m1+aci3tfR/ZuSLKy7C2HOF2nYOQdzmipc6xFm2tzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uHQ5o/5vdBWpXWuByj1FPILxBdllLLXp/ECcLkncQxQ=; b=ZISlYE0bXtB0D8m7NLJqVbS70lvpszhsipU9nSM9jxwropN7RIxA8XdYc1csj9xmd6D9fldpEfk2o7sGbNcdCEvwJN9Rqa1Gb3urBPk7LilBG8if9+4lU0vz8Cnp2HKA/49EgJkkI1LiOsWm5WjydLLYOjfR2lOfxdHYPIqPiAI= Received: from OS6P279CA0156.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:39::19) by DBBPR08MB6076.eurprd08.prod.outlook.com (2603:10a6:10:1f5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.6; Fri, 9 Oct 2026 15:09:35 +0000 Received: from CPH1EPF0000051E.eurprd04.prod.outlook.com (2603:10a6:e10:39:cafe::25) by OS6P279CA0156.outlook.office365.com (2603:10a6:e10:39::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.20 via Frontend Transport; Fri, 9 Oct 2026 15:09:35 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by CPH1EPF0000051E.mail.protection.outlook.com (10.167.241.233) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 9 Oct 2026 15:09:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791558574; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=RZkNxj58C68JWkUUNQufEi8Nkn0eLe31CLGS6pIdni0=; b=2AtT3SJOM/Xekb77MkelaBUNXnhxdCAawAjxlQm7E9vl1b44ZmEqbj92ip/Zxdd9 cbkf5g/nLEpE0a4v1FtHg3DsVBE1jDRF/bfYlPagb38P5bWwiXgyPivnGRQDescBKlS 1gnoMGqjtlkQ5raxWpu1PkRGkujuwfjPojrcyn/HaWLtxeY23bAA8MRUxZW9KNNi9vP Nc6XFZPlTRGaQqr24GrVDdeXyyO3lKNgt0s6lpIw2V4gvud5znw6KWQmetsMMAHR7t7 ZZ8fDQ+GTAxLAxWrDVKJ6peboRqzAao6QabSvbI3zzz+YU+g98SilShU8cQr3aoTE8b 8bssA7Ilgg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791558574; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=RZkNxj58C68JWkUUNQufEi8Nkn0eLe31CLGS6pIdni0=; b=Ei1adDwu4+wXn1Jhn3Jp05jyzQkuAbfpdzEJ1YGg+Dm8iCMKwt0exNCj5Vwy49Hf KdFp/Be8ijZaZGwy2QDoTJaJDMYJV2EidbJHtPtqZmv7ivW1V1Fm67Hn1ratn2JfX9c kYPp4m67mANlrN6YNb73UmShXZoX1X/moPYnkim8= Message-ID: <010701a1213661fd-968a767d-74c0-4264-969d-437be6f4c84f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 01/21] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261009-vfio_v1-v1-1-2ae91d5b8048@virtuozzo.com> References: <20261009-vfio_v1-v1-0-2ae91d5b8048@virtuozzo.com> <20261009-vfio_v1-v1-1-2ae91d5b8048@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 9 Oct 2026 15:09:34 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.09-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF0000051E:EE_|DBBPR08MB6076:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e0bf85e6-471b-4725-0b52-08df26175462 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|9140799003|61400799027|48200799018|32142699015|5063699009|56012099006|4143699003|18002099003|10067099003|55112099003|16102099003|22082099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: NC9NupmE3URnMHTZ8latFTHJTfk66GLC7fMAyZuLoCe8SdTaCSQ1MqaOJSpWzxZXZ7i3Wr+Gq+qGr/X20um3Xgn8ZUb11dX/z6QAPFh2puycQseRdPxTH/WSK2lEtrG9TLZs4DzBFsr8kNdFvQt50HVGTGg6wiiGA1W+pYZ5wWI/PBO8/r593tkzbitm62m/zHveEp372lwk0oVFglMpVbhF64MUEc7q+TawDsS1iHRhm0Cl4j5Fi2AV8eRW2HMQzvDynDhox9Y4C0Jw7Qm6ScmnlhAKqQNYr42lHteA/M+Z64xB14usOpXCHQfWvtqlAuLp9dXw8RFLHmW7Nvy+nTxGp+8Z7pjg4jx7nm0Fsw+cD2alRxOEhWE9BctGm/6jmfq9Jzn4G5JLSKXEJAWIdxzlkc9CJgUx79yOsN4O7duF59RKGbBCmnRpLveBXwswR594PDRJFUVVhePZbCTaV1BvCu5s6zcroTAoaGWwYZUdZKZUHkf+KO38nY4uzNyW/cut08ApOKn55mGE0/sZl+qz4RtzpyoTlfGxLQ9rBA2TZipieSd4M+mTVK3UHR1UgVI5dN9v5hRitEEN+0SrlvDURhMWm9tiQtU5NTDoyWwXqedcIkEJyoOclGeg37lQ9fY9TGKo9RG/L1U7I2zi7bDvSkSUayV0vawVQb5gzGhNCpM8N/2fDb7hec444Zrnj1B3VBTxhMpijdCLEKOgczrm3trU2f17Aj61wvSXAhtnvNfrJW8C3j8GQtoXaHXXC1f3iLm7qSxLRV+1hHtuRl4J99VAKt5XcoctsTUyL9zJRDbOBNyiFcmqEIvGrMxTBRL5AWQ9iWIXjd4O/ytVzgO9NdcTM/jutb2BkQ1thMew7dTmuyprA8bBAXTVKCng X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(9140799003)(61400799027)(48200799018)(32142699015)(5063699009)(56012099006)(4143699003)(18002099003)(10067099003)(55112099003)(16102099003)(22082099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o0XpBH8utWoaxY8Ouq7gqc0om/SXh3l0n63HkWbAv3aAaIxyOlIyNbZmk8sx6BEgFklF30d0FnEsrXyBwv2zDC2txaTlFt3O8Vf1w4cDWdjkLlYKmwdoNvODuYc6B7h7ZxkT3WABmfnymfYYrchMakAw2ZJ4pbjz1vBJyWzbyv+k7JjFaRM/lW+ThJUvNrEI+Lo01b+Cb7BWn1rzIu5f+ek8CADeUcWkMecWUDpISOxZXgsYnwEcC2AwL7KEfAOJEaSKeT2r84rxpAzQktuseK9ZIQEDnXRlSzCqFCdDgYIt0guK51AiAcznl1dGFGMi2vCCArtVfS31NCa1Gb29ArI4VOkxXsnfNIw1dhH1IJA6WwLr5az4cE9MmE/aBSi0GvVfzvNZRev9i+Cu5OeuJUvn3x9nHtKExQ9z2a6PNZzdvdbFa3C+oYvaLSBHfT5S X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2026 15:09:35.0896 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0bf85e6-471b-4725-0b52-08df26175462 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000051E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6076 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261009-vfio= _v1-v1-0-2ae91d5b8048@virtuozzo.com?part=3D1