From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1213de34c-af6043fd-9754-4d2e-bd95-fb75f81d8f0f-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023138.outbound.protection.outlook.com [52.101.83.138]) by lore.virtuozzo.com (Postfix) with ESMTPS id AFE7C802A5 for ; Fri, 9 Oct 2026 15:17:49 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qA9SIe7MWUDxO7eR8dMb5DOS5IiGlBWWv7E1SzXuznDbhMLkK1mx+B6N9W/Bw5MLuv0cHP729SFRFHER3eyJS0rBx3hnFNuTZ4D6GFpWS/zDwdCujQyew/3VCJ5M3xV+WIEJWPY52K3cGJv1ZNmj52LqiRZC/DvkqvGdT6gaTOhCfpj1pV7kwRKPwEWeahNDsmKQio6y4uu3P3K+OCt+hwaUXpyMvFbGfTmXbYDXClgboTeA/8keXyZsyy6OiWIWrL+E1paMHzCPDKnDHlRIWmlPd5eL7H2SZTC4wPv78iWtzlr0CUEtH8s4R5NMYZrrYr7Q4zgaDrcSl4T6bv+DKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xRXdtp/6jy9BeSGw8Fw1AcmAtMZKeae4Ybm8Ifdl/zc=; b=YfrgMg6ArYjDZ5bPu12e5XcV0g1tOwxbTd26MVO4gQtOcBephNi8YI3H+hYggx2kYc06b51uzSkXd1X9SESWNzZVQqnEEey8gbRkWY2UbNGpVZpmyGqWaHICZRncNzR21HSrmcKDJijSIpYodtDgDFAoMRaObfNyl0hAHarY5/L/izlVZiBXXXkvJDxR7G9xQFsa45PC4ReCbz2octGVVWPNVZKpANC5UlfyNOWvfpTFF7qS7M4w6js8M5Tb7ztgPMaNtPJV9WUI5zYqGzg4kONF5gIzvr9n8C3TkCoW4rITgbTkEuFOiycWi8e7k3M+rpGdQC3LNEvc31s/YWrUvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRXdtp/6jy9BeSGw8Fw1AcmAtMZKeae4Ybm8Ifdl/zc=; b=Om21HOtvZ3nYEJoj2CMY3tnmyvgsGATKhzJs95or4LvrNt3vGzoLc7zdiszjk7yp9E+fLavMPt0TylgwH4lc5InSafMCS9Qf2wcbLgPGEPtWFu69HvGQ1voJAMIztFc3JtUwJbws5w+eY1IjYYFNcNkKGOJwUDIHcG/v9q5GrCQ= Received: from PR3P251CA0019.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::33) by AM8PR08MB5602.eurprd08.prod.outlook.com (2603:10a6:20b:1d0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.16; Fri, 9 Oct 2026 15:17:47 +0000 Received: from ZR1PEPF0000E6B3.eurprd05.prod.outlook.com (2603:10a6:102:b5:cafe::13) by PR3P251CA0019.outlook.office365.com (2603:10a6:102:b5::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.496.5 via Frontend Transport; Fri, 9 Oct 2026 15:17:47 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by ZR1PEPF0000E6B3.mail.protection.outlook.com (10.167.241.90) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 9 Oct 2026 15:17:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791559066; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=4SPe1Kn/8VicIACgR3eJOCa5pJO1rvQ2rmyflHotMhI=; b=g59ST21v/diZJwPPRtWB3GfQoX9beO1B08nmaj2PGOfS4vIVmIMw1tVq0LKQsvEr umpqscBc1bJo11QDdQcdLgTR4wdGdPv32/otRy+dMSy5BgIntF7SPEuEnnpFnQgQvvp S8nfapteG6PGsCdmn05Wh3oo0Xa7+Te3wqoZyWupUHz7ydfNTykC7myRmH4c8nEYcFB yqLfpW7u+lKT7TkHvw/8O8IguIVQKHE2XyyujIcr8vy1LOMGFyTVujYjYYqklM/UW8Q sJjr5Vq9XA6ICaHzrmlcdl0YKFjtlekmyMbvY9CBOYwagNH9QfaHNqc0xkVZa5XOfza fMC9PuE7UA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791559066; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=4SPe1Kn/8VicIACgR3eJOCa5pJO1rvQ2rmyflHotMhI=; b=Ee5cYalmcXeGbHo4q3fARLg8tg0zywyrW+i+ybvA9iKuVu2hwzN85TDMudrW+4YH Sf6jQhGi4JacDZTtBMSQWzclaJMvzu4amPmoPr12aklLIdF2Y1E9LvOVViSWcmR7LYA keZL2wOZDRIl0Cb16N977qURaeAreB7lcFZ4fCVM= Message-ID: <010701a1213de34c-af6043fd-9754-4d2e-bd95-fb75f81d8f0f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 11/21] migration: Free cpr-transfer MigrationAddress along with gsource To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261009-vfio_v1-v1-11-2ae91d5b8048@virtuozzo.com> References: <20261009-vfio_v1-v1-0-2ae91d5b8048@virtuozzo.com> <20261009-vfio_v1-v1-11-2ae91d5b8048@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 9 Oct 2026 15:17:46 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.09-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E6B3:EE_|AM8PR08MB5602:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 062cf064-16c6-4b29-93be-08df2618798b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|9140799003|48200799018|32142699015|61400799027|56012099006|4143699003|10067099003|18002099003|22082099003|16102099003|55112099003|5113699003|4113699003|5063699009|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OTl4Ym5HM1pGelI5d3ozVFIvcjUzRTZ3SS9JU0RoUFdUeERDZElEaG5JUlhX?= =?utf-8?B?WG5naTlHRGtMb1czOHFzTitjYy9WaFZJZDBkeWdrV1dzVUZ6MCtCRU9SR3M2?= =?utf-8?B?MFBySlZHejNSaDVLNWlZQWt1RFFBd2N6Wi9tb0F6Rkh4a0hNRzVxQTdSWW1T?= =?utf-8?B?eFFzeHQvb3BhRUwyV3RFdS93ZElGSWFnM2JVWkxnOHVXZkFudURTaXFxU0lm?= =?utf-8?B?a0NVSyt1U29UMzlaQlBQTmNZM2NmRnZpcTFHNUJsWkEzTTIwNFVQQmtwWFFB?= =?utf-8?B?RW5zbUp0QUo2cm02YkVVOVVJdG9nSjMvZUF3K1Q0cnlEVkhZUUlOUmZsOE5t?= =?utf-8?B?UzhhSVEwOU5KdFNoUTZYeHFKYURDeUIwUG93L3oxRlBraTB0dTF2cFl1cFRB?= =?utf-8?B?R3pMWE93UEVMN0czcERtbElTMVB0SDkrWU1lSWlnZjJmUkVPaFE5L0xLQi81?= =?utf-8?B?ZmhoMXNHS3Q4OHBlRllIcVo2QUJsOWVwNHFvK3d2YVBlWURIa0g4U1U0TFJU?= =?utf-8?B?ZytYUkkvQ3dCS1ZiSmJYUFU5NXh3SURQOHpzOG8xUVBoSUVWYnI5RDVsK1Z5?= =?utf-8?B?RlpXKzYxaldaSWdESWhxYkxpQ0VGanJvaEs2UVByV0Urd3lXaEFsdnhmeTI0?= =?utf-8?B?OEdNUlVZalU3TThncWFva3hhWDlHOEEzejMrMVN3OXBrd0RQN00vNm4wTVdh?= =?utf-8?B?NFB5Q1ZoMEx2bTV0MlUwTEN4ZmdyVjZGMDQ2NEtGQWNVNEFpTVQ4M0hIRURF?= =?utf-8?B?d0kzK0hxYThNYVU4RzJwTDNNL2tJckc2YkFVTUNTQXRmYUE1Y0cxU1VUM2pn?= =?utf-8?B?Uk0xaDVJeGtBbU0zayt5YjZUY01NUGpQc05IbVB5VXlNWFkwVy9lMHZwTzJD?= =?utf-8?B?UVM2QzhhTkowNmdpSzNNWXVOam1UWmRIYmIybmMxSm9lRWpoZ3VrYlpOeHJk?= =?utf-8?B?SGV5Nng4a25USC9oTVdmWmdqMXExR3hFWDNJNjZEbTZSV0Jld2w4Rm9JckU5?= =?utf-8?B?N1hFZDMvUjZmbFU2Ymo5NmRLSnViK2Qvb3VPdVJGRkFEZEZ5OXFZOFd3Yzdt?= =?utf-8?B?STNzV1RRaXhiejVDMTJad2pDT1dUblhqblliemlQamJUcWhDVjdTRTBCZFhj?= =?utf-8?B?eVNubDdaZjNDODMxVFdnMnNteTArSTZ6cmFvQ3JsR0tQaW9qK3hQUGRmbHhr?= =?utf-8?B?QXZkYnlsQ3E0RDd3WGxTNHh0ZkROM3dyeTlmSGxjMGJ0T2xCS1JvZHVVT2tM?= =?utf-8?B?WHV6b0dzekVseDdpT3JjSFdrR2txTk1WTjExSldEc3VUd2lxSkdadXp0Z0JF?= =?utf-8?Q?LC0B0XOa6gfBc=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(9140799003)(48200799018)(32142699015)(61400799027)(56012099006)(4143699003)(10067099003)(18002099003)(22082099003)(16102099003)(55112099003)(5113699003)(4113699003)(5063699009)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WfXhzyQ4WZN7e9rcYHMFulUFViwBDcXm8jcfvkK9UvM3ISGzz9lPCqE3+oH+uKNtn4x6ZGbMrIVYfkaARc8biX4iUKa7AxgEc75BgWEVX6eT3V6RFU20wptq2Ij3qb0pAf90bKJs186Q5BnRk2XtJamJRS4EtaS2OwUTQiVaGlDxhDOm4JC7Fmmgy3vkvXyG463WjelzL3ZygZ/QwAjWe7GN89xd+OjdWIpwXjRwJ54NvhcHbfOlt5lV9teNvFcvLXIz+zVeXoVPRKJZSbb4Oekg3JM0UJIw6vRc6u2HNYLLmDlm6lyLUclDXdQdDnyLp2kYW+vvlVUdXP1ijpkz/FtzS+64VYJ4apL4S/VHkCSZeLGai9rh7SBWxMZMN8ZUN3Z7N518qWETzwosytX6//VDZzC2hA8BeaTZtKhhxdPYM2/zWsTdBSWsN3fhGGCX X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2026 15:17:46.9501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 062cf064-16c6-4b29-93be-08df2618798b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E6B3.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5602 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261009-vfio= _v1-v1-0-2ae91d5b8048@virtuozzo.com?part=3D11