From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023076.outbound.protection.outlook.com [40.107.159.76]) by lore.virtuozzo.com (Postfix) with ESMTPS id 94AA880726 for ; Tue, 13 Oct 2026 15:31:02 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g2/Bc3eiX1WxrabVDfP2HAQHEvBX6r5B8s46TPa3ufo+NMqnF7H6IoR8LeW3/FkUruLkxaw1vV4d8ljBcAQNpbxtSpJpkW8srb6Zd8DnYA+4kqqtRNlRPkSbXk1HnDikTGvW6G4s6gZA52AJT0Skijk7w2jAEefu/fCdLiPMdUBrs5VR1OonU8guCqCREX2A/kEXnPXQnj0iUFvbdzvoCPO+daIpRytl7+RXJ4Sb8CbGhjl4AhXtVDsNx132tDhIpTEs3vZyfRc2J9aBgB9zQy4T20v6EZMWJpeql7Bb3Zq4/yXpZR935q2/2qz0JjLlkJjDHSpfCwbyxC+V8AQBCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TYN8IatLyy9buUz3A3UJaHSixmboJiDGLouaG5A0ywE=; b=fcUsVVCWI7iwU0d0ReMkuTgGZK/heacleukRK8tp8J3KNliwt3DkFH0xrMqTyhoFybL2bXh7H8vhMPIM8AI8DxeU7OA9avHq0lh+uEy5riXmXBJbB9gQjdOmQ23P33mbgkIuvrbYiqLVJErBhurUAOJKG/WzR4Xsn0ljilgrCw/E7Vdj1D8bm7uf9hneSbwqdKmv6VY8ffM/ZZ4u7hpSlvbfKtGbjLPS1j0mLrWwecSI8Y1yOJc3S0LHfyvLPZ9b3RR9smxH1z39pgkXAJOtoFfNlFiryln9sj7TcTdv6gl1MI4aTFt/gZ5nBY96dKasPRlYbXDh/GZmBllEV8KrrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TYN8IatLyy9buUz3A3UJaHSixmboJiDGLouaG5A0ywE=; b=h1umI5eM4FzENChBFS/J3NO0JQC4B7ZhdK6dO+rxk+Fur+rhmvbWXn3ZQ3AVqxGIjZdq1gIUbHTk8E8IAt3okdKrxoep0GvP3vjUetuwZqYUrQxtHiMC7u3ntzFH3Y/zErHji/TA6Jlj+7oK0tmos0vz2tyf0GrkG+zC/BERGwM= Received: from DUZPR01CA0287.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::29) by VE1PR08MB5598.eurprd08.prod.outlook.com (2603:10a6:800:1a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 15:30:59 +0000 Received: from DB1PEPF000509FE.eurprd03.prod.outlook.com (2603:10a6:10:4b7:cafe::a7) by DUZPR01CA0287.outlook.office365.com (2603:10a6:10:4b7::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Tue, 13 Oct 2026 15:30:59 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DB1PEPF000509FE.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:30:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791905458; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=N9eZueiI5ksNfcpjKJr8+u7t09hkVnYjpFEkn1tvIhc=; b=ub6OKA3tGOyLA+hh99uFdfnh22fD6xZ88N83hutJWoQ0NFTbLFYi2YOn/7/UwsBb x6dI9tchXImBPlMfEah1HkUFSsGqExyAkfc/Zgp7DsWfuujJgq6q44SI1P5W8ZIgbu4 FVCXMnCD620XJCcgZPg4WzPRVXNhr+Zep1RBgTtUScX5BLqveJe7mpLoQE4u4n7KF0C qUVj+NP3jfefmCocgUWY3JN4ru9NMF7Dro4+dZQ4LxqGTf4RmJpfmwQHaGHweWhxqYx abUzH2p+uoRz2ah3D1C4w1s/zEATxJgGCDth/2Pxvz0TkX+dJ2+liPNkAwBtOLdCufI ZVtlpaFdVw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791905458; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=N9eZueiI5ksNfcpjKJr8+u7t09hkVnYjpFEkn1tvIhc=; b=ehfjGtUYeITXZ/XzU3KzePdw34LnmDM6M675+xQBHKyj3/rZ7gd5svlqSSgW6sgR 7/cVWoJZ+OEzxpimw/bfWtZD1gM+8/xxR06PXAQD8HJhJ4yydPRXf+nI0+3+GiIA/BO 2g68VfBGAVsf6Og38K/9DovQful3pyD7kKNs2poo= Message-ID: <010701a135e368a1-747f6f85-12a5-4907-8a96-36e95b485208-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 02/24] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-2-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-2-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:30:58 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509FE:EE_|VE1PR08MB5598:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: beed5448-e274-4cb9-7309-08df293efb3a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|61400799027|48200799018|32142699015|376014|5113699003|4113699003|22082099003|18002099003|55112099003|260925021311599003|260925021911599003|260925022911599003|10067099003|16102099003|4143699003|261009223027099003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: GyxUmeWOsZoI0mD0YjPwIipaDg/qAOK+6lnciAIUygq3M2Wd5KkMIbMTyRxZOlWaBo3F9waMeyRziAtfvKjtkB6VPUmpGqi6psE+1o6v7XP75nhxK5RQMmiI9/Z8PVOfj+0Oj7MkTldtbc2KorX+glWkGLh8uawHF/OZb+ikNsD1JW8fRAW/ympXkI5I45hRLt+SAMXMjt120XWC+Ta5sV+zmoryZN1QCM+qWeU13P0ETDiwsYNqdWK6vWf4wtRqECqblqUWWZbsmKKVNGIdoPz2fO5v+cy8nbJOskK/zZmMtBUN1VDpoE/iJE01xCyMASZeXTbXAscMMSrbX7+l3BvtgWP3z7WgY3NM72RHflhTniLOOKD0YTRGmU4xOlPMiXP/MTdpw5Ud/FzpsQrMExBF/PdwEnF6PX9fABYIfVA6TW837Ok6gXXiE30XR8qA/Q28lZYQrhsMj6ZEShWO2Fr3/sBtvDEHnB/8gxLelbzcZ8t04VCJ5O+Zxu4xp8HV7m0KH4u+mRXHGxZVxLAkgmmkE1CF19MEvkOEwmtlmnorpuLvQsmg5hZbbpR48H+W88LamPscyDtnHcfd9vwBdR8Luoqshgu+vP9XryRL2lC2JT8PzSKNl96GgUkmiWWEf8Y9vFpKY97uvJpF4dyv/Rtq+3akOAyUSBeZtDVoc1KngfgFGm7ASrfpttUr/vaEmFBS/BqFMahj3SJ7eMiLQ1K5Af1bTMKq+oWBw6/OKMDoOMZtZy2kuAmy5g0YBfn/iyzbJwYolyqCYH317RQstLIuq4erXTuY1akWT7b14Vg9sSYUGmnhavWx5AuuJnnqIphBv8hx0ZtORYepr37pUqBrlws6qCxAVEsiLSMCpczH5AzK9mrvThAkUtfxPWrelruNL0XD78Gi11tZqU71KQ== X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(61400799027)(48200799018)(32142699015)(376014)(5113699003)(4113699003)(22082099003)(18002099003)(55112099003)(260925021311599003)(260925021911599003)(260925022911599003)(10067099003)(16102099003)(4143699003)(261009223027099003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: imLXBKF5a4LNNVKPerFtoYqjL3A15EOyL/LJ1cdP2XrjNyMEPwKs91qMAa84Bp7z7NuAtpEb7+HCQlbZU+BXfb2miJSOHHHuvfVTzqO7vpupSx47A4DsFygq+m1Iul2vTHbSkHObmLOzQiqYaUw3xiH5g9d+gRX/1xFIV0B+aQ/CTRKn/JGwhp+6G2P4AVLsZ1CIt+m9C6D/mMZjcdaQXPg9eNjvcWvuyVeH2nuCyvt9QuGjiTvIl9Saem420rnhMXE18ffbUDoOXzBGfaQ17Nu0nTG47HCypPv9l2sI7rL+/Dmmwc6sbDnxYcGbOvzOb0aoDZ9ujo76O5gCR/Cui7eosPaOOuf0PGEqKiocqd0Lsh9ZvkTWsryEeXGCXFvSgw1qO3f2N71GMZQkisW5qnbZobBRyeW0K1SX1JFOIJjeXEX/ZDJVc8T40d/G1Ou1 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:30:58.8652 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: beed5448-e274-4cb9-7309-08df293efb3a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509FE.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5598 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D2