From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a135eb83bc-69e28c57-9555-40a3-9be4-4e977428e7ae-000000@eu-central-1.amazonses.com> Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020081.outbound.protection.outlook.com [52.101.84.81]) by lore.virtuozzo.com (Postfix) with ESMTPS id ABFD980726 for ; Tue, 13 Oct 2026 15:40:00 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NAWAvzyNEtK/j5W8egfGCkcsqlUEinYY/KiWz6B07ph+Z1Vkn9hxj3YsGl3ztSzm5P0ZDJjVsXAUR3ctrygIDBP5SOB+xp+p+OIS91OCi92kCR3pxsDPify6ELZReFgqeRU+A7OiXbnmlDXolp3sN7NxGQOfIQ4DcZYUss0G9UKGl4QK1ToiCRaGKO5mXnA3CB3k/G5m/yYe60pwqpNarGLSMSA/1Ak3LSbwoa+9WFswPtTeQpa2xZI7fnuEsPzD9ISfhj+Z3kOXEk+WCkem1tIaxnR+Kzo9BY6iTKZyQYRLYAShWmK5HEgQUZz4rhhO4R0T/0rabm9AhwvKD3JPMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yisTLqm9ZZRCV3ICn3T3eNRXFtaWMT4X8ihs7l9MUs0=; b=RhBi3k40i4b2TdK7VaKNM6gpZ+I+r8TC0qy/jH5VOApGlaELXvzRqDPcYYZ3xA5gRkxRfmh7gOjcNsLlDyvQu+YQ41zcE27Y/KPb+XxnHeXu5zlksiyN2RfpLbAw+ULdbQJt1qs9MH4T4TdkQbprWfDV6FpRSRQpYb+HEvNJI/lGd+aj78FcO27gQcWAjUjKovEWUkaE0aRoKn1FYyn3UOex5VBJr/iDVCEoS/akG4PnwQXFn8FYko4nbv9P+UhKKCAa2J/575k9wM9rlee2OisBijLfAvaEior7VFzuAZarIfBk6ChPKrkgyj3AptCWT/Na6BfmKfs0E+sy5Gk1+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yisTLqm9ZZRCV3ICn3T3eNRXFtaWMT4X8ihs7l9MUs0=; b=hSTOOT3htiQLSkkuXBNMkn/Tq/HW8n6BMcYv3safQ2Gtlhu4X5VH95ITmjDfspF7An8rNw5qoXGS3GKozZYRGtfrKr7L4I57i/r7YkCzeAChwpqoCbjshLsKPe7irqaVi7KT7qXWntE8P6q6PfdVhutjb3xCbnUVKSG5tmLmmYM= Received: from OL1P279CA0054.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:14::23) by DB3PR08MB9033.eurprd08.prod.outlook.com (2603:10a6:10:43b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 15:39:50 +0000 Received: from CPH1EPF00000527.eurprd05.prod.outlook.com (2603:10a6:e10:14:cafe::54) by OL1P279CA0054.outlook.office365.com (2603:10a6:e10:14::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Tue, 13 Oct 2026 15:39:50 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by CPH1EPF00000527.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:39:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791905989; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=i+hVhgK5zNhiB5FmXHsLv0YCbhMjwL0J8SSKF+9Vd9Q=; b=Pk8PE7JzejrQKhcWcWt8Dizx7INJHU7MNxQ+pTPNmxYVG+GnW6kRgrG1M7usEGTB bnKYQQaHAPjSUzuZxX7bAKPbYQj5Tyl1v094hGkAoJihJavxlqE4IQr09pk6HWn00Bv R9wVTMp9KmRlm1p3h2AnBDVg34q3OmkaqH87xGim6joB7tyz724zoW78UftzlP6zUey bYV6A9c4iJaa6rbDw+cqGalroSXR0q5OrfY8Um69zy7O4AxRcUVKuOL5M14YhS24wWW QfpaAgt/moFJs3JBCBR+994HGahLpsBQXNEi9EhfVyWqVObbD/eJGSwxt8OL3JZu/5z 3C1ab8p5MA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791905989; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=i+hVhgK5zNhiB5FmXHsLv0YCbhMjwL0J8SSKF+9Vd9Q=; b=BHDxqwZYLGJEtlKoCw6cTxqZjvFNMNe68vBTD4Q4ndX4MHXEhMfY/MRZoyFiVNuC qCSywkFslzSIHYyDl4DMcWD06eIa6d9hMXVnaKdl00wmISqVczGAQOM0w3CFijIa1Au 4aZiQRAr1K73k0ThcitgAH453VKtL0qFLVOJKKi8= Message-ID: <010701a135eb83bc-69e28c57-9555-40a3-9be4-4e977428e7ae-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 12/24] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-12-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-12-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:39:49 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000527:EE_|DB3PR08MB9033:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 929147e6-0d53-497c-bf15-08df294037de X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704162111799003|32142699015|61400799027|376014|9140799003|48200799018|10067099003|261009223027099003|13003099007|4143699003|22082099003|5113699003|4113699003|18002099003|56012099006|55112099003|5063699009|16102099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RGZYOExTdmdyeWtubzZuaVYxbXYxQXlrN3dGdEJoTWpBeGlzaTRPUjJST1E2?= =?utf-8?B?akJ5eEZVaWR5bXRCL1Y1OWNBRHZiNk9NV0ZwSk05RWxVODZMcVRPVnNzRFdX?= =?utf-8?B?cnF4QnJaRmN0SW5hWHNGVytVMnJac1JDYUFyeFlpcW95L1krdlF5OFVvak55?= =?utf-8?B?R1JGN0g5dHcxd0wvVDUzaW0yaFd0TmJ4THYyYzZYVUt5eWd0QndvNEVkZjhJ?= =?utf-8?B?a1hWbFJjb3NQeDJlQ0xFYW1iejJKUlBGMFBONzd0UHdjbDB3eHNJMkpOYVJS?= =?utf-8?B?T0ZKbUY5ekl6andTbjNGKzluUUFkYTROb3MrWkZ0aTFmRm5hMm1QWVlVelNC?= =?utf-8?B?VHFQODFMdkl6cDhON044SUVtaC9rOVVkZVE1aDZVTit3ZkUycWpWZW5PdEtk?= =?utf-8?B?V0RPYjQzREN4T0xTMnFmVU9TTHNBcjNROFhYaFBKK2pEQWRYK2RyelFFNnQx?= =?utf-8?B?N2RxZzJ1c2NvellpZmhyWGF1MGg5c1ZWdXo1YWxUYkluRjZmcy9KME5jSllh?= =?utf-8?B?cVpwaU9QZlBmeC9iYXUyZUxMSjZXeS9UQ2dMNGhEZ1Z4TEpGVEY1U0YzUkxz?= =?utf-8?B?ZUtqUFZCSk5McjRGNWJlanNoQzRLc3FFeVAySFQyaGF1SUR4NTh2N2Y5Wm1r?= =?utf-8?B?ZmFEU1plZ3dSaDBQVmJBejZwRjB6aS9ZVEVRZFZyWlh2dUVrb241NjBoTlFw?= =?utf-8?B?WHpuUDJVWnZpZW1Gc0Vmb2h5RXh6RHRrd1FNcGh1c1hFTjFraUhMSVdHN3FM?= =?utf-8?B?eVA2QTByTWlONzdwdXlEYTJSYnAvL3BEaDFrWk5JcFVZVnYvRmJ2dExtcDd5?= =?utf-8?B?cFdsY0RQWXJXYlhMZmt0aTZCUEVRTDFWREVpYXpGZXA5TFV5UHJZdVIzTU1U?= =?utf-8?B?aXdEa01XUWtDQWpKMEFIelhmaU10eDZjR3AyUGJwQmpHOVlxdzh4TWFZME1T?= =?utf-8?B?S2RJR0R3OWNqNm9XRXJJSjBtUmQvMmdQMXBDT1M5WHJ1U3BVSDJVR3QrQjI0?= =?utf-8?B?WnFCOWp4WWxUT09OU3FUOGplS01CVlcyclZURUgyMmpsVWZWVEgrOFM1VkJh?= =?utf-8?B?N3RScXRnVWtROFRSM1YrZlV6Qk5mTTBCTVp3dXU4Nm5WS2hOUmJCSTNDZ1k2?= =?utf-8?B?ZVpMaVlyWVJvVEtqSk51WlhDZEhUZDRrTWZVNnkrVkJ5cXorSE44eXR2Zyt4?= =?utf-8?B?YnZmMVA4Zmw4VkRCYWp5WGhQSVdIY3pTRmd0QmZjOEM2WkdsV3FoY0E4MzA0?= =?utf-8?B?S0dSNkNYbERVTFhCTE1SVkpVT2VQRjd4cFphWEU2TTdmdG5XUT09?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704162111799003)(32142699015)(61400799027)(376014)(9140799003)(48200799018)(10067099003)(261009223027099003)(13003099007)(4143699003)(22082099003)(5113699003)(4113699003)(18002099003)(56012099006)(55112099003)(5063699009)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: J10dTjIgTBxENS/V42tt9b+SwH7DML564lR/CDcIRQ7TSIggDlwXrk0UwlmpLY2cHQacem/UFCyewr8vh5pWCT3GoakRlpcUS8eiTyF8zjXJbzaPY2ToHtWRJTJqA84qGqCMy3gc97rwZizuqFMuPRLHDaGOcQ0yL/8zBIrP87hZmlyUIpD0xGu95ccUA9irj/OZCaI3FkbDTXVfdajQrn+qR6VWtUsEAanS+Xr44KvFDZH159aXeIz7HYOitgeGGR/DdB76c0KNFMk3vglQgErMw5VI5SsqmDo4M+pbL99AFtzGhdRzKX5ZSezEGdiQ+iPsO8t8tSAjSQdDk1JFvjcSGnwYZBD1R+4TKIEVmptGzq47dKDZs3zO6TkKU0udQLfACI3pFCo79iO7UVi9VpiyfF9TGQNjGvZGcucgEgDokBbN/Xi4+qzxuzkRlzpf X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:39:50.0402 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 929147e6-0d53-497c-bf15-08df294037de X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000527.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9033 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D12