From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a14554232b-2f703bbf-8ac6-4ec1-829d-88ab3a80a538-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020139.outbound.protection.outlook.com [52.101.69.139]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3B4C080460 for ; Fri, 16 Oct 2026 15:28:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u9aiQfWZiSJ6+Ofi4n8p3omw8MkD2Xe4CeRnHjJF0igMIyK4hzU8JMPx6upZrQG0ykr5kGPXNNLS/EP2tE/d6exAlNbkvClxjkohCEG/WRwClPK6OlxjRMUeteLh0TSQ0VjNCw2NOnOih1vY3NqxJgqpof+vbWGd9m7abOooACPPB24wUNQIN8PcPI6ScFJSYs/N751zVVaTVwAWjrnkAcZSvM2bcYu/kNy3y6zTsdSRr30nE5/XJLeC0O1CgfUzbkAsg3y/c6lZFze6KkqgxdlUGIivqYlQsyKazrH1ihTIHF82dxfvWt3ST6F5ZPdvPPJc5rWh+uOZC/tmb5EbtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJxd+jnIgF/9Wmo0ikkcyOgFhS4fGcrUHrc1KOtQLPI=; b=WJy191QURvufSNMrpwoDeO08vXAft1K/DA1XX6WBN40iYQUFLBskh01ecN2jTp70RzfE0lVojv4lcVUcStE2XBMRTTgg6qYPxC+xx8k7PBRH78EQOEGJzLeP10u8fQm0SUtW9AHz4mVI6ta2qZyIEItTfEuD8eBnRrl2OoncCLvTxMaLlETmpUv24gJChm/mXvKEt7Mvqa8ux8hmgrOgMteCoqD6RHUNfu+GHIKKQKOvzp9FZwUwjtZR/3Ohdwc7EapYLzGXWdJwBJbiNWX31j649pVelfs/P6usX7iTko7tCE4THt86synwaDQ96+kEMVRqvssRSFAEvE7jeosvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dJxd+jnIgF/9Wmo0ikkcyOgFhS4fGcrUHrc1KOtQLPI=; b=T4V+MKtdRcl+VrM7vX5a1/rTwtI2ZvAjENtyNayAvbyUQQDvOUSxKulJqtYvDvS8mKwVBX5fYU7pEzD1Srkq0CURQaJdSjTRjyEymgYXijwlXBa36gC/PQoZgxri7+gxBuqblDbdPtxjFTYrOvqX33ttn+FRjYMCsB6uLShFV8o= Received: from PAZP264CA0073.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fa::19) by DB9PR08MB9562.eurprd08.prod.outlook.com (2603:10a6:10:453::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.7; Fri, 16 Oct 2026 15:28:25 +0000 Received: from MI3PEPF0000847F.eurprd02.prod.outlook.com (2603:10a6:102:1fa:cafe::7e) by PAZP264CA0073.outlook.office365.com (2603:10a6:102:1fa::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:28:25 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MI3PEPF0000847F.mail.protection.outlook.com (10.167.240.166) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:28:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164504; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=dJxd+jnIgF/9Wmo0ikkcyOgFhS4fGcrUHrc1KOtQLPI=; b=SR9kM8TsncgtGxg19us/inTcfLEX7QFbACvFLjlIxO5LzLcDRv3Z0BgN79TtjQYe UU3MDQr7Xd0P4F9uTkV21tHVNb9MFYuRaOBS8MKDJGKm9JuPMgu8nvt2XUNYu7J77Ez SSiXWN3VAK0NDWdnWgnIJMSl9DlMMaJ7PeNDR/TpZMTnU02Bwr0y2Gi8Xka48KW411J Be/rT+NTJt5M+1e+b9Z5YQARHqa6SNHxLcxTMk3v30Iyd0gju/+z49Hyh+ziVuGJ+l7 /7J87JuQV68bj2jZ0HCgDCUMYLDOFj/NjIFSe0itFh5T8rOqrLa1o7iDkSm3PDSva8D LWTu4w4ZYg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164504; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=dJxd+jnIgF/9Wmo0ikkcyOgFhS4fGcrUHrc1KOtQLPI=; b=fLf2d4UAwz8KdNscNPTQGVlS6iXK2er23QkqYuNnW6hDUK2+DpOaYXyJ6Z9nMsNw hv7s90kgELnuczIcNPNnKe64IB7Tv4WElCKBjOr5i2Yi5avLrYQg+m56XAXtCNDKqdE jxgwhUVcKYzhMyYg8TvteWBq7C079apeT0vztcnQ= Message-ID: <010701a14554232b-2f703bbf-8ac6-4ec1-829d-88ab3a80a538-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 01/28] VZ: migration/cpr-exec: fix Error leak in preserve_ram() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-1-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-1-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:28:24 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000847F:EE_|DB9PR08MB9562:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b71c0c1c-7645-4868-65e5-08df2b9a1eac X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|48200799018|32142699015|9140799003|4113699003|5113699003|55112099003|10067099003|16102099003|18002099003|22082099003|13003099007|261009223027099003|4143699003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SVpOU2tyQ1hTQzg5Vit2ZEdvZWFQaFd0T0xFSXpJRThadFQ1YXZtVU9Kc2ty?= =?utf-8?B?OWxJNHBhSEI5MHVHWFQ5Qm41K2EvNWVLdU8vMFU4MldPOUg4eDVtcXFnYXBB?= =?utf-8?B?SEU5cXlTZEZZK1UvKzJkTlQyUXNzbkhBRklySUU1SEFucVlKdHgrVDBBU29P?= =?utf-8?B?NktIMXhlRnpRUDdXRjM5RGJrTThxOUVBaVpVTHBDa3d4VUhvVlU4Wmw4a0d3?= =?utf-8?B?bngyQXJIUXVBTEdSS29KV29FTm5pV1F5Q3pHSzc5THNMUUpTcUp3amh1dGlP?= =?utf-8?B?a2kwdnlZMHNOUDBaK0tTT3RTWDV0YUJjb052LzRPYkVUdkU4aFFrUGprK3Zx?= =?utf-8?B?eUY5U2poUVdQdUpSZmpRa2ZzbklHMnIyRE52RTdmYlR6V2h2SWdxSUFwL3RQ?= =?utf-8?B?QVp3U2JBUXZhWENTUTFQcmtXdUN3UHFadDdzeWxiMnVpTXQyczJkVmhsU1N1?= =?utf-8?B?Z2pDRC9hSzhRa2hLYVNxK21qMEFvaE80Ry80U0NzYWQxNGNKeTRUc0JNREFI?= =?utf-8?B?M0xjUEg4VG1HemNxaE9ZcVNsWTltMUwvSnIwb0NCUzM3Q1NBem9MYUp6andU?= =?utf-8?B?TUl3UGtWazFIU2tDSERWNVBQMU1pMys0eGxueGdsNHlTMi9GVlZIckgrRWtv?= =?utf-8?B?OGliN0xVNmNHS2RlalY0MWF2am5BMnR4WWsyZTFZa3pZYTZLcVF4UTE1dEVF?= =?utf-8?B?Wm5GOGYxMG5wK3FvZXQ2bXJkMHU0RlU5NFZZMXhxSlNuVjVYMmVsSFV4c3Ba?= =?utf-8?B?Ulh0Mnc2MHRCVGJSWVp0MzAxdUo1am56cTVvV2QxcHZkQUFxQlhTQXdtRDh6?= =?utf-8?B?L1RYS1lPT0hFdTU1dUJjVHR3aEg5cmxja3EvNFZGb2oxRlpzYytzZ2VmTVRn?= =?utf-8?B?VlpqTXhubTMxWmsrY1RDMkZpbktPa1l4b1o0Q3dzR3BPNUxXNHBIVktOaW1y?= =?utf-8?B?UVVXRU54cDNpUHVTTnoxNjdCZ2wySUtWRW9LU1FMQVZUQlZmbEJaS1B4bTRl?= =?utf-8?B?YjNueXB6QzVKdlByM3FRL2lSb2JQR1JaMGszck5nVXpoOTYvRVg3eDJyM0JX?= =?utf-8?B?bHdDYUEwRVZoUU9tSFh5aXZMaTdCaG43KzRLbFhxME1HUFZsVzZrZWNSb2Fz?= =?utf-8?B?dURkT0RHVEt0bzdhY05vUCt3Mmo0QjN3R215MVFLM2xGSW84V1NHbWlVNmVH?= =?utf-8?B?anY3YWFFZlkzWC9EaEpnWjNxbDlCb1lVak1kZXQwY0ZsL0I0Q0hrL2JpTm4w?= =?utf-8?B?KzEyRkdHbkFvSFRqU25CbFFhT3hOSW96T2ZKM3FkaDl6bWxQK0JDYURmV3J4?= =?utf-8?Q?5VX2k5WksiDkrIyTq8XYGqFvPROoOWZpey?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(376014)(48200799018)(32142699015)(9140799003)(4113699003)(5113699003)(55112099003)(10067099003)(16102099003)(18002099003)(22082099003)(13003099007)(261009223027099003)(4143699003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PgARM9T41+fZ+Zf4LiNaH65r9d1EgBNywhYM0X5EtVJx9ZIkP9awo1KLP3ZVr2tUDzPXthM47FbF3PcS2fPoZUL1MHQdD3rWXL82eilG3rj9/NsaLSBBcjt/bmfoRTFMiA1e44MKuVxeRnGNm8QQy3JdA0Gv2ohWA9bWiVUNBFyg20psQ0Dcv1dsFrNLNyzCrMlL2S7eOWfe+DS/oLJCLTKosHXBUHUDGRG9qBdk5RLqoCvHISt9/sKeCuqPu/A88KyXlhRJATsYrMABqfOWj2pPH75FpMiYw7i95ZAeKjDg2zoibLgg98eFZIgJD/8yYv4AOkSXsgaB2c6yoIutmaBmiEW3i5T1bg45s+MZuuCKJYvEYfTphoUIEDf2LK4yXOqH8CmrMjnd+jFDX8gI5zH8jo8lk/i+wjAQeiyxYqMyI7tZufC3EmP3rGbqiPm7 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:28:24.8727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b71c0c1c-7645-4868-65e5-08df2b9a1eac X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000847F.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9562 > migrate_set_error() stores its own copy of the error, so free ours. >=20 > Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with = MADV_DOEXEC before execve") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D1