From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a145559e82-bfaffba3-ce22-4f46-b6b3-2b9f85f9568d-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020114.outbound.protection.outlook.com [52.101.69.114]) by lore.virtuozzo.com (Postfix) with ESMTPS id DE27D80460 for ; Fri, 16 Oct 2026 15:30:06 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e9DDEGOcSIKSejczw+NWx54/95II2eV04F6heOkPCTTkMoMWbqfH/ElCApSVsTRLUr9xLsX6iiLKeaMgLHo5H9Gn76Uz9a9WZjk+53lhdGiVR2qpb5dWAhdX9IAGJWxMPxcnG+tSWYPlNhuk+Q6lkUJ9ZdLINu/Ng1NcW/dNd4NE+JzvXGaLWuoACltuccnbiKNV7eAjyZPh5dW37dUVqE+yQ9yqHYRLf+BKn6a5rGhcjczwccyKcD708o/LUgazs2dFHprBkMzynBEfPtQi6q3CykKFsZX3dEmgM0RAlW2/DJG1FdnxZ5WQI4gT+AMN1GMQbBGfrtVbqXNQpdgzig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9DwrI7rjYwJHDB+Hac5zvhXzBVtW/3ejak0ZKQuo+G8=; b=pIKFkYfP1C97CNycqP6FcW/ZAlOzWCuIq5aPuDZIeqwVQOu6xkbll0b0cpfgPtl/Cr9URTF3QEdr1tSZidcBG9B0lejVX3tH621urdG5TcoOz5/q4kp3QSW5uHouGpMzv4M8jpxcM8hcWEmxcjrHnaxjgqQPay0WLUroC3d8iqPjJZYw3NNIQKvynWQsL+qdLCI9lVpY971brM8S/tBfyxDh+t5VnHZykH4c/IdRDDpEpzOjhOdYDwCB3187/m0CMqzwjDo7N6yS5J0us31tkPyGNEhTrs/x/xJBmDTPXR3E0i6Vbap7yNorM9QAknoHpntMsHyEXdInHkkCeO8EcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9DwrI7rjYwJHDB+Hac5zvhXzBVtW/3ejak0ZKQuo+G8=; b=LVjyci7FHKVJ4Ee5pcq4DFUeDq6D7jWKxtS9BVGRgvPFmwniWr/gy8SvGiFSLfSkVsgeBO+scxontIzggwkfHo8DdwROHNjvxzqORe95xnDHyQTp2ZfjMVULrSTa4bA5n2RBkm2Qew6aTkKpaVNtVRXvUI2focnRiuQHMMI3aQo= Received: from AS4P250CA0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5df::13) by MRWPR08MB11808.eurprd08.prod.outlook.com (2603:10a6:501:9a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.7; Fri, 16 Oct 2026 15:30:04 +0000 Received: from CPH1EPF00000529.eurprd05.prod.outlook.com (2603:10a6:20b:5df:cafe::91) by AS4P250CA0011.outlook.office365.com (2603:10a6:20b:5df::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:30:02 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by CPH1EPF00000529.mail.protection.outlook.com (10.167.241.164) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:30:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164602; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=mvO+ENcM/RIzjSqbXZPhWfk8FUqOVhM06auRI8FuRe0=; b=PHnCxBTYZkG9cKiBnoOnMeP6g5l5YrfhTRLwAANDZM9aI4QO0tG1fblHcLnxbutm 6wPwXRDbJQLZCQ1Zi+D2fqh37kZFhrqWCC7WoGtWm3ZPg1WEdT/3ZXDfXTr8/oU2fpm PQHb0IYcVs1OJvf1b/OO+S1fBylIl4HyR20iq/mgAtVuCwPKxxL+hT/hpQw4mrONIgE bwdgKFELtG9HX7VqQxXz8Ds115sCQKo4Hlw/Otr21ZLMLJTRGyPZk3w+iu91vEG3TPN VK4RQf8gCiWn3llK6y9SN/FGIkwuVb5xrWg4sIFWdCf/LxcrtztoienTKOl4AVkCQ7F aSfZwfIe3Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164602; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=mvO+ENcM/RIzjSqbXZPhWfk8FUqOVhM06auRI8FuRe0=; b=buytUK2paxg5k4mGKdQhwikNuFE78WJywWj8JCJsDwI4v11cDfpxzWf+hEzj2QRZ 2I4Ya0FKEAy6gpYi4jZLU3p+oIdR5fNQxW353yecqhM0U1GAo+vMvnGH67DHCzlPrYP ldjYzkO1XUe778i32FX9Cb67YyYCsT8KeWb+1QnI= Message-ID: <010701a145559e82-bfaffba3-ce22-4f46-b6b3-2b9f85f9568d-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 03/28] vfio/region: create BAR dma-bufs with O_CLOEXEC To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-3-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-3-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:30:01 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000529:EE_|MRWPR08MB11808:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 13e52ae3-9577-49f1-2d4a-08df2b9a58e6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|32142699015|9140799003|376014|48200799018|61400799027|5063699009|56012099006|261009223027099003|4143699003|18002099003|10067099003|55112099003|5113699003|4113699003|16102099003|22082099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWM4SVRwdHFrbUp5T25pdi9VUUU2emJXbTg3NWtFZFdqcldPemRDMCt5K2o3?= =?utf-8?B?WnVBM1J2RjNVMGx1YXJVaWErSXlFdHZMam1mZmI1WURpekl3RVRhK05UNFVn?= =?utf-8?B?M1NnOHRjcHgrNnhHVjBKYTdBQnlDTXZBWjVvU3NPM2VXVE9yRVN6WFQ1YjQy?= =?utf-8?B?bWlUc1RBb1k1c0lPTFd0bk9zbDQxdzVRREYwWHNJLzh1NnYyeGhHTlU0NEdH?= =?utf-8?B?WGIzNzQzak92UDE2WTlYVDBKRnRQZkxvdmNvSTZNamdSb1pJVlNteFBJS29q?= =?utf-8?B?QzZ0N2JZYTdiSEgzekkyaWgyWC82QWlCU2xRQzRkQ2lUVzRlMjRUYlBkQ1Bu?= =?utf-8?B?Z0kyQnIydnRCMzNlNFlwMWt1c2ZrbWtxQXgrS1dUQS84eWV4bTN0YTJQenNG?= =?utf-8?B?MDlEU0lnNnZvT2xCMHV6WUkyZnN0T1puVXR0NXlvT2FoK1RDckR0cVJZdEE1?= =?utf-8?B?MHNaUk00WXRMZHI1NHNNWWdzTGR2RVBIVnh3Slc4SlFpYldXTHRrVFFkVks5?= =?utf-8?B?cVFiMjY5UkR5NnJ3QTk0V3c5YVc4ckpxNUZkL25IaW90MmcrZ21kYi8xOXpV?= =?utf-8?B?T0YyREIvSjNwM3RQdVJqbGpkMVhzMkRya0VLMisxd212UVY2UzFtbzJXQ2Ns?= =?utf-8?B?QzB0Y2VmN3M5SlBPSWEwc0tPenFxNnBMRlFJOUNtcjI1L2ExUzJubStGcGFs?= =?utf-8?B?T3pVWTJzdjBvMlJ3ZTJoeHZrSFlHMm9Sbi9pKytXVDFESnBWL1IzTG9OdzVS?= =?utf-8?B?a1JLWXFYOXRpbEg4OHdpaFpCNUxaYVZzaEljQ2VNbFpPMUlJSmFwQzJuR0JR?= =?utf-8?B?a2E2b0dFeWV5eXYxVjV1NG56NkwxU2xaQytXNG9aK3ZMam1ORUFybDQvUkZN?= =?utf-8?B?cUZIRGtPc2p0b0g4QmkyN01RbDAyUGNjcTVFczdvQnBsZW1uM3NMWUoyb1NZ?= =?utf-8?B?U21QNHZ2TlRSb1Y2OXNJR1ovQXZZK2prUHBnaU56VU5rUHNTSnVNdHA0dUJE?= =?utf-8?B?YjBYVityUUFjQ2luVUhZKzM5T2J2UGZuY2ZDdUVsa2p6RE1QYzVzZFZHd2RV?= =?utf-8?B?RVp2aTdCMklGTHJhTTREc1h3S0xiazhpb2dDYlptallKVnhkaXRXRmcrZ1pY?= =?utf-8?B?OHQzT0oyV2ZJQmp1SXNMc0cwZDRyaDI1NkpIbHJQOXZDMXJKL3hnODR6UkV3?= =?utf-8?B?ZTVCZkUxSDRwTTYvajBROHBiTmgwR1BFTlZDeTVVY0xPODVKOWt6dWRuMXBh?= =?utf-8?B?aFFwUFRuVlEwS1JjaTdBR1RKQVNOZjRrcVpJN0xybnAxb01jK1M4RDVyWEkr?= =?utf-8?Q?qd5HtgBIptaK1yNaELQGMAPbT1Pz++0YEY?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(32142699015)(9140799003)(376014)(48200799018)(61400799027)(5063699009)(56012099006)(261009223027099003)(4143699003)(18002099003)(10067099003)(55112099003)(5113699003)(4113699003)(16102099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dtyh9/MPvy0IcSWA7ijfK7ScWwrj1b7Qdk8HrHSDiKoKk58P4mSRJbvFKChcg7c7LEie0QmERvWrCHI3PAE6lLk+RcV7efhvFJD3Gkgj9Qwd1qQuARxvoNYyG71PXl1Dj8NJOq8aETQs8LSplvDIw7lXUdoPbuFJbeLuN+pYOstbazuAVBe5LAhQ0Vwe7qdKVJpAMfheJv4Vqxh91k+CvdrueOhEt2BK9WxiW1mleFImCEom4ks5s7Ds/TiRqLrrzpn8Zk5NnzxoxHmw42uCwMXo5RxS0V/0viZU4PUjmKaYx7WkcdaPfrvALBrUz/lQrGCKfQbek8wSFFYUk4DYrDVQBxUvpwYBBNTXcDmQyaRczUTRBXj3GGxg/7woBtp3GV3AmMmHmTcb1Y3gKFf+bmiribkBDXr3L5/EZ3VFh9B7gHfA+8t53ik5gB8hjHVe X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:30:02.5419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13e52ae3-9577-49f1-2d4a-08df2b9a58e6 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000529.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRWPR08MB11808 > The dma-buf fds are created without O_CLOEXEC, so they leak into any > exec'ed program. With cpr-exec, every update leaks one fd per mmapped > BAR, as new QEMU creates its own. >=20 > Fixes: 96163e0dbcb4 ("hw/vfio/region: Create dmabuf for PCI BAR per regio= n") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D3