From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023092.outbound.protection.outlook.com [52.101.72.92]) by lore.virtuozzo.com (Postfix) with ESMTPS id 40F9F8017D for ; Fri, 16 Oct 2026 15:32:19 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ae+r48M2QCdH8TcuYujm9hkOwzqnr6ZNrIHn+yfcf3mvlibY6mi3MVpx9aEoeWEgb18pjyyxqivBGiEVpmjg4peDdT/mUPaj6XdtLHMI1eFmdOXXwLN9Md19GQ8zVpl5fOSkHCIPqtI3TOTcDiwmXHtjMBrDQaThs11gRKAhw9IjsO/vhHbmvR49bU3hYsxRNtW8ZvDiqpLYi/J42+kXEqpfdfZkPLZ5U9YMhN+KwGv/WQ1Qg3fgy+SJrvRd16AihwBWS0QHGXD5PYwVkD9b/lAF4mdlJNhAUbTPo3hZo/tm2OP1KF4nrF8eflHeVIw7rIJw/XALMZi2te3/HYccUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgpGKKizOlBWHFF/6tPQ9HeCLKwvhzd2ZGbdNbf8plo=; b=ozrTc1uM90NyI+/CUk8tOMKMak0lWrDdjmWVdijxYnC7mh8l3p07dYLJPdi1u1OukSURE5VJCni02HHSe6Fr+E8v3zfNKDOOP9Qa4bsj38/wGlT9ClSql0ZFWRGfO3fB4NV0VEqNFkvus4BdKrH3KCIP4Sq6JfUQXE4L5covLP7tUtbEuTeF9hVciThj9iptWyBJkW2Sya7MhF+2U5D06Nm5N3YLjeRVc143DoK/NzgyFMmHgVxgjygqQ40OMzy4HM+iYNpXKuGoS80NzMy9OwEKRvqggZ6DgPBKuGjJPj6L7KoxYovdFBhfcrICabnuPR0qM1HzQY46ExHhEvt5cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgpGKKizOlBWHFF/6tPQ9HeCLKwvhzd2ZGbdNbf8plo=; b=ii2i8WAkwf8YR1XFveCgmPCGQqgPR1PJ7gvIQ8ZgoLQDguRSvjCtJEAKyi4lahQNW89qbUZ4pNcDEcSnfAkPnnp/6mf3IIXWjK446IUbFwlT/zIgcF6RLFH9J4TR3cJtQ+SOLZiFidBf4r4jeWYVFyBqXqr4DIetCW8AExuZP4A= Received: from PAZP264CA0104.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fb::13) by DBBPR08MB10748.eurprd08.prod.outlook.com (2603:10a6:10:535::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.7; Fri, 16 Oct 2026 15:32:15 +0000 Received: from MAD0EPF000008C7.eurprd05.prod.outlook.com (2603:10a6:102:1fb:cafe::2d) by PAZP264CA0104.outlook.office365.com (2603:10a6:102:1fb::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:32:15 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MAD0EPF000008C7.mail.protection.outlook.com (10.167.241.203) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:32:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164735; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=6+vwYIK7Lbt2/jUA5cVkimaqrm6f2vY/ZVRWs1wjJ7g=; b=1DYzJ4YcF8tnfcqC4f50dwJ149EORP/RaFI+mVLidatW1Hhz/v4gZFd6+MNiRHfs 2WOYIusylyIodTvovNCgPsibEjYnwaASIpT95SBZlbtmLh35+2aqCBFZEXlTyG1QLPh JJAVVjPPRRyr1lH5OggDu5qRsBJ4Uqi/191BDt+F02XBlSG6rD4rX5Pfxb9TQLdNX7D caL/UyC0mzbo3aIQcCBMhNrklf0524SkvW/Wm4FtwL5zkoO/7I0t6cZgZmmZWFE4nc1 gtEN/VJbGIdIZOUSGnpolRiZYGMmXdEagpAx+EOrgdXoyp65zzJQrjYEG3oieIeOlUG gNxX3INNmw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164735; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=6+vwYIK7Lbt2/jUA5cVkimaqrm6f2vY/ZVRWs1wjJ7g=; b=ET5XLzMbWMNfH4C7pVRUIZEgQim/AcNf37AX5Oozy62VrzipA1fT+fxd4UAi8MRw pU3Djuaiw+h5Empw0sDxTPxPAt6Fe6Z9czwJk9C59cqrhK82HVW9zA06jw2H6tU7pI5 PsBFZ3I6TZzXo858N60f5FfVxsgbtQA1bXYeuvtc= Message-ID: <010701a14557a7b2-3589afc8-b420-4d46-9956-b36473b856a1-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 08/28] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-8-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-8-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:32:14 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008C7:EE_|DBBPR08MB10748:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1e1d5552-c9f4-4320-0b08-08df2b9aa81e X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|32142699015|9140799003|376014|48200799018|5063699009|56012099006|4143699003|261009223027099003|22082099003|18002099003|10067099003|16102099003|4113699003|55112099003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: qmLKUYlJ7sOMbjZqMr8uWnCPlKKG6Mg7Z20tBSGmvx358m2Z54YxpPy658vhcX7jpj97G4uC6doJiwZmvcETsEmaR1ywq6q3t7byjER4oZ/Pyq7vXm1fcBcZ4JmEufe/fctt09ymDUbcM3ltGbOXRtx1/KqjFLca5cKDgSC78KyPAGLNsRYo1lCltXU34uw2cmuNCwJC1r2A87hMCNUBfFJG26Q9yt8eXFm8MgSyrNyfTznAJvJchSPQVnjn05+GOSGopXvnj3lB/iIePzM9npYXOZS3QALwpOWBtNHe23bdboFjEr31BOOY9IKYPilEVNUpz1WweGMzQJghnOBzi9F71wcTKPR2dHFQKrSdJz0CMzIzSEY/zq86I0Mf8h+U3iqr3qOicYPemc3LF8PJzCzr7Fkn1UgAKWdN/aCxz2wKrLyj1DE0q+3QuH0uWlIBa4hCSkNryfR5K3HuK9xR9kli6a2a5a7kmEbMCqrhcPW4uoAdicHB8nHguegYuzEIb8JvtMEQ1+ALCQ9U1UOt/Ta42aOz6Sqk4ok58h52IGqEv/pY7Vcv0gYwRatAzz9q8rqyJYIMWCTV+gZ+U7sRn69/URuXYVhbOv53qaCYll83bxxXaU+ya102lZ7kwCEm54XrhUZAfrl2rN5DQgo9go+ohDJlEveMOqMb60tgV/3kVejq5ofZvMDowHqTo8x//G7HHyY6XbBOPwoRgF2adAY6CXJPH+GYnMXfVs9KpD6oTUtlNimJpvgMxMB6Zb9uTrNrVpAY1iYYM69Ts5W0AqW4IvssNAg7A5qEusncXCeS0TRPfirtAOu4So+wbhBBu8xrP9vmLrgZtgzzwyPFquDZqCJmFEzWeVrELQTqsB5pgadsDjaf1Ww7CQnuh6mu X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(32142699015)(9140799003)(376014)(48200799018)(5063699009)(56012099006)(4143699003)(261009223027099003)(22082099003)(18002099003)(10067099003)(16102099003)(4113699003)(55112099003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dQmLagT8tgm/4CKw7bkmIGqNFUTbSSIEVZe1kh/wfS75f+ErH4RG7COSdMev2sbWcHpuE3u3Q1DlbJFOCakcAT25a2MNlaIQaPm1+Nr7E/AL2d2HtX13YwSYZtAyrfnVGUKc5JcJy27IV/YB3UPoTRMxwo9ROVvr55YSoXVOaipABj9oidRMbbZILbgYhbp0C28ifmW+8aDFjOprTyLDXhy+a2JTIWOzDIHGktzYVVKqTVuzDpiJ5T/ylldbKtRNd9ZlmJLi9HbkHOTDVQzzlI10azKDnItGndqTUba+Sp8NV+yvgOgnU16GiK9zOvbxdcXl6yuNc6S+iU0L2ew/qmlCHD7sUmw5lh1hW2qlvp35/KhVXVMztMZ0NcLTWgNk9PbGrY45wC1ECFzrWsLe/f0cBeypafhfXX1P8uC1nuQE1B43lmtsi9sHrOnxX0kz X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:32:15.4472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1d5552-c9f4-4320-0b08-08df2b9aa81e X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008C7.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10748 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D8