From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a145581fdd-ec233f38-6d22-46a0-bd71-4b5058029b10-000000@eu-central-1.amazonses.com> Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023143.outbound.protection.outlook.com [52.101.72.143]) by lore.virtuozzo.com (Postfix) with ESMTPS id E1FBB80460 for ; Fri, 16 Oct 2026 15:32:48 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lx2ssDHs/EK+QsHWt/ug5e53fYazELxwNJxQN9C0Wsew7zSj23r8NVsqudHC5qKwT3QlNQkWnz+US8HVYlr0OnYiPom92wfYrKQps2N9ioeiVxob4MGgiIG7yOHHdEXfBULLuleOkYFsl9Z2wUDSRdL+yUuqP4IsyIfThVRj5gs/QiFJjze7rORUM/gFrAnSN5HPCTd3JOe6IoKDucstV2L5HIytGV7RU9gKuzHhouyA+14GCrWmV6bHcvxCir2b5Wv0IQX/KMqTqTHF0d67nuEWRFU0H609xHRc+7ZPqmC1EJIlp6VPynb8wBBYSxZQF7pM3k+2tMtGGVtFjxM2+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5bN86tcITakszdveSXPJv/zSg+nkQXvghisVUXImGZ8=; b=EY0OJY8ZvC5pVZ/Eyyeoa4ixCoCQUDHMOC1r0k8f+X4LlzclErAU2OiwByQJip3KiNfki4c30Q9v+nfnyXT6gM0HSzzOpFjkonZ/SC1UhIvPgNNc5QC6DruS6u2uuUHX59qKIOgaDzbP1AdCguaaY2vnQhcMlsdZZtlL3C+zHCZQTuxsaZ6t22Ve+n5MhLgaNJOEcGavQAEG4sIpe23x4BmwKHAQwSfSylN4FEjoPljjlNTeReKF/l5TUsdpCN5BXLJjwMy8EV7zIhCJLfckRMRBLIcTCfx+rzpnqEhPjIsmh8AKoh3NYbSoqOeAZa2TZegqvKlFKzb2BOy66OW3jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5bN86tcITakszdveSXPJv/zSg+nkQXvghisVUXImGZ8=; b=SVvnfIti+G6hSBrb6f3C/dq69pXm7e8ME2tIRe+tITlYmEimy38rfi7KZjbGadPYyQY1uiWAyPZ3J0wKZmk1URG9FVcOe/NWIgaFtj5SqvBaWa3cdlDMBbij+0eV7Ab2vrKcfUe4y5Xz/RFAsIJigW0wZ326MhgeoO0UQTwVFfo= Received: from PA7P264CA0006.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2d3::16) by PA4PR08MB6271.eurprd08.prod.outlook.com (2603:10a6:102:eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.11; Fri, 16 Oct 2026 15:32:46 +0000 Received: from MI3PEPF00008484.eurprd02.prod.outlook.com (2603:10a6:102:2d3:cafe::67) by PA7P264CA0006.outlook.office365.com (2603:10a6:102:2d3::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:32:46 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF00008484.mail.protection.outlook.com (10.167.240.171) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:32:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164765; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=jXivXdwPdOPogcvFq7mcBoiRjOLe3pKiQWEeN4/k1iU=; b=GXliFhG7EGl5ctsji/jX1drU4ee/RlodfrhbvHgFpW9iM2I6R8oxJt0icOLNfz2R skPjHSB+htbWtJzSeAwRmv7Ss+xalGYGz/4cXGTVNgH3w59lnpVw7R+Gzw39WZDeaaw zMPK7zJKnJQrf36mMBPSpe5d/kAji4a0oGCyXMfBb+GREeKRN8rqX1Ert/1pqt1AYAQ hhv4OEZ0VPTKYT9hlsa/3kUOBLcDnUvi4wLj7LtAnlHLC2DZCRteZp6pfbQOCB9AzPW o/J6RHyncXovClklqf3tH1+4czvK06FBPpfQtCck1qJxc7nSXDATaUIoaT8cPWgUA2S nf/rKFDGYA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164765; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=jXivXdwPdOPogcvFq7mcBoiRjOLe3pKiQWEeN4/k1iU=; b=F3vc4BzF+J3F7Wf4aVLaAH61d3ATGvvwgfiOo7TKnxeDUUxHPlD74CTcv3JigIKV w1lEmrAV4RBIF5Rg5NP/Lsdz0ZO/7lNv4IAJ4uyEyLIfYQwa8tqCEZsPCEujbbwFsmp Uk3WLtwsNP8qJjsq4XwWf1CaGXIeOmWsr9f38pyc= Message-ID: <010701a145581fdd-ec233f38-6d22-46a0-bd71-4b5058029b10-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 11/28] migration: ensure APIC is loaded prior to VFIO PCI devices To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-11-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-11-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:32:45 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008484:EE_|PA4PR08MB6271:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0a60633b-6344-4e39-a0eb-08df2b9aba73 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|48200799018|376014|61400799027|5113699003|4113699003|18002099003|22082099003|55112099003|16102099003|10067099003|13003099007|4143699003|261009223027099003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?djVXVkVMOUR0Qnh4VFJIaHRGVkErcjEzdXhwU1FHMFpTWFJOUUpZTmJBSC9v?= =?utf-8?B?SFdmOHRYajVHdCtEZE1CLzQyY1VYa1lGbGpZZTRsM0l5bXVRYlArRHhod0VR?= =?utf-8?B?ZU53SlBZUTMxa3d2M2J6WUE4L0VhZ29JM1FTa3J4Tmt5MWxJY2pCVDlFVmxz?= =?utf-8?B?L2dhN2kvcnExY3JncGwzSnl4QytJUFMraFpOVmwzTnRXSXIzK2N2a3NuMy9i?= =?utf-8?B?V1k5Lzk0YVF3ejlKSFpRb1pmaitLQkdKaU1hTlZxQWd5QXRidzNkWDl3cGw0?= =?utf-8?B?QUJadmJ3ZHQzZG9wYzd3Q2hlZTBYMDhCNXZKcEgxRzV4UmdBa3BkZ0RvVjN6?= =?utf-8?B?S0R2dm90alJLNzJyLzNvY3JVOVlRb1JyR3V3UXpJNGlQZlVBbkFUYS8xMUw4?= =?utf-8?B?RzE3YXJTc0gvL3NUYWd0bzFaWFVONzFGVlVONnNyc2tsNmJEcFBPSytsM2dL?= =?utf-8?B?bWdzTW1nZmlaY01TTzg4SjZxME9mNjl1Zk9jMTYxV29EenJQNUFoalEyYWd5?= =?utf-8?B?cThWWTJNekdid0s2WmQ5dUNUREVBTWRrRUh1a2RmazNRV3dVUkNaR0d6SDNl?= =?utf-8?B?Y3J5aHJSWkprT2QvUjY4UzN1bWRmdDczUHBTUHdWbE85M1RWUHFQUkJtN1Vk?= =?utf-8?B?SVNRK1hyVjlHdHJBNmxXbklhQ2xXWGF6TjdkVG1Sbm5ycTZJcUlYR1pjQWlm?= =?utf-8?B?OTNlRGpidmVWUEtjZmREMVJLREJ0V1BNOTM5bmVuYi9rRGgwNTdRWkVVZlQr?= =?utf-8?B?STVCK2txeGczYkN6WWd6NDFKNFZnQWkrOU84S0hFemdVNHJ2dEpVaTFxN2RT?= =?utf-8?B?MHY2ajFvcEpBaUpWK0ZmVDV4ZVJvaXA0aTBicE8rNWlPOE9NSHlVMS9wVVQy?= =?utf-8?B?RUlRMG5XUjNsZms1NE05YlMySHJXMDBLeG1wd3haUjVjaWp5d3hYaGN5bHVK?= =?utf-8?B?T3FwS1g5VW4waG1hYjE3cXV6aUFUQnF2cXdTNzg1NjFXaDBYenprRWlVWGY0?= =?utf-8?B?a3BXNHlCWXpHeU1rbFZTMkoyR3kwaFI2U3hNZDVHbFF5RnUzYXF3Snd4S0pE?= =?utf-8?B?YnNSZXhDZGt4eXBYUUJKLzFQVmg5V0RKMnFkVm55ZE1NRVNWd3hwTXJzTzFR?= =?utf-8?B?eVFFSldrRWVrMWRmNEZ5WXlnWmNVQ25xUU9VSnZjVjM5bEJaUXQvdEZrQU1E?= =?utf-8?B?M2w3anlKdFMrN3lSK3FSTzJxd0lpeDl6Z3lCMmhxUzRTU2gvZHduTHdXSVZt?= =?utf-8?B?WWU0bDQ4ODRZR0YxRTllMnhxSzlWMU55b1ZYYWpSc3NCejdaMnc3UDRxZVZz?= =?utf-8?Q?6Ql6RZgJbGsjo=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(48200799018)(376014)(61400799027)(5113699003)(4113699003)(18002099003)(22082099003)(55112099003)(16102099003)(10067099003)(13003099007)(4143699003)(261009223027099003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: V7C6IXoXvibP0nYJ6cWX/L9jabS+WJfw/2W4NHsCVV40pjsqoyYHDQaCFRzoV5gI7axO9DosJFcSXPA/AkGqdEk1m+ff40lGZiDALbru89oJOm6xtExryofJGD2J+IO6F4Vt45x0zt5VQz67XM0flTOflYHBBtFbriiQAzNn+M1xevz65tclFoms4RKM0MsTsehgNr76aVb6keknYMLmpkrBkwFeKDBy9nDRfOWTyWUnPd2gKHJv63jjk0dWGzZ1VMe4rgaL5RNUeWStN3w6CdXgJQI+WFy0Gj/wfuMhII9c0FIC30a32rd4SwlBSoXG9+eqau3xzCtD1mpCgbpAHZ7ktEcTUdqX+SsYQmtapqJOdXl0Goq7WFcBNBmKvqHuWmeigiG8BboHgml1XwgAvgS8+a+tgPAKnbMn+RbdlY7BdejHMW5cu9k0FQAZKr/z X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:32:46.2086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a60633b-6344-4e39-a0eb-08df2b9aba73 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008484.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6271 > From: Yanfei Xu >=20 > The load procedure of VFIO PCI devices involves setting up IRT > for each VFIO PCI devices. This requires determining whether an > interrupt is single-destination interrupt to decide between > Posted Interrupt(PI) or remapping mode for the IRTE. However, > determining this may require accessing the VM's APIC registers. >=20 > For example: > ioctl(vbasedev->fd, VFIO_DEVICE_SET_IRQS, irqs) > ... > kvm_arch_irq_bypass_add_producer > kvm_x86_call(pi_update_irte) > vmx_pi_update_irte > kvm_intr_is_single_vcpu >=20 > If the LAPIC has not been loaded yet, interrupts will use remapping > mode. To prevent the fallback of interrupt mode, keep APIC is always > loaded prior to VFIO PCI devices. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit d943cef76090. >=20 > Signed-off-by: Yicong Shen > Signed-off-by: Yanfei Xu > Reviewed-by: Peter Xu > Link: https://lore.kernel.org/r/20250818131127.1021648-1-yanfei.xu@byteda= nce.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D11