From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021138.outbound.protection.outlook.com [52.101.70.138]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7D6DC8017D for ; Fri, 16 Oct 2026 15:40:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RtCGDyu9b9vFlBaMeP9URMWI5sVmSph1C3uI45De2LMEuA7qNQxmWdPr461MHE29///w+y4+jmkc7baTez2dlkyhYQv6ZD8ytowgkW7YelMyiUtuhZGpyIqLy4mXlDoZbLN00ZUliGZhTWGdIwLx2rlcLt+GgizJ/uqEoeh2XaTooaDehY3U6sEElW41nTR+RJLThUbvCxrT9gknX9YvQk3/VuVqvLiqu8bwM+fN1Z9mmOZatWRxAEOc1LexkwMTCMUTPphE2MhwxPsd3XSLmevu1KwNEFOjuI0d1x/sKMIJapn5QKcokCfemiFWdbaemE0mqL/UZFvWComf+aSZrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doSYy5njhyGC/wyCvuSIVS6oBdEcAzLzW7nA/0wm3sY=; b=ZsmDqKBlioTYKUpNX9HG9pI51mG8JG8697d78bFzu90VSlyGPFG8vAf+/OHt96u2Altz8cEWekz0X53A6WRCPDC8Ss8Ar4jsiLjXKLjPbNNavqKEHyrFS+fKy+F966CJBWfO00bJHnUgp5IAD4+idPG/8c+Dmn8TYLFiTgRzEP/2c5uIqbhBqsDvdigGhWBYKg80GM7hld7F77jNy4gPx6KwqJT6n/SbJKXAaipk5vsOdG4SlHvtIkFfSSF7b3TGoEsnKSHg+5lnBT+xLruW5bcBez67TvlU5ntIIaklTBOt5lVIj/aG7yvQ/u6uXFwQJAB+XN32QPufigkhbo/58Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=doSYy5njhyGC/wyCvuSIVS6oBdEcAzLzW7nA/0wm3sY=; b=WhdZbBPT25f5U2orH5xGnZSL/r9iAecb45JHec1CYn8lAM8KcYPuLKphshBFGZqSEF6RSOF1m/YN7GEi54pJhUYfNE3RqAvZ69rNcLBdWSkMbvW3pa3v6rzmgstgHakb2F7FSpKehElM+rn0GUxs5/F4cTd1Z1qa/VK0FILl3D8= Received: from PR3P193CA0019.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::24) by BR0PR08MB728685.eurprd08.prod.outlook.com (2603:10a6:2c8:46::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.11; Fri, 16 Oct 2026 15:40:09 +0000 Received: from MI3PEPF0000847D.eurprd02.prod.outlook.com (2603:10a6:102:50:cafe::4e) by PR3P193CA0019.outlook.office365.com (2603:10a6:102:50::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:40:09 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF0000847D.mail.protection.outlook.com (10.167.240.164) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:40:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792165209; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=MIJKgIzmPtzL7Qxe6W04n7v0cX5vDzkYLCoRe9GAOuM=; b=YRE3ENlAwLKu6yZgreOJBjqOw2KknSmE9rsGE5M09aLv/YF9A+5ZR+9LClpRS3tR HkkbSREah8iHDf2MwIXQvQ5YuU8XRw1iW/MX/2PqM8Am7qXq1w/zyiqWXHSFRVlRS8s oCYM92ze1p6ojWPnNKi0ZPJFum7nRy76Dp1Br/z7efJWRgcUdkxTriQk9wGxGKG1976 wnkPUapZNLKC+gFMlOEhKrYzYBipu5Nl3uvzXjx1b/oV/Y3eb0Ex6OJGsrFoPniUcbz jwbt0Z65VLuAFxaxoohW4kgYmTWfTS7fU0UhDwdIh3qPzItU5dCMZX0XrYliTY2bH+5 S9PvCbmkiw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792165209; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=MIJKgIzmPtzL7Qxe6W04n7v0cX5vDzkYLCoRe9GAOuM=; b=TyB4M+RL0aUY60jTeR3KIC/5GEse4ic9vJPFKC6GXJwh35x9w+wVmdF7Voeq2Oq5 rDIUkBucFHvkHCCaU6IurqJZlQE9dsf7XoZdiWdLqeOZctD+HwTMVTfltP5rw9B6U4g SlUE8zw6bd/5lQ8WxqpVsuVZqt3hwk1FVqoXrGhM= Message-ID: <010701a1455ee438-59cd429b-2f5c-4dff-8f50-1bb8c25df259-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 16/28] migration: Move CPR HUP watch to cpr-transfer.c To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-16-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-16-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:40:09 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000847D:EE_|BR0PR08MB728685:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 4042bd03-ecb9-4ab2-ffc0-08df2b9bc2b2 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|376014|9140799003|32142699015|61400799027|5063699009|56012099006|4143699003|261009223027099003|10067099003|16102099003|22082099003|18002099003|55112099003|5113699003|6133799003|4113699003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TEtmTk8wa0RqRndGbENDQW1rV3plR1l0ZGxOQ2Y1UnRGYjdkV2ZwSWRmaWZD?= =?utf-8?B?ZFNsbWc2RExONXdVOVpEdjltSkM3dXoxRTZHQ0V3QTBwWGViWEpaRkUybU1O?= =?utf-8?B?dU5lWkpZd2VhYU1YLzdNZDVPTlNsdldxRXBxQXNzY2ZKWE1kWjhScVdrMHNR?= =?utf-8?B?aElPbUdUa05sWnR2QVZVOTlzRDlYcVZ2RGkwOFhMbHhQdUhodkk5djg1OU1E?= =?utf-8?B?aUpEdHRncjZUdjQzZVhsVGJYazhzMk9aVVR5TEdhdGZkZnUzUmE4Z2s2d2x6?= =?utf-8?B?L2FnY2hqR1NZMVNCeG1VaE1pSFJvSVA5aU1YTS9JaW9WK3dyUGh0WnliRFk2?= =?utf-8?B?TVl2eUlIZWlVUG5UeWRuUkFzWDRXQjZHamFNWHB4WmUrSWI2OFhGcURiN0Z4?= =?utf-8?B?RmR5SXc0R2M2clRDNVVRZ3NYdEJBNlVNc3lqMUcxYmRIdS9LZWlJTjJIeGYy?= =?utf-8?B?S0gwZThicUxDVXprVEtiZ2FjR0NzL1N6ekZscEJtYURuejc3eFZvRlNqcWps?= =?utf-8?B?K0pqRTdIQThwNEZtYVJRM1FNZ2Jydm9jeGtrYklaQ05NUi9aaFRYcmVBYTVL?= =?utf-8?B?Z0lSclliZVZacW9aVDZBVjFwYjE4UkJrRGE4UHI0dmY0dTg5R0V0Y3hoUzZG?= =?utf-8?B?WForT0lEQVRSQW5Xd2VYV1F5REFkKytxRXE5UFVZTjJLT2hNcXQ2L1ZNZ04v?= =?utf-8?B?ejRrT0dnSWhhU2VmUkt3ekVUYWFnTitzS2lGYm1Pd1J1bWd3QjdlNXJpaDdC?= =?utf-8?B?MjJIYjhPYmM3UWlSWXNPNmZlZUErVVl5S0owTlZ5a0cxZjFaYXQrckYvK3Rk?= =?utf-8?B?a25INTZpd3pQQ3ZmUmFKODZiamVTWEcvSHRsUllpNjNDSWJrN3BJdnFFckJZ?= =?utf-8?B?elFxZ2NvNWpJcERpZlVYNlErZVUxTVZzMlFHUklIRFJxU0YzSTl4SzRLazY5?= =?utf-8?B?dVBKZEZVOGtOL3RQZ05xaWlraEZlVkQ0YUhyd05VRG00Q3NueG5iUERyS29a?= =?utf-8?B?QVdSeHAyWjFIcjdhbXZjMllZdzM5TDErTHhheDg4T1AxRzBTQmZkTkFKT0Za?= =?utf-8?B?ajdzRmN0N1Q1dEpWY0JGR0tOa0VKRGdxNVFMeHZCYWF3Um82VWdScWgrNXAz?= =?utf-8?B?aEswR01peGpITHdlcVlaTHRjZDJPd3Y1WGtta0dnamJwT3BPMEhFaTk1ckVB?= =?utf-8?B?K05wZGNnYndvenZJdnV2SWg5SHhtRzFnNW9DNFRMZnhBREIxaFlybkNMTHlK?= =?utf-8?B?Z0QzVHFkWXdIT3l1anUwMXl1WlZJV3BqUW1acFJ4dXJWd2dvelNvNEg3cUl5?= =?utf-8?Q?O6NNljvFYuPWc=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(376014)(9140799003)(32142699015)(61400799027)(5063699009)(56012099006)(4143699003)(261009223027099003)(10067099003)(16102099003)(22082099003)(18002099003)(55112099003)(5113699003)(6133799003)(4113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fFaamALe2Onk3yA/8GbDTjUFJXQFA5mtlUwfKzXf2YcZWg9wGK7h7glsk14HuysujbWgHFh4j4x8DM5VsMTLCb/rqqka/PjmlVCJnQKNnmrUUeWxTTpUGnsIz/23TloL/ZdCbmGF+EUQr6ayLL44zc2v3gyGhT7JBSb1zdsC1Wp8nOv2/gcVT9jiej8naKJlrEsYMVup62FR+TqoLAlAQPd0ZrcIIEMGBCPl62qn2lUivp8M4bPLz9oT0HGcU4TmkCxV9BjIbZROUt57HtE2WfldvvuvEZcuqGsRHfgGvTmawqEw6RTABV2Lj3grWqjCn/fJ/Zy+Fr2GfAyAv5OVe+cdndAn2RsFqN6m37KSZbEtnM9SRCT1FUA0IWcojKqFOWpI32qIGvAz0TJDx/dmdkSwBZgpwneV4xfeN81v29aVOw5zLyLgvs+KACp2/OjA X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:40:09.5669 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4042bd03-ecb9-4ab2-ffc0-08df2b9bc2b2 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000847D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BR0PR08MB728685 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D16