From: no-reply@sashiko.virtuozzo.com
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/mm/shrinker: allocate shrinker_info_unit from a dedicated kmem_cache
Date: Tue, 20 Oct 2026 15:15:47 +0000 [thread overview]
Message-ID: <010701a159e20580-03d3bc13-f31d-4b66-98f2-33cbe087d8d8-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261020-b4-prep-khorenko-vstor-144714-shrinkers-kmem_cache-v1-1-4bdb03031132@virtuozzo.com>
> shrinker_info_unit holds BITS_PER_LONG atomic_long_t of deferred work plus
> a one-word bitmap, 520 bytes on 64-bit. kzalloc_node() takes it from
> kmalloc-1k, so almost half of every unit is padding.
>
> Allocate the units from a cache of their own, sized to the unit. The
> cache is not cache-line aligned: the counters of a unit already share
> cache lines between shrinkers, and aligning the unit would only keep
> neighbouring units off each other's boundary line, at the cost of part of
> the saving.
>
> Link: https://lore.kernel.org/20261019-vstor-144715-shrinker_info_unit-kmem_cache-v3-1-0fb061e09bf4@virtuozzo.com
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Reviewed-by: Harry Yoo (Meta) <harry@kernel.org>
> [ ... ]
> https://virtuozzo.atlassian.net/browse/VSTOR-144714
>
> Feature: mm/shrinker: sparse per-memcg shrinker units
> Assisted-by: LLM
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261020-b4-prep-khorenko-vstor-144714-shrinkers-kmem_cache-v1-1-4bdb03031132@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-20 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 15:12 Konstantin Khorenko
2026-10-20 15:15 ` no-reply [this message]
2026-10-20 15:30 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a159e20580-03d3bc13-f31d-4b66-98f2-33cbe087d8d8-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.