From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a2da249-618f3d18-b8f2-4ac4-91d2-6b74b510bfc0-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023115.outbound.protection.outlook.com [40.107.159.115]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8483C8017D for ; Tue, 20 Oct 2026 16:38:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=idZVzl8e0EshXnoPuksGB6rSRrhLEx/KpXPHVyyxwFmfosLh3vMGmn0GLJRvSBq+IgOmZbH6XtWMIPKc7PDDG844fZ0cU4y1MF5feVHcdBJRnhdG46udls6+XB67yK1X3UGF5oX/Pus8qVwVSLp3wITmuvvGae8soCN/etfH5/wdlS9ngqY2yYQJgJnHdAozY8kzTwA0yuxGIDo5T4EK/pLBi/efJZAcQz5tzMVwxOwDe4guRD1ixWrxnTBmxsHzIuQd5WpLShy+WsIHDv89ve8wvtV8otLdB6M6bPJt69rc0UyMgzfRMoaoPbKmHAr5qmOggIRTvBiY+JNP9iRdfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X5BmfRw5Mxq6lBiZicYzyXfNgVzRcrB2zpuSxpXeIVQ=; b=butIkbIee8vPJUpjqfkITK8wq07vTvZG4QR9onRwJO6Hs6boBZCfnZgX2NQbCNgxCWSdsYyGy/YEfK+/+qhLBWqHQi+ccnTf2Go2kL3yqNik+aXDMgaRh6xwsXqD1tFAm15bv207JVkq9PIQi3NU0SmL0CK4trDdjIJ4wpGx/RjE5UFeK0O4U0U51KxtyIXIFzk615zl2d1InV6XWAWzDfRuBRCT+VpxhfTo2c8vUHQC/UwRE6MIo4izvsPCiwEEf+iepYt8mrRXor7MYvUFIUVojeNQJnJcriAV/PIilOzy5U4NianSLTuo7igl4Z/Gef5LR4wcqOWPrkVW9ZnHXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X5BmfRw5Mxq6lBiZicYzyXfNgVzRcrB2zpuSxpXeIVQ=; b=nt+sOCt3u/xx87JltQEHteRbPxT+dFaERjsbaA+DlBxuMoY6T8i1tmuF4YynQbzR8DGIPyZqzstNiZ9O1Es+FwSa5hoIhFv8E9RcPmXB3irUyQ5cnFQZKm17pR9afi1jdOYybTQvU+AcwpOXzfrqBS8AEv7bEdDunh8b7883bpc= Received: from AS4P189CA0037.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::8) by GV1PR08MB8330.eurprd08.prod.outlook.com (2603:10a6:150:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 16:38:23 +0000 Received: from AM7PEPF00000051.EURPRD83.prod.outlook.com (2603:10a6:20b:5dd:cafe::5e) by AS4P189CA0037.outlook.office365.com (2603:10a6:20b:5dd::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:38:23 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AM7PEPF00000051.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.0 via Frontend Transport; Tue, 20 Oct 2026 16:38:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514302; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=cLuQjnOUniOG8OJNXLBN2XMU0qI5xcQNBlvfI+D6WyI=; b=IfLReZug3pbm4rUbZvx2J+au6Iubwuts8xDEOSjlE6oDTt5JG+A5tEXsNaKkwqAx z8e3nXsaG9/fkAVewA8sz2tJ5DCu4w5cAewmXkTnr74QfYkRxzB9wRSh6Kb/iMNHBkW TyC8P0sanxMq8hbaPxQbiFEeb7SkBH1CNNGOm5EzA+Z5pX7DtQzvLOvf/Zwd05u/7B1 FaAN9iBsxrEcY3bkM6A3+0FrDsCdkdpSEZQv4dWvtrf3Lmngt0H7xmpuIXxhyv4AxZ4 1vewddtAqvyqcIj0Fmcln+V3JDE1THKQQ8aGvq55+l5zo+LZoNsQMrhqeHnKBSAO6X0 sRLk4jCkcg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514302; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=cLuQjnOUniOG8OJNXLBN2XMU0qI5xcQNBlvfI+D6WyI=; b=Mi6RXjBryPBfPn/pCvM5RrA6iijS2Jd6IVnKoE0g389mG9YHjDhVnWLKhb9aXKqN LRz9cmz7v3u0Qbh0jguaD66Yqjn2S0gy155zWxhzmePFyYcv2lvE/biGee42kd+BqRE GbudbZ1uHzBzrD61+Vdy6nbhAygB4h/y/g8g4FCg= Message-ID: <010701a15a2da249-618f3d18-b8f2-4ac4-91d2-6b74b510bfc0-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 06/31] migration: Plug memory leaks after migrate_set_error() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261020-vfio_v1-v4-6-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-6-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:38:22 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PEPF00000051:EE_|GV1PR08MB8330:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6b056ebd-eed1-47bf-1e3e-08df2ec88e87 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|61400799027|48200799018|9140799003|376014|55112099003|5113699003|4113699003|18002099003|22082099003|10067099003|16102099003|13003099007|4143699003|261009223027099003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d1pYSnNuSkxyc0FpbHpjQm5xOWs1cmptSlpQc0N2SXFxRHo2V0ZvWWd5QlQ1?= =?utf-8?B?Z0I1OGZnQnNwd3l2UzBPZzhUV25LZHA5QTlZV1FwUGU0MkIrSWNKUmUwOHFW?= =?utf-8?B?SkJsZU1MMzlqcjJaWTZoTEhBdVRLdDJpUHVBOW5JTVIyV0pZZ0dyN2NzQ2Qr?= =?utf-8?B?TW5qWWVIdGtxSFZ6OC90ZzZyR1dtOWtHOC9Ielp4MGgvV2wyVUt3Q1Nia0xD?= =?utf-8?B?S3VsbmtPMHA4Snk3dHdURk5laldpYmNqNUJUVlNwdHUwbG1DRTEyTTk5S3lQ?= =?utf-8?B?RlNpWjRJNjZkbDhOYWFWeUFJZUtNN1JFR2krYkFmeGxTZVJKbDV5cVB1amJn?= =?utf-8?B?MjRiczFneFVpVGtZNi9WZE1QR2NwR1o2dDRSU3Yya2Qzbk80OTlZNmRvSGRj?= =?utf-8?B?ajRQZjV4UWZpZHBvYkx6OTlhVGZ3eW5IRUpHbTM1eXhYcU14Z1NxUnRZVjF1?= =?utf-8?B?M3cyb0IwelAxM0JXNTlRaU1uc2lQVTZBeUp0L3Q1YnVEYnNZRlphdTVFNzRC?= =?utf-8?B?YkttV0NjZVA3bElRMktHZDZnTXhjMElpZmkxRUsrQ0sxU1VoV3lFaks4dEEr?= =?utf-8?B?ZDgvMTNoajBoQjB5RzRxSlVtY3JtRHZsQS8xOEdVV2ZIemJRWTJsNGtpKytL?= =?utf-8?B?QWZQZ3NQL3JnQXdpZGdIZmhEU1lYTXdiS1VVckR0cTN2UmdiRzFaR1RJSVh4?= =?utf-8?B?cUYwT1MwUy9UVk94R1hhVFpZNFA4TjZESTRIOEU1SHVNUkhvQzg1R3ArOFFM?= =?utf-8?B?djlPbU5kdXVQSWU3SUlYblFpeENUWTdQWUZ6SmFkVEhXYW9XbUxQamdPaTI5?= =?utf-8?B?WkNwNTduT3J1UGRKSys2ZGRTc2dnQmpkcG8yM2ViNk9nOUMxdEh6Y0x5WFVz?= =?utf-8?B?bFg5MnVxMkd4cUdsOXZSbUQ0d2lwdUVCbmw2QjR2SFBNUjM2eTN6T2k4dCtP?= =?utf-8?B?dUE3WW9RVkROd2h2eG1EUUx1ZWozai9iY094bTV1aUNLZzh6aUN6T1VhRFZC?= =?utf-8?B?WjdkdnFJcnY2NFRHQUZXSEpxK00rSHpYd1JPeU50Smhaa3lwY0dSdm5hSXFz?= =?utf-8?B?aStuRVd1ajZGanZYOEh4S1c3aTFqS2ZxKzZBNHdxSnF1MWc4cDF1ZXhKeGdB?= =?utf-8?B?dHhrOU5jNVg0TjZBVUNucExjUFdVdlkvMEE1WmdNcHo0b1B6VXhDQmFlRkRl?= =?utf-8?B?Y08xNGVpWWp3eUNPNFlCNWZMK25HT0tRemtqZ1FqQ0FxNnI1c2ZoQkh4dHZG?= =?utf-8?B?aURTWk8vZzdLRC9sdFhVMzczL3BxNVNUSFlPRmJ5c1VWZmtScnVpZm96U0lw?= =?utf-8?Q?d/aygc8FPwJug1ToMecOXf+bzq9wtUjOyD?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(61400799027)(48200799018)(9140799003)(376014)(55112099003)(5113699003)(4113699003)(18002099003)(22082099003)(10067099003)(16102099003)(13003099007)(4143699003)(261009223027099003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VC85qHJuUdMkkLZz89+CW/CQrRHYSBJSl2AoROCUNrbRXeoJKqaY64rLXFdWP5BKPJEuu6i+tNjTsaAb5NSEixF65vHrmiZuLNiQwwnmKWcAlNERzW+DdeBZbCIy4ssPsnhjNitkWVOq0Wtt7fg0UomBSB8xRg4W7Ai+umBL6IPA92nSaJJLpfXzLjeYgXaCFqzrwJ7sEKSgRNeBitb/i0ww95KLJT8bZe/FhB+Q3FNIH3eCPtunAexWeLhiq7W8GYCVZhr2KgGCbQgrih7wui8lxfMMCJapfU8cnQSsWSzH/DlotrQMdd79N7kl6O+YtkD7DuVBm3Awis8j/RwrZRVK53XqYAo2KY/KO6dkaw5r1LvtVKdjwOukQ59+JaEW6brPDbBC+wD3V2NJ5oqZI6BCZDyB/AqS2XxUjujjQF7gYygEr0UjOz2EjlDr4pa+ X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:38:22.8904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b056ebd-eed1-47bf-1e3e-08df2ec88e87 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM7PEPF00000051.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8330 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D6