From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020105.outbound.protection.outlook.com [52.101.69.105]) by lore.virtuozzo.com (Postfix) with ESMTPS id 148A2802A5 for ; Tue, 20 Oct 2026 16:38:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BfrBLj7saLOz2dtKIa1C3MmwUaOp0LVjtSoJFduKXSHdm40TRAo5CJP12rE22Rijga5z1zNCVSWYwpsKaXO8KEgG7gHprdO4AWy040wQLyZrLZV9T3UmXXdoqIPGE0hJTGFIwzJaNwZclaLkTktRZUJRI+EBsr8/CuLJ4ak0NFIT3i+WPkw7nMqyL/UvEujUzLml+vKXQYcpjotRCvws8UGOovq7vU7MwTl5HsWFD2QlnW6A3xkyz+QjUf5YNKaNNGD3txW+dlrsz0/lpYf5T+NzDIN7bE7lZm34syC4BBvkSlNSNfXZ2RUK0qnaj46aa1UfTYDRyyqBeqmvU9l5qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GnqEvF99PcZtlDU5hfkHHCw/q2XZyL+pO65CkjtK4HU=; b=kdSGl5eILnYe5w2VQeSXnwVhqLeedLJV8sLmktIOIiMk//oOu5piQ1frIJRFGyQQ0UbCxucDqRrxtOEwdIo9hIMKzCOLMknbBFeEYlIUfDIq8Gh1J171AQ5Ha7RtfD4R/Gj4mJLkQN1tqXMJoDB08kCQ0I13L7MSeyC8jSgt0Sa7t2Tm787OPqKe8Yubzv4UQ8k2lt+R9M9/jITY9wW7c+iVnBSRE20j2LCALuN1oSc2d4ciZiQJbNxZUiatMdrfTUC/aXD79NudjDbQLEasa8w/bJpWx1XXUa0kRwwsdExRDMurOx+t7w4cbw5fHJywQ9GDHZqHdQkzUxfoXkSKCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GnqEvF99PcZtlDU5hfkHHCw/q2XZyL+pO65CkjtK4HU=; b=m0TMi+fkjCdYKo9zA1OHTqVSCMWZyqy5DhmLrAK/3ZsA7wg/lgpH82QfpqgazM5Lda0ZlqGSDOc7Eq6ZmHt8kM+5iYDZ1uA2FYp2LVfQmVcLUXHrjWgeGFaf9sJYI+gWyU9G2wmShuAku9uLwPwQIxaiDVEioFmhlcZb9EZSsF0= Received: from AS9P251CA0017.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::22) by GV1PR08MB10718.eurprd08.prod.outlook.com (2603:10a6:150:15d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 16:38:48 +0000 Received: from AM2PEPF00070CF4.eurprd02.prod.outlook.com (2603:10a6:20b:50f:cafe::ad) by AS9P251CA0017.outlook.office365.com (2603:10a6:20b:50f::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:38:48 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AM2PEPF00070CF4.mail.protection.outlook.com (10.167.242.6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:38:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514328; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=poTxz0q/BrMiMuaVlOLXffdTgPrdGU1WpDVLEx/5aTg=; b=dbka1Jp92Ssj3DCsuk8pdIR4fCrVB5qHJ77LNhD1zSqqTkOKAKOPjucDu0t0K/Cf WcITsRqY3IFJ02ELJtGYoQgrlYo39QfaED5dAXTW8xGBLwDkazr9z9ppipf8oxoi6JB 6tAg45CwLvJq5PdpfN/BbiQtAUQkE1vDeRnQ8bRSaNXW/9oA45/c5kULg3KafSFlQcz ru/uvUEAYz196sQtrPffGEDXGE38r+KVa8YgT3RbcRhfLKjOAOre58JlR0T3emQjZcJ nb2lyj+lNSDjLMtCl7gYZ10VUSjK7voT235a80rHRifEvOQQ1t+BN2Q01TR7Q6PCLOZ sW0HXY4DGQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514328; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=poTxz0q/BrMiMuaVlOLXffdTgPrdGU1WpDVLEx/5aTg=; b=D0bzTbNn9hEPJLF4JtDSPoYGEOEJPB+It6d8u4PRO0Yagsfj204lJJIA21BWpSX7 4R35sOPTKYk2e0QDzUr4ZNWDU/BwGGfvavtEWev1iKlLzTDzCSwPjTdOrYCKgvBslLu CGc/c7RckCW7Y5sAJHucNIyLz99fz7SCmo/JkiUQ= Message-ID: <010701a15a2e066b-89aada30-1ec9-49bb-b6fa-322fa512a62f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 07/31] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261020-vfio_v1-v4-7-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-7-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:38:48 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF00070CF4:EE_|GV1PR08MB10718:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7deba9e2-127d-457e-6389-08df2ec89dd6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|61400799027|48200799018|376014|5063699009|56012099006|261009223027099003|260925021911599003|260925021311599003|260925022911599003|4143699003|10067099003|16102099003|18002099003|22082099003|55112099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: QUy4YT0InJd5RwWwuxnb2ptYSoK98egIc5b60WZcs9o9/gjKKAixeC6yHbqbQLjpDWzLEACbTBeRSPiOD/+1dKLBWZtZ89F4MnNm/dNBnYG0nHZs5JA4Zh1BYMo3rU/R7QHmtIQxJXxquSgP36HrkcE3oGPyRf5gVSXby7oqyZhes7Yt79OyHrH0ZNJ2x7mlMlPemvQEK6tR3/O+JjqbmLsq21bJCnJhCOkCeYZ/r1X5y6eG0Rllyxcm24NK6Z2BFeOvYiRwMBuEDfPQ+Ksq9ub70TCwPtpsVnijk5zWgCCfklfqFJCqxvnfJaJsRpeuSTiTzQx3VIgR8wPo6FBZSyh3PoX9QIa322fNYNVVllmxRBrpSmJAuRuPUbYE98vCPhfapgs8kpM8/ME0tJyIjERqt4E/ye4CktT0Y0jDwvSIf7z3qisSiMpvnAg6yJx8PHQYx/t9spV4HUw2LRUE/UWJ8PCxlhTy82sCJ8zFvnEpRAuWmKFnnaVB7ENIOJ4fn1RhW+R6Sp6/gYY7g0ESyzKcnfEanTlKvmhKMqpCyNUmR4slly+zGysh9LFhH7zFlnSClPTBQrXQmDzItoCdY5LdeE5SoFu8mSDMOEVJEpEqeU9ifVeM1hFHgZcbw3kz2akcV1TPvtGy4HjP1UujVhshjdW9K6rH6xW0Y4zrZTQXnH3dV88lmqGQQ9+uQtMVSmG4s4vRJOmuqJxsFGc3xGcg01Orh7nOicDHycXYGT9PtcYlHmZAGcKhpCZpfpfu0gtVLY3dM9iGW5dkLE1OWl24XiL3FhjuY6yLfK80aOdnvTSrzvbWXJj6WXtRRwQ1qjQAGporhDqOF9S83nNLHhM3Ki8oHF9DXbT4l52bJj26A9kk0IkaB9HviaEiHYHQl/ZCv0ZK3BuJICbnoxWlDXWVjcWSWnKGtqjWoNuq3EE= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(61400799027)(48200799018)(376014)(5063699009)(56012099006)(261009223027099003)(260925021911599003)(260925021311599003)(260925022911599003)(4143699003)(10067099003)(16102099003)(18002099003)(22082099003)(55112099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YCx/Rk487OjTv4O8bRjGGxkPHO0QYX/tf+eZ0ksQXdqicU9gIL85HsqpPxB0UtjJ4hCFmAbcuZ3vIKZnXiD29+CLSpWARzzmZMD+1hzg2gQ5qxAHZog5A+menPEBKo8Ow1+bH4P0p1TRp58sImiYF/FXGjqgOfRmF9Ak4jc/Rh31CmkZu69cTX8jgpqkR3lwpcjoSIcocNgIrqNc1pvlTgak2vtFY4kmVi9jZX3Vpq99kOQe9beRot+G1Ubmw4rLw07luZOiWfih/wruZuTQ70eqAQ/loecallnZ531IImAOyZTLr2lR1F5rL9HlxQeKpoAJ65sAa8Npd2v9KRgsna8qP00Fu6Aa89YRVcnOJzJVTUALzw44/QT84dpZaAMxxO3W9Imgwk03kSCn2eRG8JRnK5VhXW7GJv8Gjou4zWg+E3OBrLRH5qhRKoU+A8v8 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:38:48.5662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7deba9e2-127d-457e-6389-08df2ec89dd6 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF00070CF4.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10718 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D7