From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a2e93d3-b6f26cbe-c84e-4bbe-a537-6a2065805338-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023095.outbound.protection.outlook.com [52.101.83.95]) by lore.virtuozzo.com (Postfix) with ESMTPS id D801A8045D for ; Tue, 20 Oct 2026 16:39:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EtmGzy8R5XvPDbmx59KStx1BYb/Jw56hYgFa3fSzLcbWJETnw0+T9eIcAOI/TWGGGyLGDLDpZqZDd47KeGcT/VoSVsEyK09gTtzhDyMvJc0+4YjMLO4T/R32HAFe7XkYinbX4PIlqzdFXgZV+LN+aaIJFbtOJd/WcHRe23k62oFKOOrbRVqHaCAwjkVcQyDzBU0dZi8DDxI8IPW5wbOk0NI8WajZgDiJ/E0rBR7uqG44sIPmIGwRvPjqM9zJnc+Ui6d1V1c8zqrqAVjSICxPRhimk/N0zOKv3lEA5o4heD8hFay+poCi6aFdHvIOV6dSZ8yuzMMcPHPreQhHu4iXWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tTpAmFakHsu1IUwY+lLs4yzAeneluubXa4GQC5L7yFU=; b=LbJBato3g3mGZ4XGhdzlYeGVpCbxxvXk0mDOl1GCUlR0ADDjNaheENjHt6MRd1CRuEGW4GNs34hUNQTKBZCXPRw6ot2mVI5/8YOlJc5ImV4yTUyiUTsdh4Ladm5OlykBKkiemSv/QrM2qf5O2wIcliMjbI5fcyVhXFUdDkNYexPUYr9PFtrmwmwYq2HeCIJ6CTyH5+m2gRC/XS3MT13s8M/2T+aNsOyQUl/mL8zHK9RHs2Q4VKbZsSTPqUqPdx2M4d4mEkbsQaVhURXPpYnEOlqihjgjjb5U9G8uYPynL5fFYF0phly2dw1HTLpP68Cy3/KNYJLGDYcEZh96fTzUUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tTpAmFakHsu1IUwY+lLs4yzAeneluubXa4GQC5L7yFU=; b=WZ50jk58F7rEMJuZ7fYz57KzDUvfcXcxWHwmnsPbGh1pQG/gMVNpID3oqYLuJYDwK9GzoCHkgiTrnuSUPbvz1UqVUVBeTKq95HkQhZcqeeItGGNXRaX10WRZdx4V9dAsaVY9z3UJ61xNFy9cYjQZNG1VPNOph3FmslKcg9WCfHg= Received: from PAZP264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:122::8) by GV2PR08MB11396.eurprd08.prod.outlook.com (2603:10a6:150:2c9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 20 Oct 2026 16:39:25 +0000 Received: from ZR1PEPF0000E464.eurprd04.prod.outlook.com (2603:10a6:102:122:cafe::15) by PAZP264CA0021.outlook.office365.com (2603:10a6:102:122::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:39:24 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by ZR1PEPF0000E464.mail.protection.outlook.com (10.167.241.57) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:39:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514364; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=sx4nlVV43GEZyCK7+DOQdLhkZP9ufeg+7JEkLeKKJkA=; b=d7QImKv3NeGi84WsPJKVQGgj4ZfyFhZXaEzAa5a0nKglngnGF32iQHTxrRg1stxe V9GuX8oR0gtmXOs7fqicBVpcUBLYPLt+bpmyxGyYPP5aXWF6gXR2iWmx7NhX2K7SsXX qgBSPEUr/dIlBzTKP4LNGh+QMC0D2op10rPe4GQFyKixppa3FvIES2P+jfQhzNNsHpW wLalbkdhdCCP8qMfTTjUoylQdQmCBs9lg2tRW3Oc9N8nijzeerDy0FU12xlfBjghqZk QLlZukrLNLVlEz0uqTtyfva7cvVCxWp/6Dzs0gAuzvpk/Dl7fVtCBVBa71ZYFcwBz82 jgV2zsRcog== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514364; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=sx4nlVV43GEZyCK7+DOQdLhkZP9ufeg+7JEkLeKKJkA=; b=LLvAbfB0RzSqzq9k5KGR5UIeOCckj+xtad1PhQLgTR+SrsDVITJdcu8cyrClK5GQ iV83qHuFilbCrP8AA8CdFsHvMzdHGf7a/3lB7aHhFPiNesmc54WcXnnDk2JZjn03LX+ HbbRucYlVgDUwgbVthdzj1kPX+vL6itQe9Ob8DNo= Message-ID: <010701a15a2e93d3-b6f26cbe-c84e-4bbe-a537-6a2065805338-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 09/31] vfio/pci: Fix information leak in vfio_rom_read() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261020-vfio_v1-v4-9-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-9-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:39:24 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E464:EE_|GV2PR08MB11396:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e82ddf57-5856-48dd-04b5-08df2ec8b363 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|9140799003|32142699015|376014|48200799018|61400799027|6133799003|4113699003|5113699003|18002099003|16102099003|22082099003|10067099003|55112099003|13003099007|4143699003|261009223027099003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VzVOZlMzR1hnVDlNQ2s4cmhLdnl0VTBIMk9iS1p2SzNiVURIV1BpUE5DNjlj?= =?utf-8?B?R2dOWWZ6c1ljeG5xUndLNzNPeDhFNWtKZmY2N0IyeThCNUkwZlhoMGVuSzc5?= =?utf-8?B?dTk4VmxCRi8xV1lZZzhRYzZpdU1oYk9nUk5EdEtXWVczRnFkT2I3dW5Nc1I0?= =?utf-8?B?Qy93WjRpcnBVSkVsVVo3OHBIbzRBenY2aXRuT3ZLa1NnZXZpT1hYeElhdHRR?= =?utf-8?B?R0E1RVUyMERKQzRxdzRkNzhkT2ZZdmhLQzNkWlAydFBjLzArZTZaNEJwM2o2?= =?utf-8?B?WE85S0lYNm56aytOcDRXcitCdUpFbEg1Yk1PajFyT053K2o0YkZwN0NLWXBY?= =?utf-8?B?ajFvRDZJOVVUbVBKSEZnL3FBMmIra0JmaDBHM1ZYU1BnQjI3V0ovUkVWVTFx?= =?utf-8?B?cUlGeVBWendVUUJFVEdBbkhuemZoWmdOejBpVjR1VThXTmlxeERFWUJNVU5D?= =?utf-8?B?TEJTWHh3NkZTeTZRVVJQNnR0Nmw2NDlwa3k3eHlVMDllNHZZUjltMjN3M1g4?= =?utf-8?B?RkFQK2N1T2ErVHRuNkx1ZFdlYlZxbWlHbXVFVDNZNGFySDlQUVlkRkZ6SDRV?= =?utf-8?B?UHoyS2pSYng0bitnRkowRTRnRmd3WGdyRnVHK2dtSnFVbjRiWTFCUGNMMytv?= =?utf-8?B?Tm1WTWZQUmlSK05NakRWMk41NDBCU285RW9iZFEwZEJRT1VBTnoydG9VMmJi?= =?utf-8?B?S1JKbWx1T3Q5MitWaFVzRytScHE3bzZpVG5YRVRYRzMrRUFxODllYmRqcmln?= =?utf-8?B?b3dYUFhUbUYwMmNQREJHUGNQdFJtWUVvLytEMlBydVNpQmZHYWZDbSsrUlpQ?= =?utf-8?B?ZTVNM25IUERDQWJXbG1yM0o3c1diM0hFWlhWMzJrdTY0Q0J1QXVJRWEvTkIy?= =?utf-8?B?UytZRzY2Nm9ZYlBiWExFZE5QZDlGcEJBbmJ3ZXVFWmRyL2dvdlJRb0NQZjZQ?= =?utf-8?B?TFNLYWRxelR6YWpaQWxGUkE5VUY0SDd1TmVrYmZTeFpJSTM3Wkt6OUV6Z2p1?= =?utf-8?B?SFpCUzNBYWp2RzlmdU84OFJRVkV1NXdRanJMUXdjTkUrQXVlMmpUQXJqcEVm?= =?utf-8?B?VUpPSjhBL2VyRTRVTGdqU0l2V1Y4Q2RqK3JLQXNPMG52NjhmS09zZXcxTXA3?= =?utf-8?B?aUo2SHFGMU00MXQ5RFJsNS9YSVFjR3dEZDlOc1E3OURTOXJNb3lETWpKak9P?= =?utf-8?B?TU93aTBpVkYwZkJXanErYzhYaHV6djRGL2RMbVF1LzdINEw1NjNBTW9ScmRj?= =?utf-8?B?QmYxditMdExuOUdoYnFpK08vV3RYYlZXU3lTWFF3dDcwNEM1TVNwdW9maG1m?= =?utf-8?Q?Ulsx6SyuRD3LU=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(9140799003)(32142699015)(376014)(48200799018)(61400799027)(6133799003)(4113699003)(5113699003)(18002099003)(16102099003)(22082099003)(10067099003)(55112099003)(13003099007)(4143699003)(261009223027099003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Uk8a1g0CCzDHhTJDOEmWSi+c4YTe8RgoeMPz7MlEVkNtdF3DKKUeKUzcmE676UbtUv4ZizgnlrHGLqJi77spRinEr1h1B7UnIxw0tmrcn9gCtrLNUUEdAFQbLrz5L7RiKDAV1oj/gr2d8R9jBYfthMGtknG9cXAJ/ztPtb7UNqnRi1J8XAXrObAYm1oMGoBFbMUrUeIRUfw3/+NG7B7yEWKie/b5YuWPxBTY0XkmSuWlnsVrNtImY9T5YpiM7GHa9yaBXZLZJpJyUWmwDq38ZlXYd4isnDpcWrMEUFFCQSg99ohL10cbJVKdpTeejFrFcXGclSNXcJN/r+oEAFU9PZ9G254yb+V4UmSSZ7nB58GryxPnb7neMqj0MaeNirv3OSuADzF3GIB1HQvx5AqolBG2zWlXesnoZC7elaU4gadyJX5VL4UgT0Wcw+l9wXKn X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:39:24.7299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e82ddf57-5856-48dd-04b5-08df2ec8b363 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E464.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB11396 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D9