From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023086.outbound.protection.outlook.com [52.101.83.86]) by lore.virtuozzo.com (Postfix) with ESMTPS id B25F2802A5 for ; Tue, 20 Oct 2026 16:40:09 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p3x3T0gAd52vlMK8CoXNRLFoHCseQWkRIZPL60A9SWiQAWKNrfy0I3aU4kDDA45fk3kFPHCJDV8ba3TltFL6ketA0fm5cZxD7KogLTwKpXyJzBQx/mLJlLjogwAV3VfFgQiq21Cyjp/oNPbe8IsMXAmD3cG6E83pyORNJGzJ25Dr+EdZvEhQULH4nKhQ6FZXG3yUvGx+Yf3piWljbbFQiIq7VkjUu8UfJjL7SmS2I/wwpb+KkcZiCkMrhm/LbyfnV7iAdxGmR9iyuGyCsiwjc/HLgIjEUxeJckBqU8BC6ZZ0Bv9RGCvKBCgko0ci6t4w+dW/nHuV9m1CtSreXkyj0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wNtifcMT+zoJ29MW32h7JigV7T6Mo/dKiONp+T2ottI=; b=fGPAslB62MNy6jfSoh78n0DTYx9Y+mZ7Zuxq2OHlGSiYkN2Jsn1srdxMW0zeqU8SojN0CsUB95vCCY+EXIbxlB5P4slPXOyAmrnBPJv70nKPpDVE57QA5p0y5xcG9KfeFUL3M0l45k4MutU+2KRkAHId0Qot5a+cL2oBvBSvXOvYgwTgKzgVQ2EEzGd665BoA7Mw0Z6dpUhr9pSGJkBl3aY+ZCBUxfL85yyvON0srLg3MqcNypYoW9oEoGt72c/wYiQEE2kkXPZGkfJIjY/A4lRP0ynNLKBRJ761a0b3iCyZFLAPsdPdhw6acWeFtF6ifHa/cm+sN1fkRomgMGDEMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wNtifcMT+zoJ29MW32h7JigV7T6Mo/dKiONp+T2ottI=; b=MGiI5TsWCb5i7dDKr/7kwAWccJRnU1dGSNlDkcJ+pZXcZ3HBmj+8OR/By7SCRWnj24Qi8rN2jms0/6w6MjJwLDnnewrw5qMrp6fE2jyeLCSXLDp1njfvcD//1mQJNA69aTOX3NrPVjoCmZ4pheo1qgqijYz5NEyNdfDsltZyK+Y= Received: from AS4P189CA0035.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::14) by BESPR08MB999919.eurprd08.prod.outlook.com (2603:10a6:b10:147::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 16:40:06 +0000 Received: from DB1PEPF000509F7.eurprd02.prod.outlook.com (2603:10a6:20b:5dd:cafe::a3) by AS4P189CA0035.outlook.office365.com (2603:10a6:20b:5dd::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.19 via Frontend Transport; Tue, 20 Oct 2026 16:40:06 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509F7.mail.protection.outlook.com (10.167.242.153) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:40:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514405; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=iTuGX7bK7vUa33raWxeMAIvIf78GFFP2riN++TKB6m4=; b=x8vHbtTMCYP8xdpCY/L37ODebCrJMtfQJ5WgvIGoaL2eoG72tpneOGPbr3vxc9+6 9wb3cNGSFMmD9XhNxzKGt5JYhmeoHzxmkiuAYMwBRyo60tZ1rc2RGRaq83mypW98k3W /li2zoy35/iuFbjvlm9DBfSCHUqkUloviYYKomNffbtJOWRKEqxmO6jyDKBq1CnObBY 2qo5s7Ujy6EMww0/wJ4S4IgcdWHawqDgj1WW8tghjr6T927DtLonR6KFzTqOD5TZ2zu oMfOS0Qp9CQaZae4xFwDd9j8/f6ZeJB21+r7YBo4FdCL3FbsZ63dy9SHOOKK06SIbDa I4uqmyIyng== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514405; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=iTuGX7bK7vUa33raWxeMAIvIf78GFFP2riN++TKB6m4=; b=QsRO7YANNM+blP6fW8XvrAEBeltPBuyA+e4CyEgqDh/L9sdQWitHag2YHItAm/wt Su7luyDkEqfa05fgeKmAik2/vej5ZqeCvRpobuemnEEFbwsefW+u2P1s8Oy/pV+OxKB qjGPntmmd90Whj0slmYtzbaviPUlGNB8UrUBoF48= Message-ID: <010701a15a2f34f2-450826e7-a88b-461a-8a79-6bebd931f184-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 10/31] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261020-vfio_v1-v4-10-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-10-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:40:05 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509F7:EE_|BESPR08MB999919:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 41fd8cca-a4f4-4e77-cefc-08df2ec8cc10 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|61400799027|376014|32142699015|48200799018|5063699009|56012099006|4143699003|261009223027099003|10067099003|18002099003|22082099003|16102099003|55112099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: reanigsdk4YNVb2fFf86ADAb9EvOZ2u/bxSg7oHntCy1QpOITM11QS5JVdIlb/8G6mGJ1zqk8WKzosNrU7IbAlr8BhtVO7DTTkKVQMdFt3RhRyR/gUhi98VP8e4sK8IZh5SnTQeHJ+Tt9/iStu6W+nTZdp/6Cu7O0iYRaLKTisN4xctzNrGah8TFFCPNvdoh+wZNBI20VD6Fs9ubOzF3YWncY3HBnrILdqM2leUf59LbumG2HzE2exX371gafjlCVH4e/4bR/0IFhDQgiHblpwMXKHS7uxcf85fwAknLnumhFUH65n8XoR+I9ARMtzu8qOrUprd2ZIExU9nRC6z8CDiZ8ix8D/bxIB5Xhadhnb88ed0QFLE/4EmXrIsy7MPsImI8Q/UzOzfhdkxTmZq9QZenIZPJ3Vrf6IqWW185UFEC/CxhWr68mtFJj5es4izSjC1UeP9iKNCUNQUu3vyzVubQxIc90xyDhZiaLCrXqmPqWVi3620GLdWzcS7oWv8x55PqixvOD5jV6bzoFAFauVWJsdfnqOLUzZXBTEob5WAfTYOcahMpUNYq3fYD6q+k6nVrD2m/uUKb8cqVmZLSE30RCCMwK6kgS79w5gi4QJFp52yJGpoe/a5r0KBf5MV16tuDmw4sjCciFI8uL/+sawRwrq/lsVXrmZzYUzJBMIAYBhGQYadMhZc3NsaV73Fxd3/q1On/CI7zsWjU9jAzHNKAN4u88FJp8S9DSQAnvKvqY72tLeaNbtjFFLd1ddAJsYgKZutd7JCe79UMFyE66ctAsnTL1pBMstvU2m/fHA/y8b3WZvzYy2ZSk7wXFZGut4/xdAIRmzO5OPU/rq/G2hWyQzGi4IvuWq1d8hjG5vpLvVZQP+dn2Z/3vC/mS3WI X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(61400799027)(376014)(32142699015)(48200799018)(5063699009)(56012099006)(4143699003)(261009223027099003)(10067099003)(18002099003)(22082099003)(16102099003)(55112099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Wos0k5rLZFuJaWESbcI1uzhjjUNth+kuNAQPvTvRZ5aeZN3TxkuE/iWIIvTdmimxHVRt9yHJJf5yfssLrrvvHutUpREQ1O7DRoQKJ6nE9+G9ayTJgSO96EBQkzoIrNZ6MYgJumPoBH2hKP9YAmVT3RMnFW1ToYeYw40k4bLCtNOIwIyHYA+pC02mI3Nq25ofPC9RqcituiN5e80xAWWgnHOVnUlJRkMRCLm2HO3k+6qGLqm4tjOmIjgmjzG9rEZAhWqr28lnvAgSuHT4AA07MbHEwrhEi4Dv6bRRlvCu4b3tZ8SejNWEFIom/AzwVWt32WZpUN9mhY9FasB3prnxadX7I3hDVAberPzLZ6612NCfNNrkcnjBXUOFhA1WA8ai5/zneG2o48c4tWYD7w3C6GsqFmFwihc+cR7YE+Iyua5RvpOCL3yuM0L3Kf1tUpgu X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:40:06.0927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41fd8cca-a4f4-4e77-cefc-08df2ec8cc10 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F7.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BESPR08MB999919 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D10