From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a325d34-be6753fc-9e51-4bc1-9b35-c864e1c89cdc-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023123.outbound.protection.outlook.com [52.101.83.123]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8281F802A5 for ; Tue, 20 Oct 2026 16:43:36 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sfS3LbczGx+hzlnRHHv0G/imGve1y8Xhbq/Uj+dl5zvFMENizaSS0q9pekI8gUl26aWQDdSNm+ESGOF8LaP3TBYwwhbMJw2doe1ddiiNxatI7ONT40ytjjTbER6XY0mniNESmQRomsSlTDfdCmvHBGPYN4Pp2Fm2mZxv7r8TQcRl35Y5K5Ut+le6Whj8Ve5Mhu+ANf1pi/pFIwCD16RwUUOwA+60vPe94Tht5RUxhlAWXp1yzqvmtkE+h1mM/ddeTYIHxdwPxVBgYtXQ2+zCsadF2hJCe9SsmZbJkNzbrFJGSUc/oIsV5vAajpd+z5SjKf57Xr5wrCVnTdkOBU5P7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tEAqi0NQItHGZKC7fTlIibV/qd25gOr3bJX1l2I9eIo=; b=plm6yWnqcBXaxCbk/+WnP6RDDudOE3nCiJHZxQdYHnHpD6+uQVq+/z9R7sdHqR2grFZHeaQuZHJf5z7gFS2XN9FjqGRAPhK3NoZH5n7PHfdvXF8p99Kr/pkOHtw6q3RwUViKL/7dh1BipRbHe/wZVzmrqrB17PFt8YVmiQykrvs6INO9L+SuAg9v1xmLkMZLap9V2VC9eo2Q9Q3FKSFLj0WFjj/fQVrUFmaLwBaEYvI4AgOD0l3YJkstK8WSX5Tm4HVAv610gl7JYPHxcocAunORbFXJ7giNKltLkgbBQxiyEmEijNlHh9Pq+HR8vLauxxwVSFpcc0A6MEaaiZ453w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEAqi0NQItHGZKC7fTlIibV/qd25gOr3bJX1l2I9eIo=; b=cBnpYksNngV8gzL6H2DyUtuUH+SZJ62ISH5IskwLsnZM2p2gsK7fzYfyEiGN4F5njaNGt1IEoTY9HWemIFx4QmgVPdBpADQIzG8HEtHdYcGMj2D65nOc6+D7swOVAjSKsoWLsGwr6Vn7Yv6gV9tIbmb1CyATC3V7F4BmjMyy+2k= Received: from VI1PR0202CA0026.eurprd02.prod.outlook.com (2603:10a6:803:14::39) by AM8PR08MB6546.eurprd08.prod.outlook.com (2603:10a6:20b:355::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 20 Oct 2026 16:43:33 +0000 Received: from MI3PEPF00008482.eurprd02.prod.outlook.com (2603:10a6:803:14:cafe::17) by VI1PR0202CA0026.outlook.office365.com (2603:10a6:803:14::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:43:33 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MI3PEPF00008482.mail.protection.outlook.com (10.167.240.169) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:43:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514612; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=iXinYLkVHaVtiasfEkS3eGXtTkWRdcdAkKqxz4hTYoY=; b=zaMv5yEkJUhPjWW1eIxQu+5FslklYd9m9wHhnlW8dZd5NbctXDJD17xh6pl1bGDQ KjrouPUwjAP/PbVhjXkFOSM1QEHWEHYCnZDLOYRA8IHSzev/f8MNspVFemhEZ0ZgneJ UN0nlmJwNlH5Fpg18XRocKctrfYRCl/1slTWArn6KaLiC6aVQltQGTB4UXQLDsB40G7 qGS2bQ8XjJDCjI8EyOo3MlSC5XFJW5q749DXycVEvkb0PI8Kt7VymmD0lU6b1hNiWtu 2okjRbYLR1nfaHQhQ+IKl3U0cBguAWCfsIsPT0RToDHOtHdrwNjIRf6jYbZUKJBy5+Q fDt5lFLFAg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514612; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=iXinYLkVHaVtiasfEkS3eGXtTkWRdcdAkKqxz4hTYoY=; b=Py7kTznoryzlUsx2Qwki7mC+Tz7jAvsn17LA9IVuw1wXVFN5p9p/epF96T/aOSZj 2edYKpeLzU/CAmhTes1i/O44+dZZFVAP8JiwHRkMcrXez3eIvjpi+N4XtR/8aMq5QR6 L9bNupDH7M1sunRrn2M136lKO1WLjkNZzgT9etqs= Message-ID: <010701a15a325d34-be6753fc-9e51-4bc1-9b35-c864e1c89cdc-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 14/31] migration: Fix regression of passing error_fatal into vmstate_load_state() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261020-vfio_v1-v4-14-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-14-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:43:32 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008482:EE_|AM8PR08MB6546:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 48f3ea9d-a309-48a6-9c60-08df2ec94753 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|9140799003|61400799027|32142699015|6133799003|5113699003|4113699003|55112099003|22082099003|18002099003|10067099003|16102099003|13003099007|4143699003|261009223027099003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: X/Ya3ypxj2xv6FsPsWMJAoIuWadM5ShSx8Zgyxss6lSLMqbG9zqNFuGgV3oNs88YMu9xkH4AVPOlcmubL1ni9MTu7o/WJKtOrX3wVq4/LtoGF/zgKFiQtLATyp0NJ5D84l4OKl20Sv4Emn68BSkJoUxSZQmqWzUmk8k+tfVOstjaCivef80KS+TmvDeUiZpdCcPgTfKU4t1BaPL83LqOJPylnfkH4OJTd0yIS8oDH7Ae0/Ui1hxkkl2gFTk8dxSMVtPvKUKcL2rPjCLX/sFkmPJncbVIfmNmJkmtZIenUgUCUEnlZgSwLQmJz/Hsoi1cWxue+xLRmTMrTnHMryVRF7sRZW31ZBM4cdyaibkxEMlh7bjHwTCJLpFQKQfs9P9ncKll1nqWQRDfzTisGd9QhVDEOYpTl4AkMsLAmYXNfhs5pwVjio0RuDCjAWZa3bOtmWVS09hYvCqzb2sLHL57t0NkeFI9UqX6alnuX4m6FZpG6yQ9UYrOk07HHTtojplSK6mdvUrtEuIT5qHpJLWpLEIpJsL/GMD9Sw0Y6mktQDKGAY7/sxgZEBkLi0HC6y0VDhtsBXyo5CWeb3fPhGdVYRzQ+y2ithe7rjlsayLS7+uVBp9VujpdW3xcMJ4LpxWqCN9DB/hXQOgOMkXuLWiguoRyyMGYMBsOS55QkEa7s7Z1JLUQWL0KzkckbEKZArXYl0KhX35xY6bH2FUMm8MdrXOvvOUKtQY7QGeX9KmI3DV1ZLUO820MnkAaV+/jtHIIhnwh0lsKZzqiBmJ2vREBUUJQCAU1K7/VOalrJ8TUfnqVkkwUf3VuKtqyR9FkuGi82PPdl1Nz+X7i8B3/9TukwdUL1NiZwHSg4v2Nt/n6FM2E8Dm4E5H7nWGyF+12kJjx8oA1XMCIzAMgMl3BaULjXYR5XLxfFE3TXNUo8JtBUbI= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(9140799003)(61400799027)(32142699015)(6133799003)(5113699003)(4113699003)(55112099003)(22082099003)(18002099003)(10067099003)(16102099003)(13003099007)(4143699003)(261009223027099003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: S3rh9WdlQ5cUMJJ6zM0EOUUdOP6OFLej1XKVI0B8tHbQ3hp1MiHBYSdIwIoOZzTvwYglvPMyzjsGXfw/vHRGR9Gveyji3DCz/uj2AeZeqnOzI4sZGUvOqYxyoTy4e2FN8Kl6jD08vLzauiJRXrhZpCFYH/iv0FE4M6l5X3WWMykGScQn893Syb2LTa42yEBLLGwkfuxKj1lW471D6OdweJNN0FosMDsiQdrW/y/2ti4x3ZNoULrOmqBj3MyTucn6h3o5Z2Uowd3H8fd+hYiws/Q2MV3o90jimSiP9zTuciOUDH+suoJNC2EPgUbVY+fRSdOQK29v8cDswRCztd7wy0Y4hy8+5wH0XniZ7bnbAk8Alt3CpZomdo0hTr8KQO/dcZH5eXRHjubc9GBqnf0N4Q6jqxkuqYFzHp+bRjM01SIkJWrug2Swjgos4G0ii7v6 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:43:32.9169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48f3ea9d-a309-48a6-9c60-08df2ec94753 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008482.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6546 > From: Arun Menon >=20 > error_fatal is passed to vmstate_load_state() and vmstate_save_state() > functions. This was introduced in commit c632ffbd74. This would exit(1) > on error, and therefore does not allow to propagate the error back to > the caller. >=20 > To maintain consistency with prior error handling i.e. either propagating > the error to the caller or reporting it, we must set the error within a > local Error object instead of using error_fatal. >=20 > Reviewed-by: Cornelia Huck > Signed-off-by: Arun Menon > Reviewed-by: Akihiko Odaki > Link: https://lore.kernel.org/r/20251028-solve_error_fatal_regression-v2-= 1-dab24c808a28@redhat.com > [peterx: always uninit var ret, per Akihiko] > [peterx: touchups on line ordering, spacings etc.] >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 986c3292c6b8, > adapted for the hci-dev base, which predates the upstream commit > bcb536cabe10 ("error: Kill @error_warn"): virtio_gpu_load() has no > 'err' local there yet, so it is declared here. >=20 > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D14