From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a3596a0-43dddf73-1e8a-4251-9145-8debf209dc6e-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023122.outbound.protection.outlook.com [40.107.162.122]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6A45E8017D for ; Tue, 20 Oct 2026 16:47:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=knpNIJar6yV2OZE+r1aS3FrQheVQkf8q57eogj7p2oWAbsgH6YaX0gDLGU3tcLtEaKYndouGzka62lH2tpVaAoYtmIj5sBX0CSpn2rWmbJc32/sCOpEPOvVejfk4MPs2dGoKdQ7ohNymv/dhX2WuHQxHLzrELT83XN6VhE8KzsM3r3ZYxozV/27rd1bZ5MOnqppRYzxuAJb9eneswfvyJWddYhLIBOzlV5K53v4eA3oXPLeEKvZQLwNIEYdGN9BF5IfPOwdqxqM9ILUt5cv2LfNh5FaZVKUYtdq+2ZF2QlzV9l5G95u02u6I1b/Ugv/zOj1P/2HyvbpPUKvwBDGwLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6grkv3JjrmNMivUioweG2k9fWUc4gBw8suBSkM/NUc=; b=a/biaDpGbllnqCRTmQGBTeS3DlxYmJZEYq/6x/gf4Fd+lwMfePirau8kmOlNEWokGJ2R/hY2HSDxhmUcvUkIrc3p4x3w0Wy4D1TfdQJCIeDmKkWvxad3hElRbPdUhkPdgTN4x8ExdnwqIohHDdB6VjMpj06hKsBmqi9pPcKmSjveI44MqEKmGjD+OcyNvUGIjxGlziugWnzaWOl/oPxNH9JzonuJnUH3fhNNgdRmR4I+tIi16fbPJx8ZOJTcR4hj3h76LbdgCQTurspOsWe2d8jQ2ilXZOWcHO4sPNy6qdvxp0zyvJN5kFbICHboZsk2LdQXN/kDiDZMnaQI7FQuzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6grkv3JjrmNMivUioweG2k9fWUc4gBw8suBSkM/NUc=; b=AJQUdspf3AY0XVWrL7Ana0kU+AoFON73tZcRkQyYDDxJwNiogIqcOvMjFs3lwkaIt6f7KnjGrnzl9xNXelyF4vPcCnWmlH7rEaMbgEkt809MBS5PqCSzPWhkbX7H71yZsmBmg+SkWHn672LHu8If5b3db/5kCn1AF0lhYvBy61E= Received: from PA7P264CA0077.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:349::20) by DU4PR08MB11006.eurprd08.prod.outlook.com (2603:10a6:10:576::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 16:47:04 +0000 Received: from MI3PEPF00008554.eurprd05.prod.outlook.com (2603:10a6:102:349:cafe::51) by PA7P264CA0077.outlook.office365.com (2603:10a6:102:349::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:47:04 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF00008554.mail.protection.outlook.com (10.167.240.8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:47:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514823; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=HqUXFrU+ODG/0/PnMPUORotU3lleP7iVCHMLJr1u6/I=; b=Zad0gwvMTXcf/GaqCe5yKKAZCv7ozcdxHBq9y/ZxnwiirNQqZuw1hgMCpjZ6zy0d M0OZK8gcdWvskHgnmMqPu9QRO0JvmspqJTiTgivI4ec2KrEXDDhviqkRAyivE4QqAyb LbVag6QzQknlUAhQ2CzyJKvQzZ7eyAB94zevM9EEV4SUX0LK5FbQ6nSA0/etgFXVYZr Ng2n5dYJPZIPiwx1Ta3/83YhKZFsgh96mxDUjkHC20yfup8yXxdMSghPRfKI7/Z2Cnk NliJ/u6qbqOAg/HbC0i/SoffL/adNpQUcVW4mVSvrUPTC1cY8E0udRM0XLQSTF/9WNx MllwW0NEKg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514823; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=HqUXFrU+ODG/0/PnMPUORotU3lleP7iVCHMLJr1u6/I=; b=fxOfq17o1Vm/UsAWn9rtnCLrl5m+oItQqvQ4QHTXQ6kZlcZod/metS6Q/LvQnwd7 Z188aOCQd27H1fCmOOIyUSjyqZkY+IBMocOtDbB2sSOi84HpdyVj3VUkWuojTOLpilw PLuNU4BZn7481rdTxqW9fsIgEw/0RO42xTEuK7+c= Message-ID: <010701a15a3596a0-43dddf73-1e8a-4251-9145-8debf209dc6e-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 17/31] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261020-vfio_v1-v4-17-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-17-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:47:03 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008554:EE_|DU4PR08MB11006:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3969cbf2-697b-4cc6-f5d4-08df2ec9c54a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|61400799027|376014|48200799018|9140799003|56012099006|5063699009|4143699003|261009223027099003|55112099003|16102099003|22082099003|18002099003|5113699003|4113699003|10067099003|13003099007; X-Microsoft-Antispam-Message-Info: GU4Ab51L1tPzD9i0q2aZPKHWLFV0lDZBnpaH6NGBu059zobJUHrGgv5/Ym8hTcTEnT1m/TjZAkCa2/PhGpHEGi2/VOJFeIn4BaqMzivCFewIRbHppmEw9Z7cDT0GWzlJ2gDscAWtl+wf6jCuMLpMsjGab3afoAxXA8rkqODhkoLexANtFdEN3HX/u8Qsg2SA5EzQS6KWHqMA81fSEO3zG0QusiFsVNWc9yYDFkCAVCGgc4NlSWvoiQvSF/Igxw4qA+lpMRtLrSBr+xtVzV5pcBoKHLehz3vvUmEzgLnR90niXt80C2jLZWAQ2gefYpre7nUjoeBZrj+C5sEj/uuKu6e68N1YZZ+6i4e1JorugG9SC1XGXAyIBb9tpmjA4WKTC+TxHNwxeN5qUfIPjBYmHxefdnjaAoYs0XvGyxCxtRKX0tU7jgJJxIAdaNi4EOlLdxaXXHwKm+vH3fgOXKuUV6FfvEBOArGOHHdU7VHAlHgP85uAFtFWqB78p9UmPNqz233cdkvS4hpXodmJwqaSM+FGWJZdjXs5ZZogYKh4aE+TE3cca4N+dhvsrhP2kg6wqtcIgiSGvErG7csY7MtXhT51oHkj4bj7KndnuVR2CJEWL+L7eOQvXZqNgVBWFGU7lO2rYKAoQDMP+VVGfbafpoKsOoLZu6bvPRRwt/vuqf6ITHGvNCeOkNZHQUZeiMhn9z45SxDz5/KdbPLJRiAg6x2qxeGVxu/bmJ8PoJJGgf0g/zIWSM9Kg5UMrZO0hsnuROZnH0JIoyo1l0zmRe99hSDWdZ4pB/AZWKB0vpoDpeFK7+Bw8i+rzd9tBgCMTmrEMl4uy7exGNUvqGtJvhR9c9lYGtue3evvAXZuJ42ihh5b+2ra1pX8tgCigAnfQhF/6FApWmDnE7cI9U2lq98W5b10rbrjrehPcb5ddKaFanw77Nf6W6WZ1vm+9w7IYJMK X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(61400799027)(376014)(48200799018)(9140799003)(56012099006)(5063699009)(4143699003)(261009223027099003)(55112099003)(16102099003)(22082099003)(18002099003)(5113699003)(4113699003)(10067099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g9TA9hZuZqmCm1rcZPWYMdiyvwWUxCVaOnsI4qzc8S+QTYC1AEkSPOsgq7764PxtB9B0j7NaLLRCVBbemJdaa8gP4iDqQW5qv7cEd78w+gHdmEHXniXr87mZZ0gqXrMFURwmwvq0oOK6FnH//LwuRCSWQwqrajURL6aM8TpeElOts4f+FAwRErGkbRr85rSXXHpdGJWvbrDwR9YcylhAM4kU4ExA0/NHiXcRm3mBLzS0aTFIt1yjD6t3VHm+IpTCMngUCtuxePC+YoWqnmuojCdWIi10/53jruC2Pnpp6bR4DzFh/NtU54Ab7u3lJkXCDVoQPtfM/cmq1kF6+1qf+DQvbx4voILKZtvfyDTOsAXcXvBA/c5MW9aEPYpy1RzDhF9nrwVWc+ZPviTZHD9yWWetFJnJaLLCnWNiZoqG1Rrz3t0qn2qzz4UA7vOdN51C X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:47:04.2484 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3969cbf2-697b-4cc6-f5d4-08df2ec9c54a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008554.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR08MB11006 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D17