From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a35ac8e-9029c598-a857-40a1-82e1-8d8a4ed48f61-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023132.outbound.protection.outlook.com [40.107.162.132]) by lore.virtuozzo.com (Postfix) with ESMTPS id DE77B8017D for ; Tue, 20 Oct 2026 16:47:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XKGIQqKX7/qITj7z0beVWDhWNJ1qdMERzMNL1htzQk1XsiZ4BoIRHogH/iBuXHa24nUeyEaBeYpsUXyYWszBOHnP9yX8enMFlaPOAUBQ4Fa8d6y2FSogNXz9otxfRjofbYK+vvAgqqLPgBSsh6w694hgDiNGYB8zwViip6QCHZz++JVgV5Ca8mmxQI7m90SL5fbrWaVhQVwRVWH/WNH8Qe+zsZQzQHcqiHRlEhKA+gMAe7IQ+NsV9p4EKQWk2E7Aca3XF5YBis3ZfsGbgVnG0t2jixeSYkLGF5XWyIdv2Yqgid+cpft9voE57IYE7U5vE0cgtMl8jXq6BX6AdoV0Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5fhKv5bOg1OCQ23JtoEr7+8XFiY5cOYUtUfCkv/grCQ=; b=dGdCmxNS0Ba6uL6UnnOCIUqTdMRkuqWip4wC1bwprirg9ITKKKtiXO1N+V2MSo+kiD7WHJ1UakS0pQB8nqFVxPO+TNCTx6o1RC/48pU1wW8OKvDecHEj6GG4S6w4Tj3OTs6t52bddQvCevDculUOCQ7GttwHK9Wfzy4kxU7ammVEYtU/HuHy4sDGG3JxZEkvfbKUJ28T+wP8GSF+ULz6g75ZNFxTkOtN996U4nNF7rCF1wYR48md8IzPirIl44taSh8YapnzJGSeTdgu9YiO6dVo9TeHurSZ6i9nNR1fxdnwznFME27eN6GJQvkTU2gNv7o0RJ2M5r5t/mkmHEIvTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5fhKv5bOg1OCQ23JtoEr7+8XFiY5cOYUtUfCkv/grCQ=; b=IWRA9fXcpPLZL8HXKK1CUYVSuFOpGSFcXKFeHmDe/CoiKrMnEInY8IsfNCcA46MYE7u3vFjam/FgtuOuUSsu2G8xxS69Xu2F2C+XFT9yZjRL8jP923sGg1yvkefVEjOTPjQFagDQ9ahYOBhZi0BFeyNUZla1CZw58i7s6rGgQrY= Received: from AM0PR02CA0111.eurprd02.prod.outlook.com (2603:10a6:20b:28c::8) by ZR6PR08MB953203.eurprd08.prod.outlook.com (2603:10a6:910:d9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 20 Oct 2026 16:47:10 +0000 Received: from AM2PEPF00070CF8.eurprd02.prod.outlook.com (2603:10a6:20b:28c:cafe::23) by AM0PR02CA0111.outlook.office365.com (2603:10a6:20b:28c::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.19 via Frontend Transport; Tue, 20 Oct 2026 16:47:10 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by AM2PEPF00070CF8.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:47:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514829; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=9Uug0TD/VfjyNkS57XU6BOnpVLdG2KYIinLGv54dEug=; b=bR5bZE4riLw1aX+ROTL7cPdcVzBkeQRIjDikYR9L32FqlYhAHpEZ2ikwy+d2l/2p /uBbS7jAL0Vo2ONN8bmsAOKdlUlDCbs+j2XCuhKmHNJCJDXS0uRUdUWRdfnNnAL75/c doW8s6MN4uVpv8D4zxIhHcQ62dpS0332ZEdk131+si+wCsAmSkZlelAI8wcHH1Cf6D9 ++i7qSapniTY9rg+opX7RuH1wTIlHgs1Hm5mH2jz3TCZQte/TUug8jLAS1Qfc1I9H73 TZnurCa0uXedKo+0j89K7vwJRfI0pO4KKCxfS9AoGSz+jMsqU4G1BuUd4fDtExjE+MX le2KuYi+Cw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514829; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=9Uug0TD/VfjyNkS57XU6BOnpVLdG2KYIinLGv54dEug=; b=TpzPErs670x7WRJ7znKGp2hqm2FkSLGaMHwSVLmPX9TlpoTwxfuzFnp1roMrdCqu aA4Xn13ZT+imyDhHHeTakZ51euDbYvzws0fSIVB+JqnNArH8+D3rSL/QVlWh/YDbXZ8 xGjK0YQB21laTRJj6Rwm1X7mAOJGgjPjuOeY8gy4= Message-ID: <010701a15a35ac8e-9029c598-a857-40a1-82e1-8d8a4ed48f61-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 16/31] migration: yank: Move register instance earlier To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261020-vfio_v1-v4-16-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-16-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:47:09 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF00070CF8:EE_|ZR6PR08MB953203:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b3d65068-40f6-442d-ede8-08df2ec9c8a3 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|9140799003|48200799018|61400799027|376014|32142699015|4113699003|5113699003|18002099003|22082099003|16102099003|10067099003|13003099007|55112099003|4143699003|261009223027099003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: mrLbR4okSOK39nHlJlXRN2gFVOIcy2TITtyJt2H+iR8LpsFQMTOxRF6TpHIvKFv/AD4keWCsk6VWsoVYR3EXBCux5zIGY8Tx/YpXTPItxBU8n8yysWd2qIaeONzR3Wl7lSQ22ZdPHkQzWCdpeEss514h8A5xE99JEHSxSYY+DxAZ+N1Dm98UQTYIeXC5/zFCLditNsl9BLcndQcD8gCV8rgWA9MuJITawSoxJUvX6SHqJe+T3Dlc/CyGtENHK38KBFn1xAb5WKfd+8WuVFxzKWSH9w1FMyXKno8v3TbWWccYnfqkG7IZILPGnSfw81R+yy8hfBrewp8yg99jyeF/6j1qYmM+FMDYq5fGgOChGO/NuR8jZl0cZ2NHWTMGjX6Tzy18IOYn6FRcdL2C/Qhqvn/E/BrDiLYoBQSMn6e4lH+xbpmgEkreSHT1ajhneyaXmYJW9Y9HFb7Q5bEPBoMPq88eQcIgaOVtieuiesh/HwwXksg8lHb/HI2BefTM3ml/7sqlfakXtNlzIkJNWkbUYf3awg93C//s/egBR+sC8jrEVD7rdq6X+U5SKNkPCZ+u8IAg5Y+j46juTa5j+ID1lBPfau5Ezl0I/bxWkcUTFfbrz/miLoW7tKWBmBa1egBekeVhNGQJole9p2OEKUjr5Nlbaf5fovsp0f2vkUCmLHl9cj7azsQxtHkufPzORaHSaU+kkp66hDmaKhMmT6kExHQQfEQlfJtGfQnqNBIhATicu3AUUIdmQ9mWTTKrxZl3Cnc3jY+YfwWA4KDwb68jAeLABSxCJbmLfYfCssz8aAihPeWAlqXkpDaapOXdYw0Om5q5Vs01O7EeRlR0Ya0Bd9Rvsd/HWYNlvsD3uy/v5y9Dshhj3jJZKHwEcd5PgmK3Ak3KQ3Yfsk02WVb2MhXPNP07YwwoB8mR8q3YGN7JH4Q= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(9140799003)(48200799018)(61400799027)(376014)(32142699015)(4113699003)(5113699003)(18002099003)(22082099003)(16102099003)(10067099003)(13003099007)(55112099003)(4143699003)(261009223027099003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ODggI1Y5nzJbZPy6uQrZHB09hxRQ7J76CDpOvVHluHwj915NIqsPPpPVNjX6bcgJbPN6rW+B1WRN7GCdu6m15MOw/K9RWygyUsKA7quvqAwKcYQnEZz2UQPrAbkBi+S85u0/koJ7I5LRH5UQmEmWsjYt7I+324T7mAIxnymnkspqNS3EOc89Z7D3JxjJpvWWxztxKuHEEAToD/ZB/JSd6KsV+YvMURTZLWhOTv5DSCyroohVlnCYtKW7kCBYFiGXZkkVLN8MN0gDUkWN0MRbFgtTHZDYddEMnIl/1UnL+OV4up0WkMvzlpoDoxd523VL2kTCP83A3BoGy2k9+Yy9sITILXTf5tCK7vEHAcE7WxUqGAGCLuY/vrgvnI5E2ZrUbuZpQz0gLXOmLvHlOdxlVqr8Zl5PHe3A8lmvuQ+EnoWBGgnyO77u6rfyo7vBiuZk X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:47:09.8731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b3d65068-40f6-442d-ede8-08df2ec9c8a3 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF00070CF8.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR6PR08MB953203 > From: Fabiano Rosas >=20 > Move the register_instance call to migrate_prepare() so it can be > paired with the unregister_instance at migration_cleanup(). Otherwise, > the cleanup cannot be run when cpr_state_save() fails because the > instance is registered only after it. >=20 > When resuming from a paused postcopy migration, migrate_prepare() > returns early, but migration_cleanup() doesn't run, so the yank will > remain paired. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 7e714392437c, > adapted for the hci-dev base, which predates the upstream > migration_connect_set_error() -> migration_connect_error_propagate() > [ ... ] >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-11-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D16