From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a15a367241-42b95fce-6ca7-4beb-8960-0756b09d9358-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020074.outbound.protection.outlook.com [52.101.69.74]) by lore.virtuozzo.com (Postfix) with ESMTPS id 33AC5802A5 for ; Tue, 20 Oct 2026 16:48:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QqSHTrPbCEx6GgE5coMJkiHdJFO2j1E8EPoJ0qRNLOKRawwA9/m6wlCizupd6JwbSN49TqXUeKpHe63ZxGnWcFvJBnWKwagKLLnCVKx28g1qrhWbQ+QcIkYcmKQleYTcS+D1cs8v+c3bgHva6as2YD5bigHTGhc/kQDNMgClei0uE/9yTwyiR9qLOSPtMxopCMLvgLQIQ6+yHQi8clfMN6L69AAG6edxxwObgLW4OWp7WHniyBvDFo1h8gTzMpXv3NFT+8Vol6d3wY2G9YssVBxYIDLtYd3XXvML13bPHcPTdLf0vsa9FRwDnBSndJ0Z1PUUMhZ6wlSHZUjfp65fbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rHTlul+PsS9ukmowZGRS8iXuI8NKqq2ojv9SN9DBJWo=; b=D4XFE6P1oxuDWBQ1vNRojhL7wlh4GVmbQ3M8+IZmqPt4GoMScVbff8ulLlYdY0hyk3MPoX2wey4K3OLGKpLlI6EiPqcDNxfTvdrXRvFt86RQ16DfNPfREpSmbsLvf0o8/GxiVda51d0ohPoJko0hVai2po+sF9RrxyBKQhsJ3TcmN3y9+dMKurNnZeNYmGgo/39BmOeMfOT9f8evbUNU1PjQ1+af6Clr0P0vAwFzmgSq48hejl2DkE2ehn7TmXr0n7WwMPRG2OZujI3LGq3WKL1l6vxkGsOgV5V+5Nu8mrbXqGFths5fFWsbDn64Eo983uqSLA+StK6Tv/8NiO1ENw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHTlul+PsS9ukmowZGRS8iXuI8NKqq2ojv9SN9DBJWo=; b=H4VIFcPEWh+GNFqv9LxjwBl23gPoP4bjkr6fj3CkdTYY7rPyPLHZSIVIdHioI3Ppp6/80f7DqtGgW1vNKUWo4gHv8kgyAXqnMHVb6hXD2X2c/6XDIwT+l+8LMo+PhxXeifAoXRUpnBw6vZDFH2cQ1dy3FDeX9CON5Z64CIN+WLw= Received: from AS9PR05CA0345.eurprd05.prod.outlook.com (2603:10a6:20b:490::26) by PR3PR08MB5836.eurprd08.prod.outlook.com (2603:10a6:102:8f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 16:48:00 +0000 Received: from AMS0EPF00000569.eurprd02.prod.outlook.com (2603:10a6:20b:490:cafe::ad) by AS9PR05CA0345.outlook.office365.com (2603:10a6:20b:490::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 16:48:00 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AMS0EPF00000569.mail.protection.outlook.com (10.167.242.119) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 16:48:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792514880; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=kqqrlotqBErRBg97HWF283w8kwMVSLfVAZC4Yq+O2BY=; b=YWO7cM8kQuSiyVu63UMPNCXp/fOdkvtLyM3cAss081ODQyUl0neiBvAnRi69CDLd q/yfarkHL5r8G3Oua3eb8Ddyya2xftRU05ejy7t8d+GZwRBUap5x9B5T90m3sVQztkG MWMKjA8KtyMDnGPewaxmyHV82UcRX3XLaPslFVKI4VzB3vZNexFKocRVsxpgCcEUEW4 WSH4tQV2pn2VfFBTtMmpBJ/r9+/iL1Mng3YuMDjCYf1hRalnJv4TEvWOx10ajXSVSue uAFdRYdsrOpvUM+xxvqoFPzZGzaGKT/+qGBtsw91cQOu1sbHJvDd/DHt8jD33HW1lzp 6dhanyx9+w== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792514880; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=kqqrlotqBErRBg97HWF283w8kwMVSLfVAZC4Yq+O2BY=; b=EnNC01wqEVEvKmz1R2LlVlWBbPwSWcNoXmrveizY74/8uQGPlBHVbPaIWMYP6gy3 CZ34dWKSweggXZ9MeBpCIU71EBETx/CTOrMkvINKLPNTl1CbP7dficw9FBsKCNZexyx Kg8pNKORJp/d1oxy2d7JNGBiOUeYSLN6NiXpViqE= Message-ID: <010701a15a367241-42b95fce-6ca7-4beb-8960-0756b09d9358-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 18/31] migration: Move CPR HUP watch to cpr-transfer.c To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261020-vfio_v1-v4-18-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-18-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:48:00 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF00000569:EE_|PR3PR08MB5836:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d8f0eca4-379b-4b29-aa32-08df2ec9e6d1 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|61400799027|9140799003|32142699015|56012099006|5063699009|4143699003|261009223027099003|10067099003|16102099003|22082099003|18002099003|55112099003|6133799003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a2NrMzNlTUdsNlFZLzZLMkFRalcwZXZCMVRwYW1JazVTdDJ0emhHeElTWEpj?= =?utf-8?B?MVVLVkVmNDNvOXV1THpiM0F2dW43aXhVLzFBZFNvajVDTTZtOEdNWEZOM25o?= =?utf-8?B?K1pFbG9FWE1adjlwTFJZWU9RSzNXSVdzeHdqKzVyZW5ITVBYRTNub1luS2Vs?= =?utf-8?B?bFliSHZFc2FOSTlRb1JVeFBGaGxEWmptZTVBWWplZlU0RitTRDIzZmF3UHly?= =?utf-8?B?MEZxYU9zaWZRUHhLVXlMN01VcldkVy96Z09wYzk5TFlJZGVRWFYxc213OXVP?= =?utf-8?B?YTc1aElaclpyYWkweHVmQkNHQndBUzZQVjIycGtZUEtTUDdtd2d5WExtNmJo?= =?utf-8?B?VW5TNFVYclhxaEd5S0ZtRFZ4T0xJODlFN3NJNkJaVVVZU0Z3dG4zT0hRZkdF?= =?utf-8?B?a000ZkV6RlJqdnhlMnQ3Rld3UzBLelhpbDZpcXp0dVFjZkc4S2ZvQmRqY2la?= =?utf-8?B?SFdOL0U1NVJ2UXRTdW1hNUJUWXRBa3hYVVNsVmMrQjhxenJrN0E3WitWaHc5?= =?utf-8?B?ZG1SdFJHN0tVcHBVb1M2cmwxMldPaFhFTWxnbzk0MzlPN09QUHM3dnhaQTNx?= =?utf-8?B?KzNSdTNINHdJTWlrSkVYVzVWbDA1cTVaRU1YS0p2ZFZnbGRxV3BhZVFyMzU3?= =?utf-8?B?UDJGRHh2Y0xMUkt0SHc3MkhZYmxkRDBPUkFhVXo4dXllRTFndkEyL25sSnN6?= =?utf-8?B?UTN1bGY5OU5FeWliYUlpdTI5SkozVmpKemRkbURtdEQ1cUkrSjlaUHZEZHdJ?= =?utf-8?B?REU4UzdCYUQ4eTFNL2x1WkEvSW1IMUU0bGkyeUJtalFSWm5rL3JEY0hoclBW?= =?utf-8?B?bVNKV1dEcUxkRVh2T0dEMTFHQ2h6Y0R0TzQ4MHFqK2RvK3JHajQ3a1B1OXgx?= =?utf-8?B?Rk5RVTB4UmdLNDJSYUdWNGNkVW5xc25YSnoyRVMrWXhrT0VLekltZGdNVk9p?= =?utf-8?B?bUNkMWh2UGJaamtGSHFxZGpBOFI3SFBTYmpoMjNvV0dBUFlqSVdQejFMd0xD?= =?utf-8?B?VXZuZGQxSVdVNU9zdWVRYmdHTTdYUDVQeitISXBRRkVteU9STzZIbmsrUW1I?= =?utf-8?B?cFdVRVhoMlprc1hDL0hsRnloRnM5a2NNcDcyUmlCbzhZa2NGNEJrUTBZNjlN?= =?utf-8?B?Nko5bzdPc3lDUmVYYnV5SnVoZEtBZHVOZm1taVQ0TE5aUTA4M3hyZjhhWkdr?= =?utf-8?B?RWxFRitIa01LZTNWczRvWnpOK2JDWmFOYjY1Y1FFMDhtZGhKNlM4YjBPTyta?= =?utf-8?B?UlhyVG1jbWUrU2dZUnJsc0hvY1ByTWRXaGZkamw0ejlQQVZvdmx2UGFFZFF3?= =?utf-8?Q?qSxyShQDE3v3E=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(56012099006)(5063699009)(4143699003)(261009223027099003)(10067099003)(16102099003)(22082099003)(18002099003)(55112099003)(6133799003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7Yd7zhG/acU43hb5t+5HAsFVsafRA/Z8/saal4FdjxAEQlPPohJ7xcn+e5r7h8MtT8NcEKVdHgJO5F18RXWZm6wkU1UtEQRoSIKi4EDTMOqwCmiPhAdZhhhrTGkXmpit36ir4dak9vrYbT8DX6id41FMzyFiMkSqf0fwshQRTelfWoIhss/wGTsJgFXtju3rNw3Nzuy1hv5rsQZBtK3bQqj/G6DqivNEcy9C0r070ppYjib1vT85bIZdeyTZF29VvkFMuLJ1yDvMmGl0C3ObedGmP4LGzDGR//wckmUi0PAKWGIh56jTn/hklHk6u7vtQ+wJvuaAKoLVK02ahc8l/5UbyCTN+YwL5pzCvly6vtWc3eGtn4V+SnvvROrf7tkQIvDIXWUnHjVs7ZYpkhrtbyLJSQuTIZAIVV6bOiMIGNA+pTY0GEpGMjb5ZppS15Y1 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 16:48:00.5048 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8f0eca4-379b-4b29-aa32-08df2ec9e6d1 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000569.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5836 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D18