From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020076.outbound.protection.outlook.com [52.101.69.76]) by lore.virtuozzo.com (Postfix) with ESMTPS id 05D198045D for ; Tue, 20 Oct 2026 17:02:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uUFpRCv3x87V3CUd0Y8khwtV/5in/Zk8/Kzy9g687pX3p5D7Fs7bkrBujWVwqjAZulzdFAJ6ncUyJsOPQsocI8+xkhAM0oJ0LHMGmHB4Rqz/P64MjtvBt/oagzVGqTWHYb47WUMO5fkGgLI+Civ5//nY4Crc3TmxHxBx9rDEEj1DIbNlynnpipeJBwBgeZSvciA9a+XMwFv3cxIQhlJkxJC0AcdyCOjb1BMwTLErg8Wk5s3C6w9fGE7NpErtDhi3uWZUft/IzrM5ykjL96c0iwRpKKpaV/IJ0oNfMTR1eDhxEorGXxhPQYK7HFjiH2X9uU+AB5efMCttfEAVvyOtZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E232dzGbrqR4wwJNdIgRbcxQtON7VivVUq8GGqJc1vU=; b=u04r6TBCbjEGEoKk6h7dvsdCp2zntYyEFgsk6+Uqgzris3N+dX9PVSL9ii4aRp8VElUYyt1+toUb3KRY9ZncD5VGBThSgVzomoOlqxougrHSwCxkpxzckSC/p05rV9NiicCcuEsYTV1UZ2tE5orYs324Z+hIXukxvO11lI1C0fx5ff6/2gEgh42YaayTk3+DSiyUgzkwjaxNyUtJJEX3tqm/1CiSeltQB0o+LkyNzdwm5FM6iDqnTWlR5HxzhMGLAOUGSw4Nn5jL7tl1I3R6wCkhAhWxFgQcAVLQ94j1ayJbadwWDTf3CpW2mOML3MENlIix5WWRga7LZdNWiY4jFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E232dzGbrqR4wwJNdIgRbcxQtON7VivVUq8GGqJc1vU=; b=pQmIo6wqMMsSkZxvzBl/I36NmoW8nHqfWaucR/cfdowDwZTXxtU/edeu2f1Q68xW4ZvBQKpA7to2VmqBoZoBaSG5fCW1h7UhY4Zjw4nFUo6PFhwD7jNVj1slXltG3len7KV4gAa+xqPocgtW77WvMium//WLhKNSEagXxK3VZ18= Received: from MM0P280CA0075.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:8::14) by GV1PR08MB11178.eurprd08.prod.outlook.com (2603:10a6:150:1ed::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Tue, 20 Oct 2026 17:02:41 +0000 Received: from CPH1EPF00000527.eurprd05.prod.outlook.com (2603:10a6:190:8:cafe::ab) by MM0P280CA0075.outlook.office365.com (2603:10a6:190:8::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.20 via Frontend Transport; Tue, 20 Oct 2026 17:02:41 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by CPH1EPF00000527.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Tue, 20 Oct 2026 17:02:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792515760; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=W3bWtgfZT1UT6sRYhfAg679BYSauEWcSNe0N+8lsGPE=; b=GDw6icb6JhDX2/3graSDNcGxzxIcH0DoCogfKOKiUlryUMxb5eKIsGZGAWBZeN3a tpfag27/KcH07l2wHS53nv8r4IAty/NtlSwiZBZBVxSVIgwd0JT929p06DYyDZiVu0n TQIr1ahCrUsorrIIvMzBskF1JI0yWYkm4xrrpcIsuDLCY00Gv3Np/9z8r+nUaEXDp22 8wJjlW5OjluzB99r7NYDprTAKX+s596uSaN0cICwYENTUfTaxfXpaksRcLBwViWJUiZ pGcfQ1WweP2fQRtF4oJIE6L9VlY33weQTUJr9b9V0J/wSt4Bru5c6mcpeZl2bVT00bZ lVnWSInBQQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792515760; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=W3bWtgfZT1UT6sRYhfAg679BYSauEWcSNe0N+8lsGPE=; b=CrH64NRlPIKNhk5AaPRX0Su+K3gtbzk2NxAozVaSaWIv6KD+EA3Z8c/xFPE6EqW/ kIWocSidCVZe78nRgna173+VvuC+oe8ofmRHEjBQMug+jfsWkVTLjuHv4nh4CZtXjsF jqtbc7MeLHk7Aj8LeyHyOEl9wuqMmj2/qkvEuJCU= Message-ID: <010701a15a43e0a9-10247610-57f3-42dd-aa0f-aea6a912fa2c-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v4 26/31] VZ: migration/cpr-exec: abort cpr-exec if memory can't be preserved To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261020-vfio_v1-v4-26-83a5668230e5@virtuozzo.com> References: <20261020-vfio_v1-v4-0-83a5668230e5@virtuozzo.com> <20261020-vfio_v1-v4-26-83a5668230e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 17:02:40 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.20-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000527:EE_|GV1PR08MB11178:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9ff32fef-4871-4efc-6f16-08df2ecbf382 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|61400799027|376014|32142699015|48200799018|5063699009|56012099006|4143699003|261009223027099003|10067099003|18002099003|22082099003|16102099003|55112099003|4113699003|5113699003; X-Microsoft-Antispam-Message-Info: Jp6rkPR4vPKBKCtvhJSYwfonBmTtUaGa0UtrcNzKd/CKnNxM5lUBhZP3OnFAygCVVUmlJJRoTM6LXKaNNR1l5HzVPTe1HA19p4o+0J+nKlN0ZovVCx3WhI16Eb02OeQ48XGJ9DZdJsj68k+iAA3Lx/AsmSMkH/k7f3iPiqY+hKe+rTcfBoxXuzrxoSiZyC3FljxWlVoBwLO78dnnVznnGjlYsoFUVnAcmEcgQ5/17IJpkYq+s4TS9e5onc4JMDmR4yqqhzxu6pymKJaLx2eLyz1qAnJzAmXDscb3hvFJ8piyfOH59oJmWLfGg9iI56DbOKGdJE3IObw74wZDTkyOsWHuYtNbe4eyjTYX4XO3l3OwM/OEuVPzjXNFO/n4jiKNW+GOW91PcZR3nFNoKW+bYFFTqVFFBbwWHcvVt554OUmcBkHDdE0EU+pq8VOpMjoqKYKkSbFVZV69R6p3LZxDXnl6TG3PirhbRCjtDxmqxO1U4NdCw3NIeOOJPBaPZ8M5GzJz/eKwUt5bGhoZKo92LtOMD6y9BHaO7cTFHoGmsEa9c9gg5Lol19TP/tHtnoFcs+0Riwz5YX4VFHAqjElgIaJkmeU1q/vuvSC0dtEN+bvXlA899RS5CM/H2hAAuyVTpyYECohcjg/y4rQg5FpcWul2M6qrBeJ9sO/4gDxlft4xe2zIsqKFKUxqnqgjQbbr/CWJUXc/4L6fpIveQ47DZ7mzA7AP8vElMokn9vSCFvk+NGgRVHipUhMhYV7VoW/NL+Gq7lIWqzUz1wM/WsrTPH4pDjXEIHz3k96lxUJNkRfzQatBBJSx2FLoWa4nTVy3GABGsjB5MqdIhpzUY4p+bDRh541/v2k+XBYQInT34HRoHDxzbotozh3qfFNvwyQ7qJw4E5xlZbZ5SQtqJsBuXo2rrxO/Zp94rE2oJzcMp4HZTJ0xCgGu8J1h/pIUwh92 X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(61400799027)(376014)(32142699015)(48200799018)(5063699009)(56012099006)(4143699003)(261009223027099003)(10067099003)(18002099003)(22082099003)(16102099003)(55112099003)(4113699003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: arfMBgbg7L6yoXaeNTur2S6RjYkRCiWP1vNlHVD+f99/OWqL5Jnb6OUqfIGamI+TWIddcZstyW1vsSnw8qb6hfenrGEV8Y6zT7ovXnYkRY0XQOQoQFIwgCvYTZHnxmxWFMH3jHd5Cy9ptJ7tY2Cew3YROyEGtVEtU7IyUDUuvM4+a29zoIq2DJ+p8gCQBF/SmxHXcwbKFV4OSxlaUEIIW6VL4aOADSMDBo+gInFhOyUw111Frb25tfraPyZ6ZLB4FOFhzfu94yres+QMEiITUtOFR95fOWUFG9HTD5rLrbfamTtex06ZciE1Ll09I2j/ijDFVKv0DVEbN/7eryCExNo4zrg/2n3W9RjPvxEbR0KxNebdJBVsSQPrjECZPMBa0CYrkVIG0rtwLu1yZqHNWBxl8mtPaJUMUvHMxbUi6HiKAGJlFA84FgYyQYdBTuLL X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2026 17:02:40.7688 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff32fef-4871-4efc-6f16-08df2ecbf382 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000527.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB11178 > cpr_exec_cb() marks all saved ramblocks with MADV_DOEXEC before exec, but > ignores the result. If madvise() fails for some block, the walk stops > there and the remaining blocks are not marked, yet execvp() still runs. > The new QEMU then reuses addresses of guest RAM that wasn't preserved, > and the guest is lost. >=20 > Treat that as a failed cpr-exec: go to the same failure path as when > execvp() fails, so the VM keeps running in the old QEMU. >=20 > On that path also clear MADV_DOEXEC from all saved ramblocks again, just > like the preserved fds get close-on-exec back. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261020-vfio= _v1-v4-0-83a5668230e5@virtuozzo.com?part=3D26