Re: [Devel] [PATCH hci-8.1 v5 2/5] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: stale CONFIG_GENERIC_VDSO_TIME_NS in shipped x86_64 configs
--

commit e601305998d6e60d88bb518baa79a61ef65b0de3
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS

This backport removes the GENERIC_VDSO_TIME_NS Kconfig symbol. It drops
the selects from the arm64, loongarch, powerpc, riscv, s390 and x86
Kconfigs. TIME_NS now depends on GENERIC_GETTIMEOFDAY, and the symbol is
also removed from the pidfd selftest config.

Link: https://lore.kernel.org/all/20250826-vdso-cleanups-v1-10-d9b65750e49f@linutronix.de

> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 7bd57bc01adbe..04f4bcc0d59fc 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -180,7 +180,6 @@ config X86
>  	select GENERIC_TIME_VSYSCALL
>  	select GENERIC_GETTIMEOFDAY
>  	select GENERIC_VDSO_DATA_STORE
> -	select GENERIC_VDSO_TIME_NS
>  	select GENERIC_VDSO_OVERFLOW_PROTECT
>  	select GUP_GET_PXX_LOW_HIGH		if X86_PAE

[ ... ]

> diff --git a/lib/vdso/Kconfig b/lib/vdso/Kconfig
> index 45df764b49ad6..a1cc90133cb9e 100644
> --- a/lib/vdso/Kconfig
> +++ b/lib/vdso/Kconfig
> @@ -24,12 +24,6 @@ config GENERIC_COMPAT_VDSO
>  	help
>  	  This config option enables the compat VDSO layer.
>  
> -config GENERIC_VDSO_TIME_NS
> -	bool
> -	help
> -	  Selected by architectures which support time namespaces in the
> -	  VDSO
> -
>  config GENERIC_VDSO_OVERFLOW_PROTECT
>  	bool
>  	help

[Severity: Low]
Is it intentional that the shipped x86_64 configs still set the symbol
this patch deletes?

configs/kernel-6.12.0-x86_64.config and
configs/kernel-6.12.0-x86_64-debug.config both still contain:

CONFIG_GENERIC_VDSO_TIME_NS=y

Patch 5/5 of the series updates config.vz10.minimal. It removes the line
and adds CONFIG_TIME_NS_VDSO. At the series end commit b20653c3, git grep
still finds CONFIG_GENERIC_VDSO_TIME_NS=y in the two files above.

Running make olddefconfig on them will drop the symbol silently, and a
savedefconfig or config-consistency diff will show drift. The compiled
kernel should not change, since CONFIG_TIME_NS and
CONFIG_GENERIC_GETTIMEOFDAY stay enabled on x86.

Should these two files be updated together with this change?

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261021040939.2103947-1-eva.kurchatova@virtuozzo.com?part=2

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel