From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169b2c1f2-473e9f90-a062-42cf-9791-3cb42165612a-000000@eu-central-1.amazonses.com> Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023121.outbound.protection.outlook.com [52.101.72.121]) by lore.virtuozzo.com (Postfix) with ESMTPS id DA86980474 for ; Fri, 23 Oct 2026 16:58:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J9XoEk4A4zHueKGRGbPpBiT/no4npJV118dMhLBOVyiuvpZPUGhIsG5+xdE952qQasjkCxGu62+slOFEyDU7700PPJ+CDHOON6UBp1EW3PEu9L9bjAkg/KNqw1xFzg/geH7CHCIMcIaASndSB5AnXtdBA+IB91cnvbwRpYOVNBcY74bLdMnjnv8UmifpngUBB8B1FM8Fylk7A9NYknFFhSr3xxh9X+qmZldi8HS3/B+sRObgLWSU8DdxjqjgxNq/fUSxd+MakX+Z7jI+Ui/No3+VM55W/eHl4VSjbfnVNk6/sQZ/fhcmwZOiADqIsqrwKy5BJoPhroc4+HFWkODc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pjXvSHMfUgU4+OeSNrGadGgBLu7VI1jVGgIY4keXiFE=; b=u4pqjAnpzxAJogK1j7z52teNzcvq5L7ZeWj4P2vLSHnDA/29kBuywxMJSkZ8ny++y/DcdfeJXb4989rtWNjyKCkgA2v6D/97Y6LPade+vLe9BS4+43kr9YRFB6c3u+02LQagefazvXAOxkFUdSV2ZSW2ZamahzgQ8ykX1QPEvHBaUduur6b1hmeueWEqsUuwYXK5P026CsjNp0kJkzynK0hRozaMFdvDVEvc5ol8LvrIoDhOZDssUgZIbioaZMUmMWeNK0u9u/4PndD45h8g65fBPeI9RTePENvS3eJzkYfhF0vfTgZa+8uVZuVxv7FSB5HSvIiDd9BLLkWrb8mxVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjXvSHMfUgU4+OeSNrGadGgBLu7VI1jVGgIY4keXiFE=; b=LxxqN56tldYhuzRm4ZefEEcArCM2cCsHcBUB0cKu+nD1e8qz1MxNtJAAd7O14I49xg1U12WmgYUYrSo9SCNp74jG/KWfCNrm90AY3QXxpkCKo57ASOvKxECiQY5URqUDVh3BZ2WJ8rxxZvVUnwLP6/NjSkubXAr347VBT+OdZDw= Received: from OS6P279CA0099.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:3d::8) by MIWPR08MB222869.eurprd08.prod.outlook.com (2603:10a6:290:94::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.16; Fri, 23 Oct 2026 16:58:06 +0000 Received: from CPH1EPF00000527.eurprd05.prod.outlook.com (2603:10a6:e10:3d:cafe::55) by OS6P279CA0099.outlook.office365.com (2603:10a6:e10:3d::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 16:58:06 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by CPH1EPF00000527.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 16:58:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792774685; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=pjXvSHMfUgU4+OeSNrGadGgBLu7VI1jVGgIY4keXiFE=; b=NP6jH8Af5ECYrwIy4sXM1fp8McxJYjvXSOsyjZqp/kWuehXZIoyBpkYR7kU7KWbQ SMrFlIPXC5lw27UcnWmEa3+KeR5bEABy1VHv6FLL9hNJ2Wj8xPE2v+emTCNuDaEPkYx ahHhY+DwR34DZnlIfF5qxR9ZMkxmhBkrCCT0ZUxBH9ZWBicOB1UUOQpdjaNa1gk2GjZ 7s8T9H3r2+OXcBqQlPAb0IW+kMKdDA2MhHkag7oWuNn8kWmj2YRID4t+3jApNf61MLN 5IWlA9MZMFYI5htINRumm/LW92hP9IhzbFy54Jp4V6EViFE/ELaS0sx+Oi9YBtVL+DL iJkQcyq94w== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792774685; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=pjXvSHMfUgU4+OeSNrGadGgBLu7VI1jVGgIY4keXiFE=; b=LZvBRznR+sf25j6kysJgWaSm6F4reS35ATBAunN3qabAtStm5FSA6ZksUcIsfjNH gin9XFFeDLJAoBpIEz4nlgHJikOAWQNZAtzoYdJj32k9BhnEJaAEtULyL6zWFdi8FK6 Acfp644i/5SFohpCeKsex1TK41cWQ/eTlgqpZizw= Message-ID: <010701a169b2c1f2-473e9f90-a062-42cf-9791-3cb42165612a-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 01/36] VZ: migration/cpr-exec: fix Error leak in preserve_ram() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261023-vfio_v1-v5-1-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-1-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 16:58:05 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000527:EE_|MIWPR08MB222869:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a6b7e76a-ff31-4e31-cca2-08df3126cecd X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|32142699015|61400799027|9140799003|376014|261022105027099003|56012099006|5063699009|261009223027099003|4143699003|10067099003|22082099003|18002099003|16102099003|55112099003|5113699003|4113699003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SnZtdHNBNTMzOEp2T1dYZWJnNmtGN2p6K1FHNjlKYmdrS2NTU1hYR3Y2SWNi?= =?utf-8?B?RmJzemVGYmg0cEtMdUIzdlRiVnRleU9aMXcrRDlsSml3c3RXSlc5amVzZGRq?= =?utf-8?B?eHNkV2xISGlNOXN0VUFsM2RHaHZ6bGxwMjhTRnVPcVFhU3VydXlyOVBOU3ZM?= =?utf-8?B?Qmcyb3NVU2FrRGhac0wreE95d0wxd3JvMlR3SEx3STFCVHlDa20wRnM3WUpM?= =?utf-8?B?YVMrZ3V6TVFjaUtkaFM5QWN3WER2TzVoYmJaRElrOHZTaVVKVUllZzAzeDRF?= =?utf-8?B?bkdBVDhVWXQvNkFCQXcwYURWY3h4ZHoraTQ0TFh6VXRTY2h4OUpQYjlTQ1Za?= =?utf-8?B?VmcyZS93b3ErWTh0SEFVd0Q5NENmSCt4VzdITnRybEhMUmkvZ1hFUVlXdkRJ?= =?utf-8?B?SUtuT1hhRFZZL0wvbTZ3UTY1MXAxYTN1Nzl1cHB2VUc2R0F1M3pmZXpXTmh5?= =?utf-8?B?VHVTTEtZbURQejV5Q1hBU0x2SnBnUCtQSUhQT2lJc1hxNE1jSFNiUzkxOHRY?= =?utf-8?B?S3dnaGVqOFhEZkhqaHRUR2YrZmNSZitmQk9FYjUwMG5XOExFa2lBRjF2WWIw?= =?utf-8?B?TkV1dHpoQStwSFZLQmQrY0E5R3hjWTExTWJOTnowMVFwVjdZNjVUQTQzUHpX?= =?utf-8?B?cy9XZFNTb2VoWFd5N3JkeVQwQ00xSzRHbHhFdmpRdlF4T2dyS2dINndScHBR?= =?utf-8?B?QzZsY3IxTkdBZjRKcStoc2JpV2dMNGtwTE9MZjV5VndQcE84a1NzWmlZdmNi?= =?utf-8?B?NjBUb0M1UEJycE5EZEVEeHVrSDdXUllaR3BaclI4NDRsNFo0Nmtsc2toZ3BE?= =?utf-8?B?dGVyNnhxU0loZXNOOEs4UGcvV0xQQjhvWWdydDBabWJFR2wwU0kvWS91Nzdv?= =?utf-8?B?a3N0Y2tVdEJ3YStaemNES2Jad0lqWXNPTnpWYmQrY3ZPZXNKZ1MzYXUyRUda?= =?utf-8?B?dGJSZitKZTRUM3A0UkRWYTVXVUtsT2hsY3NjTUlaMUZ3aWdQeUswZzgwdTJQ?= =?utf-8?B?YWZtQ2p0TlBVSWExL3VpQzFVVDFTSHJvQkFTTVQ4ejN6TkFNdElnSHkzMm9X?= =?utf-8?B?RC8rSkpDTTQyejRjbEExbytYTCtlMzlvMnduRVJ5OEFSSGMvQXRCekY1TTQ0?= =?utf-8?B?enpRcWJJY3FnRGF1a2ZuSFRtVkVHejlOMFhwem5ManI5K2JTTm45TjI3TzVp?= =?utf-8?B?K1QveXhEaklXNTArQWJPYjVqU1NtZDdXb2Y2V2dTblUwMnIwanduWVZUbkdI?= =?utf-8?B?ZEhHbzdCdkFCbVN1N0VYT3dWZjM1VmdRZHZYMmtKZ2hTVlJiY1ppWHV1TWxY?= =?utf-8?Q?dBUEOHye4cg8tXUJRh1DZvBI62Zmdgp3l8?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(32142699015)(61400799027)(9140799003)(376014)(261022105027099003)(56012099006)(5063699009)(261009223027099003)(4143699003)(10067099003)(22082099003)(18002099003)(16102099003)(55112099003)(5113699003)(4113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 86TFBhLghewKJLZXg/phNkbk61b05+97/zADZ0ns/m/9yS1Ps+8I3rdQWIOdZzDX6xYf+Cg169AqCd51MczlNZghHrRh22n/EAYFv0Sv4YTaNi1JGZ7s+7NF6ySRiksOv1e8h9H8o5hZBgIaJomhSG+LnpuNiVRWHCNE7ApnZ5hzX9c7KredUfsfeEMRzQTj2FWlY4YSoU1pv3qsk7PcBIt4qciGsMfeZ1pUUAi2NIhIKe4NLuD2efWakCW6YW/7j7nZV4kJpzx0ywfvguKK6DZljz4iKDZ1t2L+UewNAkyZ/I8jC/rdZl/ffFdbNPBwCxL2eRckPpUzJeZpGvcMqiggMWTaIM/RGPUSuL7iPVJ61WRxbgMGcFIHhO9TW+b1pW/SNj1OYrzXLzex7c52pcT3+kDj1acdNsY1e4RgD8uxGENYTy6raDnn3WNfdkn8 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 16:58:05.7149 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6b7e76a-ff31-4e31-cca2-08df3126cecd X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000527.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MIWPR08MB222869 > migrate_set_error() stores its own copy of the error, so free ours. >=20 > Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with = MADV_DOEXEC before execve") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D1