From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169b6ddb8-c710bbd1-7759-41ed-8f1c-e80f4f35b8bb-000000@eu-central-1.amazonses.com> Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021131.outbound.protection.outlook.com [40.107.130.131]) by lore.virtuozzo.com (Postfix) with ESMTPS id 277DF8017D for ; Fri, 23 Oct 2026 17:02:39 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aC2+bS/YVBtKdXM6dJ3bpBIM2ji7mNwsRgQ1HFl9R2d99QB2L929ob1r/Xmqrn6mx2E3NwKXANr69RvkXFoRS3Wpu23okUR/sTzjCAaGSodbvWXK3yeXG87BhLzaL2ZcEe0520dzCowqjPo4anF7NHthIlINPPlKtDSunEVndczvKobKI+a1jbbshsHettG+qthyZbb3epRUdSeOonfs8FGhhU5KKMS/y86ViosxKq1d5+rdTDlLkN+t4mVMFJ6gDFaAr2VlNvTXrnO1OT9cO8His4pVrdeZx6zjb7dpoQIQ/o40x4RM1MUQNH9nBvVGJdfW2rvZUfugBU11by2VNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hXh0T2lCyb09NI03mWeowYJYpfGe4x4sb2X/zKq4PbE=; b=RwpLuMmC/q4OcH/no85+g2RimJg/Aq1SjMnaNyjhvbqIU3+lYNSeHTYvcWR047NRE9DpxqZuNZIO1kf5iiQT/gs9IEoXgRAGt1eOAJZ3YvgVxoemd9COcuFrzoG3gKuHRbLAfyQ6uQWmcvzQokXHi+eh3Na2rMd0b0wz4B4pSVp5Y4ziocSh0kq8cFzMTTPbGfOACboaSONPi/sdQfDVsx6YHradQuCYF4BqgtaH6FWDj6lBjM8CnZq36ESVEHhvEpxfaKDfNNsctVB7rE48K9I6sGr8hObVEdutqmXqPjV/GDOdZSYjsCmzH2Kl3nTYDQBMPjuXgUy5X6PJrFTe4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hXh0T2lCyb09NI03mWeowYJYpfGe4x4sb2X/zKq4PbE=; b=YvoRiYVnsP60VtrlbdZ1s1rI+iRxaPutXfwjg2QLuNK4Wkojm2o1aNw8QP9LgKgXuGuyIPvz76aINdJDQAXM5Xsg4SINXyzkaSoZRIh9FE+zf8eyrgAgnSorlowLDbp8i6JXTLuF9SWQQfis/axFs228J1XHSYYbFLCCjAfVH1Q= Received: from DB9PR06CA0003.eurprd06.prod.outlook.com (2603:10a6:10:1db::8) by PAWPR08MB11194.eurprd08.prod.outlook.com (2603:10a6:102:468::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 17:02:35 +0000 Received: from DB1PEPF000509FE.eurprd03.prod.outlook.com (2603:10a6:10:1db:cafe::1e) by DB9PR06CA0003.outlook.office365.com (2603:10a6:10:1db::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.18 via Frontend Transport; Fri, 23 Oct 2026 17:02:35 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509FE.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 23 Oct 2026 17:02:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792774954; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=iKnAxV/52B//QbzATFsxG/uNTqdjCauf5RIkk1A5l2M=; b=2dk849UsKL1RKNOBkH5Yw7T8vCiQlwfzhTEjNM/qa0oy09NBu36MIY5zpxoWmLFY 2UNURbBOYIW3QGRTsFvZdBgV7+MtPhKKK59cdatKi8yRHih8S17XjOyiqmnWDiUUxWz eq0Gw724287PFqn/hDJqTjdeLlNQxHeEMabS3TYdPrPH6ve0O3aK6Sbcfxx25mMcUKr vBS1sqodORrftJKcEgvJ4CdLFfSIXisSi/Ad72KgeOELfcXwfQ+FWysljt2X5IaiG3m uA1wHauuNyd0ZXUn2wl6RYFeIBnEj76Ih5WYS3uDXPBWF3+Kz43TckuqrZ3UTtuFz6h gElOYRg1Og== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792774954; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=iKnAxV/52B//QbzATFsxG/uNTqdjCauf5RIkk1A5l2M=; b=odqSyXYoBLGuHsc28jVZXv76drZCH42pX6A+bboaGerl8D/K2QyTkknaLPPRSOM/ 1sAG4xiiUNd+d+iCMahkiOeLSln3+6mBmCiZo7G+KuCzt2Osg8r6YldaYnwpPZtDf3I /uO7fQGVAK6ItmTXWkU+RWIeG0DPgXPK3eK+YR8U= Message-ID: <010701a169b6ddb8-c710bbd1-7759-41ed-8f1c-e80f4f35b8bb-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 08/36] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-8-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-8-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:02:34 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509FE:EE_|PAWPR08MB11194:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 14c9a0fa-763a-4d7d-6eb4-08df31276f42 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|61400799027|48200799018|376014|261021121427099003|4113699003|5113699003|16102099003|55112099003|18002099003|22082099003|261022105027099003|13003099007|4143699003|10067099003|261009223027099003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VWRmVWdKaDdEWmNOMjdXY05pMkt6RGtaamVjczlManE4NHk2bzYrWWdxV0kr?= =?utf-8?B?clhXTmV4NGVJZkhnZVI0MVNiRFlwSlovbGFwRlZIL1ZGRFVIaW5tazF1dVBI?= =?utf-8?B?UGdMRHpLazRGQU42NFA1RndaVklLRnVGQWVhS2QrVGZudXc3czd4TTVVcXAy?= =?utf-8?B?S2ZvTWxLdjlQeU04aHpVc3dkbTVUNDBtbmpGT1ZuWlUrWkIvc1FSeVNPL2pr?= =?utf-8?B?TUI2eSsxdm5ibm9sNEdPSjY1MFJGdm55Um00S0dJY2M4R1oyV1dHelVJODBa?= =?utf-8?B?ck9zdDZzUm5GR3J4am1TZkFFYVpTRk1HaWIzSDVQcHorOUxIWGhuN0FWNUpr?= =?utf-8?B?M2xQTFF6cDhIUThTVTAvNGY0d2JGY0Eya3VsUzR0RkUyY0hBSGhrdlBxNDMy?= =?utf-8?B?NTRyMGE0cXJLcGhEenZvSFZIWVNRS3g0N2EvZ3Awemx4c2QyUDBZV2ZqUXov?= =?utf-8?B?YXh3UmxOM1dhTjZ3V0RYTDFUYXVsV29sOTRxT0pMSjF0ZEdSaDZEZndFV0xU?= =?utf-8?B?WVlleVM1N2JwZkdncGVNbmtTRElETjBCVzM0azJrZU5UeDdCbnpjcFdqWUhv?= =?utf-8?B?WThVQTYyb1hONHNnaFo3cEY2amsreFNMbDVrQ3dhekRta0s3OE92Z2tScU4v?= =?utf-8?B?SnNKTnhMOFYzQ1R1dFdLb2FyWE9mWHlRd29mRmNMcGxmMFowTnZ6dCtuY25i?= =?utf-8?B?dy9kUHZxalQyOW4ySEFHOUFxS2ZYSkJJNU0vZ1E2NEd3TGczRDBDMllnV2hG?= =?utf-8?B?MHNEUkRzTzIwam4vcXU0RzdyeWlHSGFuQzRqUjd2NmlSd01GWk1TeEpjTVBY?= =?utf-8?B?K2tLL3FzcGM4MGFob0MwWkZiS01XZ0tsWUlWRE96akhqTkw2VXNMdFVNQjNW?= =?utf-8?B?dE5SdlJRVG5aaXhnSk52WTZzTEt0Z3ROSHpwS2Q2ZUh2WHplcXFRUVpBbnNJ?= =?utf-8?B?ZzFEeHA4aUFsMWtBc3MwVWZMRXhQQnprekNzTGRDc2huVkFqM1FLelRvR0Zj?= =?utf-8?B?MGpON3d1ZUxia0dBTlVlSkJmYWhDKytrQWl4bFhaaldzeHJLR2VramlRbFlR?= =?utf-8?B?dWRqWkFMT05xZ2Z4dHdsYlkzRzlvdG1NcTZiUS9pRnErclZXNThCbzdnYkFm?= =?utf-8?B?MHl3Y2JETzJyZnpWc3V3WGJhR1RhZkRBZDRScTVuY1cxNUNvdTgwQVZVWVBL?= =?utf-8?B?N0o2L0hBS1BQMUE4djZxUkNTamdjVUp5VWRONmtwSE84RlhuSGZodktEejFK?= =?utf-8?B?Ukc2cGxjeW9hcjN6YUR5aVVJMUtvcWlyMUV1TFRuclEwWk5vNlhsME5xb2Jp?= =?utf-8?Q?0IMLGQ2zOloxcU0lVxigkoRkHAa7/KnKpq?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(61400799027)(48200799018)(376014)(261021121427099003)(4113699003)(5113699003)(16102099003)(55112099003)(18002099003)(22082099003)(261022105027099003)(13003099007)(4143699003)(10067099003)(261009223027099003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rV7hcbgBA2Kt9ahmz3U62wjJNx8uKzthyvhj54N2O7wPxlh4Gvk6JSmlGPgtCbtR3ZUkjULRORW8x1WJWhEh/IIOGOHFnY5BaoUXbLCVfFcAFnO64g51MQJD6KNyqkeqTfGkfBF5Gy5Il5g4ZLBY8KEDlGrVgdYfWPtrLHrB04d60KF9ZLgIW5Q5ByHmj++t9kqLfSEN6QE0OlrOjc/zCwK+T9aZ0Q4QD0x0wDPJqTZn29S4pPwGxvSRF8td0YPMoId43kYqFb+IjzLYD8kCUwt89eothvUlNGCWxTKlthPCRTvDh7Nb68q9t1LKHIqnKC2F4CRqdDSeXpECyDdKOTAWEbwObn5nbOmwORHM/EcY49/rTFSEb+YmHWzeJyTD3Ryytvsa6cSF1h2eiBQU7lwdYH7CZoRyoy/VX/dHricvaFiMTOyCl1DMexxzOWtf X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:02:34.9067 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14c9a0fa-763a-4d7d-6eb4-08df31276f42 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509FE.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB11194 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D8