From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169b87fc2-bcb717a3-2ae6-40e5-b07b-be3141cf3a0c-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023126.outbound.protection.outlook.com [40.107.159.126]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6E9CD8017D for ; Fri, 23 Oct 2026 17:04:28 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BtnobDq1U7tZwQACJJLAZ9+XW03L9NDXoOvIlpxttIg5+ghj2uKPqcKhZ+kVSckJUeTPbIfBKAcP3kNjAmR+DlXJxH1CXuUc+TkVy+YK9hDp4R0ex/xaz0+G/2ulRTYSqXsQ+hUfAiWOlO0qlkJf3YPMOva6oSEFcHC4oCJaQwc5iK+OB8KKwig510C0QJRKVQxw80wsCj6YR9V4z2WEw25wh6w6JbYdyGCEvbSpLQGx7ptxs6i+nzfI63lLh/88Z8Pk0xZBwQIoWiZsuGXGRsfoBu5r/T00V1f91iS8lV3QGK2DVQCjVNaNXoFq9gE33iLFsQcx0gfDCJTvBZbl8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kAE5ch9D0GkS5CiSWEMNJ6nPcIFOArEfY/6vWgLGKEc=; b=S9aa5qE6+tAaPjvRVwCgceDGKhUJiqd9kQ2YxYsWah2Gscc8awmQR+5y6f4lz6YR9lktO/nP67YxWfQNByyeLR4YNfiFgKILULBKWQFdYbDjVql5p7Cc33msyexGfFji9lzmESHk/vLC+8ny4QbjVdYYHABlLxnrKZFpoYCDCdHr4pbbt5zzDXZ+oJHiHz5UtKWzD4OI8tHKa5mAfywMY8weBZPVVxv68BLtIDJSO5X+gB9w2y7Cda5b8TEeizY5VyXBQDjQBdEa5C3sJt3doVYodAmT/uzNw3sXIDpsOQcLlx4u0Ztn5C+MBq4XvSYecG3fhgyCQcCW+rWTSyWZ9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAE5ch9D0GkS5CiSWEMNJ6nPcIFOArEfY/6vWgLGKEc=; b=HV7eQ3ifvN3fVFQK3T2PuatO4iq6rzUz5sabcUz4Aj/2sQfLFZInTz2GtFuS5yNhahdemLyLeIIhLxVuzN0wdKDLgScLG8v2E8HQcVrTO3TFStoCusWBjl1sspHILQ6B/o06KGBWzNat5Zn1V48BGriVOViimbVFhQo7CQX29fs= Received: from PAZP264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:236::31) by DB9PR08MB9564.eurprd08.prod.outlook.com (2603:10a6:10:456::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.19; Fri, 23 Oct 2026 17:04:22 +0000 Received: from MAD0EPF000008BB.eurprd04.prod.outlook.com (2603:10a6:102:236:cafe::a6) by PAZP264CA0192.outlook.office365.com (2603:10a6:102:236::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:04:22 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by MAD0EPF000008BB.mail.protection.outlook.com (10.167.241.170) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:04:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775061; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=gTIDK0K1d7KMUHm9ie4Q+OowTJ/NwacM9g59Wte2WeI=; b=QrQsDbbrkDCqgXYr2ptdqsE9LeyOwQQkN6RjLJTUEOTWUgj6VHFUQ1k8W2fo7QK1 qfPHD6mkwxtQyeYVNrmRFPrOfRou9pnkx40GM0jPH6BCyM3YjMNx5R7nvNI4PeEL7BP x3vfZwxM4buSlVASKfOgvgXarBJ9sjTceR9uewU4PppsOjgFmztDyJxr8ONUtIuiZsZ hrsKXqIDgAfRRgJJ2LjfA2Hp/lI+Rgt141eM40UCXEk/7ftgqiLR4oGR1blfg/g4zyE 6xu37t/LI7Vks/AUjLFZiOCyu+KMqlWbH9jqiKsGYhYnEWziDctYooNbpTsv9r+JYL2 U9UgXYsZdA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775061; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=gTIDK0K1d7KMUHm9ie4Q+OowTJ/NwacM9g59Wte2WeI=; b=LJWcOmGs31FRHS/XHBtr7z0R1yKJjCGS/G/aT1mRZpxWFXfRJXa6ApYS/5D3+0+J 3BqfaN8zVkHmNGcD3njkIT6IPmOeJ5Cf4ape6IxoiKzwR0YtgwV6Lm5GEP0QMwYd8vc gstYR5TXUSvXDIviiIc0TqyBfNd3lEFOi0fe8cKA= Message-ID: <010701a169b87fc2-bcb717a3-2ae6-40e5-b07b-be3141cf3a0c-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 09/36] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-9-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-9-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:04:21 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008BB:EE_|DB9PR08MB9564:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b1ade941-650f-42ad-9b25-08df3127af11 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|376014|48200799018|61400799027|55112099003|4113699003|5113699003|22082099003|18002099003|16102099003|13003099007|10067099003|4143699003|261009223027099003|261022105027099003|261022075727099003|261021121427099003|5063699009|260925021911599003|56012099006|260925022911599003|260925021311599003; X-Microsoft-Antispam-Message-Info: hcD8AODF6vp/PIyHxJ00tvD6mhJNfc0zRdfBJAnxlquHCp0FNVmYH9cJOxNl90hHxgzggIktKypLOYs2iGqU/L/Wqdu9/4cc8CF63vibYvX4/Ca3RBYsF3SzZB+QidKYukXU/4OV/PbmGtUh7Nq6iUrGO7netFRuvT3R1xp8sVRDrLqMMraJBcBby1y/XlD2g7vop+on23Nr0NcrLHAcdBjOSmpymq0VJUAj0H6PfFO6VeWEER3430yiwmORh8tTaIHdwvrJ2AFuwe9qt1JOLF3nKfMoXTLtPkVzuXuANWSYK3vwRSYO7z9NUwSEYdQH9usm+ygmcdLZdVjdJQV77zYNZmqzS/59xJTaZbNB5rblEmoc8SGJS+enGZ9vi6eBxMapqCs4R80y4CsEBHpN41Fr5OcMujVm0uDpXiXzwbmgmpqqn2k335PHKHI4lYPJpY2yqizvqJJRySGjLVsfOM+UneM+YxqKxQef/NFvGIKRriM/lxLL2a8dJABJXv1fOrhEl11HraTRIInn3ECes9d1DnQDdMIDOJ8KSBZRZg06/Igv/1KXRfnAjhY6QKsapZcWQtpKZ1W+qZ64a6mY/UftqaTinQWRnnLyyF2ZidxAfivqmRXtGClHdiNo3r0oViDPDrA2X47NWd+qbd014H5KZw1dTI0iTFO+sHIpMQ18em372EsFiDgtrDwnAsFQvXCPe+pjQKLBBdprSfs1VwAdkZTb4SvE3roJhQ0rHA2wNdi97ruh8O3CLsUKandPIqJnc0U2Sg5WRGShrISjk2/1xwaXbaoe2MW/0/DJqSr/c61TdKPBt1r/uTju76oAkDUcUffDB+y6s5HLU/RRVCz3u0yjNjhLXiLjOJevveBDx24ED0LoC1ZP8eMHHE2IVTb9gh/l+dTZv77GD0f+FtkhAcORtxzQIkn9z9eiSWo= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(376014)(48200799018)(61400799027)(55112099003)(4113699003)(5113699003)(22082099003)(18002099003)(16102099003)(13003099007)(10067099003)(4143699003)(261009223027099003)(261022105027099003)(261022075727099003)(261021121427099003)(5063699009)(260925021911599003)(56012099006)(260925022911599003)(260925021311599003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8XAK+tWcSb034YfsrqFN8Cop78LeEzfjO7IJ4PNmEXqmcoiQpytXYlAiAPdG5qHKr74cqKKiQ7GqVLxHA43B25dgvGyFv0LSOYZcZBtZoV1J9TnR8kveVL64XQ2s9EE65t+C9uUZhQP8n/dhf0T7xPV0xr2S0yef9acVCKgJW2SLC7EK1v1HOepoaqYwGwrNv5+UsyaTeTGbFertlQAf9Op9x+hAO83fKdH3xeNIRsG+7nQaZEc6hAjQa3xjrfCxXeqVHraxenzT2bROvbRTkX2plehcnj2xnqNE1BdGzXYsmzsvyd8DQgGoxBZywZ/uVsZHKWz7eSqXslmhsPL47WQ60qPS5IQBIZFWs/8UqCNy8Od/Fms6YFY1bDbFs628NLAKYnr17q9pD4F4x3XQeMHcCi6F+uanDgchHwXk7jpW0VfzLtoWBUpR56YTu9Pc X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:04:21.9582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1ade941-650f-42ad-9b25-08df3127af11 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008BB.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9564 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D9