From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169b9bfcc-1a0b8201-8748-4f99-ad55-da3efbe8197b-000000@eu-central-1.amazonses.com> Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021103.outbound.protection.outlook.com [52.101.65.103]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3E01D8017D for ; Fri, 23 Oct 2026 17:05:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mO7DolMVMCop6yLt7+LOsGoRG51zD3xWRzDO5DbLQz16ctaUefbOQF0MScvu8hFl5PW3bc6AMyw1NqXkrY7dV32tQK3CcaG8OwEY0rfN3xAei1WzJR8tlkEqrPMkX/5XcZAwZxxvSj50ZTSfaQeXpb+pi2GjGcD5f8WcmlSH7nsvvdEau/s2CIa3ungKrdCy0cQgVYgTrG9x3AClwmBcFfoqiwEpnPY71frvtjducL1EGfDBV942vXBtVG9a92Vg11g6U+sQCfHbIjYfktCstJAndwkyAR9SIbFJMMQNtMnKeDX0kSFX66JLsufCMsDkqrQetTzRC3FwZNyBKrCUMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PjQ21bPZzH9gvHK+S9yWNJptcTY+eszxE8CLw1oCfOI=; b=nrlb+cjsYdrAopOZ/ziMfD5fpiTWcGGryaYgua0uPTvHINca7SlIUo74M1VIzmDBkCgbxl4t4g0C7OIR8lsDSOkkCLNd27Wi8IbEIYIAmtw1l0o22BZxirgRWCZS1AX1w30BQH7eBx+3LQa7Slkr+bmGT2y9/enf6zm+gjsaV8g0sD88bSvzobMxSJPHZlSx+eRFqKQ12dTSFq8SOuAE7fGCZHUZN+aHmNJk4j4yQQn8CiKsQyc1pvC6+qi9pUyz8Hb72XrTUbdUwng5xIFk70NpDdjryzk+5gSwVwFAzBycZEoUo3x7iMWmXDaK4Z0iwgyyCCLhdAVCAdQQQUT5vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PjQ21bPZzH9gvHK+S9yWNJptcTY+eszxE8CLw1oCfOI=; b=KRmB75p4YRM8Pud7oovN3l7DsYH4RwNjjwKeqFQSNWJVI+HrP2dXWXpMtkxc7I/56cWVWbBNi/NUxDFGXTobTk5F07fNlTMrStjKRob69Q4rjkwfFRCQcUUluzyaJwPdAMVSpWYHmw98rQgWUfUCs8NiVbxOc3W9r78AaViCan0= Received: from AS9PR06CA0123.eurprd06.prod.outlook.com (2603:10a6:20b:467::14) by AMBPR08MB11914.eurprd08.prod.outlook.com (2603:10a6:20b:761::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.18; Fri, 23 Oct 2026 17:05:44 +0000 Received: from AM7PEPF00000051.EURPRD83.prod.outlook.com (2603:10a6:20b:467:cafe::8e) by AS9PR06CA0123.outlook.office365.com (2603:10a6:20b:467::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.18 via Frontend Transport; Fri, 23 Oct 2026 17:05:43 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AM7PEPF00000051.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.0 via Frontend Transport; Fri, 23 Oct 2026 17:05:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775143; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=CwLkCXokV4e/mShr0QAAOdXswcoye7CaQpKiBsmbrE4=; b=rt8KJOeiDWy1gvZkqeWHU11X6e5sTHbfVOPynowodzHmiq1YYJ2LhhDkzyfmMMYw hKMSIc8Gnb6jBJPH/H7s3MN37Cn38euCnakhFRuQa4eEyWsnU8+PLkIo1gwYmQ6lXWT e0/Hbx9Ldc2sEjHOMEjnyT26hjeN2RybDbXozVLsr9qSWg3NvXXTZQueW7XxE6Wpgu8 kjaacob2eeHfV0xjxPKFu9ElqyPflMnBmUKBFGsngAAbRtRErJrZ1AdzU2iOi2Ry6cK XFA7V02X4i2D3DIeLk9RWOpNvqftByIb5HXQSwbeHnjh7aYaKo69MVEcx+syl/OsAhf xkUSCtthFA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775143; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=CwLkCXokV4e/mShr0QAAOdXswcoye7CaQpKiBsmbrE4=; b=hdHNknnx+XLIzRvkxEdXgrncVKjGuiHp7PqnfGYn5x1ou2xIBlindqtr9E7NRyTN bwwUkwAvEI3qUEHnFO1v8gHt8tXGmbKLdjTBIWCxE1VA/q4iJP+GVCV7KV7lJBe4mL4 LCJ9h02+9EG7kkUQb+JLJ3nFXZVrQODWAM2E7pxg= Message-ID: <010701a169b9bfcc-1a0b8201-8748-4f99-ad55-da3efbe8197b-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 12/36] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-12-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-12-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:05:43 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PEPF00000051:EE_|AMBPR08MB11914:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 579b90eb-088f-4a2a-c93c-08df3127dfd8 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|9140799003|376014|48200799018|61400799027|4143699003|56012099006|5063699009|261021121427099003|261022105027099003|261009223027099003|22082099003|55112099003|5113699003|16102099003|18002099003|4113699003|10067099003|13003099007; X-Microsoft-Antispam-Message-Info: +pN8cq2HtuE8n0x8tFwyTYmXjnTu4BmX1nErgWhgHV8Vt8pIHdtsiqZJDD89Jida2D9gOv/SshQL6njVCNrDluj4IS7AV2pdnaYeXS96A7X4PujKWmvUicLH+akNP92J4phILYmGTMO+L9mA67LfTqVWL1kJdWwI907VjuwSZWTSRDmwfDIKV6ZocHXnPXW2uxPsFzOKC5bRDGftoREd0vh9/v91vNhkhBk5g13pc8b+CKHFFhhTKDJiolz0y20rfBTfh1N7bI5ZdK4aG+IQbPzawPnI82lhrtDZRicZjJysuUafhzyBKa6UxEqYf/nmX08LVnTR9M1ZkeBK/YSEZQO0uJs/SSysoarsVFyvTzqOxj9g0cjFJUVfDtAd5sQBJqpfOJSjjDtNsSjqDPeeO8ijwMyacQZmx33NjtrAewDJZ7uROL1MkO33o0FMkxCK9T3QL/AbBN5uz+OoYIXNiSRWJWF6cCNVk98CKWRsW2+p8UIkWfkW+Fx9wuq+7SKCUvYghBWPURouBx60yCqyyAqLvDUJuDOTRctx0R+RoTAjx7q/dTDWNGpY7xL8u7JgZPBI2IwZ4wS0+n0njoDz2gh4dKpMvABj0MbUBb74tsZLP1eD1JBJda0kJylbmXoE5FrirxKNjAMwJ/cFMsDFUBIQW7h4Argto8BdiS+uhFwJckM5H78xB1CXlZqbfZdXPq2wbYtqZ4HA38w0Z0+wmwq2kjW65lu5ygDL3C28M5J8/+ULDryBkErHiqCDZ0JQDDMtODfmDXzdFHZaK1QRREMKdyqFczbfBDEE8IkoOQle5obiqcvVZZ1Yrph2A3MxVOViGyGVWbijPfnJkHhetfoVBXneQ5VFAo/Fh+zBgIw= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(9140799003)(376014)(48200799018)(61400799027)(4143699003)(56012099006)(5063699009)(261021121427099003)(261022105027099003)(261009223027099003)(22082099003)(55112099003)(5113699003)(16102099003)(18002099003)(4113699003)(10067099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1AaFtVTAYy07jltrfg7R29ucVY+LQIipU8v39qN6t6fICg1Zjlul/uTeZtwj5Z1nOXA5dkN3Ak4IcruUQxg0zc0+ukVMZNp08q2awNqdTWbR+DBry6EKx1RwFQ44Chyy02LzYVktxbhOtDZ1i5dClZTqfxVqA3oGinhuLD+CIGhZeS/AZBwXNXqikw3LaTBwdO+J/rAR/7ZP3tT5nC33yS/+bY6iH7Hq7sV4O/cd1vWaKyQyOgrS5YAfin+rDOIGN0xeg/2dmsMvIkx+PhX2/RvZvym6EfuQ58soUCy2Jftf43pT9N6s0j6u26QkZE7ZZJ0WaAMjipq0av3abNy4zPqh5MT+yRIpNap14RSQDPLgBFmxb48Dr84NjZVU+AkFqGzimxu/F/A09mVSeZzpKGenFQuP8IumHjxbn2EvZJIQyEP15FmrTVT33MVlQyQk X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:05:43.8176 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 579b90eb-088f-4a2a-c93c-08df3127dfd8 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM7PEPF00000051.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMBPR08MB11914 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D12