From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169bfd366-60f45de8-6061-4e5d-b545-7a71e91d09d0-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020126.outbound.protection.outlook.com [52.101.69.126]) by lore.virtuozzo.com (Postfix) with ESMTPS id C2C3F8045D for ; Fri, 23 Oct 2026 17:12:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=na6lq6RzCMr3PW883Ox5hpgISpM6EmJaP8MCa2I1GEFddeiGiuiMYMtmkbUXQXiMP1jwwvXqIPiDFvFVico58sL3os3vQurN8jO91nVnHjJ3xpWclioatncwOzij/XTHW7HhMgUYtblNhdOGV0XywLXxG2QvehVw2Cqc2jHQD7a6oT/DwG07+1i9EEdTop7W12/hLQlD9Mhi/xlWq/Mxp1MdmJfbux+W9eKVBrNUuW5vYs/ct/JvueJf87M2Pvlnqke9CLcZs1SGOlDq+HTEGp4xtU8gKwwJe2awJ97ZnwP52oOGAsiWwCyzZGoIBZMX1qfUy/hQXJfFgxZH8Hu32w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/kaPyZmh+dZzN5FsdToVNh4Evb3Oe+ugpvgjYzhO+NY=; b=BM4TEfg9z8EEy/D7Eo1LKrVc1Gx3k233TIDSKV8+yQTpoV2XG6GhrMiObW+ZDG2/edoEToxDee/IJRQsPVXyX0Q93DJ4XDD4FyjAsVLGWfrZUlsaHyiQlJRz1SrbOb6wkTNCkeb97vJ9iDuEJXnz5ISO4vOfzt8YKFVc3RkTTKQVk59UEsSC+4PFKP8Q67HJtqmTR+gUm2l3meBYJTKgcjHE+cDJjgt32CKs8gZvuIF2J8hNM1Xv/Z9KM62qtsb8LnVAPpl/uKbNMsX5e42N+by7mwk1h8f8Kou7es39QXtpp7Qk8+dPa95eDFIaeia+uMaI4fBPi98pmrg3zdfluQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kaPyZmh+dZzN5FsdToVNh4Evb3Oe+ugpvgjYzhO+NY=; b=Nx3WrPLAvi1Dojq/1UBkYZKQOkOkFYE42zxc5klMcHSh2ivp/pP4i5hhQVm2mB3YMBqs0yGr+tB8EaYJxCsPRlxeEVD1HT2UV/4sIIbfgEmewKv3dD8ucp9IL255n4IESO79wlwyp8+hK6/pegAU+3z3C7BIK90PPHFukj/phCg= Received: from AS4P250CA0016.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5e3::8) by DBBPR08MB6267.eurprd08.prod.outlook.com (2603:10a6:10:20d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 17:12:22 +0000 Received: from CPH1EPF0000051A.eurprd04.prod.outlook.com (2603:10a6:20b:5e3:cafe::30) by AS4P250CA0016.outlook.office365.com (2603:10a6:20b:5e3::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:12:22 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by CPH1EPF0000051A.mail.protection.outlook.com (10.167.241.229) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:12:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775541; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Sifjg47nM625d9iqCeAsOi6Y14S/cI8fYh4/Ob4pKe8=; b=l7HNeQH5DXc7lBRdw9ZTznoQb+khghDFTx0fK+Ek5cYmp3KZQEUfZQd+DpEjgu1K w8bSPvNA/c/Srj0unD9GWaZ4tW3hk+Ba4BVMf6TI2W8e91/HpWFPBXRtM2S9eEOYcQb ivGg/LE36S3vWeHZGU1KsH1GMmNEEWR7Ac+RfHGDD9oIWEBqvZnSGq42WJSwnMYhNsT ClHX4FlfzHWQoEeS8hO6szcrJY8I0KQQ625ZtnNKExBZT9Paq4PVNJ1LCibRAUT+qZ8 N7Q4UjGT0Cg5pz7h6smXeRJ/NKjUUi1/H8oN5NqpQEqdkzV1YYVSNhhmN6K5fVEuv1k 6RqqDj95cw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775541; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=Sifjg47nM625d9iqCeAsOi6Y14S/cI8fYh4/Ob4pKe8=; b=f1FsVo1tGxQmPqkcp0vF70A7GdRYROLcGQ7pRgUM0ddVIqBHetLaO479/Y6ey9yj iqVHERMM9bK0Uq1PvzrzJbECb0cNZzoLsse2UfNRD6N/GzD2WwkkGWjUVrjgfgw6tQR mdXjKgSAJoRYOKmzCFOu9W/vvAlGIhtJkF2QN6iQ= Message-ID: <010701a169bfd366-60f45de8-6061-4e5d-b545-7a71e91d09d0-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 19/36] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-19-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-19-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:12:21 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF0000051A:EE_|DBBPR08MB6267:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: cd2951e4-1311-4c60-0169-08df3128cd2a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|376014|32142699015|61400799027|9140799003|4143699003|56012099006|5063699009|261021123027099003|261021121427099003|261022105027099003|261009223027099003|10067099003|16102099003|55112099003|22082099003|18002099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: 0zXQ4WiswaJNput6JMw/+jS9bS8lt1FoHgvX3Z+u0uEW7uI3vobknyfh5im6usmFY5ngQP5klkClbH53n+povgm0wIpVhIJjZPxVNPlzokZnjgzGf5pf9hxrINlIO0IRfOaIDKyqsvylCL8VWv3iM8IuASmutZURGvU4oiqaaXxg5x0omyb/nf2X8KAkS6mDT7iKUFFpeXFI+CfKX5ecuFzYNmIee7qhg6YDbrBePpsuTStB7jO5My4987PL79ktY+AIODaIvYWv0PMiYAMlZkyJ2ZoYlnESzeUjQhPOrlQ3zrvH0y6Pux69DZ2YMCVULPm+26/xxLCFQOdMTWbmkGD0mRHi81pNBQpsQBPcuUr0XYmvBU5ZaT1jj0ZznVJY1cQ2rO0cVvQWUlugEc44+3sqiqLK099WBmSpDlQPQn3bpOqVWcbcTQOl9wMB0gQu9xDzq55KO9nO9iUavbfhDUk/YC2a0qjUCv6KtXJ+cnq9oofrTNBt4vyuKRIUqBBHmCIs2A74R2UM7F3Ed3XqYag1El/cHZQorCiE+1hMx6pC8GREsEzB06ZQlZ2K8MTKmDaL0sreTjLXdtZB/jGlgOtqrOdB9HS3sQ0mal1QD563WwjjfLUY3PXxTfKRTHVJTcRetTZzkmE7M+mZ/5nzMzSI0kZ9cAcOPQ3dNHXfedeog32p+3M006rS+IiFkQykCm1cNU1z7FGAlhij3tX3tP3pcQpb8tLQBZfSESrcbA3DonAe6/fxjch+INsH/PQ1KwM062hpKUm66lXdDIQHtRDuYLfTShcgRivOa5iM8rvg31TQD7b9ijSgdA+STFdB/Md/lu4GClfgbQKncO7G40MW2vwc5MMCFLsXRGkQbogoT6edUJY8I2yhBFlYL/G8qgzpPo0+mbOTudOMr0AVjZb3lPCwzD8lP/KElMfXBXTcsxsVQgtcE3fc5X/4heo4 X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(376014)(32142699015)(61400799027)(9140799003)(4143699003)(56012099006)(5063699009)(261021123027099003)(261021121427099003)(261022105027099003)(261009223027099003)(10067099003)(16102099003)(55112099003)(22082099003)(18002099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8Mm0craFH27XxiFcmpVCNY1x03qEZ1dwo8nGM0CHc7RWC0mU4QK97Zj7UkUqJK0Lxz+Bp4bd6mQ0T6D+vEA1QwsTuoFnbOHY2ybk228qVXtEekLEUnrR/F11I3Y3PYbpFa/XGYp2dbaIUus18+e6rgEcPXMCYP4Y8zeH/HA3edGasEImYwILLhh/no5Bjw8WhZVGjGr6U6h7/RwiLINu2DX75NclzYEiPI9kFCnXzvy/Crg2XdM/KDaUsNIwGfhxo5Jw5sMF34HgIZwodfTMsN5dWU+6YnD/+XCyyn7F87E6zDZP16CSmGnMftaOfpxbXSZxqX1cpN1Ux8GrTsO37J6dx3ZNYPj8Js4FFsyruJiGXH1bjPVrBp2DmXJygubhyud1oUuLwjM7Toj9vKNlKrQL0XJLDhO9yPOdYTOWoZlvYg9BxtrNTbO8/X9NoLgP X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:12:21.8670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd2951e4-1311-4c60-0169-08df3128cd2a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000051A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6267 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D19