From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023097.outbound.protection.outlook.com [52.101.72.97]) by lore.virtuozzo.com (Postfix) with ESMTPS id CE3528017D for ; Fri, 23 Oct 2026 17:12:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x/7NIfLIo+CUYfvERjyoPvnIBp1i8bgho/Jb98xHmOCo5TT7ojEAe3p1PKcdgZh/YFaui0TCjbyVLvepGUJ0SgKqYrgUbesKNAufCHYhXCFVWbLDhvWM+jvIAfZMPYNoSGL82TnnWxVP13ERf2Q3NRLLaE/md+Y9CkhAhpFDQUxOIMGeHgoBK9gMVwo+JdqLAFNaDE4RKkf9wo3PUQ43nfpCbAQpxJDlCNpim/wK2FWrBhYF2jb9KRsCCftXdwKnPfb7zN5KvN121llYwyFLGz5fY4OQT9FFFMbWaR+VvpMcHPo8Kl57KPF41Z6l+wjR/bc3ptVcKtL3h2S/viakzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3hkNMTGmwAsaNkGeUHu1vT2cIXkUkzLqPM+L4AMGt+0=; b=egu4QHZpAAPYuFiR6mJuQ5+upaMGYqKHHaq5PDgguAeIoy6sh8SZ8VVvIUyEoAyVJw3M1nqszVmCF+ZFNMAMS/rfJSKiAOEFLZ+ruCxytQFBSMtISfMtDSzcS0OVFthkspM0YYWwP0JKOIMBFbxgWGXKAFLW2fqZuVv0U+FcIiApGGTL9X7Qiy1BWhwgViQe2bEmSdXuZ1PbxNYHiUnNQpn3/GUH3aFDBrGOQzQUOTiSvyiid8tkCKcJ56Qy2jN04yTWvrhMK/dr4QtUc7OLfQAlfrwvF7TMZkLZxboDutageQW9tW/VkuWzPaAt3AhJfLr2RmU16WSNu49HJDPVDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3hkNMTGmwAsaNkGeUHu1vT2cIXkUkzLqPM+L4AMGt+0=; b=LCZTNnzORUnw1wAN+JFX8giVESjac8SRebX0zgCVOfAgwcsmRBVm4cmWDiZ+UAbdJ3eiTjNAutxdx5OXAuvth+hrOB49EPZqw+Gc22zT5K02Ci/jznqSRlZogwaOO/vh4F5mtKLuORbbS1Y1hZ7gPhlC6HftU+I3GJpqCptRB5g= Received: from DUZPR01CA0061.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::19) by AMDPR08MB417246.eurprd08.prod.outlook.com (2603:10a6:20b:748::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.18; Fri, 23 Oct 2026 17:12:48 +0000 Received: from DB1PEPF000509EA.eurprd03.prod.outlook.com (2603:10a6:10:3c2:cafe::3d) by DUZPR01CA0061.outlook.office365.com (2603:10a6:10:3c2::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:12:48 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DB1PEPF000509EA.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 23 Oct 2026 17:12:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775567; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=aUG/74zZFtDQpopb2GB1c7jbEEPHMySOjoH78gJDLjA=; b=T3RsC/gKUUrO8vXicPRebyiXlYWyMdH0+3hPSalk/cEtE1dhQ4lox95vvgT/8U9f wnsy7wp84ZYovCWlKfHFob1B4/e0xvxH/0ws2GI1o5kfEAQCtUbxZ5YbZQDK0yf/74E pJ0lRXwzWy8W1mawyb90bVrROt9QSIdrfN0EgHasmMzAhA6aoyQ23ZjwC1c/+5rq/7u xFKo5HY65zWxUItBqe03VclSOfuP4OJRP2IXTakufSCosApm0Cd+vxL/rSyT39GjPcD eYNRemy4xe/NadGy0vqox5p7xc1bvMFLGLdyN8NJAGqtIOLFpokpgYz1ljrnoWuYxSc 3flRJ4A2Qw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775567; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=aUG/74zZFtDQpopb2GB1c7jbEEPHMySOjoH78gJDLjA=; b=eYsORovattm/nyXJHtQWoRjkaOk3qACYVlcotnmku10vUck/JD3ARr0zlCFaKKyh qNEbQjzRLM8QW4vs+abTYzBkgtoxkT+JLg47U419iYT65ztqDXltfeKPKk33xqLAcJT q/l6YcG1dyK2r2koFHG07np7EoQ/R6F0roxZ7DNE= Message-ID: <010701a169c037bd-b63d6fcd-b8c5-4ebc-93fa-9dbfcd28a5fa-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 20/36] migration: Move CPR HUP watch to cpr-transfer.c To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-20-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-20-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:12:47 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509EA:EE_|AMDPR08MB417246:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 661ad9b3-6fe9-4cc3-127b-08df3128dc93 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|48200799018|9140799003|32142699015|261021121427099003|4143699003|56012099006|5063699009|261009223027099003|55112099003|16102099003|22082099003|6133799003|4113699003|5113699003|18002099003|10067099003|13003099007|261022105027099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OVhiZkdWZTZ3ZEoxU3g0WUZ3RE5JcGU4U0FFbWhpNWx4NVhjcS83OEVVZkx3?= =?utf-8?B?QklwVTNRUGRqMXJOcVUwd3BLdjdMNTJQUkhpbkFtY2p0Ri9MUnY2Y1kyZitH?= =?utf-8?B?L0UwQWIxMVJDZW1jQzN4dUxBdjU3bUdnSjZ4bkRJZFpjbkFNREVNK2J1c1FE?= =?utf-8?B?bktydFYzeU9IbEtmcGJNRUZHcHB4MTVrWEhiWGtTOTRlQ05pMUZJTXZPOHFI?= =?utf-8?B?b3ZWL3dzN3hqTEVycXJrc2JPZUtMMjd2ZWgycHJySXkvcExqcDdCQmU3b0t2?= =?utf-8?B?M3pXZkVJbGlzdWQrWUZxTlFZaCtaWndqRGNUUElwc0lWb0pJTzRncVJMR00v?= =?utf-8?B?L1dNbE1kMURjQ3U0SW1QMXZiMW95Yys5cERMTExwNHhVTXM3cEJNL3VXNldS?= =?utf-8?B?SzVXekRaYmxTTmsrRlNSeXZ5WWd0NGhBbzc3emZMZWRtUlRzZEpYZUFBVzE2?= =?utf-8?B?UVBvT2pweGZHdU4xMXZXeW1tZVU0aFNXQWVZcHRrTDk1bGVCL3FUcmdMSHdi?= =?utf-8?B?QlhQKzN6UDdaSEx1QWR4di9JditDL2FhdWVJNlRuU25aQi9wQnlhblpubmdS?= =?utf-8?B?UFg4YVpkeFlTUmtGSzI3bFNnajMzL0pzRG56K2JaNklpNFU5NTc5RGMwMjBm?= =?utf-8?B?Mjl5cUVNRlBYRmM0ZW9yYVY2Rk5jR3hKV09JL01mRndadDJ6citGQTBxa3lC?= =?utf-8?B?TURKSW1GQUZkTWowVUptVEcrZ2x5L2FLQW1qVjloNCtsN3FNdCtpWUFjUU1w?= =?utf-8?B?d1NTQjhNRTJKT29ybTBxZ2Y4UGkvUDdFV0hJckF2RTNCQmlBKzlrTWpWNWlC?= =?utf-8?B?NXB5YTNvUHQvZDNUaU8vVnh6bk5xOXUwcWpXaEgvejVlVExaT1VpcFJURlUy?= =?utf-8?B?NDVtQThXTXczV2NCakg3Q25LYlBuQlc3VHlpcCtVa21kR0NaVFdWVlRBMnl0?= =?utf-8?B?UHk5MkJhZVp2K0pqWUI1M2VHWm5PaEZERTJMK1VsQXowcnljcW9HMUE2MUEw?= =?utf-8?B?SmpYVnNRL0JDSnVyNnJxY1c2QlNaT3lBTjBOV3V2UFhXTXFObXBwb3MzUnhG?= =?utf-8?B?VStaaHQzWmt4bS9DaVE1QXBBRE9sc09vUmE5NVdFUXpmZjI0M1FqUWxWbXFs?= =?utf-8?B?Z1VWM1JLRTZJR2VSZ1E5eDR2NEtjTGx3dnpFTVlJSWF6c2g5WUN2eGpwMVdo?= =?utf-8?B?TFZ4ZHl5dStvSnJsUkxvZnNJekxQa1pBRkhXOUFFYVdMUjhSRWxEVDBGRGlU?= =?utf-8?B?NHU1dlo2QUxFeXJoMUVqSk5zdUFMME5PYktpMDRtTmUycDY0R0NGTjF2NEV1?= =?utf-8?Q?IUmixuTn9USGs=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(261021121427099003)(4143699003)(56012099006)(5063699009)(261009223027099003)(55112099003)(16102099003)(22082099003)(6133799003)(4113699003)(5113699003)(18002099003)(10067099003)(13003099007)(261022105027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7EBLSCxPlpvoLNt9nmuceo0pNMOTGeJKioZHGKfi6+Oj0m7jjvHP/rUY3D0O792Ch3ImbmRhdUvMyw0fG+CdgfVjqK0R77DORWh8NXkGqiWjdVNUUTVDAYaZim1tF3KA7DKK6ByN4LzUUMMJzGnhyH4E0IXdx/Qrn91yFcA25PY9QFz0FzCm+k8n+O9ZurgjZ4GCMXE0hq9s9tC8hBBxGBngtfcg2Gxv8wK2pVT38etWikfDm3s9NnXVgAS5K5UOY1MZgxAJP83Q99aSRsFvd3QIARZptoSmB2wn9aHS8k4FqK1YmqsOA57Tx7dzUxE710U1K6Qt1wJTNhBhgqNdAMW/QQ3KEA0yHr+i3FfRmZ9S5wnszdxKG47wBhbkxXUfGS0M4jc8ZWMjE3FNEmEPb/sdjyb+P+O0KD7r5aHIpvXEbO/kzXYl8YK7Mnbo3JQH X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:12:47.8097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 661ad9b3-6fe9-4cc3-127b-08df3128dc93 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509EA.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMDPR08MB417246 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D20