Re: [PATCH hci-8.1 1/1] virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] virtio-scsi: commit subject carries downstream tracker tag #VSTOR-151351
--

commit 6ce8922336ce923544c647be9bf402727f9af695
Author: Denis V. Lunev <den@openvz.org>

virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351

This commit moves the TRANSPORT_RESET/RESCAN event and the REPORTED LUNS
CHANGED unit attention out of virtio_scsi_hotplug() and into a main-loop
bottom half. The bottom half runs after the device is realized, so the
guest can reach the device when it scans. The bottom half takes a
reference on the SCSIDevice and re-checks that the device is still
realized before pushing the event.

> virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351

[Severity: Low]
This isn't a bug, but the subject line carries a downstream tracker tag,
"#VSTOR-151351". It is a Virtuozzo bug-tracker ID and doesn't follow the
usual "subsystem: summary" subject form. The patch is Cc'd to
qemu-stable, so the tag would also be carried into stable trees.

Could the tag be dropped from the subject, or moved into the body or a
trailer?

> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c

[ ... ]

> @@ -1163,17 +1186,10 @@ static void virtio_scsi_hotplug(HotplugHandler *hotplug_dev, DeviceState *dev,
>      }
>  
>      if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) {
> -        VirtIOSCSIEventInfo info = {
[ ... ]
> +        /* The request path ignores @sd until it is realized, so notify after */
> +        object_ref(OBJECT(sd));
> +        aio_bh_schedule_oneshot(qemu_get_aio_context(),
> +                                virtio_scsi_hotplug_notify_bh, sd);
>      }
>  }

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261026111113.145378-1-den@openvz.org?part=1