Re: [Devel] [PATCH hci-8.1 v2 6/7] selftests/futex: fail run.sh when a test fails

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/futex: commit message carries downstream Jira URL and Feature tag
--

commit 32515d0daa85b1e913c1fe888da07e4c683238af
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

selftests/futex: fail run.sh when a test fails

This patch changes tools/testing/selftests/futex/functional/run.sh so that
each test invocation is followed by "|| ret=1" and the script ends with
"exit $ret". A failure in any test is now reported, not just a failure of
the last one.

> https://virtuozzo.atlassian.net/browse/VSTOR-134205
> Feature: fix selftests

[Severity: Low]
This isn't a bug in the code, but the commit message carries a link to a
private Virtuozzo Jira ticket and a "Feature: fix selftests" tag.

Upstream reviewers can't open that tracker, and both lines would stay in the
permanent upstream history if the patch is merged as is.

Could these two lines be dropped from the commit message before the patch
is submitted upstream?

The run.sh change itself looks correct.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261027155236.1226178-1-eva.kurchatova@virtuozzo.com?part=6

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel