Re: [Devel] [PATCH hci-8.1 2/2] dm-zero-rq: drop flushes, discards and write zeroes instead of failing them

[no-reply@sashiko.virtuozzo.com]

> From: Denis V. Lunev <den@openvz.org>
> 
> zero-rq kills every request that is not a read or a write. Requests
> queued against the previous table and dispatched to zero-rq after a
> table swap therefore fail, a flush with an error returned to the
> syncing task and a discard with an I/O error in the log:
> 
>   I/O error, dev dm-0, sector 0 op 0x3:(DISCARD) flags 0x4800
> 
> ploop reloads a released device to zero-rq precisely to keep the file
> system on it from seeing such errors.
> 
> Complete flushes, discards and write zeroes as writes are completed.
> Reads already return zeros, so all of them are honoured. Drop
> num_discard_bios from the constructor: it only matters to bio-based
> targets and to targets that pass discards through to a device, and
> zero-rq is neither, so "silently drop discards" above it never held.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-152097
> Feature: cbt: changed block tracking (for backup)
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261028123130.2828357-1-den@openvz.org?part=2


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel