From: no-reply@sashiko.virtuozzo.com
To: andrey.zhadchenko@virtuozzo.com, "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/2] dm-qcow2: fix a merge reporting success after a failed write
Date: Wed, 28 Oct 2026 13:25:07 +0000 [thread overview]
Message-ID: <010701a182af95b7-58a8cdd8-a9d9-4480-b033-0b75505e8418-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261028132104.2885097-3-den@openvz.org>
> From: Denis V. Lunev <den@openvz.org>
>
> qcow2_service_iter() collects the status of its service qios in a
> function-local static shared by every dm-qcow2 device, and resets it
> to OK when it starts. A merge or L1 COW break starting on one device
> while another one runs wipes the error the other one recorded. That
> one then finishes and reports success although a qio failed, so
> userspace may complete the merge and drop the top image, losing data
> that never reached the lower image.
>
> Keep the status on the stack. The qios carry a pointer to it, so the
> function must not return while one of them is outstanding: every exit
> already waits for service_qios to drain.
>
> Fixes: 222b6f1291c1 ("dm-qcow2: Introduce driver to create block devices over QCOW2 files")
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261028132104.2885097-1-den@openvz.org?part=2
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-28 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:21 [Devel] [PATCH hci-8.1 v2 0/2] dm-ploop, dm-qcow2: fix merge status shared by all devices Denis V. Lunev
2026-10-28 13:21 ` [Devel] [PATCH hci-8.1 1/2] dm-ploop: fix a failed merge failing every later merge on the host Denis V. Lunev
2026-10-28 13:25 ` no-reply
2026-10-28 13:21 ` [Devel] [PATCH hci-8.1 2/2] dm-qcow2: fix a merge reporting success after a failed write Denis V. Lunev
2026-10-28 13:25 ` no-reply [this message]
2026-10-29 18:01 ` [Devel] [PATCH hci-8.1 v2 0/2] dm-ploop, dm-qcow2: fix merge status shared by all devices Konstantin Khorenko
-- strict thread matches above, loose matches on Subject: below --
2026-10-27 17:49 [Devel] [PATCH hci-8.1 " Denis V. Lunev
2026-10-27 17:49 ` [Devel] [PATCH hci-8.1 2/2] dm-qcow2: fix a merge reporting success after a failed write Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a182af95b7-58a8cdd8-a9d9-4480-b033-0b75505e8418-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.