From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a187a3091b-75a86f71-9f2b-4067-afe9-7bd890b8ed76-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020138.outbound.protection.outlook.com [52.101.69.138]) by lore.virtuozzo.com (Postfix) with ESMTPS id E470980E7E for ; Thu, 29 Oct 2026 12:29:38 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XSja4LHpaofM1l5BktbRzATCmuoEPVX4DjdL50qgvCH/Tg4wKx0rtP83kF28WPYJ7gBNori35N9H44DXJOky7vwhLjmMWsixWDqnBHHHz7fSzp+6iMQBmIrlGeCZ48jpHsRdfeZJg6bPszIU2QY9Zcxjc7N6lGysfxi1nFyMoRNpJZh8Cb44fi1V2W3O6Gyg8oM7iujsYkQ12xByu524hKfjTwSnjeg+SvtQghC16hPlJitD3LOEO3dRBQ20JD9bhcKUzZG+Qe7jsh2nFHbRqEuY03WwYvcaZVb4REvgCmLJvrJ/9tnCJ4JQA+IWLzbXtmL+AVy0M65Rj3adcz+vcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TobgXpKWPF/BDrtkLfcsxC/O98AxtOKUtgZdgquwIQ0=; b=le44cpQqPyz8u4QxMSgbxOz3KqPhZUIHj4iyITG6w/1sU7PO62y9txz5I7WmO/Zh3PoXqsWUTAG2SFtkOxNSj1Kre7ZWs12xEty2oo+DJtcgKn+UIlw87OJzDGkOFcY86pd6ArHxhvnin4kCUEoo2BU9L0gkajou4+tcr3oSSV5Qr7NSj/dFTFVZtB83o0HDguiATq0cBS6pSHvR9GpsoWVaiIT+xceDsJsD984MyavdJT9e/QsoOm3eE02U8yINSUjkstc22hEPf1TCy8TYov3O4wxeVNe2E7LMLTIBx6MzOMCPg6Xmg6XF04CwueL8zGQ0/O2AbJWr6KiDTx6s2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TobgXpKWPF/BDrtkLfcsxC/O98AxtOKUtgZdgquwIQ0=; b=m9RwjUAn6XsiWT8VB+SJJpSdBV7wgeHYx6XFyTiGs4i/rhgsOY4xULiaD6QFvJVgBD+XyznmWiNFNjuJuF8iROm44DvfdrzTG6uScBmqCACgdGkO6D+v8S4zYxvh2GdoSUScPvOJ24WUNzCwuqiLvUjJ4l6hdIh+wKC9sm8yjXo= Received: from PR1P264CA0138.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2ce::17) by PA6PR08MB10645.eurprd08.prod.outlook.com (2603:10a6:102:3ce::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Thu, 29 Oct 2026 12:29:32 +0000 Received: from MI3PEPF00008557.eurprd05.prod.outlook.com (2603:10a6:102:2ce:cafe::39) by PR1P264CA0138.outlook.office365.com (2603:10a6:102:2ce::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Thu, 29 Oct 2026 12:29:32 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MI3PEPF00008557.mail.protection.outlook.com (10.167.240.11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Thu, 29 Oct 2026 12:29:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793276971; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=8hL8LGZ0ioj6xz+G95ZSa5Jta73uQbjpiDKrspCNH84=; b=pQgCDwV/qOCiUJCqSCJALh0VLLDf6kLROSim5T0BTVTkp754gPcqdwEgMq1V44Sr wCJ3M7kD55yq0hD8p0A3/tr8aNib/66PbyEQUNm62HfHGN+nUOpoQdQcZvGWZYxLlXl ZjHuwISp/Imn7KGmYssbk7zwJFBk1EiboTaCQL74IUcKP6hGXlDIneTsDmyuotMtoul wLBQ3oKfViTG4JD8hjXDo7Nq0Ft8U4dDEg6TZ24+ClcNSk388UZ8UWQQThMhf7HDeaM JyV4F/6AaiDX3tNUA0hs7Y3mMAwkO4qzrfktGY6/daFfAvfDKZhz5uwb709O90m7ENg w0omoQdWzg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793276971; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=8hL8LGZ0ioj6xz+G95ZSa5Jta73uQbjpiDKrspCNH84=; b=M/7FLIb2xpLkq8gyDObVM4X99zfrWclUdRfSmZL+xAAS9Wf7Q8IDjAlgZ/DAOQUM 954XKUBps15aH8GJttlerFNOHN4/20+aHh1hW4f5+IME2m96kyi0Bam2BRSEyDFkOph hYZYH51c/JDICBv6YtA3NhLnB5ZbjtrGk9BP0Z88= Message-ID: <010701a187a3091b-75a86f71-9f2b-4067-afe9-7bd890b8ed76-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH v3 hci-8.0/hci-8.1 3/6] i386: keep spec-ctrl for AMD guests on vz machine types up to vz9.2.0 #VSTOR-151770 To: andrey.zhadchenko@virtuozzo.com, "Denis V. Lunev" Cc: svt-core@virtuozzo.com, den@openvz.org In-Reply-To: <20261029122527.365104-4-den@openvz.org> References: <20261029122527.365104-1-den@openvz.org> <20261029122527.365104-4-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 29 Oct 2026 12:29:31 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.29-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008557:EE_|PA6PR08MB10645:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 24a562e6-a642-40e1-8e0d-08df35b84895 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|32142699015|376014|48200799018|9140799003|261028144727099003|4143699003|5063699009|56012099006|261009223027099003|261026140227099003|261026121527099003|261026135527099003|261022105027099003|10067099003|55112099003|22082099003|18002099003|16102099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: TPuiX6Ve6rrHnMPi4SlJjEupg/AVdT0D3fLnNaeW3500jQJMXoPkWIitxtkEeTaK06GXGtKNNIPcWHdiW+uykUXvQkbgZYDKkCmv2I2prFFMkmT7VdK35CtbaQkvMIc0jY3ai5PwbbHeWMlozjEXtBhlP7rJZivv2PMR/kibQPK7Ph7N/aznvprDsB0O6zzRYci7vnjJcYfEVIqzQRbkNs+Yf/SUin0sIZ4Z4E0ApeZqoTtxheDK6ELo+ySS6nHhx4QxiKElj0Ro5JahSQlYY3ymNc+0GC5JKpTcz35rTA9rVhit2FzGJSb2f92rGQH32gA6p4vKbgWr2CYgjeI/VBYRfttXXUGp2p7RmkSd9Ow1s6Gie25uEAva1d/aw/IeyWlzs+zKZLC85KEwVp+B8JxgjgzCKZBcBI71J1JQJd7tDBupMMlZbQzMAbXZiTTm0qNKa8NoLqo6EWyKmIpMP+epAdYBtOY1cL5uthMa1/r82VpyGzqxAACwuQ/H+663iViAeKlu+ljX5cKah48sWZCkBVO3SIWrrZrDmvGcSRVhJa64jrWVzB3LnyL+1Ja28b2wcrpXaLYmt/3NzenN/E/kqpFlixoT379hYCBb80CKJhiGzsKQbK81u0+3+BpFiNUqjbO2k4YKvhzM4PDiOaf18ZVRux/gdMGsCLuQHTfgb4j+cvxUFa9fu37cKzEIJTBeDIj2JMbmO5VHmr5rWNuOcWh30pHZQXeFtDScOMilq1TlfP3jHCvJ4M0VuCTosi+P+ajnbSiXjkQLtRffckdQ74922jIy2AZm/N0DH8s7FOXgPYS4ilmVbH4C18GsuHDX48GHxtzMU9KQITopsfCgijWX+XHYT/vaddpFysTcEE8vyxInr7WnfCvtiGQInBF+4V6prcbq5gqHRGkV+Q== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(32142699015)(376014)(48200799018)(9140799003)(261028144727099003)(4143699003)(5063699009)(56012099006)(261009223027099003)(261026140227099003)(261026121527099003)(261026135527099003)(261022105027099003)(10067099003)(55112099003)(22082099003)(18002099003)(16102099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: r1QCn+sWOeKDBIDCaaYUABxplC9ELx0nl7CMaiJjP5ZmZHPLIf106+dD/lz4wI9zk8I2qF3XE0sy26mQd2+Xg3e/Fewnn82HtmeEn3qPJnXu3lCdL/g+9/WCnhIG+HXjkCEJEPjE7KT1vGpBoGsfvGWLbJ4AHy/kZK4KV/2Pq24a5PwKN94FooxxQjZBzvAg6M6UG3wgzARbNoagxi+L9mNtDMtAg5F4GBQin7IkjY/OZPODR+Fyz5PBpo19AnuWVVd8NHdlvXmipluhvSpB80sj3NAna2/Oy8tbwGieiPcYt8aPUyQ+hDnsgtKCTgxIo/khyNQ81qurPTGf1KxlWW9R1LUhE1mlONrCjJrZqZl0UjuZwIjDG1JA0y2VD0cgNszImYuDlzyJsIewt/5HY6QEVP/MKi0/oaG0PyBERXxiZEL5NuyfwBYilBvBKuAG X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 12:29:31.7257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24a562e6-a642-40e1-8e0d-08df35b84895 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008557.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10645 Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] i386: shared tsx_compat comment does not describe conditional spec_= ctrl_compat -- commit f0225ca6e631cf113e6cd09a3b55911125b7a154 Author: Denis V. Lunev i386: keep spec-ctrl for AMD guests on vz machine types up to vz9.2.0 #VSTO= R-151770 This patch adds an x-spec-ctrl-compat CPU property and enables it in pc_vz_9_2_compat. On AMD guests, a requested spec-ctrl bit is kept when the guest and host both report amd-ibpb and at least one of amd-ibrs, amd-stibp or amd-ssbd. > diff --git a/target/i386/cpu.h b/target/i386/cpu.h > index 85efd0b9fbe5..740fb3aedc56 100644 > --- a/target/i386/cpu.h > +++ b/target/i386/cpu.h > @@ -2337,6 +2337,7 @@ struct ArchCPU { > * older node keeps its CPUID. > */ > bool tsx_compat; > + bool spec_ctrl_compat; > =20 [Severity: Low] This isn't a bug, but the comment above tsx_compat now also appears to cover spec_ctrl_compat: /* * Virtuozzo machine types up to vz9.2.0: do not filter requested * features the host no longer provides, so that a guest started on an * older node keeps its CPUID. */ bool tsx_compat; bool spec_ctrl_compat; Is that description accurate for the new flag? In x86_cpu_compat_kept_features(), spec_ctrl_compat keeps SPEC_CTRL only when the vendor is AMD, the guest and the host both have amd-ibpb, and at least one of amd-ibrs, amd-stibp or amd-ssbd is present. It does not keep every requested feature the host no longer provides. Could spec_ctrl_compat get its own comment that describes these conditions? --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026102912252= 7.365104-1-den@openvz.org?part=3D3