From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 3/3] drivers/md/dm-qcow2: do not revalidate inconsistent persistent bitmaps
Date: Thu, 29 Oct 2026 14:48:46 +0000 [thread overview]
Message-ID: <010701a1882286b3-9f8de895-8cd9-4c81-bf7d-e55a534c111b-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261029144358.3384569-4-alexander.ivanov@virtuozzo.com>
> qcow2_check_convert_hdr() ignores the autoclear features stored in the
> image, and qcow2_parse_bitmap_ext() sets the bitmaps bit whenever no
> bitmap has the auto flag. If the bit was already clear on disk, a
> writable open sets it again and marks the bitmaps extension consistent.
> The qcow2 spec requires to treat such an extension as inconsistent,
> since a program without bitmap support might have modified the image.
>
> Keep the bitmaps bit only if it is set in the image.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-138887
> Feature: dm-qcow2: block device over QCOW2 files driver
>
> Fixes: f913aa3f7a1d4 ("dm-qcow2: parse bitmap extension")
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261029144358.3384569-1-alexander.ivanov@virtuozzo.com?part=3
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-29 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 14:43 [Devel] [PATCH hci-8.1 v2 0/3] dm-qcow2: keep images of a read-only table unmodified Alexander Ivanov
2026-10-29 14:43 ` [Devel] [PATCH hci-8.1 v2 1/3] drivers/md/dm-qcow2: treat images of a read-only table as read-only Alexander Ivanov
2026-10-29 14:48 ` no-reply
2026-11-03 16:30 ` Konstantin Khorenko
2026-10-29 14:43 ` [Devel] [PATCH hci-8.1 v2 2/3] drivers/md/dm-qcow2: fail writes to a read-only table Alexander Ivanov
2026-10-29 14:47 ` no-reply
2026-11-03 16:30 ` Konstantin Khorenko
2026-10-29 14:43 ` [Devel] [PATCH hci-8.1 v2 3/3] drivers/md/dm-qcow2: do not revalidate inconsistent persistent bitmaps Alexander Ivanov
2026-10-29 14:48 ` no-reply [this message]
2026-11-03 16:30 ` Konstantin Khorenko
2026-11-03 16:30 ` [Devel] [PATCH hci-8.1 v2 0/3] dm-qcow2: keep images of a read-only table unmodified Konstantin Khorenko
2026-11-03 16:33 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1882286b3-9f8de895-8cd9-4c81-bf7d-e55a534c111b-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.