From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021097.outbound.protection.outlook.com [52.101.65.97]) by lore.virtuozzo.com (Postfix) with ESMTPS id E6CF68017D for ; Fri, 30 Oct 2026 14:52:02 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uXgzlafWbRGxpvfSNNJ0fnnHmAugGloHDOMIPX0AURUmG7uVdL8oGBvy+CgQFQ1aeNZRQL8e7D2jzP5yCXMig3cEYZw0uFAIsimRkQFZ0zX0UAjk2jzwSfmHoN8OnQ9QtwQv1Jl3hxFHotzzW+Rrc8VRRjucHBRAGpcAMxVZbIEh4W1WDFU+H6UIti+2jcs9FGZba1p+cGZCGlesMVhCZpOPXaZkNdWpBQfFrMRIhkr+6GfJNhaoCwCiHc4TFuAAst0bPkKNgCPG+jrFGBLtagYZYwIjf5dUFlWVx2M5Cs55x2Dfk00e/YrkE5cMpvVEh0V/8ypufNt1iR7ZujBbtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3dMC8a+yx9q+JuNQINZDhFhdmg6UFM4/wE65FQCU2/g=; b=g8VQMgIJY4VMYe4/0DHZ6ZxnmZdqnsIa0C2eF9LVG5VR3EtfoAflZn4v/Rz0kWFwAJLiXitkUZJ1iK8Vyqj5PtITS0tv3TXtCHfcPi53w1xWWhqwjOx3LcDpzlQ2F3cv6XX2HxLVC/HkbJ4C8uu+WeeIM7vO0CD6kIiLThBQYifltx6LqVt0DgvyC5g4BdZRNtlk+My2OLHaj/o5NVdAg4B8oSqY/Lc6HNbC5ml9lQa9UVGidl95DUzJu2UETGadYHksGwPs4dt2NkTmcRDMs2r1g3I/2IPaJVQ+wOd88PLgLXZJetv+Oh2Ru3on1PH3iG4Z+mDB1U1CHEK6DMoHkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dMC8a+yx9q+JuNQINZDhFhdmg6UFM4/wE65FQCU2/g=; b=Cdzq1pVPCgSYZcKN1bIen82hfR8GNovADrzBldF3hn/7Qs1VpYLcaAd8u4VYanvxmo0iXVX7QRSqJsOJx/aXbX+uTBLpr19RwFtOBecMJukmj4a3pMiWPlC/n+H9y5hNGAXrl1GP4epwmV+xlKXpbfpiYOBeJr2vd/a1JTN3j1g= Received: from AS4P190CA0040.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d1::20) by DBBPR08MB10602.eurprd08.prod.outlook.com (2603:10a6:10:52c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Fri, 30 Oct 2026 14:52:00 +0000 Received: from ZR1PEPF0000E45F.eurprd04.prod.outlook.com (2603:10a6:20b:5d1:cafe::8) by AS4P190CA0040.outlook.office365.com (2603:10a6:20b:5d1::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Fri, 30 Oct 2026 14:52:00 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by ZR1PEPF0000E45F.mail.protection.outlook.com (10.167.241.55) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 14:52:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793371919; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=XK/KwyIgIbKlPIlSd/0t7lXa229r6Li+4uVDgf2uNps=; b=xNh6BPQ4dlTDl8022DCVYxZgIgeSbGHLF+H8qjKba8Yyk4prgrtFjMgHV3P7lDHd fw+WgyJlFFBr3tMAXGy6N8s/lnjL38rP7kgyrN5Gbw6DDaICplsPg3LGIwH/wKO7trf hyXQ+TRzLPScjJZJK1doS7jD+/zXHUPu6BxPR7NNM67cf4dZTwrKx19lpjphN8TWYHz M/rzn5QePDA4G9l5YJAIBX7gOnwFaP7o2y3ghxfw0ciNnHauRvPQSscwVtldb4JHr6V 012oMiMLfVdXI3uBL2R3wT6eqw4YGP7iutks9gwNYk87V6iyu+5jyAwqydLI0/Tm5JN nhJUSMLcyg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793371919; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=XK/KwyIgIbKlPIlSd/0t7lXa229r6Li+4uVDgf2uNps=; b=NrwfLsfnNAmitKSZfvBvrnLWIvQaVUV+e6OQ1G6HbaB+WgygdIg/3zifge3wUIiv J2mfAwjCCYRIYwKTWQB206LBNejXrbijzcVW76mulPXgBJuyADztrB8irRvS/HtDpvw y7Q1M15wDB3IvtbL+DN2M1o3fVojoLnD7rI4MpMY= Message-ID: <010701a18d4bd542-878f276b-42e5-46f4-b37a-947eff0811dc-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 06/34] migration/cpr-exec: close the persisted state if the channel fails to open To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-6-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-6-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:51:59 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E45F:EE_|DBBPR08MB10602:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 50f612dc-019f-4f7c-0f50-08df36955a32 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|48200799018|376014|61400799027|9140799003|5113699003|4113699003|55112099003|22082099003|18002099003|16102099003|5063699009|56012099006|5023799004|4143699003|261026121527099003|261026140227099003|261028144727099003|10067099003|261021121427099003|261022105027099003|261022075727099003|261009223027099003; X-Microsoft-Antispam-Message-Info: u6BFRPxVSnMJOjvVQVW0RG2ui9hsiA38G4WZs8s1AWv8IN0++eXeNwHnTZwL4RJWkVFkmuiMjsdlFKGucfvwQTpch6FDUPSDXUC3OOeW9T2rgYetaMh2iNuieTqleuMZi5J/JpvW1CNpCG6FWZgvZofNFK4cbQdm6/Rr2apZcsAgQMiys2nAFbZDKhmUnAbKQl8Ybh69o2hHD3mTD026bkBVJklPeLT7sRJ8MwrhZACv9OpeP4NtNmfaL4YTNoJhUKaoxJY3Rxi3WIwO1V/Wlrg4W174/hyi9YEeCYAcmHpCEGKqJqv2jUxvcUEE6gKEaXGU2ozWJtZnCl/dlQY6Tt/uSukJnZfo2Y0C3HNKLKr04MJa51bX7VGeSMIiyhV74EmIXHWpyuXVqxsssg+gyVdqmCXa4M0PZG5UviWknQYFcq2T6NMnHJ22PDGX8zahAFYtrNtwUwRvaAMhtBQwZKQ0+eJHDDq4bqfqPpVlku+vf1HB4WGX9/2tPs6gtmZQErioOfpP2P4tvLvy4MTckluS7L+Fy0H4b7lOuV59yILaeAmCXaPO+4esaiKWKxaP45+EWAx7TqAvZ2gy7EGahnUsfHBtoFVVeSF88S6Pf4eIM8mgjkSCZaToLVUBqAdnhA+2Zz+TxApLbxEClQzZK086pbim/AA/KArh5M2p4v5TFnthXir75U0cWZiaeGAdjXwcJ/OSusZpJ5zB5DXlzrTUbc+etoSLJho6RTFI8xVeCiX6Ib8dZV6HwnhaVf/cLCRDkdbK9Dsr4vA+kpIjHvfqVvOBjNTWf2INUKGHP5JqYrCWJWz+I0Z0SmJiLmRSSyY/6ZJn6PsIQO9Zv9GFcOXJAHovPnthYRImoEEMvlRNQCvJbPlzLhuyRRplrTwMZfG/RdcBWPxKnYQJYwPIRw== X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(48200799018)(376014)(61400799027)(9140799003)(5113699003)(4113699003)(55112099003)(22082099003)(18002099003)(16102099003)(5063699009)(56012099006)(5023799004)(4143699003)(261026121527099003)(261026140227099003)(261028144727099003)(10067099003)(261021121427099003)(261022105027099003)(261022075727099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: I+XoMOQHnBMLr2wOvfQVvsJnfi6SrMX8TooRfo8kgzLyw00KQsi6qu4UOfmeGV323Wru+N6STblcdGvLFRy4qBADerhXQ1ulVH4Eynud7sJWMqDvuRisQL3ZHGw90oiVi3Y0xeiB5QTXmBXJCo61dDJBc+HS1IZF0v0b9MsWiK6M7btavmZypo6VR4bpMYNXX1USAeAVQlP2Ft3eCHOKRwvxPA8FwEQtxVxQo1ARDw7tLvqt0InxoeZf47B+kg3+0HSXXcc8nLrutGxBwlPEB4OelCcdTOHlT4GNywWOJTLyIcyV6JsHwtRydY6VTFHDERasoPHoTtUpwuLWLJ13Nu6k4qkpVnW6wZvNzEDlEImAXF2u++Wpu8G1gVBCwiKlP5CSIEe9Wj411cW32q++lp645qXci1vZQWkV815nAR9rtwS2j9Rw+vABUuPNm7KN X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:52:00.0572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50f612dc-019f-4f7c-0f50-08df36955a32 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E45F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10602 > cpr_exec_persist_state() dups the memfd holding the CPR state so that > the dup survives exec(), and remembers it in the environment. Both > are released by cpr_exec_unpersist_state() alone, which runs only on > MIG_EVENT_PRECOPY_FAILED. The migration channel failing to open > doesn't raise it, so the dup is leaked and the stale environment > variable is left behind, once per attempt. >=20 > Release them there, next to the CPR state. That path runs in any > migration mode, so make cpr_exec_unpersist_state() a no-op if there's > nothing to release. >=20 > Fixes: a3eae205c60 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D6