From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a18d4c9b36-5f704c30-d2ad-4a37-9c62-f30c44f63fc6-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020090.outbound.protection.outlook.com [52.101.69.90]) by lore.virtuozzo.com (Postfix) with ESMTPS id A643280E7E for ; Fri, 30 Oct 2026 14:52:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m76MWrkLNTTQfyuBP9+V18AzcII2A2fqNMOQvDtQ5ETfQ5XONwnMCekXnwL/nMswIKPI32U8iW8tEr8dRuLhInuHMlndSij0mbfiDfgMNoFBsBEmdKNmhDCFjd6CZJfG588SUIBrJjNM+qAvgOvCed99z1Qcnw6T5FvwGQkUsDJSzFYL7eb8X9lpoA2AVDEDEVZj7PCzAo0PIe9RLtnvHnSNc6GH+/B8+Z2K7gRlVcMfzmkHs0QFusewc34qyJUmLIxK/oY21NGayoYX5gV2AvxyXqo2XN5VBgBeV8XdX3jvl+M/C99zf1skmuKZmgBR3eqQg6OQbp1Pavinh3sinQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u1ehJ8lcQmV2jokwOZPLRtkSk3lxxCYsRvJVNabmTjY=; b=HsJF0VPuFiv1JPVz8RJRgvHM95mRlRgFbx1pkXp4YgYZZvUX8wqXOgQzfdUJzjEQdnbmpBjTghg2SkZ1McQ9yd91BxDL3+Pf530RsI6kF6H7+I9fgfzfOqjz3TD4mTvRC9en1/lC5kI1FLMixDTxq66ZSEAQ8pVJENBozHh2WeC8K20FzgXZktM+yYXieJ6zc3at0klPUc35ZHYBpu0YUAHZf9G+w3z3c53oxi43GFeUTpCUiA28jBFQ/jHLohHSOOBZuUnH/f0xXtqo3DO3oWMAJIOtjvqyCKo8tf9VOD5i8JnBy1Drx9B/hc8apDKtpxJkg2AKpSFklfMwGs0sdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u1ehJ8lcQmV2jokwOZPLRtkSk3lxxCYsRvJVNabmTjY=; b=jYMqnUfw2tej4gKy9lW67DUC/XnB63va1iZ/YwFsHoWizgFZd2U+nreZ8oAhil8UDuJ9M2R5Rz8o8Hor4ixZKjS5fXJItPfs9ouGwmbP/yG2wGYVW5sKOuJc5NuTuRWF2hVpAhaiouyum0RhKJ/5CefO3Hcdu2dEvuMWxNCnKaA= Received: from AS4PR10CA0013.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5dc::20) by DB3PR08MB8913.eurprd08.prod.outlook.com (2603:10a6:10:43a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Fri, 30 Oct 2026 14:52:51 +0000 Received: from CPH1EPF0000052E.eurprd05.prod.outlook.com (2603:10a6:20b:5dc:cafe::2b) by AS4PR10CA0013.outlook.office365.com (2603:10a6:20b:5dc::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.10 via Frontend Transport; Fri, 30 Oct 2026 14:52:51 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by CPH1EPF0000052E.mail.protection.outlook.com (10.167.241.169) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 14:52:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793371970; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=uYm9qkJJDk4EMaonaZYllqfnX4AUyaxms/D2erSMPA4=; b=2fTO82akdM1ijPB+YK9oJlwQBJkr3A4LUftY36s61TlnpMltAqYgmaRHy8Z18nsh iTIBqCPxWDDbjAoVbrQKb4AtY87ygtSAIy0RP0nSm+ArFAbX0mcn4cBsf6wAgiL1oH6 a8x3DDBEAWSoxU21crrrA6KO2R/Z6rOilf/Z3FJecC7ZeMHvnWSlh1+YdEwMX+KdyG2 myArY+0Zrd0BEBJBn4KhZ6h+ZbdmajlYLWh47F9pYrrBnQ0AlBWRgjbfP41JM5s6UCe ldwZOZpcQGX2+5rjAtRDjvrLCyQnItm9qOCcI5uSnFODyNXtb9vYMqipEY/KHJmG2i7 DV1i8A6WfQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793371970; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=uYm9qkJJDk4EMaonaZYllqfnX4AUyaxms/D2erSMPA4=; b=gwCxgahzY+qypVR4mJuCU4eGI1m0IOjpwlqL8OrcNsAlyn3MVMFGsmkRdAM9hsFO H72krnilMmyBgbC3C4hZ7D3m6XLkqVXbHsWYVzIxiAEuloKJ7kw1fSvw6kM7AmKs6Ip fRZR6yA557NiTh5sCxQ15bfdt5PS82pP2Qv6+9WQ= Message-ID: <010701a18d4c9b36-5f704c30-d2ad-4a37-9c62-f30c44f63fc6-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 08/34] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-8-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-8-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:52:50 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF0000052E:EE_|DB3PR08MB8913:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7877907f-c61e-4b3f-9294-08df36957887 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|48200799018|376014|9140799003|61400799027|5113699003|4113699003|55112099003|22082099003|18002099003|16102099003|5063699009|56012099006|4143699003|261026140227099003|261028144727099003|10067099003|261021121427099003|261022105027099003|261009223027099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WWkxUTBTMWFOVHRpOWpZYVdKcytuSkFCWlMxREVSTUZ2NUg2WFd3ck1hd01L?= =?utf-8?B?WnBxWnlaV3JDdVBPRVROeEZvU0xqTi9xU3ZhRjdRbTM5MXBqajBqK083TUIz?= =?utf-8?B?TjNIclJ4R1dZOE1lMjhZNzIzYSt3ajRoMkVhSnlyMW1xSHF6K0Y3d2V5d2Nz?= =?utf-8?B?NG5OeFRDL29naGptblB3cTgxbXpVbDAxb0VOci91Qk50REtjYktrbC9tbWVK?= =?utf-8?B?NEhJVDhUdUdCRWZadFZJMzlNcFpUcGZwRXRNVmVwcTh5NGNvT3JtbzFtTE1q?= =?utf-8?B?ZUE1bTl4bHROYVhvRFoyeW14U3VzQm5uLzR0OUNGYWFZR1Vab3d3NUhwWExQ?= =?utf-8?B?NUJRODR5YlpPQ2VjWmtWL3hLSHp3NjVtQUJ4SW9pOHdxbmljK2RiRVhMZTFR?= =?utf-8?B?c2F1b1F5eG5YRjBCOUNhbTRQR01waXlJQlRqdnp4eThJdzZlajRnNFlzbVR6?= =?utf-8?B?SUFmc3dmQ2pTK3dncWpVUUNyNTdXVG4rUEdXOFQvRGZtbVFrYUY2d0JjY0dS?= =?utf-8?B?K2tCelhJVU1IUVVvczUrUkU3QUFRSmxWTzlwZWdKTnI0Q1E0VVRxdFdiMUQx?= =?utf-8?B?VkttdXdjbjF3RXl2UlMvY0NiOWkxRkkzRy9kRWtHTFY1WVhhM2szMjBxTm0w?= =?utf-8?B?WWZ3T1lBelRBbUl1RUFZMDVEUTFJcW9ZSm9pU2t5SmVGRkVxQTg0WEhVRlcw?= =?utf-8?B?bTJnd3V2UXUrcE91VUllM0s5ZUhUaTBPc0xpVER0ZEZqUEFYUVYyZW0zL3oz?= =?utf-8?B?ODljdlMzN1FkM2k1Mmhha2JDbHhZMFEwUEZHVlkyWHlTYmdwSzY4Q1FnNjVB?= =?utf-8?B?ZWNyMXkxSjl0QzUzWDFTQTNRUGk4WTh1Nk9xUHNjYUJPcExqZ3JLSzFlUVVh?= =?utf-8?B?RXFLcS8rUVo2TE9aRThWbUNiZUFIS2Z6dnpPdm4yQkhPUGYremkvTUltOHoy?= =?utf-8?B?VU9hbzhRVjYyT0kyMUlPVHNSZHBPbERISVN4VnZxVklFS00zclJ3Y3o1eHJy?= =?utf-8?B?S0NMRWdGZndzMXc2YmVXVmlrY1BkN2wvOERjSmdDY3NMODlrSlluQU5MWWVY?= =?utf-8?B?UHBrNmtHL2F2dTJUL1JiRFVyZ05QMTFmcFhQSDIzU0p1eHdmQVNFUlBKbkhv?= =?utf-8?B?NU9LUi9BYk5Gc0ZsK3B0bllWd2pBTlc2NEQ4cC9OVjcwaTNGTEZ4em5raWdy?= =?utf-8?B?M1RoU3RiaXdFRTZRNC9NZm4wS2VibU56c0xQcFgxZ25Gclo5WjcxN3BWVlc4?= =?utf-8?B?VTAwNUN1NCtmeEppa3lXNi9pR2YraXlOekJ1d0E1VHliYVhuR2pXaHJVN0ht?= =?utf-8?Q?XcyanJ7jIGGGhKbU+P7YFwh248BNvd9To6?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(48200799018)(376014)(9140799003)(61400799027)(5113699003)(4113699003)(55112099003)(22082099003)(18002099003)(16102099003)(5063699009)(56012099006)(4143699003)(261026140227099003)(261028144727099003)(10067099003)(261021121427099003)(261022105027099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JB3c+GJg1hsWzg8bBvrtnI8uOB2BLqR4t8UM9ZnPo28OeNUJmhPoHTYdtEjWeZK6cIxZjxh80T7XEL7nfAKCt7tchYOiLYIalmFAERr/wyI2ShZSiyP9VgH224YWtWjdu+8PAYhgY5DLFEF9xJmz0fycXIHrbG37x4cSq/0nLuwWJhpOYJcgyY/ImqoAyTkFEHBmjY9qGs8wet+/khFomNFu9GjZiTI8cUe24dt1Dus6cfobpiimp9MlH/K8soLpySsnKAL8WZu0DAhkWD3mpYL1PT0IuS58nZckXM1kUJhaW7CAtQJTWuVnFbBk3ek7N83MFznR48eBph+ES9yU1rmAIyGStVNyE32V1GHnWCyDC3Sn1bhuulkd2J59XscU48f5T2dtBdW5M6Jz2Dx57XH6YnHt4+NqmvZXumO8XDUTwH29oa3yq6vQFm/N+tj5 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:52:50.8702 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7877907f-c61e-4b3f-9294-08df36957887 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000052E.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8913 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D8