From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a18d4d7a19-da5211f7-278a-4d2a-abc3-5dae1b3508e6-000000@eu-central-1.amazonses.com> Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023119.outbound.protection.outlook.com [52.101.83.119]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9E9D080E7E for ; Fri, 30 Oct 2026 14:53:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PDeWs47o8JIUZOnzTEr1qalyQ9LOryQ4vlM8HrVs/9igXeXQuHIx0b1/WSsCoMDmk1aFqWAey1xp7kWpZjAuuqmGCXjMjCa/8YDyR4SYD5yjOesIVatV91TWwdubYxeJJkvX+rgD6tk6bULo3gCAkekgw18oun09icQ9xZnfJGEb/PDE8ArOp84dKlyhzcJeO7/5yCjd0/RzmZMGdeUv7rLhxDtNsQ50zQpIK/uSbYnSK0fmlzsCKkreomXRu0oRLrEc6uqxo5drPLW3agJQ1Au2dYJl0wxkIToQhCorhMcbNlXsrDSweGLI4ay8NZSP/azjdy4i3D0AYkkTknyfNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0iUIRUAlNnIO3aCqWo7k63Hv19YVvmT4XPpQG0iEgQA=; b=QEXnKFIn/6JJisZV8Wj3ZYFYux+fADv580I/L+kzRuF0lrEheRNCUWWukgasSfGcJbf8VLS38U9opbu3LRazyexXlyCy1SCxCJ5AR1uJ3rCWZt3t5diR1QoFXsOshHF+BgZWFvOSMtqzH2qRW+WP/f3TU/i3mT7noahg1YG1aY5vhk6DDLCRJECD48k7NldI7gP099eojblqr7SotTgmxx87v3wDF2QgEfAaZ+IFYNvxUZRQ7OlMB1V3je0xTSbeWTL2z8yJHFvsCM/B/Yi434TItT8B4qocb7q9cYlK/G17XPlXMWRHroG/NXqXjeU5KUaZSexepfKmnFwSdDloDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0iUIRUAlNnIO3aCqWo7k63Hv19YVvmT4XPpQG0iEgQA=; b=Jl8/k9wZdsARPBbsRZwmnaDKxmf51FTK5/u/yZtivUzdHyaolkFtFBtpKv2xH6VkgAdzoJGYymm7yZ65cpnx2vZprU4pFsjGFRHtiDj64Yc5nJ1Y8IiCOBAb5Zkcho/77Pq0nKVoGrDLOM9gvw0wNN8D7RBgGvghZKbfnvBF7XQ= Received: from DUZP191CA0033.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::29) by GV2PR08MB9253.eurprd08.prod.outlook.com (2603:10a6:150:e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.9; Fri, 30 Oct 2026 14:53:48 +0000 Received: from DB1PEPF000509E2.eurprd03.prod.outlook.com (2603:10a6:10:4f8:cafe::a6) by DUZP191CA0033.outlook.office365.com (2603:10a6:10:4f8::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Fri, 30 Oct 2026 14:53:48 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DB1PEPF000509E2.mail.protection.outlook.com (10.167.242.52) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 30 Oct 2026 14:53:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372027; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=PkGwiU1XzEjJYvb6mN+gF8KE4ENcHSKZ71L8N1Mwo0A=; b=QBcb7TwW5GtIzq2JtHBramFE30GivwF2fhL/0AzlSM7MYxp5RwRAlxNXl+LkComR zoIUN7+Af4gXqdeuJLgvR06Ljuo07h6cvWq7g71bvGBxLhoRI3r1t/jpQzpx7yuT0sw XKadvCycTv8zJpoqAwZb82Uh0KLip8YUgqYuOjzmDPNZFwz0wyTKQjl1Il8X+HElosK aaq+sLEZzNgBixzRA7gY2cB+eSPRIKbK0dRoVgKvcprsyF7aVcUckYJv8O8wDeaJNUR 74Rg8npR1dzlhcqwYtlIfzJWBY2YmSvv5HgD7iBfopuXkIFqdg5RHZ5W/RJ8t7m3EV5 BH+uJD2Ejg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372027; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=PkGwiU1XzEjJYvb6mN+gF8KE4ENcHSKZ71L8N1Mwo0A=; b=Ww1h0f8SisQcjIyEwLcIGtAuAl+u9JTl9xzGGBWDZ+wY0nh63H/6OQZ9IkdzLbhU F6lHbANMzWMUmRSfg1O8I3b4RTkKH90tLBtbYM3/84ipy0uIl6pfnQrzJiuHA7CTdF7 IpTjsxZhlT3707gsxp7BCHMQlfSmPErJEXh2B4WU= Message-ID: <010701a18d4d7a19-da5211f7-278a-4d2a-abc3-5dae1b3508e6-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 09/34] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-9-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-9-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:53:47 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509E2:EE_|GV2PR08MB9253:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f7837c65-2d97-4a74-df29-08df36959a78 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|9140799003|32142699015|61400799027|48200799018|5113699003|55112099003|16102099003|4113699003|18002099003|22082099003|56012099006|5063699009|4143699003|261022105027099003|10067099003|261028144727099003|261021121427099003|261022075727099003|261009223027099003|261026121527099003|261026140227099003|260925022911599003|260925021311599003|260925021911599003; X-Microsoft-Antispam-Message-Info: zC2gVnAfgmOvBngSysttQiJsbfxlpoJPbz01av+MgkrXc0pu9KIcNzZ+Sp2WOgfwLdVQpdBrOJMuwI9ndw/nvyN5UlfAQUpyXv2yxiigKr97Mg4LfGRNPDUqXp6GifoIFeAGQUgiml0/WY+ta8wi79hTgjhqy9y9hrR2EC0lvq0ZtRbtka1yzIXDoUkY1ZBtE4DQvZGuiOtcS53O/znRWJ/VKDkHdextRM7FGtbHEi6VEyNn+xnjTXZ3Q0xq+Y2nqiHqCDm6Xk5LmBczlLf3/atFVlx9LIY2anLnAz/7cFN4n4gG/oTu9c9l6wpE9xCaVXHMEzJIypYzX1dRkxiI4lbdEGjPpns9GdpxUBvJX0DkwnyP5Q98WhIUVFVn4VhSRJqRvDpi+8o0K7UnFfkLf/Pz0+MkJXdkDUf492VPQprYroYPza6TsB5FHvkANfj1UngcBh6czXWF1WaL6//H+41V0Jv+Oj3AdIj6JKNBaKtPg3f72fOyVZE7lyfuxx9ZY2F+tpIphZYWzvgDEq7BL0iSI5ntmajJdApeR98pbn7ujwQS+q8dGwsnbIIMpE5R4fiPWs83vBqopJrmscZzH0WEGn/wCDz7ekvo3/V6Y0AYR3p1hsNzz1wjzUDDc6bMvyvwM7JMTcFAM+bq9vpVmGgMWs8iFky8yaQyXooPO+IELqrK8ppCQOaobQYr4ep8NMF7kyoaqloOS0Fj2YuQj28w3zvP3pqxoFKJIC/2F+QRWyZFKprWydVkC5FAAEOzIAaOp6rK886udQ0yqnAwo2uZrddvouwm/NFX9x3Z4ISSIW58/seILAkOzneUT/q3wZNalRyvZL/tlVQfC1BwxEU6Fkh+pmik6Qj3ZzzbrHXBBntubgeteeQa8RbfH4mbJBDreIUpXodejRjRDBsy7bzMHLDB7NhU6K20uJbUmDE= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(9140799003)(32142699015)(61400799027)(48200799018)(5113699003)(55112099003)(16102099003)(4113699003)(18002099003)(22082099003)(56012099006)(5063699009)(4143699003)(261022105027099003)(10067099003)(261028144727099003)(261021121427099003)(261022075727099003)(261009223027099003)(261026121527099003)(261026140227099003)(260925022911599003)(260925021311599003)(260925021911599003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NxkQTf/IbnsvJ8EN0npPe4D+KfgJ6f5jGsFvd9OcS/NyCkD4CuJnazy+lQgwRX/yjfGisl4xsh6CTRbYhnleTy7u/70U8GROlFkUTXBiOTm44Lyg0nVOpWfuJP95hIQ+1aqWm2Ri6vF5lm9lMROaGv1UpPhQZeclVsyWY0klCxSEgXyGKXaU0oC9G0FZPWW7vrwnaaBaHL6xSARayDu0HWD/opa7d9zhIVAtQ2l3Q/mJ5Igs7vQ1j+njQ/KLqRXqs/f0lRbAkmOCKE/DtcZPByFE5138jIHWIPhtQTHjDR40BfYM2DE6YlTjIhscAaK/SVo9kVSb7y5mOAP4VdXaDBwncGpILHqw/LrPyAWc3KXSMqX3UcMUtwseuii0Hp94eiz7D7rB36e0n2e5jqQjhM3WReQtSOZmPrcRiwEFlyFX+YqMbCMba91VZL2Tu+w3 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:53:47.8651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7837c65-2d97-4a74-df29-08df36959a78 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E2.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9253 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D9