From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020084.outbound.protection.outlook.com [52.101.69.84]) by lore.virtuozzo.com (Postfix) with ESMTPS id E4E3280F25 for ; Fri, 30 Oct 2026 14:54:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TYHl6jo0VuPpG+XBnuU+DG4tOe5CVszeffqt2JsQHxWAWYbI6uIbbsyAYe0k4AGhdn1hA+bNajqyj7E/igXYnLrmplliCX/AJzNJwn2ocSmnOW6/m9/jJ3kIiM6GzF63JIgQeo540cKkU6wEsmlslsQg7M1EnP/zb/vKLlWR8T2ehF+FlHHEgXCGFPeHNzHdhL3VEnt7xVUiKZrwg0zUPb1zOcrNpAVdQGDbIEg8ZKTA2DK9ylVBv6Kr++bAvL/NzzjCYCXYmjXL76NMeiwIKGF36vhNu6eKPJ6ApzSOCmcABigSh1nXspF3fOfz40vai/WHY2tRHVE+nYQ4773WQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZmKMVNtMaqu8SztDt74DetosKZn8emqfLFf+/7CAPxU=; b=TG1EkjTLr5mB7vHDnxctsdetEqk+HKTOHvabQboscLDKxHBawHysUKc88ZsaqpA0+Z/+lzr5r21e9VgEz5fjmrezs3N7yDi9ELYRkZG+MUBQ9NmBB1aV9ioBBtJ2gh7blU3Iy/dP9AVWj/s/ddvhoptAMqQUXIZb5eokHOzGVrtvyS6hHNl9OSpyprm9iqy1z1K8I2txgTIns+6kKkcuGNDIznfPq2NTY7y3v0ptNmw/oMMnXZqg5JvzviQ+4E+f1sRZ74WiHlF8X9WJW0Lbb+oB1HdOJVO6H75pcnAkhDTQ3uN4p2Ci8N9TjCPupn04LS7ezpbWkcZVUWisCq2mig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZmKMVNtMaqu8SztDt74DetosKZn8emqfLFf+/7CAPxU=; b=lDJCOfYODkoSe1nrOBCHrsq8I4RYb20/fENKl/KxSwtBIBgOGfqwPXLZIdtPXPnLyfmAmTbmhnNepxnBCQi+glEeM0U0Q6oHiXVwALTYfdfYBPlUc9mFxeFln/NCXdL2SnogZFPgBSA15Xup4Q/JSbIJ2QVxD9Sz+R82yQqmXPI= Received: from AM8P189CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::6) by AM0PR08MB129083.eurprd08.prod.outlook.com (2603:10a6:20b:810::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Fri, 30 Oct 2026 14:54:19 +0000 Received: from DB3PEPF00008859.eurprd02.prod.outlook.com (2603:10a6:20b:218:cafe::39) by AM8P189CA0001.outlook.office365.com (2603:10a6:20b:218::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.9 via Frontend Transport; Fri, 30 Oct 2026 14:54:19 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB3PEPF00008859.mail.protection.outlook.com (10.167.242.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 14:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372058; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=EFeCrhRU6818JRNVImewTmhy3C12LMnDG03vni3Yes0=; b=pJe/cZ0ddf0jEzKkEtH7KUH+w8uPDyDcl0I/VToN6PwQI4aJC4F3IQJ72kyRkC6X 0auqZVaU5naKk+6vVlNZnm8ZzaiKRvGdMlOpauKKZyLLVbr/yJO6AbP9YuUJp9msD47 5OSaXNKuajV27GrwWo5WIHscLjFdZC7PT6fHeddX9TE4Dxz8FICgKuDh/1zMBe2C2/a yp8k5PqJdBI1VtgRKnaUlxYYgyU+6q/tMgwCatprsIEBOBbQT4Oq+k+6cXaGuWXKn1s /8P77QHzLK7nh+cKg8cvkXHybMWJXvDOJvgu4KxxNqQVLva1PdZpGce0nFI4HSG9EqG TJWRXcim9A== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372058; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=EFeCrhRU6818JRNVImewTmhy3C12LMnDG03vni3Yes0=; b=DKrNp9UIjoRQgWgG7nR0FHazKY81/Y0slo6DUaTVmu6lWl0P2OxK74Qog9FWxRyl +639Yy9VYcu9/rdVeNhMTUflxfnLb2qx9QaTv6dc87q5OZmC2Mfft0mOqJD4u35Xgyz aNvWuh5Kg6IvDW6nNyWLdjL56cuVMZkZUQpyht8Y= Message-ID: <010701a18d4df395-fadc5976-86a9-4e07-a8ff-ba7a979a0b99-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 11/34] vfio/pci: Fix information leak in vfio_rom_read() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-11-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-11-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:54:18 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PEPF00008859:EE_|AM0PR08MB129083:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8e5dde02-4a0b-4748-6990-08df3695ad05 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|376014|61400799027|48200799018|9140799003|32142699015|4143699003|56012099006|5063699009|261009223027099003|261026140227099003|261028144727099003|261021121427099003|261022105027099003|10067099003|55112099003|18002099003|22082099003|16102099003|6133799003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NkdlRXc5eWdZYlFxQzV5YlhDcU9Fa0M2eHFPbmlHMTU2OVlUWkV6L1ByK1dw?= =?utf-8?B?TnduMDh6NlRjT1kyZzN2aVhVcGhaM0dzM2xXY0JxZVJ1RExITlBEMmNtNndY?= =?utf-8?B?M2szVlYzTzdQSHVGYnJLd003VUwxREhxVnJrbW5tT2dPQk4venRUSTJXMmFS?= =?utf-8?B?bURHUm1kaFQwU3JMT3VaSFZWY2FkcnI2UEJrTzdjbzYwNjQ3L3dEMU80RnVD?= =?utf-8?B?RUVpMUhETjhMaWl4bzdyTUJPZ3FuSm1meVpQRjFCaFhPYWFXWmtMb00wUGJZ?= =?utf-8?B?LzZISGdoM0E1TTg1SHRlZmkwL1JYTTI3QmR2Ni9nSE1zRVJtU1JKOHk5cWlD?= =?utf-8?B?b2RvZlVHSWphZ0l6bVRMeDFSQlFDNjVFZVdWbDJYbE9QQjBPeXFwTS95RGNx?= =?utf-8?B?Qmc5RXpQTHNXakpjcDZjK3dUYzVpTXdvcEFINkFQQnJnWTAzY1IyemVyMUIx?= =?utf-8?B?VHZJUnVxVWtlTGtxNGs0amptTTEyYVlhUWFybVRnbE5NRG91bXFmcHV4MVlK?= =?utf-8?B?Wkh1eWZic1h6bXpMYnMrejVVOXVmeldYdDJIM284WkQzR01MbEhReGJSTjRv?= =?utf-8?B?TFlnbU1yMGVBb0JZVTdYaDZqRUFtWmdab0hCOGFhTC9MOTJ2Rm52VEl5QmpG?= =?utf-8?B?eXZhR0xBNGZ1eFJwL2VPSFZLTGxuMml3T3RMcW92RFA0S1FsbFA5eVJUbWlK?= =?utf-8?B?bEtadmZqUzVqc1FDLzR1ZDZFbjRRWWY4akF3RnpVVjhxeklnMWtPbG1wT2J0?= =?utf-8?B?MEJ2THdwU0FBb2dOQnovZmJaYkdDUlMxZlFGdUZHRzJUMktNdXNwVGozOTcy?= =?utf-8?B?bHlQSVZ1VURXcklEVjc3TGp6RFVkTkdCRGgxMUJTVW40UzhuZ0E2RUszRUVl?= =?utf-8?B?Z3Jna0dQM0Y4dGtralFwejhhZE83Z1FlRm9Vcy9mZEsySTZ4Ym11a0VRZll0?= =?utf-8?B?eXk2QnEwTThwMHcxZkRJNnVyYlhGM3Nrc3Y5TVBSMWFQeTUwdk1DWWViLzY4?= =?utf-8?B?dXRMazZPK3ArRTI5U2h5RUpVM2VDZW1wcE5JOW5TejJwOTZGeWtQRXlvZGI0?= =?utf-8?B?dFhucC9Hb1lrRitHazQzODBVUklVZ0pIV1pkYnd5MkNUZFR2bjNQTUtJMXlX?= =?utf-8?B?Zy9lczVDVDFpdTBXNjVENTlHTnNYMitDdHhza2s3L1JYVDkreUc0Tks1RGN2?= =?utf-8?B?RkJ5OFpRWlczalcreExtcmxYdzJvRFFnU3E2dThGd2pSRnZ1cEE0bHVDUWtj?= =?utf-8?B?bzI4M2NrK2RXWENNbTVjTCtQdUhDMkpOSlAyMVRSek4vU0ZpVU1vZTR5ZmVH?= =?utf-8?Q?UkAdkA6dX7dkc=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(4143699003)(56012099006)(5063699009)(261009223027099003)(261026140227099003)(261028144727099003)(261021121427099003)(261022105027099003)(10067099003)(55112099003)(18002099003)(22082099003)(16102099003)(6133799003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3gW2PrW0CpKpiPYgpZB4cVFvQvjZ/50dP180yPgVboXwBJB8wPqaoqBbYT/s72FEYfguQJJ7MZ6qnS6/uWENdl3MvPfn5C0dOeLguA6GYatzW8YSMvolExQOo1lDzRarvff68cByg7aXg3fsP/EkVD8PWFe5ki7ac9Qk9kz0FpD3EOkgiqKFj85qWx9fwDBkAus0Nl3lBEm+YWv/CH/zMiLhNHo6lV3fOI7dbkquxTyCMMlYuO79F2LaF7cApip+MGgh045cxg7FTIuUvHivGp8YOlgFsMjfs7tVLLqwjFuPcYUBrlYH6LUbT5xdbXJWYB+WSoh5vZie7HuSyR7w6PVX4F8lTGHGT+wcaEcviB0EKEC01ABZJ983ZBdK87Q3V9Lt0ovCNxvESI0zrT4N2G2uNKdN354HqxCsV9LOu3m+UiuFyDRaCLALZcThI1pG X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:54:18.9855 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5dde02-4a0b-4748-6990-08df3695ad05 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF00008859.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB129083 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D11