From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a18d4febaf-978ca346-cc70-44bc-ac3e-421e808a38d1-000000@eu-central-1.amazonses.com> Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020093.outbound.protection.outlook.com [52.101.84.93]) by lore.virtuozzo.com (Postfix) with ESMTPS id E620580F25 for ; Fri, 30 Oct 2026 14:56:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DXYfYL+I8xqHVqsAxoGOzOmpJjfjsp3dEIDTzzqYzWtWapUp8i6jsO/rBKB4Mv2LkCWSK4lCobw6+bpjgvoCPg64TsfSGHhkqOJ9Jp4b759+aZe2N8Kw94V0wqJysn+5B2sdKdor2WCDYRJpQkVUV2CADuMmgwOICzOve5Sgx/yzFNeIzSZN/cL9ygsGkw49+SgGVVAOHW7X+UpuDpeOuT+ihR3Y0A1z43i8pRgwGiQsdAnfbDIcvpoJBypWKMoL6l6HIq8mnBYPYua9tt1GK2rRXIvlEHgTjy+0/AdQnIDCLjFF5zj9BYx7Cc5jHEFLSwFM5TAMucp/y+6uRnZycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCeAcoLcEzDlijGQzgBDhViWjbigZUfoXOw/JEBZcdg=; b=vtKik0ah9FE94n/oiHfoq+lz0M+UKQyvQdgerGVXNE6gx05xcFkK4PzTNrv5K7b3KypyCkU1tYLl8SBut+beAX8jkm0tOFWMQFPoEOPxYPyYhEEiEtPIOXt7bUI63G1fHiZpjbiN2uU88dm2/cWDP3LJIzpfjtrR5/PAT9AxKl6dICeqSiUEE6EVajCfj17vAqp8nNhkyFzYEsH8ZxFMihZezfDj0cV+aQI0Q7VXMO2BWUHeEVz6DLC69/IvYrilSVE9wvMwkVu8jZZ+2UV66nx++Rxo4sebC4+KR7U00iJF/l4jaUMoFvXOfKsErOOfTnjK3qcHpj5PsEUqEiN+OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCeAcoLcEzDlijGQzgBDhViWjbigZUfoXOw/JEBZcdg=; b=cgGo/VltsCtR4UM23OOlrGOZrnYCjMc+qnci8TEnxnklu8S5Q9sFIrFvd+Jm14TtYMxFxZko/IqS65SeoiwLmWPtgt7MHe3G1ggnJwlX8jwT7FLC3JJhEPlXfu3hvXVh9i36rnOgtpf5DpB3Twhw+CE6xXDOJ2Olcw4lJOUQYAg= Received: from AM9P192CA0015.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::20) by DB9PR08MB9826.eurprd08.prod.outlook.com (2603:10a6:10:45d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Fri, 30 Oct 2026 14:56:28 +0000 Received: from ZR1PEPF0000E462.eurprd04.prod.outlook.com (2603:10a6:20b:21d:cafe::6c) by AM9P192CA0015.outlook.office365.com (2603:10a6:20b:21d::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.9 via Frontend Transport; Fri, 30 Oct 2026 14:56:28 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by ZR1PEPF0000E462.mail.protection.outlook.com (10.167.241.52) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 14:56:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372187; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ox3xIrhWvCNfPDxHPs1JO/OZWPZa1od5AF3Zuh3AKLs=; b=ynunkpAp/k7FowRFuhqC5YZ/E2H4VLp2wZkpzY1rzvLczez1/qtAoMndzuNMltkH 4FHY5dyqmSQPKA2nqxgvh/ju7k+3MQmb2i26jz+BLUF054zWPGKNCVLt1RayRtsRI9H IdDA2p5gXal4D/5aoH6Il1YIbm6xG9l3nC0+cW1pr+3FlTthobFTpyyp/LmoVhTUUaX /4NG9w4lpd4HKV17hmZeZCUZavFIfulN4tUNiEve/W7tjpjX1Dkjbam/awqFdpH+N/7 AUF2ZqJb3nkvQru8Gp1QshSBj3cYtIvDupnPiv+Lz/63YH+dWehysIKrEyFw6lnzMRj GtGDMNPWag== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372187; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=ox3xIrhWvCNfPDxHPs1JO/OZWPZa1od5AF3Zuh3AKLs=; b=Ybq0jesrQDL/xQALEl3zQ/Rk14Ynt9EwriREqxhReLIfZzPdkNMa6+vE5cqfbFal jbEOUXDf6pKLKEUAUbea22vfAxyLt1BT2KDJIsiGVuEpCYXDd35E+tghXZrwfEeW5R7 ZaBbdfw4Byco9dAL5zmf7E+4mpCBFuJI6X8sTmzA= Message-ID: <010701a18d4febaf-978ca346-cc70-44bc-ac3e-421e808a38d1-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 14/34] q35: Fix migration of SMRAM state To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-14-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-14-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:56:27 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E462:EE_|DB9PR08MB9826:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c15adb62-e0d1-48c1-3086-08df3695f9f0 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|61400799027|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261026121527099003|261028144727099003|261026140227099003|261022105027099003|10067099003|55112099003|16102099003|18002099003|22082099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: MrvIVkMdirPH7SAM1VD8SidWhESTLzcrVcla+FDNiB0xYGoIzKYXOOIQ9S20a4tpcWb1ytkPvYc9nqH+JeBhSw8e/p5DMvfIfY+2vvsFYDJIpOKrRPU2VvQSNi7ssnczo4p0hOIukofZTDwpPJ2SGjfRGEvG9+1oKBKypTcsdsNwYBX/x/wdyiuVuXAO4ISn5xcUcqlXpLgGhXh262cVUfiDXeaVCadw80XLpVwe4gwGemeEHkFor2o3C8yMKI8USWJBYz8sS4P1Zcg9fxXPHYx/yJJZ/zk4T9oUVUHJwn6ykhwTAK/Do/Y7+V70zaSlRKFDbPm/F0g8JB+nhErMMuIitx/uOvc2aYzxdb6DSm/xv4IjrPFM2IsaeDVjSBhSAY4yKTs4CGvGZX9KWbpWE0j1DDi76yTDwzkskvDuJ4481RAKWsVlLFGd+Qp2r9H4Kj1dqKkXCZBkHmiLdUsyQ2i3Lucgqf4lE9Ruvw0uLJaFs89QZrdQoaPXsww8dj5JJ5rNu12XLZz4i71mUGkOPiNJeS0r0CeRuwC7Un5XsJzVm+7iZcsSF81Wxl6g/zfzliSs40XghIlGjqNJMtojNz9UjLIVdXER/j7qjo1uI4FB8BGZuePQw0DX/hk8WP/1JXt/FNByBJ98b9DPSjdk95mFjaHCQKQzoXs7pz3h6HWKMicbVedBTDeJmatX3alWQhaSqh3V/nT5ykIKT6pt/sGkJQrTsxHh9pdqKHz+a+S5NhRk0i1IwW3ya0muJOA/4TdHbnKLIUzvJVtRg4M0TL1Ena4wST1Z2FMiqfLHFKeY+Wa6N6R3EETpiMetbtOkSkTYkWWRkoiHv6cizFy+KXAS3LhunDilxVMfDTInqK/+RFssJ/dzBEDNKZk4MIrdvO8VbxasHDkfJmryG9LffQ== X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261026121527099003)(261028144727099003)(261026140227099003)(261022105027099003)(10067099003)(55112099003)(16102099003)(18002099003)(22082099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g0pyvAVbragTmRhPpV5K1QUyEgoF/wlVDkjWC5Y2f35H3tjKDuJSl3To2KuP5/S9hYtwGq8RkQBJPg3/3BNkElbRR8DoIYbhqyKl97AZp3bpnXQaUgawPoknX/gkeGVcnxEB7IHwSXZpiV1pH8YY3YHZcnqdt0NAGgVl7bahZQswIa1MJ+bRvCygO9zwNvXXXjWWF7WkIYez0hQ8RhNws/CmF1ZZPo+3vQyeEpC/+cbNwUB38+ZMNnp9LO8QQhX8Kdd5mIPIFxMGFC6yWSIncKJQjZcq32k3nm6HQnGrC6JhQvTuWf/qx/tLVuVnYwi2DA2M0whMhjPFADPkfTHPhY+UQF7+E1LA/rRHhofD2qPRDoSpjUXEZXAUik41H7SLGBbJ40mXkAWtTlAGDbodD80hLwwhrlOAMj8XL7fnSsLX4mDbHbeNtRH7ktccATE8 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:56:28.0323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c15adb62-e0d1-48c1-3086-08df3695f9f0 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E462.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9826 > From: Igor Mammedov >=20 > When migrating, dst QEMU by default has SMRAM unlocked, > and since wmask is not migrated, the migrated value of > MCH_HOST_BRIDGE_F_SMBASE in config space fall to prey of >=20 > mch_update_smbase_smram() > ... > if (pd->wmask[MCH_HOST_BRIDGE_F_SMBASE] =3D=3D 0xff) { > *reg =3D 0x00; >=20 > and is getting cleared and leads to unlocked smram > on dst even if on source it's been locked. >=20 > As Andrey has pointed out [1], we should derive wmask > [ ... ] > Reported-by: Andrey Ryabinin > Signed-off-by: Igor Mammedov > Reviewed-by: Andrey Ryabinin > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D14