From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19bda3825-2b5581a5-273b-4e73-8ded-14b5cfa129c2-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023077.outbound.protection.outlook.com [40.107.159.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6BE7D80E7E for ; Mon, 2 Nov 2026 10:42:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Um3Hcf6oLJTpx4UQz3Z3rztKRe4o5fyNvWxXgNE7vNkrD3SzCKyNFjGSINUL9jK/uNLBuNhnf1mvE5a+DrDBJ1zSNAQSqrzRQDY2jow4GKAZz2HLA1fK5B/gEFxb8BHWSYUgL1OC0/3bDoDCy0LcT4qn89SXYDnn29VOVY76TyaGLF38r6z7250jmQknxGgNnws/t4fVGR8WdOBcZ2O2UGzt59T9vCRYjacVRY87c4Xyaebyslb0FaF59meGGdCUjsVLo0T61Uljo8NshW+gTQJLzvwB0RAEwPPQcjEMYzwN+V2hrWzHgKDRXfZYHi6t+TrqwrzG2ccr5oS3hEfVHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3PST9Xq8aGL8fUKX7pOv1zKcbi5Gp6pMjlk+eOHb9w=; b=HVUzGOEC6KdhvI4ZpbL+OJveexTDLI+dJnNN0/WX3HeJluGm13kZ4xwwAjklzy5kQcpim42OkeNaW21OVuaZApBtYhmOYfcOitmMNb+yTPdttwsyeDamKByfcG3s1TMWghAdQ5I9/XME2wyi3xlfQBxEL7c7JDcbE/765k5YSASO5nJRFahfpYxetsvQKh29Xp+aJygKeROy8gZyf+yQmsyWhK+7CZBB+g7qyrpf4pZMgAq3q3gufcr39k/9Z3B+hv76Kqsv7FAsd8sS3daLkez7qFTLdk3obt1s5DpFixj5BxvRiVd25Ogsi+fAVQ1HRlTLPKE9xM4sa1pOkD5QsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3PST9Xq8aGL8fUKX7pOv1zKcbi5Gp6pMjlk+eOHb9w=; b=X5L8u5shmZGlVX1GOnZc8crh+gBx+Ka52+GCq8LxIRRL01Cyjx7lSDL6FPC1H/zrs0XzqEHMBjSsXacvpH9S7zYUOCc1HcDJiyeQ+sDJ+D+UwABi9wBl00bo/PbnWSjXulh65oJ0+AU9oF9b2iF7I8e0ahrkDHK/1dk0aerTgPU= Received: from AS4P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::9) by AS2PR08MB9221.eurprd08.prod.outlook.com (2603:10a6:20b:59f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:42:12 +0000 Received: from AM2PEPF00070CF9.eurprd02.prod.outlook.com (2603:10a6:20b:5d3:cafe::ac) by AS4P251CA0020.outlook.office365.com (2603:10a6:20b:5d3::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:42:12 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AM2PEPF00070CF9.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:42:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616132; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=m6cENNRTFvGE5b7jNvu90qYx3ELb+TGaAQaOe8bckAI=; b=cTwuNFVbaruiTnEaNG7eIw9pX6XewQ7ASkHiRztCluDXpRekoRgzwfyPTf+xlq/w idIE1dmcktSTzeB0OUxAwTUoKrOSV7ASX3PbWYoPgpJuiCQb7qUqmpNiazNSBWoMPJp t39834kQeyAv5zsywnTmiXpHSSGPo3j1jU/HFblkBsYyzJXdsBQTNmdn7jpaVk9pLif Emdq/CvG9LcUbEenh3j+wrkQgHfpwBY4G6Dbg2y4PutDEYQPSIpyDPtWC2eYz68LZ9S FkK15emCEyl2yDgl2vLJ7lcnV+ZKtC59arXv9oTa5nS981/ZOsFQE751/01TltcQH+H HVz0YgP/sw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616132; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=m6cENNRTFvGE5b7jNvu90qYx3ELb+TGaAQaOe8bckAI=; b=VHEpFV2/pBooKgwADa1Dz/Y8MqjN9Jfq2Ecc7G869DFCrQHf3WVTWbsEZjazRESe WK6GuLTdTPxHj47791TZhP2xHqxtXCefO7QqbZL6Ii1f+dTVZm0NuAZlKS+QAZqdvwt mVHoahoySSszZSH2CtdoV5h9GTtqOIjqPiRWSDj0= Message-ID: <010701a19bda3825-2b5581a5-273b-4e73-8ded-14b5cfa129c2-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 05/34] migration: close the CPR state if the outgoing channel fails to open To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261102-vfio_v1-v6-5-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-5-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:42:12 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF00070CF9:EE_|AS2PR08MB9221:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 53a14d7c-4ee5-44ba-93ae-08df38cdf433 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|61400799027|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261026140227099003|261022105027099003|10067099003|55112099003|18002099003|22082099003|16102099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dE4zVWZQSDVoQzVHbnBGNzU2WmxkcHFOelkwYzhNZ1o0VVdYa1JqeG1ibjhn?= =?utf-8?B?MWJjLzFSSlBWWVRMNzh1Q08yWGZieDJMQm14dlNUQjArdEhmMW16eTM0M3dU?= =?utf-8?B?eHlnYW5vdHIyRnVWZ0lvTVhOdUNXUC9CaU1VNXd5Q24rN1VSWTdLUUdHUlBB?= =?utf-8?B?aWdwSGhOTVIzSDNDTFIzUmNkemY0WjlrSjBMTHoxQWNjaDhWNCtuREpFYmIx?= =?utf-8?B?OHR3bmVhczRnR1czOUNiWmw1elVqTUdjRjNyVU02eG4rbFFKSVpYTVpjQlph?= =?utf-8?B?S1lqc0tWcG53NUl1QU1jS0lyWVk1dUNpd2R4ZWg0ZURsVG05OUREUXNlK1Rr?= =?utf-8?B?T2IwQjRUbjlGYzJvL0xpZUlncHJIaFZPR2VPQlExY010RlFLMHJSR3l2RUpH?= =?utf-8?B?L2pHanlZaVRjK1N0b1paUWpRNzJsTmc2blFheEhLMTBjRVZoVi9BdkRobTVw?= =?utf-8?B?U2Y2eFNrVFNTQzZUOTN2MGgwdHkycFRXSS9vZE4xbjBqYS8vd2VEc2JXemla?= =?utf-8?B?eGVTdHFtalVRTHZzdkdiOWIxOVBLK1BDWnoybmFwM3FYTk1OL2w2dndHOGN6?= =?utf-8?B?OEtGNXdKVFhHbGpXdkR5RTF6Zmc5MThjOXcvUXJLOXRPWUY2OU40V3NTYm1G?= =?utf-8?B?WDZ1cGtjRmhhVXBFQ0tnaWs0SHhPSGsrRUM3NlI3WXlOUXJEeG5qVTRxRUVi?= =?utf-8?B?YTFwZFhIcUoyWHcvdDhlSXB0UTVYWDRod09QYkJjSHNib1ZzcE1md2NPUkdr?= =?utf-8?B?R2dFei9tMml0aURXSWpMODhOQWR2ZzVma0JBWTlmSlhUWGlLbEs0ZnBhdzIv?= =?utf-8?B?WEN3YXQ3aytIQmZNcVlhNXdOY1phTkk3cXltQWhHM0hrbGQ1R250L1FkOGFn?= =?utf-8?B?emRpN29qSGlGRzB2bER1OXp2dW40YVNYOHN5VlVSRmx2QkZ4dXNRK2RlY25a?= =?utf-8?B?eWpybzVqT0tZU0pXOUtyckYvSWd6WmJkQXpCdE5xTGF0OStRK3MzVlFFRk5y?= =?utf-8?B?Uml6QWxOeCs0OGlsc3NqTXhKeEN0M1dJSTlUODBIRXRoMHp4SCtBQjlRVCts?= =?utf-8?B?aStOelZwT2UzMEJlZEFibDN0Z014ekVPRmFPTVFvd3o3K1lMVUNyejFHYms5?= =?utf-8?B?UmRrNlZVVkxRblZ6SkMxOXVYYSsyby9EUi90RmJIUEw0aTZ2K1JLUUVhdyts?= =?utf-8?B?V2xaZ3dURFU4R21ValBQU0YvaXd0RzVaa2JDTXY3RUwxQitFQUFhcnNEOS9Z?= =?utf-8?B?Yi9DY3pHQ29DOHRJbFhlRmEweHRqanRtTzNSaFRRVmloaFR1Q1BXZi9uRmFs?= =?utf-8?Q?D8Fu9d46YVqwQ=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261026140227099003)(261022105027099003)(10067099003)(55112099003)(18002099003)(22082099003)(16102099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cgApSGTv7A6Dc+3Biw6JaRhmrRjLszJu6oavadaDPB0DOKafhyJKKOEw7d+c2fVh0HjRrtX9AjuW3OzuVyoUB3V8gZv2CEqwQv2Pet7PEI7770kjM02qb2HO+4Trebc6yoCNd+3vU+LCklk7yjBR9w+sIXZ34CJFf7wMThFuO949U7ZSpm0EMpQUO+Vl6XaVNUzjoog4pK8eEjJbEffcUPPmegM84tF8tWr5bhjESkBma/ZJXleTSu4CM1J6PRxBI9FfHFDegpy+ipx0t6twiml44iTZV8Ifn0XtiQeHXaNYMdgEz7VuExWOTeKhkO+HHarHVVQ+wBgcRutOCNK2o6VywAM6UcGNVEmP24AcRyG5P7HuCNeBDg6IPm/w5NBeMg4W8/J3pHlaE5Y+2O8k8v3RPgjyX4xkxem63I1ZVpvZ7CF4lcLj7Dzkxa84Ddjv X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:42:12.5729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53a14d7c-4ee5-44ba-93ae-08df38cdf433 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF00070CF9.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9221 > qmp_migrate() saves the CPR state before it opens the migration > channel. If the channel is a file or an exec command and it can't be > opened, qmp_migrate_finish() returns right away and migration_cleanup() > never runs, so the CPR state file stays open. >=20 > Close it there, next to the yank instance, which has the same problem. >=20 > Fixes: 624e6e654e11 ("migration: cpr-transfer mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D5