From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023131.outbound.protection.outlook.com [40.107.159.131]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2271B8045D for ; Mon, 2 Nov 2026 10:45:06 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Shs0a8/PsPrX7AlJkUQEEp0TIxCImcev6x7r9t6L/SyoMg5LOPlJQAq00cxC5tXKVEwWwXjWw+fljc+AfXgNoobVZgaswhia9vVWFQDKvkvUCuusNA8UvNhLpIWHkzkkqj4hvAfXZHKoXutKOcTl/ae1HIZvrmYsR6ejC6vwApQhwq8B/D5oaBSUJVDNirsJNrPx6p/Z4psewaZFolOSTBprT2W01hWLY/0FfmWqO33+sNn1kwvE1gNiqfLEPnPkd5JuyOu9PDk51T1aEyQYtoQ7TbXevdJuyqXv9lumNZvzd0IrakHRI2fLQkkLRIZ2gxyUI6Yh9IDUlDMpKozC6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0WtwfBqfsSW6wMbNvSCxyqKYBHdkSs8TmbP8M3UXBdk=; b=Vhl9RwpDlc2RzPsn1DnqWQmmzvJSaAhyQamYg9V4Rnr5XaTzkhdxtDW5Q/jhKH/Xom8T7iKxBisvs0RigOGhIEtTVHVjI6s7e/5AejLVa+ps2neWdKCh9LCbe8WJ4zL6s0i5kHoRz6g194kGkiUauCQxRgA5nFPt9HDkO1kBAQB5h5PUhwkb8asEP50WYluFe/QB1RnbdBUzcIurXlQow6e5/+46hKRJlBB/YP/dy7LGW8gzKW8sJTz9QYwqaWNIgrBo6lQ/ux4IUQo0QPRJjdvrj4EPNLttiFDW1o3B7m+zrtEU1wl+RAZY0gzknlpxDvx9/olKn2CTEqjjfsPeww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0WtwfBqfsSW6wMbNvSCxyqKYBHdkSs8TmbP8M3UXBdk=; b=jkLDoXN1Z6VmfQO7hQGbXRUnqHbR8oT4jceBDMwmCXr0/qXUSMDq2VTLcEcG4lhXFq4CJDjIYQ/YEz2cgctaFJphfRinBSHWwW669bXAeGWLRV92+/9FWvg9Q4kI63lapI0RhKNbbmRQPa3THg2x+YzqXd6iwfgKCLvQA9qjPSY= Received: from DB9PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:10:1d9::29) by AS8PR08MB6502.eurprd08.prod.outlook.com (2603:10a6:20b:335::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:45:01 +0000 Received: from DB1PEPF000509FA.eurprd03.prod.outlook.com (2603:10a6:10:1d9:cafe::1d) by DB9PR02CA0024.outlook.office365.com (2603:10a6:10:1d9::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:45:00 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by DB1PEPF000509FA.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:45:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616300; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=+kEVM9jPs8bAOp2SRgUt6wE1xu51dJVsCHcxpLOjTKI=; b=yFafI/KB0NMB32YtaTztBq3/HMgX5eV2eyuAMabRod2/nd/kFfyKaqv8CvryPbKL n8OeFPr7g2M3ZFt/4DnqmDjja7OFoPhnIPEAo9WW9z5q0T5lSrGuCCVb+kTM4zRyjzI FXmenhlMSdpxf2a8QlT0uUeJrKgri18cuUbfgwnza/SsNL0PS1zhaaqzfCicbjyTGPT 3nzr9ow14kkiJmU/w+tISVOe2ffRNDozym4nup+s8gKx/LrBJjiLWiHFHpCOShYbE2b xi7iF88fqv1Lt05iaoTFtlbBEH7tBI4O01b/Lf7PJvldcE5bfGuC2Ni1uxY1BCQLtOL v2EvojJeKA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616300; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=+kEVM9jPs8bAOp2SRgUt6wE1xu51dJVsCHcxpLOjTKI=; b=G1hdI63Tqqb7nCs2Gb6ogo0oLElnBumHn0pyOdaKslj5DJPvEgDzlvQljUOrt75B bBIarY5B5YgNRI7Md7JfQzwOKvkYSAAxmd3qiRwnugC84LYx/aD21fWQn9lmSmPo7P7 WvHOzYZ6oegerr2tnlecvVyyliuIvptvT497ksjk= Message-ID: <010701a19bdcc75f-2d0cfc8d-d62c-40dc-80fb-a2055e2ce5da-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 08/34] migration: Plug memory leaks after migrate_set_error() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-8-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-8-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:44:59 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509FA:EE_|AS8PR08MB6502:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7542c8ba-f5f6-4aa7-c0be-08df38ce5835 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|48200799018|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261021121427099003|261022105027099003|261026140227099003|10067099003|18002099003|55112099003|22082099003|16102099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S0YxYy9RN3JMMXkyZkxZWE0yamxDWDlDSzgwZ24rL3pmUU1mM3JjNUF3VU0w?= =?utf-8?B?MFpncDV4MGU1ZUVLeGJKa3JCb3BZbUtZdDlxSm4veCtjUFdsSXphOUVWMEhi?= =?utf-8?B?NlpFVHJDcFBwczdaQU5naW9ETDhndjV5WDVnN1AvWnEweEhRTVdQTkZxZGNE?= =?utf-8?B?WThvSllhdTJoUVdnRzBGTWRtNVQwdWhKTHVjbjZQcndGelU2cE5GRWxmazhY?= =?utf-8?B?Z2txTVlwZWp1cGxSUU1LZTFOVGJsWGthMENRM1NDN3RiUksxUGtIOW5MVHJR?= =?utf-8?B?c3NYTkswcElvK0hkSWRrbE9xOGxUNzh5bm5KbzdBRnFmWVhMdGwvbWI4Z1Q5?= =?utf-8?B?K295Y2QzZkI2WWR0bzNkWlo1dHF2UmR5WWd0bFNQa1pkdzUwdzNnV1ZxNGFy?= =?utf-8?B?N3BPZnJHQ29pUUF1NmZiSndVZ2xWazR3NTZIN0R3RDhRbXFwQ0FreTFGZ0lJ?= =?utf-8?B?bEY4UEE4RDFBbjFmYXdBb2RMYTh0R2lCZWpuMy9NUjVDVTlmakx4UUcyZnJ4?= =?utf-8?B?UHNjOXc1VzNlYllKb3lOZmR4ZG9JOXV5Z3BLOU1xMWRYYVV6WVM4SjIvQ3FF?= =?utf-8?B?QTk1UkR2aGowV2pUUjE5MDh3MEdJYkNEbUZrRkE4cE5zbHpMSDcrT2d0Y0J5?= =?utf-8?B?OURzRmdsZTFBVHVUUE5vVWhFUVBVRkN2dEJDaUNNd2JZREwxcjQ5SWsxWlVN?= =?utf-8?B?OXdrekdIa3p1NXJ5MEdtcE92SnNFRVdaTU9DbmpaZHpickVRektyd3lzaEdB?= =?utf-8?B?MTh5WGdQemJaSXNJeHpUVGJNYlNvK3FQL3R6R3VFR2hublZGM2NYMHlWYVVq?= =?utf-8?B?ZUpYR3ZBZm5oRmkvZEh6VnVGZFE3b2EvdWNlTGpTTjJVald6Y09VcUdUT1dP?= =?utf-8?B?MmE4WDg1bDNlc3R0ckdtREFNRVhoRVJJRmt1dWlSWVpjWG1iTi9wK3c2VCtM?= =?utf-8?B?U0tpYk9qQTdPb2tWSmhNUzgyZ1NKQlhaQjZvazVoVGk0ckVaSUFETGVDalpE?= =?utf-8?B?b0RjUWs5aE41Z3htRFlTcWVnMnM0VlpUS0tVOEt5M3YvZjFDVzRHbE1haFcw?= =?utf-8?B?bk5oV014b0Q4bnp3d0pCcWpWMnhJdVh1czYvbUpaWXdVSkI2MisvMEc5dFRI?= =?utf-8?B?SkFtMk51bElmRG9yOFlqdXdxYXFmbDJsc2lGWHJvTk9LNnNKcjVIZXF0RStH?= =?utf-8?B?c2RVdGg1V3hZNW43VytVTGJJeWFzcDN4a3Q1VXFLZ1VkcU9ESU9CTlg5RlFN?= =?utf-8?B?SEd3ZnJnZ1hvMVREbjZiRzNEL0NSUlREMyt5WXRJRlhQRDF0TDhLc0VkcXBM?= =?utf-8?Q?7rl2YVI+osNHpJFIcfVHz4wocvx22IKkUp?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261021121427099003)(261022105027099003)(261026140227099003)(10067099003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: apOd36jAa7XKc4ZhkVi/tP1lfuSP+AGwmYSh3ysMUj+COCg45WK1wFgm4kzk1qlxbp+CoZZhtHJvGczhd9HCa2IlM9BA8G+XNo9s5Tgy9P4g1VqvRnJcYGVxbMI1ObD+ArEGPAjdAuZHHyr2eP2PcyfI2iABCP7/2rRTKhPYMpz/gIzgajuSLreFvdGuy/+eqa0S888qqI62DrHuybtWwG/LiMxPporoQ/jhd9o12u+gU0z0T+WNCigVRBaDqUv2jc5+1AL42aiG9aJMYzElCM2T6PlCv8g3dlf+4sihBt1atlAg6UrfY6yT8GYh9RgLArpQG48UutyMya3mpzM6iJR7Lw7zvFrBdqgwn0W2CwLBi16kOYNPpYZVeqHbQS6mRwGCXAHtebOJ/oe0Havzl6HY4nPHcpZk0Ir8jc/2zJsaMWgSUFk0tDtqE8R9WP7h X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:45:00.3372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7542c8ba-f5f6-4aa7-c0be-08df38ce5835 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509FA.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6502 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D8