From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023117.outbound.protection.outlook.com [52.101.72.117]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1A9C38017D for ; Mon, 2 Nov 2026 10:45:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QIFiH7+kOY3bhzPU3VStJw4g0JOoMYHL1jyrMt5mZxvqVQVBujyKZiNP1GVCicTuarKJ37JARR70gRPAKV28yoDrq+Lh6/VUarmnrAYbKymVK3Flb21K4njGOZau8IcRyH6xSANaKJe/wxUj/o2fbCeF4HX0mlZz3HFF9D/nYQP9Dw5bEE2MwXFhiAfobWRqaLCjFC2Rwyndag6+9/eG3uzIAMlMCiZXjGiw0tTk++X1eSEOp9umaRdd+eBPf76Oh8KidytAXOhw08O7omufUhDg85/i+CRbFlOJpf9wH1ivajC66f2kHoMXS5Pv1oYM817Y+4CwT3rQEPws6WqeUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AUcHaeIlQHsXkuFVrLB3pqhLe3Jc4uBpKbHJpjnwx90=; b=DhlD5qnJ0Uok+ZEHEdBpU4foo+Mng0z+aktnxvIUEXZKjKI94RooWdKBxQ64DpTC2K8W7HvH8HSg9Ynj8XDq9domHSeJVhHdHVtNy8k7UzCt59ew2KVPHlNQh81ISYlq/LrORxc3MvY5ETtcXZp+QEoNpONJAtXlMk2/LlVNW86pULCy+0L75RgA1VLSuh8pPS7QvjkJ9UlA7LBO5qsTwO3g+AjHt2jS4MW0kB4szwRw6ldS6/JN1s9M4WMSRFjkk3iLo6JXv1PJk3zM7ZXvzaku/V+PJpDgm/hhzpl2dRYOwROerDFZTXholQk+XI+1/x7lFWnqQMdst4gYCGtPGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AUcHaeIlQHsXkuFVrLB3pqhLe3Jc4uBpKbHJpjnwx90=; b=jVMmnMFQw+fa2OKpf+PFYhMGRL4aA6yz6N8vi75uGG6FG9NkuKUHN4QhGt0nVEqrLLQMFhYGLdTVEyUQrcjvpkKDJ6ytyrpFMF44tC/mAR0G37PYigCyjopzLjbZzlD+o1/p3K4f5wfBVOPdPq596KT8S9/mgsqqBbLIsV08kus= Received: from AS4P189CA0055.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:659::22) by AS8PR08MB8825.eurprd08.prod.outlook.com (2603:10a6:20b:5bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:45:22 +0000 Received: from AMS1EPF00000091.eurprd05.prod.outlook.com (2603:10a6:20b:659:cafe::3e) by AS4P189CA0055.outlook.office365.com (2603:10a6:20b:659::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:45:21 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AMS1EPF00000091.mail.protection.outlook.com (10.167.242.88) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:45:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616320; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=MnCOXQyvonV3dc6+OkiGxkP2lHlGUEL1B+xRqy1XKAQ=; b=rFMkzJZuFu90SaPPR509yeMUImEKQkeXDES9AFqNhff+aglo4BsOdcmeCUKaZILh QZyRFvOPjv9fuu1Z5wHzrQy68WQwgl7kIh0dz/Q/M5sDbU8DXsqYh8Vo7vmQOMmsLve sYLUwBEteDxVL0Wz+VaLMSazsx8sAD1WDyDgHsGYGZk2WQsg8p8vUmP9ukTLU/4+Fya sNGz3CKhU9O3rfQORZu7YIkaLurzCey7uiMUUCxwc6E/tAgO72Wx0bcyQjVCi4dfuiu tjWedb7SCf3hqRYQ0RgXYfv6SB8Svx/eKXobe5d8zggVu8RpnfduT4XSR9c8PlZFQnR AakB6a798Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616320; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=MnCOXQyvonV3dc6+OkiGxkP2lHlGUEL1B+xRqy1XKAQ=; b=Yaz03xQi/XvEQUHdQB0vGCeMobt55Q+cd8s2eVAjj04BSAtbkFNBRTudrcvfqeuB JHj4QDAVboGriTmYv6cx3BPWEO/VU1MIf3ThFSCp6hN5Ox4NSuq37vTJXNmdKwp2cdc oPn1lNRs9zTuHZBB9iDTGpe3rFqPfwfdUrdmTnFA= Message-ID: <010701a19bdd181b-89acef92-c012-49e9-b6c1-c8d3909fe1b5-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 09/34] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261102-vfio_v1-v6-9-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-9-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:45:20 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000091:EE_|AS8PR08MB8825:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 07284318-ea97-4563-074e-08df38ce647c X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|376014|61400799027|9140799003|32142699015|260925021311599003|260925022911599003|260925021911599003|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261021121427099003|261026121527099003|261022075727099003|261022105027099003|261026140227099003|10067099003|18002099003|55112099003|22082099003|16102099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: 6Bv6MFZVKL0eAMfE0MyHPWVpmM7j9/+lhNDZQtnNNJG2WKPr3yHf6ZZ9upZwdk5c4Ux+28EmLGwpExE4JkbjyRf/Mm1iRtTho90sfSRnILfkMe8EnABeJi0+GMt/R+a4ATDmtEpucJmXkBeRLI6owTQ5bQs4GpDaDDa4vCRgtyS18zA3jQ9ANnNaKsj7PlueOgkl+6qoiF07cxcw3i9AvuYkyiwfh9kmazr7wHTh95ilAqwoFxmhC1jOeDC4964c/W44Fk4glPKPzJ4NSWcOhmQndm4pwMrmGxvm99DXHdOQqY6DuIo0RK6qbTvRtMUI90GKUU98OYLWFxxFVn2y3jcPRctqDKxOpj1dXSyT9e97Vj6TSrYp5gdaI17BnS3on5JTuCe/IgvIeSswUY2EqbhY1/VwO4s75dDlJvNnvaPas8slU0vnNyaurakmEMTAEtxIhJWQAkoffDz3exvpULiN8kk4yueLfjL1lySPtP7tyabAMTwbGOtiWNfnUoYPRGZ4jvwsY/Ct0QByAzwmqQlOMLmJHxcdedXU9xRtMkps8uSkwXTukYSir3mmwisLLOBNxCTGDWpcRYg6PRcZ99fEt626TZ6dlpPtCm5WrnOazGebByoGrcNric/r5tLiUiEoCsXSLFG88oIEfvu7SJkNmueN0oh4FY3d/NVinNGbhCCe1mzYKuxzVzSDRd+Cw68FQNfRUh1I36ax+3+13PSieotClCJqLJQROcAkSL25Nsh2xUZIu1wOSh4GukMniNqicqOzX7jvRjnZfVxw/13iVtnmwcXmqJ+oFH5yz4bYTT/LmzpJ4qY8cv/vWuHZdWYjg67pAyAxufQSFhDlTVAKMyjj2K1h1UOMgmaWF8qU4yBZYPALdpMDBCfrzLX4Vd8RfHKEqf92FXkpACrpc68aRUdFWSOQMYPVyjZ3o4E= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(376014)(61400799027)(9140799003)(32142699015)(260925021311599003)(260925022911599003)(260925021911599003)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261021121427099003)(261026121527099003)(261022075727099003)(261022105027099003)(261026140227099003)(10067099003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6svo26d8RFQUayIBpPHSXXJd3q5Kufe1A3u+WhBcBrjRADsmTG9vqcNUGngannmg4Fjf8kCeKH0dA65hqs8vbUghxzzZfAROoL9PF+c1qJLjhyCF/LCn28whxqRlFDv/SWmmD+rd/5YKJG6OurYtom2l4QhSXe1PGTHDlv3EoQe8OeJg00U8UJ80EdF0nOS8O1pigIG4vTK44PtlnUGmIHQHgaPK6xEPQzxW9xbfO67bncY5kkfGUskG12OV8rPsfGpS7i0GeAo0lygMCKeWpf0nr23axwI4nvX5Sl57FAHiYUPDuq7khXlkGEk3ngkqxOkWb7j5EQVhjAZlKcoK7k93hr00Di3NGrRr9JsWAngo6CFk4KHWb2SEycl8KcMhMf/fHG02MGGzfrWJyv++0rQJGDRx9QtZY5wy81TXONP/462RRO1yVLdw3uEbIJGB X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:45:20.9459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07284318-ea97-4563-074e-08df38ce647c X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000091.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8825 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D9