From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19bdd957e-8f57e319-6da7-48e3-86e5-1b6e89d28fa7-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020084.outbound.protection.outlook.com [52.101.69.84]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0A7B28045D for ; Mon, 2 Nov 2026 10:45:56 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qBrcbpTru24Y0ZF3FtizhvdXN9FQEJEiVNO33QyQ1Btklxo5qYBxx32VuU8FtiVIbNImCm0cDoLKD9ZdyqyQVWOHwYxxbuiLdTOfrtvYV9q6Ar24qrn/57OtGJhgHmWvBcet4CB2Skt+6DwzBgfwjKMueeV1ZcjdIxHxMX8FR2c5afE8q5utErE9w2Cg5S2igGDDKvVdMheUUhKZfOrGuexbqzfw51pDLQ3lNDDskM2ijWSGTBdbL1c6v6H4eB5OFa0YwwD7SeMkpeneNv7Q74IPQrdLyTEj2TCJcHSM9U+Gsk32Z4s44P2YWTIK8Tg1wKyPtxljmZEGxmeKU2K4Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ItHm0qjKlaH/iQ11/OgKE2qeK6apCUxs5LJ3KjAqQE=; b=H7yZG7704d3KaiIn+fv4liQ2FBbV1NYoMGsL/fyUeCbBRjQYDBsoLmsagsDtzWHSBCUZxdwgIMwZtL0MnGc9Yb4MdxLYtNLpUG94dld2TaxNsWjWspqGAZOUtCxGfrh2OtF/m+HOwJ48ULYTXd65H+cTYL1P03/nuMQQL4b+kU/D8Y2VLxrNWA+nfq/qDPCoOTr4/HqYJGpEOnpej4OYCGQySWmeJC6ubxXrINaV+efTNiyO7zJ0H7B81H/eMI52nwMtjjDFCziqeFQnrzFT0ApJLN9lw1/UNuz9JIh+Patiz0GcED4V4g+vTm7A2EAR75FywwT1aaw+syDUF938wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ItHm0qjKlaH/iQ11/OgKE2qeK6apCUxs5LJ3KjAqQE=; b=oq4iI6aB8ZAZgzn4H+lpICGkuuPZfXRdg3gkuEZvR2LBWxXsXNb500bnxmKqrZU5qImRBRsKbi48TtMAd+61EZJREiDA9a85vesmsZv1gRNssJ1AD6D2eHZvjKScwXtBw+9tilKRPcMfAwYAjCBWkAFg1Es81xvmSYmxp3NF9eg= Received: from AS4P190CA0016.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d0::10) by CPHPR08MB906065.eurprd08.prod.outlook.com (2603:10a6:380:105::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:45:53 +0000 Received: from AM2PEPF00070CF7.eurprd02.prod.outlook.com (2603:10a6:20b:5d0:cafe::81) by AS4P190CA0016.outlook.office365.com (2603:10a6:20b:5d0::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:45:53 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by AM2PEPF00070CF7.mail.protection.outlook.com (10.167.242.9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:45:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616352; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=4iyI5N1JhbCRO0yIkynvzLKFWLlvoZQqbJVo1lTEH9c=; b=XD+lYFOZ0mvOo1KjPBIDhtUMs9m9SG0Xb+kHo1f0Yuz1BAro+X21OfRqvAM0EqC6 cWerVIx7BhHVWjL3zH2MB9i8KbUWvL7czzCaAxORA3mTwFrDzHEQryDKyJ70spovZ6S a5jipXXgNK0fE4x2tAJde3KBIsOtvTx9/N5Q9AM6R27ygLVXr6xE0voH9TGqb9JOnr1 NeTjqiGQrVvlO6D1KzSCiArRKKulte3T97vsE+jWCMg7IkGzWEPcwOxBU7N/kQ67cTQ ++/IoKVhaU0SC81AsiSVtWIuXLX6Q3S3III35+u2v0Bp+XZaWfL4PxZCxe/sluRPpKw 4JsiouXidA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616352; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=4iyI5N1JhbCRO0yIkynvzLKFWLlvoZQqbJVo1lTEH9c=; b=UFkXI2/weN717fZPx57D5czSpeJuKCCnc+/PJsVi1wLgnXNZaHnrdtRTRIkAQxdu hZvgVfp2j6ZtHiDzAzchPzoEdFPjt3sXODuWuAxzri0iOTT7mVKP1ZYipsuc2/oOdFK KmL+7dos6zh7oJr6y36+NG8mrKEhufow6RXORNLE= Message-ID: <010701a19bdd957e-8f57e319-6da7-48e3-86e5-1b6e89d28fa7-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 11/34] vfio/pci: Fix information leak in vfio_rom_read() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-11-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-11-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:45:52 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF00070CF7:EE_|CPHPR08MB906065:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9b4e08e5-a6ef-45d8-e068-08df38ce7796 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|32142699015|61400799027|376014|48200799018|9140799003|5113699003|4113699003|6133799003|55112099003|16102099003|18002099003|22082099003|10067099003|56012099006|5063699009|261009223027099003|261022105027099003|261021121427099003|4143699003|261028144727099003|261026140227099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QnpvR3QwMFVta0R1VldXSUdsOFpFcTBHSDM2THJJbThQOGxwRVJPY1hSUEl0?= =?utf-8?B?cncySFNJREpCZ3o0TDUyYXZhbmZzd3B4cXRka2w4VFg3NnArbVpUdVVGTlRG?= =?utf-8?B?c3JOS0x1bFlzc09MQUwvRkFrSWV6QVIwTjdIamFjTGtwNlZhVWhncHNaNXFx?= =?utf-8?B?WjVMVm03aHZlNTVFdlMyaFQ5THBiYXZvZnZRaFFzL0JlQkd6YVY1UGZIV3pB?= =?utf-8?B?OWNmcy9BQWFUclNnWGtlSzlESTdVWUJyNE1qWVNWeWg3OHVRNlUzS2xNazJh?= =?utf-8?B?UTNEdk5ZUWNDWkhCbHBpdHJ6YTg2S2k1N2hibDdIazdDNnQvUTVvcjZRWmtY?= =?utf-8?B?U3RkT2dEMDNDOHFiazNhZUFYeGJvckxlQU03ZTlmZUs2WTd0Y0FNZDQxM0JS?= =?utf-8?B?RlQ1bHB0OFRWYlQzeHZVaCtIUXFjNGRPcjBHYWpBcDZoTzB2R2cxNmJwakhu?= =?utf-8?B?NkJJVmlNMU05TGZjY3hET1MxRGRmNitNUHB3c0tWaWhScDBMcy9ueldCT1Vr?= =?utf-8?B?TElCWWdVQ25oYTNsMGNwdDN3Q1BVUTJCMGJLSnFwMHcwT2tMa2Q0ZDRGWU5S?= =?utf-8?B?cmFYdkd6SXpmTFJycjZOcVh5L3NUTG1rRC9mcGhIR3NWT0dLcWZYTjE5S2dO?= =?utf-8?B?OE1tem4wVVZ3c0k0NW5lWnUyaUZlTTZBQ3NIN3VheVBxQlJISTBxNWpCQ085?= =?utf-8?B?L0lWVDl2OXU0YVk1RU9sY2NIbkoyRytoTFlDMVBtbklTM1hqbjQ1ZkNyT0da?= =?utf-8?B?Mnh3Vi9MK3dEU2dqWXQ5UVcrakM4bUZxdXhOSk1oQ2xFT21Kc2tPL0kvUGlZ?= =?utf-8?B?bHExUmVTcTM4TDJSYkRlSUtFbXNzQTdwTkx4cngvVEFvdFhMN2QzdTFDRFlM?= =?utf-8?B?c2ovR215RXBuRHU0djlwZzMxNHdXRitvekNQZVpHYklLelllQ1FGN1FtOUpQ?= =?utf-8?B?NkVoSXdxU3BpbTBaMnkyRytWUkZCeWpjTW0yY0V1VlkrQjMySXhTY25vYStG?= =?utf-8?B?dGRGSENZaUIvL3dOQTJYL2d5Y2dUS1JYa25FWEZXaTZBbkpaUGYyemMybzAx?= =?utf-8?B?QjVrekJRRkQ0RE95R1pkU25IT1BidG1YNE1qbkFxNzBpSFFaZkgzL3hQdU8y?= =?utf-8?B?QmVFMDZUbzBWVTR5YWZla1lvVjI1QWNia3RtVDFTZE5FOVJhN3RIRHVGT2dz?= =?utf-8?B?Uk9wM3ExekhtUFlRdHFXVDg3clQ3bmNrOFNVa1hUdjdKcTZ0Qnl1WjlucE14?= =?utf-8?B?b0xQclZBbVBvSEZRZjd5SnJYVXJYVnZEelBHRThiaC93REdyUytkSE9peUsx?= =?utf-8?Q?znSQKpp2FDMeA=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(32142699015)(61400799027)(376014)(48200799018)(9140799003)(5113699003)(4113699003)(6133799003)(55112099003)(16102099003)(18002099003)(22082099003)(10067099003)(56012099006)(5063699009)(261009223027099003)(261022105027099003)(261021121427099003)(4143699003)(261028144727099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Px256wAivEamuN8f66zGP4NWlUiuSxseLzswY8bPeyjKhP2KOz4oGaeHpSVcA8eqjZUgbjzkUC46SO/9/tCa4xWaKqRFB2Anmp/YhmBAVjm0wIsFarSWNARJWz43Kz6Hamp8p3JQVbVxuowFTJzN3hGLWsixU/EuZ+35+hKwKnKnuCItP9G8XJ7C/iKKl/ZzxC3Wr93coSkFhn0S2TPk0lzvwERQf98fLDYzHA7QHS06t1yQHq+6ETEfXjhnkw26J64EWRZmnrUirFnkC4xi53iGpDCm2Tu9up6wl2ccJib35G+AmTGeLeMQNNrgbZLEElnzE2FUOynwQUTrUodb2nkUm0cVVae1NJ+fn1jdMaJ17eHEvNHlj8khXUaO/ZsZ9lvPLUhYPF3zdCttUzXbVhefhjCwTfYYsS/8c/FGENnIZ8EPEsSO6JiUw65LQ0m/ X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:45:53.0045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b4e08e5-a6ef-45d8-e068-08df38ce7796 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF00070CF7.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: CPHPR08MB906065 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D11