From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19be4e7b5-814c0145-4b09-4ed3-8a72-f61b1e7a353a-000000@eu-central-1.amazonses.com> Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021133.outbound.protection.outlook.com [52.101.65.133]) by lore.virtuozzo.com (Postfix) with ESMTPS id 49D208017D for ; Mon, 2 Nov 2026 10:53:57 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RTNv13qxiG6j6oiR0CSThoNeeglogiJoc5weIDsuYEqJBw7oDTLAAZUatJyf1Af3HBFPKj46sAsoLz2lfrvPN8GVG/k71XFRWlSdEALT0H8NOwZdDrMJ54xrnyOFveHN/AFk51sQffrWyzS2b27V2mND5sjX6Yr4+RPzaat/rlocHJ1Nu9BlgNA3gURO8RIiZGdxpF6qKc3QFcF6DABUtT1khGyNX802yJ39acIvAeRQhzHenNkW5QSyULDW6/sZoWhIWmnj08GYr0jxGhViFtjp1T0CB6hlTojshgDL8tJaMDTOg5QXz7fNr7mOCze34k+4cAK5n5TKxCKTj+uYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twEuhwBYzWFlEQLE3sQQrKqLS5Y2KCcOhDzHh3x6TAk=; b=S62zovDtVbf8pT7eFzSmdeWf/cIjSh734Mk69fBFuXJCSefNNIOvGCI+8ZVYgJtcy8mP9lkrs+xraEmUko7VnBT1bRiiVIZ405yO8eZSD2rpJhTm57xRjstehomcg2yTRCaBajvO+RDLZrTtBPTKJoOzyO4t1AXrTplaZKdqIQWg4PR9Xshcxe7sNXGPfPmBWBQaqNT7DOapTzzyM91DlgWcjYNjbK+g1L2y0Jt8nDrnyLOi3oBD09kUlsqa8cNRMxwMUOojuG1jGZfGVYvRPcsVs6uVu+xtd+wo6X/Bt+OTE5+VcnZ42aQRDglFzWDtAVmjhaTuY1LpP8qk87k0Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twEuhwBYzWFlEQLE3sQQrKqLS5Y2KCcOhDzHh3x6TAk=; b=gkrixSUiRPkuaGeicfjlz9khe7uSyMGIELSvkHaRhr7QFy+xDhVXRfrGdVFatQMqMmzTRGCzBYFYINImT6QVEZYVVDsjS6WcRH6Cs9QnZD+aR0VImgsFUgjd5l7yS0C6fVb37pQef3h7oJG+/L70FHQGT2svo+xKnH1G5PxoNQI= Received: from DB8P191CA0018.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::28) by AS1PR08MB7612.eurprd08.prod.outlook.com (2603:10a6:20b:477::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:53:53 +0000 Received: from DU2PEPF00028D10.eurprd03.prod.outlook.com (2603:10a6:10:130:cafe::84) by DB8P191CA0018.outlook.office365.com (2603:10a6:10:130::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:53:53 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by DU2PEPF00028D10.mail.protection.outlook.com (10.167.242.24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 2 Nov 2026 10:53:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616832; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=mBDUgunlwyYfDRkO8rKVK6OOeYQ2O4ppj2zJZjpu82U=; b=GObb/GlUtMdYVVmkf5EMYfUBJ0lycoZow9vnahETvlt/qsSdFgW74wo7liVHpla/ 9k+dNuui8oWbdI6NVTsVVHjllxWSx61QB4JzyS1qA+Cm2BtwwcVF2w/SCZ8J7Jx97Wp or0TQaHuwB+8aiNVwDU9k+L7530qFzgRdgtnFw5VdRoBkRV5ftakDSUCcXybSEPXOIO UG5XmupSo36RDXxJDDOlJMIcYShMYd7FCRH8vykNy7XB2JsSlWJM3PAvUDU6siiaPWO vypVwXW3n7sizcKUiv1m8yPrT4BLl7YUP3wHIjtYZdodAfIK4FGyCsShcctFt4F5ByZ QMTmXGYe2Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616832; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=mBDUgunlwyYfDRkO8rKVK6OOeYQ2O4ppj2zJZjpu82U=; b=B4Vqdwze/ZNTwZscR5qquPHAi8yvC9GyLgvw7VQlhM1valsN6GiykjmPHuv75n8A ajW1kAd9bdxcF+YSGA2+hiG59tCOi6B4BZn9kDSqEMQTI0Li8MS6ISLwtQosQ5KGt8h 3a1YFjVdLWSBiWJb83opA8zXeKI8AZevrOJtLV80= Message-ID: <010701a19be4e7b5-814c0145-4b09-4ed3-8a72-f61b1e7a353a-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 19/34] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261102-vfio_v1-v6-19-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-19-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:53:52 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D10:EE_|AS1PR08MB7612:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7a989ac9-3cbf-4403-3118-08df38cf95a5 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|376014|48200799018|61400799027|5113699003|4113699003|10067099003|55112099003|16102099003|18002099003|22082099003|13003099007|56012099006|4143699003|261021123027099003|261026121527099003|261026140227099003|261022105027099003|261009223027099003|261028144727099003|5063699009|261021121427099003; X-Microsoft-Antispam-Message-Info: 7tlA7rIdohtAUlT0RonxoW914wxoEVUpooqAsQadqPxFJ4stbFGkTVYvdjV4LAOX6mh/fOTLZfVffqOK+EMHlzU5elu1SjH3rgWX5NTIvNYluJWgYXe4N9/PMu5lMPdFe1FMzbQtOY8dWuoT1SRKuED279tN1PiR6z3MC+InOIC2pOa1fTeyj0hazECrLpNP3gWc3NycIXj8GsgAs39OpaB82ZAkuWPGqSxDoaFtY4cbjQRV104lQ+cNn6h380MkbvCay+9n3NoSSg347Eq4/SDTHkS6V0lCIb/TkYIUw2nokbH49y/7Tn/tv0YaSRxK2HpdqESeVkkp6Ia4qQxkaZo4F+JTlhzmc96ekB2OVvsYmuJuanUuTCxKVvxPXTRTxCeMNvFPeLq5qSs1qSCZ5ROuFoExouogB6dRpXA+RhIpqcvcllfoRepIV3cBMgWqMnRwfElYMvLpUxMisvzuBPur5ZsXnRG+QLiH0fYnoU3MZ7otOT+zzgbAO9i9vcOHUqRiprPyAuzPkNuiq9De22cX+QaCLdCaMJNPgQEeEP88HATCA/ExqC4giQVvOuethYd7sOsG4n+pe+idmQg4oisrUBu5pSDlKEbk6u1seqger1khzqXjJLFbCBCvyRZ3stKWx+J7P3EI+965oD15SJ5qMsqJ9J4OhsU/OUpocsCyVF7gunDP0WilUwk5ncasCYLL8C7uVvRjXoE1ftgPuUfVt/Y6xwwGLh8VsKcemDPy3fLwomwlAlBQlYcE+rnD6WOwS6Urgla5S9DhCfhyux44mFYleUSbDvwace1RHy/pPpdLOMP9pmL4spUnJImdqnoVmWTDC1ZEjRBfYuNZ7T+moAQgCnLAAjsTF8LLKLn3rRyVa12M46cL5O61b/5NmVcfe9+s8k+E9LZNyQ7soME0KfNFIr4FsLf+JSivigWLTno6+b91dUM7Y4hPebkg X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(376014)(48200799018)(61400799027)(5113699003)(4113699003)(10067099003)(55112099003)(16102099003)(18002099003)(22082099003)(13003099007)(56012099006)(4143699003)(261021123027099003)(261026121527099003)(261026140227099003)(261022105027099003)(261009223027099003)(261028144727099003)(5063699009)(261021121427099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5zvH481FsEk8RWeFlpNxvST7Lo68CxPadr9bDnc7ZSK+tymDt0tZ+e0lkLso5ZK23VX3Y6eFfVHxoRi/6vepPQTJMMctLeBowxo87SoOJ5XtW0V+p1maU0EMftWMGlXCb0b0xumz41cGC2CcJG9WNYIGH75n0JkRXRx5MFzrd3jjyNcUZ2LoCT1R6gotRxyCqhE6DZLlQBcz0Y4vFA3hq1CVnEceJJzt96YvERbTl0LyOfYrLzUcLUWiUIndyl2Qj9jLsckO9jtPDHgWdYHf2MKoJqB6+3O5YSu3r5GtvgBCcCXfSIuUbHUSjntRb4eKF3ITm8R6dwe6iaUGlUBSpoiCLpacJm74kTJkyeDKtVHvquPdN2wXL6ZChXMuotEj1MVC4S7uLxv5k/U6OQU9mXT/LLp4o1Dza4JiX7yPgn1mK7anZshzULX3/ptSXsHf X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:53:52.9014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a989ac9-3cbf-4403-3118-08df38cf95a5 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D10.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7612 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D19