From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19be5fe53-186f682d-285f-455e-9228-5f0543405af0-000000@eu-central-1.amazonses.com> Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020090.outbound.protection.outlook.com [52.101.84.90]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5E0198045D for ; Mon, 2 Nov 2026 10:55:07 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TlgZFEPSzDM6wggpxnsNTQ/msquMOyEBUkDvTqVXQdvG7pw7iZSaz26cWVUc+RXbId5h4CmIxhgZEHAMrCZlWNCrS1uNEK5T+/72uTDMiE5dVImscg2KX2yVLhrS5vGWbzDwxStvyLsG9L2L/ppT/IEdw3XHf0kjtQc51o/erzJX19lDvlIWF75XppfHi5LuWUKBX/BlT310sXn3pm/RqRtJG1sI2avoFNtCEF0JWEa+lThyNQUK1lDRzhdlg1/ihG3z+W1SuR6Y8mfB+s3cK+xB/SHe0ZfI3xXS5P3GZQXmsBpuiY7zqKdwu3RN12f8KXH9DkcBd851vfS8vtN8lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PcSDiNWUqN9hkCscIFKrmxn3drXiH0V+lnQuXO+ffOI=; b=SofMzg996DYq1V16CssYEzh4G7wxXZRAZSyGyovvD0QQsESnJdhsWpo4L/cz9BFTT1gasJMfdH7YrhqGqPnLdcleVLvcrSVi1lqIbc82OGLbmzT5IoPbWYyfX9KnQI2NhKyxYsI0OJZLa3hN42YIWfTd9Nv1koURGB+ivQIPvqvAfGU53kgTW9fMpmxP6rPcPEaMjZnNgOO8adZl+4DCt2jD66+nUYddzt3nGSkmNmdXQYjKDY4nhFIjRITzKF7h0ANo9P9wTkWyO/wwe70Sa433lZ299Fyzy45bhdKT3YH/2IdsTaP4mZDT+//mSzlS236pkQPKjKaF9kPWZFrMjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PcSDiNWUqN9hkCscIFKrmxn3drXiH0V+lnQuXO+ffOI=; b=J0N5oJ2AYz/kQ9gj2YHeH10U58Sl2c/dzjLP9iveeTAwWTw/hOqmpesATeEK25vnYopNqhFUjLzREwVRxCjiMUU/SkkIwglG39O4gojWKDSBC+bProD9L/ssi/JSwoVCxCpS/AUQ/0iemB9cPUenulWG5W29HEoxQwOUcMBm5Hg= Received: from DU2PR04CA0305.eurprd04.prod.outlook.com (2603:10a6:10:2b5::10) by AM8PR08MB6465.eurprd08.prod.outlook.com (2603:10a6:20b:365::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:55:04 +0000 Received: from MAD0EPF000008B2.eurprd04.prod.outlook.com (2603:10a6:10:2b5:cafe::15) by DU2PR04CA0305.outlook.office365.com (2603:10a6:10:2b5::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:55:04 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MAD0EPF000008B2.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:55:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616903; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=yECFSuDOvxN0qUD/emZYhQ7xT53UZhYxd/eKaXc99bI=; b=uspIShc+X4J/N8enjftWVACfw+tyeQUcFXroZ3IfBPGWP6x0yD/65gJRe7L5UU2q bWGuQ5AJ7v+aOexxUlOStXJCQDu5dFRKqNhms06j6wL/Ajc1bOe/ATz4CHqqtkdlUFF dBBxc0hk/stvAmpXKEuygcaOktSa5e2TO77SS+w5TJtwYLk2PfgJSZ+67V1/+9HcUE3 qK73DEtHLlPwBY5hNcuO3S/osuF3TEXUc2XKnSssDj6Uktp5eUppbDz2kktQnNul+RP r68Ew1SKYavTUrdm1uXwqWKsmcIBjik/xdRPz+B8JNVKEinhtnEvJ00m8IO8lMbabC9 Mh0q564hQg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616903; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=yECFSuDOvxN0qUD/emZYhQ7xT53UZhYxd/eKaXc99bI=; b=AfB6iVfzNns0hZgZ9llx7dyW5LMhpV9WjLqDT0gVfXuVa8rfzPez0ovmcbSOftfs mQOXqU8ilRQ6+zDOlB26ekrbDuGIA5vtaNHY9l441CmaGFo2f67gjzbqXNueM4lrjD2 +kSD2Yj2+yarRHX9E5Lr9TqO8/Kwbc8hSjCrbf2I= Message-ID: <010701a19be5fe53-186f682d-285f-455e-9228-5f0543405af0-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 18/34] migration: yank: Move register instance earlier To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-18-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-18-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:55:03 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008B2:EE_|AM8PR08MB6465:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 4a950747-45a0-4dd1-20df-08df38cfc02e X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|48200799018|9140799003|61400799027|32142699015|376014|261021121427099003|261022105027099003|261009223027099003|261026140227099003|261026121527099003|261028144727099003|4143699003|10067099003|5063699009|56012099006|16102099003|22082099003|18002099003|55112099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: gR30u/qrgFMNmx9kYuw9T+f1uUguJ7OyfmVHE0H1v/gPHV7YqQNyxRokjaNELbWLQPpdwjbhWhigyq1jguIAEt/NHSvFabRWaPPRB+EJDmwhsURxNmBuV23DcmD5cDaWN2tXtDFCSo+Vp1HKNVn0GCM2qktuKvMXEiL6qNKPhjRHmgSr+fLB3DMuHHL4mkFIQ0sCspWkT4x3neEa6PEwUtrqQaxcYNARoYQxH4UzjHGgNW2x4yXxw7E8fuS0y84bXpbrPDuMi03LNR0zQKRBoiT8+q6LqIIBVafY8oCv3G/HEP6xtPvjCKf29PBH7uNcE7W3l3CmBfuEsK5hPu89UgD95km7AjA9DPixW+1mQKcF+nHNM7++Mjn66JN1dapplzhZTxk7gVwWslnC5sQioCNcLWny+qxCeoIYZsiE4eZ6LutvR33XlCdhcscYOIJpl3KyvYxJjLljc7FamW5I2jG+/eTEDVKOwxmXWZy4TGBFdavUfMdGGd/WWqeWEa/UUSCFn8b65fe9QjV4m91TVcFgOoM2rU1vmTG47ve6pmRrYKbC7siD535ObMUmbCvCJPakUPw5k/LNv2OTAI7Qk4EfQ4J3gwLW5nuNGda4hHHeBWm/X/HanoZhkeXbwRt8Hka7BZcJQWKf483qSdT6GC4edZPqBW7793Vsyjj8ACvpEfK25iJ71QMXrD3y/ZybBS6cQqGB2aMDPvUnkuWhW/YLlGRDfw+HlkEIEtIFYdPTzd5SRihIHL6ZQMGAA1XLm+00yQnlRL9XMv7GxMlVakjljoxbBl3Xm6INnmKsw7bKZxdq8130NnhOtOTZK2GtQt1a8r4Jpg0/vIA54a5uk/REnw2irFE2i49l55VVbij2adj8BO4+hzMAoTX38x5Nb73jpcqg+iFt5nJxteeFW5Gp9WqZT8sTY6n427tLphs= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(48200799018)(9140799003)(61400799027)(32142699015)(376014)(261021121427099003)(261022105027099003)(261009223027099003)(261026140227099003)(261026121527099003)(261028144727099003)(4143699003)(10067099003)(5063699009)(56012099006)(16102099003)(22082099003)(18002099003)(55112099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Nd7Azye92Kj33L34UqpIxweK1+SusFDjrcicYmR553tlqmh1E+zE1Odq/smekYSi4jWHWdjF+1H2+o1krb1OepWgjZbT5eJ9cI/1QUJdrgLYGo6e2B/vycKVlJHH+WbG2JmmJ245YFVRGo1ACAkyDQEeG9Hu+l5dYKOsjZJxypjEYWuQkuzqa1YhQYSeKEiAAhyO7nPHb9DVYpryWsVY9h9OoBY4sADxvTNZMJYBRU4S8n5ZECI6JbwOeJGV8oJeLM8pH3ZnNU4g0CggMxiz5rTHfGfrDPiw43v7N/4eIK4oMRiThvwUbFTsrio71oZMZf5mZV+3EdIlQjy6Cn/zc08lDEBkQFxj+YuFWf0YPcoFPKwQgILji0okgwzUI6kuh4bV08a79gqIR5AHg55RN0nUDlT44a6SdQ6uTQLrBv8xJdmeivN0sTqa0c93w2j4 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:55:04.2631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a950747-45a0-4dd1-20df-08df38cfc02e X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B2.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6465 > From: Fabiano Rosas >=20 > Move the register_instance call to migrate_prepare() so it can be > paired with the unregister_instance at migration_cleanup(). Otherwise, > the cleanup cannot be run when cpr_state_save() fails because the > instance is registered only after it. >=20 > When resuming from a paused postcopy migration, migrate_prepare() > returns early, but migration_cleanup() doesn't run, so the yank will > remain paired. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 7e714392437c, > adapted for the hci-dev base, which predates the upstream > migration_connect_set_error() -> migration_connect_error_propagate() > [ ... ] >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-11-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D18