From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19bf346c1-9d664bdc-d313-4b6b-b5fb-0b0575bf25fb-000000@eu-central-1.amazonses.com> Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023090.outbound.protection.outlook.com [52.101.72.90]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4BE1A80E7E for ; Mon, 2 Nov 2026 11:09:37 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wmg4AxL2x3mr67eS53lYPz5ZIuOzafKy7BC3q43oALhdDa7NuiyBhNpHNwHv8vm8lrQ0vruV9B/4LIZENNjsm/LWxATwx6kYbQbksN9R0siSOFOMSt5EAV8oKN7ZoO2H0IfJzaM2XPWIFWNjqq0v6RDvGE+iy36hK7ATsuGesRq3q4xVZXA7k7p4wOiMtFjih1CDtD2Hplx635nMsctlwHeqIRdiH4DVZtZa7h1+mOtTHw5hNkgyDt1XAHPXlfLEFZGfkX7gGxbDp+I4j3qA3Q6dv8W957/wcYGrVWxR2sRkW/zcH96j6rnLcRnexbnS8xOA6z2Poh/vgMIdu+MIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qftt0qSbMvy5WI8eN3Cto3uesDwRzp4cueVx3ePfY3U=; b=N8tObSoD/IUjK6PzUrdhZHec2QmKyib3NVHFlds5Vaxym88Lf5Le6aT2LrisMfoOd3bQezLzi12p9LCNq9j3sX1tJddIMV61BVDK9KgsxlE6plnMOVjnAAK5D4r8uicCOCBVTfdcPisXg3Gppmzya+u7bpv4dI581dnjVhY3DLC/+T7lGACyx5UGKoWwWRD/JhQ2wzDxlXQyabkbuxXHN5sMVtAL6HM/pTEvdZd7AetbQBU9BQjtdg24JWziqnsiE6D3moVvT7yt1hQ1WphRfmdBMmmY8jlQ6Vbez1koC5loZ3v9RzF8L/jf5mPTVD4gH6iR7sbvSL5UokPbZcZagw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qftt0qSbMvy5WI8eN3Cto3uesDwRzp4cueVx3ePfY3U=; b=DTI3i182hP0iOkMYsI+/yxCXtzqNe+qWlLZHloDAHqEwYghV99fnRoYlu7F0H98pXVjhgfHJLr5+Mm0ZQpHd3A3Oy2x2FZNQ8GeEwJus8Dx4nPaPz9TYqxTkicXNfBzuRDY4lRXDea8SsohEO5yRjyZCHTXr2njLXWBKxH11+wk= Received: from LO4P123CA0563.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::11) by DBAPR08MB5719.eurprd08.prod.outlook.com (2603:10a6:10:1a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 11:09:35 +0000 Received: from MI3PEPF00008481.eurprd02.prod.outlook.com (2603:10a6:600:33b:cafe::a) by LO4P123CA0563.outlook.office365.com (2603:10a6:600:33b::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.28 via Frontend Transport; Mon, 2 Nov 2026 11:09:35 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MI3PEPF00008481.mail.protection.outlook.com (10.167.240.168) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 11:09:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793617774; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Dg6zJfYO9bPvq49Pea3/Gl0h8tU6KoxAZFn/QATFggI=; b=g7CVJHPSlit/o2BMwc0Yt11hbUxjBzWw394LKMEkv+c4Y1V4Y6tFDGWIXi+Swvti UtMuTXjEbU4wcMMFXwueelVmb36frgZ7uUTKpVdlWDwjdOAbBnd6vHjJyl/b/tHH4ac pB25FgaaXpeQk2Z7nYrOvNXHbnbiDr4bYxm714XSUzBXsmIdZPZHNKBcsxLo0j0v3f/ XZTNAtfaEyYUC+q7x3ohClD0+4YiraRxsEVXKUhlaGoNtWJ71A6klaM95GZGSYy9HcY e401rh4/4RuCrx8b1NqhaTr9+bQoTzuH9/FDUb3wfO98tJo4bU9fGDjH5PMbtx++lIK 4RAl/VuVyQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793617774; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=Dg6zJfYO9bPvq49Pea3/Gl0h8tU6KoxAZFn/QATFggI=; b=SlT2SPxIHrkz96tD3sjpylCJq2CqMI2yoRAz/LBCRAk1ztWYc5dkCOVK/hiNyNDS j695H2UMI4SM5TnjTLGvbcBuAFp19icQxzzuMYcjvPnFty/8wHX0lX2LAvrumcXpM6w 8FBLPPnvZwUcf2j7J9RcDLKppLTg0YlXEJLui5bA= Message-ID: <010701a19bf346c1-9d664bdc-d313-4b6b-b5fb-0b0575bf25fb-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 29/34] VZ: migration/cpr-exec: abort cpr-exec if memory can't be preserved To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-29-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-29-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 11:09:34 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008481:EE_|DBAPR08MB5719:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2cbc0275-811a-4ec3-7f15-08df38d1c706 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|48200799018|376014|61400799027|5113699003|4113699003|10067099003|55112099003|16102099003|18002099003|22082099003|56012099006|4143699003|261026121527099003|261026140227099003|261022105027099003|261009223027099003|261028144727099003|5063699009; X-Microsoft-Antispam-Message-Info: cetauqpRJqx5fCfR3/74tmbJSDCYm5hGjbC7+b0b8OOpfjinNlmJz6lwK8IMd/yyVq8n2XJafeFCO19aFSRXfy1hPHEjQ6oBy3PSL7azxImOz/uGKcFg73/V2VY+HVcWLe94yhP1WZVQ68pkr7GEHh3NycNUXOkDHaliqh9o6Rz38BgzzOh39AWcGKRyvIZ1rVqd6hQ4UtgvCkKtLu9sJchyEK/iLuNoOYwwRcEbvApRa9noxPjtJZ/B5iN2EOlKj1OsysBCJpyFfOCmnkWdWaUi9eksrCsfNznBwjyChTpnA+rbZkJVrugRpSchfQ/bCSQQ475buOpJ4vTI6dFXNOM4vME539tEdr1A8oUn0zx0rKsotoAp2VlzRQ1hyuN85FE2oTDs7yZL9HVBgRqFTId25cBlMPD2imEewdqGvZcLD0DYwUhHoJ8VOzFmpa/QTFhuf1CzyDsrkio96WiAI22TQ0ro6RrEiGiDVDoWaqMUbXvVh/hCV/iYqeYqSBFxWrBoL/Pjiy4sfVd9wk/+yDdGjVgSk0WuuYn0QSpz1U1TvuQXuwWp60RN38qR3RXcwMVrKBLtsng5F91EFdwdenxlNrgubDDopLt/ljVJSubBZcCgtf0EiU1tk7LNi+TMipyAtRvGl21SF9mIDbxItUfZ40tQoHlkB7dbdoBG3VC0CPok/IYsDWewaUDMtAK7yfYWDkGk55f/RQYsQtj7dSjmlKM07MkhcUxcUAu5JBDEyIeF87L4hIKKtiRlZoUD/xIMjI21BpLsRTMN5nXS4gSmAHiu20gjMtPZw57zE1VPvZNb8Q/pNmmuhEwU5OTxlCYnOc0kOn9a2PD4B2czxCVxAExpKZC7VoQCWEc7xpoJ+FVqrBdB2owCugyFquoyGp35C5h/jNMmjbH4Asb9raxOPv4uOyYo/Ytrz6jbzZFN17ozMawPRBq9lZZgFSPQ X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(48200799018)(376014)(61400799027)(5113699003)(4113699003)(10067099003)(55112099003)(16102099003)(18002099003)(22082099003)(56012099006)(4143699003)(261026121527099003)(261026140227099003)(261022105027099003)(261009223027099003)(261028144727099003)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6xonwthJHxxSR/Bxxf1q9h3hHepZNYyh4U4N8xCxiw6Hn2fVjsf7mXEw7GDK6s3Np3wBPH4rpbS7a+kehEyQGmy1CDQC1qeazxJjYCk3og8Gotkg/V+alInhAtCwfeXqJ46yOOazNwTvaJacu1k6Bl4hUDQgQ5L/N2JcrpiGawsF65qFBXPVqNZOT4VcQ3FXOmhcVNXXOVonRSEMlbp9Knc5wzz2Vsr39SU1o/7+FSr2JcTwkXgYp98ZILl63/LS2m6d0faVHbZXvGZINJMireI/lRt90SkoCdUMikYWzfq1Ne8wKnyIQyzC99t3itCy47zMBvhUALqCwuqO6kp5ghzZK0jwJaWRYBnn4ttRAgKCiO/QTeljIhjAMCAFqNPdnhKs5c5JNe7etyP6goEokz7UsyUVVSv/ZWcLhbm6hPDP6U4dcJu4jA4LSaMGLTKy X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 11:09:34.7604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cbc0275-811a-4ec3-7f15-08df38d1c706 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008481.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5719 > cpr_exec_cb() marks all saved ramblocks with MADV_DOEXEC before exec, but > ignores the result. If madvise() fails for some block, the walk stops > there and the remaining blocks are not marked, yet execvp() still runs. > The new QEMU then reuses addresses of guest RAM that wasn't preserved, > and the guest is lost. >=20 > Treat that as a failed cpr-exec: go to the same failure path as when > execvp() fails, so the VM keeps running in the old QEMU. >=20 > On that path also clear MADV_DOEXEC from all saved ramblocks again, just > like the preserved fds get close-on-exec back. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D29