From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023074.outbound.protection.outlook.com [52.101.83.74]) by lore.virtuozzo.com (Postfix) with ESMTPS id AE5AA80E7E for ; Mon, 2 Nov 2026 11:09:49 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hq/zuY2GMLTl9DVbrrvkn1uZICY78mfWoFfnYt8VqzPJbQdj3Cr47HaGPs2xSu+x3pfGgx3AMWv7WjALgXBGZ+6mU+LAHq7ZMuAL3cnZtIYr+C0Si4pe0t26bzR3orJIYwrMmlhsoWWeITn66rFhZw9Hc2kXWoorPgqKU2owLjBggRQ63wFAtrhBSebDyZsUYad5/MrOf9vjxRv/G8QrLMs5dTAGzdZidZv4IUW72foLz31RIcd21nHVv4NzDbO5veZ3WjB9Pbnp9+1hw+nFvCyX7Inpl635s/Nh2Bct2jVkO86Vurjg4I1tIKJi7pPaQl21LXagYkCCl7GOSrEaAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sq5xaRiONV0hgtUAp+ac/8vjUw4JZaHWDhKRbV59Kg=; b=wyj9PntUattZhsWNjLx9/ovmiPI493OWzTUXBTPRegC+YO+rm7WKTTg+UorOM/pVX28JSceZrPHu/6vHuI+0U7t7we96QWgGghLxxn+iFCXkUf/tpNLRf8GI4ZovB6jIFg01Tj0xox2U5eB4s0921jV7CfZHwxfspCxh+L2Ofy9sLvMYoS+MvEu/UHpX8b/MdC9JRHh+dErn7SyJ6fRL2dyVi34Ac14Xwv253hYWf5QdS52YVvH9GsJFFD8EBWay2N5OppZ3CDWDU65uJ4uKnUYLcsW6zJPu8cx6onTQHySD+oFA4EBS47l9h9tx6zD2ETEwPQN/Te+B3G/OgMbIxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0sq5xaRiONV0hgtUAp+ac/8vjUw4JZaHWDhKRbV59Kg=; b=C4YutfodPmuVYP0ZWtQdc6AjQT40ElXnjBh+AVlBvjNYL3EAHcOZyT/IIRmREktnzvK6GGz91ZltvUsqL0rOFWCgpJFLdolf4FH1W5tULs6fvZxc8CUW2RRp7/o+0PQAwmrZp0+wb3p2RHgIh0LaPf42sAb4z/qeMc6s41FtWPw= Received: from DU2PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:10:3b::19) by DU4PR08MB11102.eurprd08.prod.outlook.com (2603:10a6:10:577::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 11:09:45 +0000 Received: from DU2PEPF00028D13.eurprd03.prod.outlook.com (2603:10a6:10:3b:cafe::7e) by DU2PR04CA0014.outlook.office365.com (2603:10a6:10:3b::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 11:09:45 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by DU2PEPF00028D13.mail.protection.outlook.com (10.167.242.27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 2 Nov 2026 11:09:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793617785; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=5sESw69TaEaYyRmM4Rd1PePCrB6N5z81NfRGX/91m3E=; b=B9sjHHs710WL4cp32wg5PP+PRGuFUxx7wKqub5mV/QjQgszum9ltmY9Tu3rOgtFj sqr7C14ND7KPZOlTShKKyjxDTjuJr+34qkkkZgxzvT/v2kdZ8kcjfcInbQh8W9Q2dOn LeHWN7iBBF8tr4UQeVCnltUg5asj2YBO5hHzin9S9T0H8X220v5tU2ayFEMEW9pWRLM Jk96SOsD5RvAVu2IY5hRqsxMXwsV/G+YVB7zMBzVDIDUx05rrVtGIbq7ZgERVIR4kd9 wpRFvy09jhupk6gNoE85viPAjhhd8ucx7Vu0zrHnl6vBXvBxYTsZ2tV1T/CGHJIKsSq XsFGSeX6PA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793617785; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=5sESw69TaEaYyRmM4Rd1PePCrB6N5z81NfRGX/91m3E=; b=D8pGKGMhZczcP+g2rCfAjnS8/su/IGhj0gLkZTfMdPZ/qnkUe54WaDslGMDF9SBw veg/fk+odku+25pC0mfhL2k/1Uj531zeSYUVMcSz7wbLMKa6nDjinHqzJaI6vO/xQs8 vgp2iAIIRp4i2FlmfxDo3ggQFQP3fKwKyKYqDh2U= Message-ID: <010701a19bf37059-e7ad8489-dfc4-4be4-b945-876e44559679-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 28/34] VZ: vfio/cpr: don't close KVM on cpr-exec To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-28-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-28-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 11:09:44 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D13:EE_|DU4PR08MB11102:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ec47fae9-51fa-463f-28fc-08df38d1cd66 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|376014|61400799027|48200799018|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261021121427099003|261026121527099003|261022075727099003|261022105027099003|261026140227099003|10067099003|18002099003|55112099003|22082099003|16102099003|5113699003|4113699003; X-Microsoft-Antispam-Message-Info: Za1gAm65btELqHNYVUWujoN+cgZRTddS3de3mzCMYEZpwbPsE8T9AhJv/V6UioiMFGriHGEgXeENkWMPy1QXv1L0taua433HWMj177JVAdp71toSV8BOJ2QjZj8Q8T1uqSjPxct/h4bB/uGCZKg4sMstUedyVZb3spMw6LqSbEk6zNM9pR/rYoJQkd4XCG7pNjULtTU2osZcdan5ILro7WAmwryugfqCyqE/r20nYAIhyL9gC2HpFOQasZ4ittj09tHkg9jWXK8NdFkQvcX8ne/oMpwo9dFiCEmkvOVfexKXYsojGt2WkTAmIO1EAIjkpJGy3PQmXfeM3Ji8hC4Kjkapq0Kzy4FXjq7ZIzgtXjlSwSCHIUV2tafOkFeG/OeLwBZEioOohp1f91kXlGwQlWfyqX+Po7HY3tZW0VtYmRxWFOdjRwGjcR1dDJATxt9GcjuV7grS91c7EpCqCcnFH8TuNh2StgnISc95he9//EOjoASQ9S704LFSyTzxVQFeuHc6e4mzNAv5X/mcJjXmzp0g00d83PVQV/efaQCk3Vz5X3QVxcmaCxOpseNXxVhpnMmnCldaaSPiRZuXFiE92hX7YZdXobm2A/0rFZDQav5Iv0t35m4R4t2rg3u4yToE939l+djmIek7brcKm3pJqP61eSOSu3LzVzWWvPClbcQ5vYtkfiijQ4OzxZeVnEQuphRPcI1rdGuHOF45QTGZflPmz4MNbwKSX0vRfCdSHEpFffeLSLHmvKvnR4RGLU5f+vehnZ23mEy5fbS8XS8Hbe5qCE3LOmfWknrz9ZmnX7ml12mC5y/V2pCfASdB8Kt/hCF7KnjtkQk1QKy8jo/XnuN15RowBx0WeyyzRYSX8EanZzTR/ay8vn4RyRp+VOCDpOwXXIqllSNoB7KqomVgdQ== X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261021121427099003)(261026121527099003)(261022075727099003)(261022105027099003)(261026140227099003)(10067099003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(4113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +yk7XJtknXdpVe0xEf82IKCAO8OcvAN6Cz0452w4IKTiZ8g61F6HBf6eKbVmz/jW/SE8NHva8Giu6kxZ7QoZJi8GOd/XND7M1Tfv0J2hhGeRVNVxU7VYqzmZF1rz0x+x4G7iNgGKhBTdjlZ+dnQRjGC49MyWzErflA8fwGDwWgHAqNapv4UORJD9JCR8hynmbPF5FSptPBpUaEzvujctHWCUrQvgSyOyh0tOwN9ebkm3/1X0tsCl8KPr4FLZ1LebnQ6ZtP7EcTQxgQn99JP9JmRJrkwMGPNY9CrLvf9huozWq9nfiBqVT1z1ozqqdA0GxZm42htYHsr+SkoCeZbj0PsKPLicAtKwoWRoTvaANqg17b8JBA3DR+K5oXeqg8qG1ugQueUBibogeLdl/Y9A3QoiKgGWMmr7ueP2/1EkseATMumh5ddUYDqL8MDZZOBd X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 11:09:45.4364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec47fae9-51fa-463f-28fc-08df38d1cd66 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D13.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR08MB11102 > With VFIO devices, KVM is closed on the source when the migration > completes, so that the new QEMU can create its own KVM VM with the same > devices. That is done from a migration notifier, which for cpr-exec > runs before cpr_exec_cb(). But cpr_exec_cb() may still give up, when > the memory can't be preserved or execve() fails, and resume the VM in > the old QEMU. A VM without KVM can't resume: kvm_close() removes the > vCPU threads, and the first KVM ioctl of vm_start() aborts QEMU > (KVM_SET_CLOCK in kvmclock_vm_state_change()). >=20 > cpr-exec doesn't need it anyway: the KVM fds are close-on-exec, so the > kernel closes them during execve(), before the new QEMU runs, and > kvm_vm_release() tears down the irqfds then. Keep the notifier for > cpr-transfer only, where the source process lives on. >=20 > Tested on the vfio-net rig: cpr-exec 5/5; a cpr-exec aborted in > preserve_ram() and one with a bogus cpr-exec-command both left the VM > running with no lost pings, and a later cpr-exec completed. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D28