From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/2] ms/selftests/futex: Correct validation logic in waitv
Date: Mon, 2 Nov 2026 20:10:14 +0000 [thread overview]
Message-ID: <010701a19de2449f-afe4c1ee-14ef-4fd6-b454-54fa0d8d72ad-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261102200610.2414832-3-eva.kurchatova@virtuozzo.com>
> From: Wake Liu <wakel@google.com>
>
> In futex_waitv negative tests (invalid_flag, unaligned_address, etc.), test
> results are evaluated as:
>
> if (res == EINVAL)
>
> Since sys_futex_waitv returns -1 on error and sets errno, direct positive
> comparisons against res are always false, causing tests to silently pass
> regardless of real errors.
>
> Correct these validations to assert EXPECT_EQ(res, -1) and compare errno
> directly against expected constants.
>
> [ tglx: Fixup coding style ]
> [ ... ]
>
> https://virtuozzo.atlassian.net/browse/VSTOR-152660
> Feature: fix selftests
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261102200610.2414832-1-eva.kurchatova@virtuozzo.com?part=2
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-02 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 20:04 [Devel] [PATCH hci-8.1 0/2] selftests/futex: correct " Eva Kurchatova
2026-11-02 20:04 ` [Devel] [PATCH hci-8.1 1/2] selftests/futex: run futex_waitv argument checks with a valid waitv Eva Kurchatova
2026-11-02 20:09 ` no-reply
2026-11-03 15:13 ` Konstantin Khorenko
2026-11-02 20:04 ` [Devel] [PATCH hci-8.1 2/2] ms/selftests/futex: Correct validation logic in waitv Eva Kurchatova
2026-11-02 20:10 ` no-reply [this message]
2026-11-03 15:13 ` [Devel] [PATCH hci-8.1 0/2] selftests/futex: correct " Konstantin Khorenko
2026-11-03 15:14 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a19de2449f-afe4c1ee-14ef-4fd6-b454-54fa0d8d72ad-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.