From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1b669e4-891ef1d5-24bd-4eb9-8feb-f097de2b55f5-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023143.outbound.protection.outlook.com [40.107.159.143]) by lore.virtuozzo.com (Postfix) with ESMTPS id D8C368017D for ; Tue, 3 Nov 2026 14:00:52 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=liHVnzXA6CYvQ4WU355d96yCwaqp6o0Iq3//Aj7ulWLTOIKVQiiRJ8eKpS28xvfrYUbR41uEqOjNZuqs82V9Di/P5SLCCQfe1ZKjTColQB8HuhUTke8T8g4TcrrdFsK5uvj6p4ZUjcq/hwdTPdAKwaSa4dD82M7B5fXYf2SgMVTjuun/f4KR9c8Ag7Dtpd8kN6/Vggov2R7kwxi6Jh7U/VvbDlJ0n6uX1vI2rfOr5QA7VaGhz2PbcL7sdpkm3pxMNozyoSNg4+1zBxjRaF3Yph4YLpFMR+Bbda7ZnRXrsZJ9yC+YKvrLRvad486quVl/5CVX1jRg9kXIyJXStgHBWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Gy0yLp0Hni57j5Ofi+P2eziVjButOP7bPy8Ago98dY=; b=l58PheGj1LHjl4fl5LTLtQmnLIOL4VCImkOeHJDsM359GFeHvkySYCrqgIVu7tVGDh9j/AinDNpd0V2OHfvXSvtcN3QtLkIF2ij1bZD7DWSTqUie9BwkY0Hvd5J4W+dMkTLy6jGGK8WuoJsdFDbGjLzQ3JXgTNP25LqYsqljyAnGe27wWe4qkJFurXt9y0QCi/dI0J4U7O6j3NcKPQwUHxD2bOvaJMBRDuPa+TIUYnudMi3y21Rx89tTK5546/0njcT543YHaqW1lDlGI2eKgBk/iUNHpQGLKKwsA6e2DsgIf/62zTqWvJKIddrQqn2zDYvuS7lYHuOb6ph6GETjjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Gy0yLp0Hni57j5Ofi+P2eziVjButOP7bPy8Ago98dY=; b=DweYt2vIKGRxHYdJDjkGTJ+sVh5UbFtZoc0RWTDUnkkZmriuG1QvbZPNumb4Qb+/l4FHpCwu1Bkm22O0SxeMy1+o0V1exRuQMvQECNzEa7EYOVFqeWLdYH0dIqDZYdTR4bZ+ldl1GRV9HHX9aDDSR6XMHuzQdkiu9TLa2EOanpY= Received: from LO4P302CA0030.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::16) by DU0PR08MB7637.eurprd08.prod.outlook.com (2603:10a6:10:31c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:00:49 +0000 Received: from ZR1PEPF0000E6B7.eurprd07.prod.outlook.com (2603:10a6:600:2c1:cafe::68) by LO4P302CA0030.outlook.office365.com (2603:10a6:600:2c1::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:00:49 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by ZR1PEPF0000E6B7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:00:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714449; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=4Gy0yLp0Hni57j5Ofi+P2eziVjButOP7bPy8Ago98dY=; b=vlNPCR4ijQ0xG6DZUfoJecBduc64yX4g4qOfTc/WHTVeMt0BDFG1um5Ljl0LV+J6 AwPnryjgV9/kOggTN2XlVeUXH5YDE9cP6Me7IFnaAuLA/SDy8SVYxhrgmuu1v4uWyDc 6PP7JFD9laSdr3JakRpXDEDTwIzMp74YwAPNpxKozH+xAPjsqRjq3df6eW7IPe59533 31T+MGMidTKAloDSdnUchAMqntQkdK0Cf6nTRo8EoQQf8J8sbamvdwsSTWluQJGEOhf Udc/VXz5n9H4V+btgMXyzPf7Bxhl70dS88dg3bG3z9oxUWGsUyQL3k4S7Uu0Day+bHt wWSsq7f48w== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714449; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=4Gy0yLp0Hni57j5Ofi+P2eziVjButOP7bPy8Ago98dY=; b=RAe3va43LW2INQtdUDz/aVkPAtqA4jlj1APs43edFhdLN7tk4bpo2clbnVtb2VZR iZkA4xRfTTU5tPTnZiKk5thzwFeoDGMqL94sC4TMjKne7l9BkHdGqwi7mop6PJK1ok+ aF+CemSkkP+rVPoF3ZhTuL7VMP+fxNBeJJy0AccM= Message-ID: <010701a1a1b669e4-891ef1d5-24bd-4eb9-8feb-f097de2b55f5-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 01/35] VZ: migration/cpr-exec: fix Error leak in preserve_ram() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-1-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-1-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:00:48 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E6B7:EE_|DU0PR08MB7637:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 15f905a5-94ca-4a9d-f4c9-08df39b2dd8a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|9140799003|32142699015|376014|61400799027|261022105027099003|261009223027099003|261028144727099003|261026140227099003|261026121527099003|4143699003|10067099003|16102099003|5063699009|4113699003|55112099003|5113699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eVgxbUtkWEdjZ2dlU25aTGVBZ3BCUzRsTkNGelFEdERVVitmY0w5T2VVd24x?= =?utf-8?B?b2NUaGhURVUzWm00SXZzNUN6Q0RBbTRHcDg3ZkVNVDNETzBrRTMwWmRMdW1i?= =?utf-8?B?R0NFcytFd3E2ZE9tNjRKNCtKelM5TzBZT0hkNzBpWkhqTzcrcUZiRjFPVGtW?= =?utf-8?B?Z2t6UlQxVHVIcGFTZ3EwODgzd05QVWEvdnpWcW1CZWs1VlR4WlBpZDR0U1Uv?= =?utf-8?B?VFpsWXlmQkprcVdEcFFYQ3dVazRnT3h1ajVLOGhTRVU4Z1ZEZlQ2azFncVd4?= =?utf-8?B?OWVSTUZBUjgzNXFkMlNmTHczTHJUeXNhMTVsNU1QNk9JVVFCckVrRmFjNmNY?= =?utf-8?B?UDB6Tkd6b1ZZWUFQQ00xOHlldDVXbytRanAySVZSL0xObWNCTXgyV2hYRVU1?= =?utf-8?B?Sm85YmdtR2RjZGFYZzZXTWtYbG4wVy9xc2NWdnRxVldFK3IvRTZ4WkY3VWEz?= =?utf-8?B?cjg3UDN0TDl5bkhXUnR5V09DR0tJNVZYUVk0QXFkTkNwaU1TK05Za3pSMmdY?= =?utf-8?B?dldJcHowa256a0VzOEVNT0gxZzlaWXJTV1lPNHdocU9FQ3hTTElaR0JTR1lq?= =?utf-8?B?TXRvUndaenhSUTU0K3ptWVVHZzhFdUhkSmRWaVk5bCsyUk5ndER3VSt1T1M2?= =?utf-8?B?NGtlMmw2UkhvTEJ1ZTkvZTcyMzM3MTVxYUNSWm5uWk05T2tEL1NkRktsZmxV?= =?utf-8?B?SnFpV3pkZ3lUczlPc0RIREpQc2YzVDhXWlF1LyszbmZrOVM0Y2IveEF2bkNt?= =?utf-8?B?UjMwTXJLRUIyRjZmYWUvYllpdllvRStSVFQ3YmdmcktvbitGa1R4NitQc0tp?= =?utf-8?B?VDNZN1ZENnFIS3VvV216ZlpLYnd4bCs4U3l5dzdiRndlSnZvcjl5bUpRN1dZ?= =?utf-8?B?TmJsamIxaE5JY0MyNG0rZ3I5R3h6R1FXd2dZUTMxSFJrWW5DV1Jsb0JJcFA1?= =?utf-8?B?Uk1qNW9ER2NJT0s2cVlUSWpJRkRLUVk4ZFJiSnlqUmh3OVlKT2R0cVZOQ2lm?= =?utf-8?B?a09nN2FNU3U4ejh5bWFpL0xES3N6YmVpbUxBZkhEWm9TQ1VSNkJYMU14cytU?= =?utf-8?B?cksrOGVDam0wTFg3UUtabmV0Z2pET0JZVXc1YThqY2FXRHhNQk83eml3eTBw?= =?utf-8?B?elBBeWxxUTUreHhmaFBhWmNaRDVob1BzdXN5UmhrOVMyVjdSUklScDNOQkVE?= =?utf-8?B?a1k1U0xaLzZ0d1g4UWtpU3ZTQ2lOQ2ZYS1ZUM2s4bzFCdkhvR1RqUENGM3J3?= =?utf-8?B?Vy9Qa1ozTGNvbUxuWjBZZW5LaEIrdHdncTBwZ3lNRVV4MG9KNTgzUlNMbFU2?= =?utf-8?Q?83tiwNkk2z2sPT2FNdA/fNHP+KrUqa2efC?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(9140799003)(32142699015)(376014)(61400799027)(261022105027099003)(261009223027099003)(261028144727099003)(261026140227099003)(261026121527099003)(4143699003)(10067099003)(16102099003)(5063699009)(4113699003)(55112099003)(5113699003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cX4jz/YAJZqYq6WfGBsKgPPA+c7rksg5bHktz75jxlS9TmpczLunoMfAWfgDyjk85AdVyEzyTIfLAz7IhMaf9QIpyXGpaeVe4+XJ9ns4iijRudwGdP7JRADJLT10g8KCldeQwA2ZjHrBsJoAu4dVboxjR9+Ny+xxnfZ7bw/CB0qFvJnOA1l7kN3kwPIikZlYSoM1VysXlW94FLzxAN1Qe3yQKe6OhblrNfU3/yEhPgzcQz2Y39AgKTdP7wu1Ny2nKsTTgtnY0JLdoqrBZdkD2WTHhbzDb5/MkPaKdaPOm4uzlAVflucJAv6u2CKsFq5E1EXpLncY1Ybc9KydwsZc8cqklxECFe5GGOVjnI2VJGsKjYcUDxuKv1VjLF2RwI/1e6TB6KgDOU5+BxLLYNQSZ9BCdrhn2ArELaov+LlwaYcDkbP7MD5U5BMkw3FWCLgX X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:00:49.3128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15f905a5-94ca-4a9d-f4c9-08df39b2dd8a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E6B7.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7637 > migrate_set_error() stores its own copy of the error, so free ours. >=20 > Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with = MADV_DOEXEC before execve") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D1