From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1b7e2bc-66475cc3-1060-4165-84d9-d2955afc72b3-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023104.outbound.protection.outlook.com [40.107.162.104]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7B1DC8045D for ; Tue, 3 Nov 2026 14:02:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XD3ecGHGSmdNkv1hNPhRxuWBuRmIcXoiMflWG3ynMC/s4sKNRShuSXy34/a0hzXL3IkgxEK9Rxbt/Y7knG9MwYUXJxFtGKHJvsVzm9/s9oREJi4mNzJG1oKa0ZYmotEBuAK9zUSwzsoosKB0y97X8xEtVAbpdGQtyg/zGAO/X4Ayd2oFEmJOU7mKdnHKLO5wCgh13ARPyJOmy8j7bNw7beQfDAK5b7jxMk4uKyrKlfFWQ87aMY1FUa+AqFQ1j27Pjdc5SQfbXTw59KiQNUtWMV9dXm9rLhVUMNkIi8uOw+/CeUbN9dhVZY6rSkB/QhMvQiQZNbJ60rI1WQPZE5WP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9E3VjSBdElHa5lruByafsxRy0uoz9eACYcixvQy4cY=; b=yRxyCFXRVKFNGBlnarvxKnHx+8mXfnBt96/0+97wxy8DfxHogW9a/LiCm5nEHXL6VMu8Ce8fT4lXasx2tuB5sFiTWtnxahPQ3NPVVc0/qOl+my+/6KTRzAAbZeK5/3xv879CcmIuhQ0kVeR9l8VzFoqB8vdN37B4PiHmtV/VyLmtKqBQeuEj1SlNnP1PamXn0zHORtgy6ZCf++4/Ph8wlfX1GC7A3b/847x2fwNj9WUYgVcozV7wxuk9jAjw9TNSlyn7DU+KVYnMzRAszOEKtbRFQ+MrPUQKR1tWZ7IP7h5LbFhEyZswRHItj2+9XiU1pNOp59HNQntUFiNP1n5Dow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9E3VjSBdElHa5lruByafsxRy0uoz9eACYcixvQy4cY=; b=AIdJaOh6amb/Q1Mgwc9IyboiVGZH26T9S//+XJ+8A8pAHR0Y9y+hNIYYNegmIkAPaNRdJjgtOA829bnxJBAOsuaRkdCGRzeH0OHkpEKL5jLtKDOS4SKn7ZQoNvEz92WX1c6HVeHEm5T7fB3ikRtFWS65L09rjQ9hgNr6ZkGw330= Received: from DU7P194CA0019.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::34) by FRZPR08MB11097.eurprd08.prod.outlook.com (2603:10a6:d10:13d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Tue, 3 Nov 2026 14:02:27 +0000 Received: from MAD0EPF000008B4.eurprd04.prod.outlook.com (2603:10a6:10:553:cafe::75) by DU7P194CA0019.outlook.office365.com (2603:10a6:10:553::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:02:26 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MAD0EPF000008B4.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:02:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714545; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Es1TQTQhM4o/WWGk632f0TcJESGUVCDrarhuqTp1NSc=; b=Iy+JECLTqPzrcLXLGSST+DbCaeAJcTHVADeUS0D9Uq2RaqtPmDvXTfmLcQa4ZOII ZJk5FZJm8arYFYW7EycHcYzYm4P3Q0UBBga+tyNsrq+TFIEk5IDwHqZ77XX13dr45T/ mQQvXfuJjznjFaXi1bTX9p2epSajaI7oiusID2P3qSLRmEhWWIvieiH013EktNhgmm5 nr+UPf7t9EDpiPYZzrCSMnfpxaQoldKs74KJMulYuZMdCFV9XWkDth4NMOU3At6kX7S LLDuI3hhRTN3WR3nseFuOSPePiO4R/egBHNKKLY4mGmkjMAeXMwTFgEP7sWEpJ4IVwr wgUAuXnw0g== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714545; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=Es1TQTQhM4o/WWGk632f0TcJESGUVCDrarhuqTp1NSc=; b=in7DG7QqPnc1RbC5NU7hUyevQgZTj2nrAVTHTnHB8FINVYdx2MarU9tXb5t67tBb F+Hus5VfiLPkCoD7tlzDw7tl/Jk6io/eyce7da8B2TRjpKadprkEPMeGpkCizwbmEKO kqSIUXnFaaps5LT0niIJhlN9pDcb0cuDRMrXr6Ak= Message-ID: <010701a1a1b7e2bc-66475cc3-1060-4165-84d9-d2955afc72b3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 04/35] migration/cpr-exec: require a file or exec migration URI To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-4-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-4-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:02:25 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008B4:EE_|FRZPR08MB11097:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b66836ca-3e03-43e0-16e8-08df39b31779 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|48200799018|376014|61400799027|9140799003|5113699003|4113699003|10067099003|22082099003|18002099003|16102099003|55112099003|56012099006|5063699009|5023799004|4143699003|261021121427099003|261102123227099003|261022105027099003|261028144727099003|261026140227099003|261026121527099003|261009223027099003; X-Microsoft-Antispam-Message-Info: vGI+QiNIniOhlMUrzQZ9sq76Th1cdorpQLxWtJuySNoE5RH71A6jRGHMpvlE6g6iLgAsaG47WEdYCj8Jw3GSaOFvK/CrBt5Ltk8q2PbMEI6v4VsmVU5ItD8pZ1Z4e5Rp3UiLuDmMjSbfh0Vn3ljXdIbn47y5EFPEVeNlmh3z0nogaFsWRjFy3iiwcWwRBEE3naV8TvfKsLxd418uKFrHHcEEBij1VXd19+gukESQxzFJ/jJXVbX3VUeGi2HKdu9w0jRSNntWc9qIBI5ri8zRBoPHGHYFrQlfKp5WKaWj59Y/q3zMAJH/3tqYm1tN3HmIFdZc351kXlAe0JzAOUfheAOxo3iPCMDxiF+yoFzp+rYfhto7NGVUYOifeKdKRBt5CI7e0IO2qgPgS9Vr4HEI+gjzNEJR4T5UuT8DJMEtKrpavrak3BKSyAqvecihxdo/o5UvSfBytkRmZmP8W6gqkz9iVW92RU6yLXns4ByoBUVqs00kY4/5K+Cm30DlGeZr6BUGt/2D0vtS7WGgj9uxI1ay1Dzt+LR6swXg6l6X5Go18UD5iPP/+LwA8a+5/8mOoT9mKcCq2pGun5pZNiL47xKzmyqScJCvx6Hi7DXa5Ad2sbyM4FqYFfc+eYIWdbfwBAuHz07Iafn3Foj+foHMKnJTBePXVhEgMEAz30TTuEv43HHf0DIJB5rAIlrR/x6LQkIVcbGMv0PmThQ9feCRBdQYW92M2OArIDhkvMF8xgrz93Wke7woIla6UyuwiIkW3HTWoSGKjHU12486l07m2ZKiOfRmvP/3QMfcOBTRLCp7ccOC8Ll2WSsYuwUMvC6wZtE4ntZ34rl3WB1blV3cUD8yanx/Cj9ppgk0aZSvmi1zqzSGg6/2Qi77LZcyEn5s7geY1orC3pMcN+t+eMlAdw== X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(48200799018)(376014)(61400799027)(9140799003)(5113699003)(4113699003)(10067099003)(22082099003)(18002099003)(16102099003)(55112099003)(56012099006)(5063699009)(5023799004)(4143699003)(261021121427099003)(261102123227099003)(261022105027099003)(261028144727099003)(261026140227099003)(261026121527099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K7W1K/4KmtLfFz08HeG2+lC5DVarqrDhaHApUEn5MhuLd73HghVFKZouKcWsIkC0Jh7QWwHnSjwrWX5M4EEURuDj71vXDMwt51gLdrmex4mWYiXmZbOgBjNohV23PKnUnwU1kKG8F3tfxEtG1dHxoVVsGrSBrzB6jDx7BHZwyvLqcSWQv/2U1whOrehYG6gJYqQFPRxhXn1k0e/GUf2YoR0xPEW1aoKfn8mkwdLQB8cLypHK9Orshdj7tbP/Z6l6XYfZbQXVW9CeGdXsowY6j4jiXpe5zX2acrH/d6inSz1NzpwGkQo0Sp+UmPSjPRVEOD77QXvugnFJs0BqZM8B/VyALctofuLgdjF9Hv/qYe/CvPAYbQIt9oW8kYf1gRMXW65SduqE1WAbHXAhefeWF9KaLYmLjLjPBw2WhZkcR6+m8CCLOQIL+RfqXQ1UhqQz X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:02:26.2510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b66836ca-3e03-43e0-16e8-08df39b31779 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B4.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB11097 > cpr-exec writes the device state to the migration URI and new QEMU > reads it back after the exec, so the URI must capture the data: a > file, or an exec command that stores it. Nothing checks that. With a > socket URI, e.g. a save or a live migration issued while the 'mode' > parameter is left at cpr-exec after a failed qemu-update, QEMU sends a > stream without the guest RAM to the peer, execs the stale cpr-exec > command, and the VM is lost. >=20 > Refuse cpr-exec with anything but a file or exec URI, the two types > the CPR documentation allows. The check covers the incoming URI of > new QEMU too, where the mode is cpr-exec as well. >=20 > Fixes: a3eae205c601 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D4