From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1b9aece-847e4d5c-9a81-480b-8a19-0d99fef0e0d6-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020093.outbound.protection.outlook.com [52.101.69.93]) by lore.virtuozzo.com (Postfix) with ESMTPS id 202D78045D for ; Tue, 3 Nov 2026 14:04:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L/z3m5DhfWzx6x1DPzQ4tLosMyoLnfnjYD+M1dzm3Z8ecnW2aqO2sc3VCQ22QJRXTZDUICNMGAXujUDtQYO22EjuWRItstl3D80vABYofD2wNpF7Jvxd5MmwboP2uXV58SZ2B8kr7fjyBxt6BxEi5NBICP9lmmMFSg/HfxEKT/AWzvcWvMorpPtUUxjKjYLeQd73QvYPy8Jxz24Njpgd+ngm5CPaxSW0R8yYWlPE3weYJoep4WpwCow7kLEQFXvJDcyqO5+fYAOThAv9tpm0Ta/+0PU75VKNAj9wiUX+9APzaMcCTSy9LyRoiPIB4pQvOmu9LsKb4kJK7a5llOctyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t8ccD0E6rBCm2miJ7xGIVChEhaYzT8IsiudL1toWTHg=; b=MYQuhrmrwP1yFJbqPIzXmh9t6uoscKR6axxZ0Q4/Cfbn3uyjrO1kQXDnlNXcLrrycG3a2eJ6cK/Xjcd/1QBAyNkfsPTyA2BTSWXh3htUcnb0EnjEy/l7kKz0/sxH12LABqwbQCVwTcMgpZvp9EnBqpTpqmLIPwgngx9K1g++eeZCYJtP/7vOPfC729gIpkUJHGHCAMNpJC5+WbXsuaV1VqTB4JtLbmZ+D9A4sELgc7BD/d7gaYd/8HYDjzXzUFt2y7WiRHqZemIIG1w6Mhvulfv1t4RA2cZ9Wsq3+anpj5Bk3CN99lfU+rfacNron7IgIA2f5kOkr8KR4HjgNfQdiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8ccD0E6rBCm2miJ7xGIVChEhaYzT8IsiudL1toWTHg=; b=FzNvpFEu3jfiu5acj8pXOJQt0o2Q4rcvWE39oyC2DFUkp/Q4sYXDP+UZOM62iCjMieCWwRE3D31sXhOXJfK9rNWv8IWCKFdKNQBum6Q6qj6AB33DVLNgsBu1ph9YdwvT1l2l8qObGpQTisdvEKrZhdOP+VBLHCMymJHvzDTJaiY= Received: from PA7P264CA0095.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:348::6) by DBBPR08MB10771.eurprd08.prod.outlook.com (2603:10a6:10:53a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:04:23 +0000 Received: from MI3PEPF00008491.eurprd03.prod.outlook.com (2603:10a6:102:348:cafe::53) by PA7P264CA0095.outlook.office365.com (2603:10a6:102:348::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:04:23 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MI3PEPF00008491.mail.protection.outlook.com (10.167.240.152) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:04:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714663; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ncaNj0lq1Gmjf2AZrGgWfuXplCEBEVbn9z32JeEpcKM=; b=10DwaEQCP/UsccQzx2PnDHk+mU/2lMHTcNcsZT9mjaYqFkZPV4DjB7QP6HazmMX5 R+bWMHb1Lgq89XlZzBzxj1CSjEyusf9uSfaza2KIYN0GLWgUpPblzIxH4EZaJT44vVR OA/v/UuVudfr1cfn9s/8NnANjMhO4E5b4vV+/anOetnOKAGyL1zq3V/2DidIC1kznjF kZjHeV9KIXGI92EvmFQR47hVNoHFQJ2GMYBHFj76T/WqPSQqqsyhuS84YloK5m2O7Hw yVvtCEW6YtLlo2OeIo8z3OVZNTZHbzMcpBsqsPWwsyBbba47w6sxME84P4pULEPQOkI ojYnTv2eFA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714663; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=ncaNj0lq1Gmjf2AZrGgWfuXplCEBEVbn9z32JeEpcKM=; b=Xp6FUhXiY1I09MEQBJnGtg5R1m1yzcqbOQ42J2roV0/MX7TC7Yq/xRECYjxOvBX3 br1RV3t6pTT+dCko93BsFieoOyqh5YIlBGvdpP6c1zFpHOI1ArAAZZ24WW1wD3WqaJw jSNRXQhWvYzsYkjJdKEyYlwb+Mfg2hAq1F4q84Sc= Message-ID: <010701a1a1b9aece-847e4d5c-9a81-480b-8a19-0d99fef0e0d6-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 07/35] migration/cpr-exec: don't leak the dup'd memfd if g_setenv() fails To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-7-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-7-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:04:23 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008491:EE_|DBBPR08MB10771:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8f5d210e-742b-4540-f190-08df39b35d4b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|376014|9140799003|32142699015|61400799027|48200799018|5113699003|4113699003|10067099003|18002099003|22082099003|16102099003|55112099003|13003099007|4143699003|56012099006|261022075727099003|261026140227099003|261009223027099003|261022105027099003|261028144727099003|5063699009; X-Microsoft-Antispam-Message-Info: yfrhkYRSOR3yqn1IcEov02JzEuacDtVgupw0lb0oH5JCiW5pn8XPX8doI+zgYLNiU4I6n6VWr2VSCSXCZ768lcKYqwOTf8alMS18gnxplCl984HHvtnRue+JjIRq3RipasYYti34aRPXyxU6FTprE9y8MiDS+KN8edodDNDLSUw5RbVohIoiFxCu7x4FESXqaHwNcAEuPrQ0KyPdHBr/IzlZ3AIUKA0Q8tLilurWZcOWlJGp3dpYSK2sDKvt+6LbvR9zFK+tYzDZw86k1IbbyVpVxqdm3ax6csA5f5FAI1P6CNp3UfmBIBJQTHruh7hfiTrzvA7Gon6P2LD+lEhG4hNLcWgUPw7dtnI79bskCFTPUGs01gnMCOmOC4ZWaHVqd/OfInHzeeRR6EDZpkFpRiWMFRjb6afuUkX6cSEg1Sd8EBSnpPfblvOVL1s+XPdYDq77QxG1i9+RumJDMGGwo/rTRfsMygmRo4QisFU24KxopTLm5slfOVvngE07uA5D92XmiPPhcSfh1BGOLX92hDoEvYUV6ueKrPP9poVpVmpCpiP0/MjlB0DTAqaDRhyXksHv46pcQCGw44fg3rVPJUM+fyLHrAcTlQ+miPtzosXW4AapcuRq/14rWzbGCNyVMKmL/48WNQfyy0ro6rX8d3TIAO3TeNCa2evvGs+e7hEqV5o8jzkXwgsrVrnWDHrYpT7XLuZ2yuUdow336HIbMyaRKW0PFf1Vp7OYqVujvDmnAD0HlhNigmgeNo++Egz6XWsla38p5xvmrVrgFDjU3ZGXmEFbKuINIakndVbsIORGtqOe7vRuztzcEg4N99Xl7jrjZVI0pk+alVg/oU/jeZ9E26ofhV8S5/9t66oRQWAcBL9eXbcGw82+fJSka+Hk/P+q5n2Asy9vg1OX8kjg4w== X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(376014)(9140799003)(32142699015)(61400799027)(48200799018)(5113699003)(4113699003)(10067099003)(18002099003)(22082099003)(16102099003)(55112099003)(13003099007)(4143699003)(56012099006)(261022075727099003)(261026140227099003)(261009223027099003)(261022105027099003)(261028144727099003)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zZZmPVQV1gidU6TB0YJtYEuTebhM8If8z9VFd17WYLp/3R85urX6Bj1V4rCwb8vZ2OUe8klB05rDL2tXTjR0wa9uowj47ZT+yvnq87xx91yqIW0SV51eeHM4WHpQEcD9Ic403FHe3lfV8t8fNVWu57rrYwP5565d+NpP5uuOw1knvf0g1C/VoJ5XQkb8AqP6fWk65HrxruGHAT9naXpSJaSn65eEa9rgvexIdT0J4j5Zk0hfyeAI9/vg5kBTYXjpC53jWyVH502OqxadfL71+F8zLppp4z+YQbQD0+jcvlMXYj+hKPGeAPRKmBGy/cltwBZMc7r70PExHwohGvhBmYsLrctYeR1+ZgB9gtebQDI0zFmbNuZgVkR+MMM+dbAy7PPvgQEHwZy/VESirrBL9HDqvNXqNqzt1vfq1BAn3vjS/gimC7T5pmGZvm3SwOfs X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:04:23.6330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f5d210e-742b-4540-f190-08df39b35d4b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008491.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10771 > cpr_exec_persist_state() dups the CPR state memfd for the exec and > records it in the environment. If g_setenv() fails the dup isn't > closed, and the leak is inherited across exec. The dup() result isn't > checked either. >=20 > Close the dup on that path and fail on a failed dup(). >=20 > Fixes: a3eae205c60 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D7